From: Michael Ellerman <mpe@ellerman.id.au>
To: Haren Myneni <haren@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Cc: haren@us.ibm.com, hbabu@us.ibm.com
Subject: Re: [PATCH v4 16/16] crypto/nx: Add sysfs interface to export NX capabilities
Date: Fri, 04 Jun 2021 21:52:33 +1000 [thread overview]
Message-ID: <87pmx1g83i.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <340144138c53ae83588edcf0b4a5ae1880a01cd0.camel@linux.ibm.com>
Haren Myneni <haren@linux.ibm.com> writes:
> On Thu, 2021-06-03 at 14:57 +1000, Nicholas Piggin wrote:
>> Excerpts from Haren Myneni's message of May 21, 2021 7:42 pm:
>> > Changes to export the following NXGZIP capabilities through sysfs:
>> >
>> > /sys/devices/vio/ibm,compression-v1/NxGzCaps:
>>
>> Where's the horrible camel case name coming from? PowerVM?
>
> Yes, pHyp provides the capabalities string.
>
> Capability Description Descriptor Value Descriptor ascii Value
> Overall NX Capabilities 0x4E78204361707320 “Nx Caps ”
> NX GZIP Capabilities 0x4E78477A43617073 “NxGzCaps”
That doesn't mean we have to use that name in sysfs though. In fact we
couldn't use the "Nx Caps " name, because it contains spaces.
And we don't have to squeeze our name into 8 bytes, so it can be less
ugly.
Like "nx_gzip_capabilities"?
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Haren Myneni <haren@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 16/16] crypto/nx: Add sysfs interface to export NX capabilities
Date: Fri, 04 Jun 2021 21:52:33 +1000 [thread overview]
Message-ID: <87pmx1g83i.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <340144138c53ae83588edcf0b4a5ae1880a01cd0.camel@linux.ibm.com>
Haren Myneni <haren@linux.ibm.com> writes:
> On Thu, 2021-06-03 at 14:57 +1000, Nicholas Piggin wrote:
>> Excerpts from Haren Myneni's message of May 21, 2021 7:42 pm:
>> > Changes to export the following NXGZIP capabilities through sysfs:
>> >
>> > /sys/devices/vio/ibm,compression-v1/NxGzCaps:
>>
>> Where's the horrible camel case name coming from? PowerVM?
>
> Yes, pHyp provides the capabalities string.
>
> Capability Description Descriptor Value Descriptor ascii Value
> Overall NX Capabilities 0x4E78204361707320 “Nx Caps ”
> NX GZIP Capabilities 0x4E78477A43617073 “NxGzCaps”
That doesn't mean we have to use that name in sysfs though. In fact we
couldn't use the "Nx Caps " name, because it contains spaces.
And we don't have to squeeze our name into 8 bytes, so it can be less
ugly.
Like "nx_gzip_capabilities"?
cheers
next prev parent reply other threads:[~2021-06-04 11:52 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 9:25 [PATCH v4 00/16] Enable VAS and NX-GZIP support on powerVM Haren Myneni
2021-05-21 9:25 ` Haren Myneni
2021-05-21 9:28 ` [PATCH v4 01/16] powerpc/vas: Move VAS API to book3s common platform Haren Myneni
2021-05-21 9:28 ` Haren Myneni
2021-06-03 3:32 ` Nicholas Piggin
2021-06-03 3:32 ` Nicholas Piggin
2021-06-03 20:23 ` Haren Myneni
2021-06-03 20:23 ` Haren Myneni
2021-05-21 9:29 ` [PATCH v4 02/16] powerpc/powernv/vas: Rename register/unregister functions Haren Myneni
2021-05-21 9:29 ` Haren Myneni
2021-05-21 9:30 ` [PATCH v4 03/16] powerpc/vas: Add platform specific user window operations Haren Myneni
2021-05-21 9:30 ` Haren Myneni
2021-06-03 4:05 ` Nicholas Piggin
2021-06-03 4:05 ` Nicholas Piggin
2021-06-03 20:25 ` Haren Myneni
2021-06-03 20:25 ` Haren Myneni
2021-05-21 9:31 ` [PATCH v4 04/16] powerpc/vas: Create take/drop pid and mm references Haren Myneni
2021-05-21 9:31 ` Haren Myneni
2021-06-03 4:21 ` Nicholas Piggin
2021-06-03 4:21 ` Nicholas Piggin
2021-06-04 4:08 ` Haren Myneni
2021-06-04 4:08 ` Haren Myneni
2021-06-05 0:31 ` Nicholas Piggin
2021-06-05 0:31 ` Nicholas Piggin
2021-06-05 3:03 ` Nicholas Piggin
2021-06-05 3:03 ` Nicholas Piggin
2021-05-21 9:32 ` [PATCH v4 05/16] powerpc/vas: Move update_csb/dump_crb to common book3s platform Haren Myneni
2021-05-21 9:32 ` Haren Myneni
2021-06-03 4:26 ` Nicholas Piggin
2021-06-03 4:26 ` Nicholas Piggin
2021-05-21 9:33 ` [PATCH v4 06/16] powerpc/vas: Define and use common vas_window struct Haren Myneni
2021-05-21 9:33 ` Haren Myneni
2021-06-03 4:38 ` Nicholas Piggin
2021-06-03 4:38 ` Nicholas Piggin
2021-06-04 4:35 ` Haren Myneni
2021-06-04 4:35 ` Haren Myneni
2021-06-04 11:52 ` Michael Ellerman
2021-06-04 11:52 ` Michael Ellerman
2021-06-04 21:19 ` Haren Myneni
2021-06-04 21:19 ` Haren Myneni
2021-05-21 9:34 ` [PATCH v4 07/16] powerpc/pseries/vas: Define VAS/NXGZIP HCALLs and structs Haren Myneni
2021-05-21 9:34 ` Haren Myneni
2021-06-03 4:47 ` Nicholas Piggin
2021-06-03 4:47 ` Nicholas Piggin
2021-06-04 1:30 ` Haren Myneni
2021-06-04 1:30 ` Haren Myneni
2021-06-05 0:37 ` Nicholas Piggin
2021-06-05 0:37 ` Nicholas Piggin
2021-05-21 9:34 ` [PATCH v4 08/16] powerpc/vas: Define QoS credit flag to allocate window Haren Myneni
2021-05-21 9:34 ` Haren Myneni
2021-05-21 9:35 ` [PATCH v4 09/16] powerpc/pseries/vas: Add HCALL wrappers for VAS handling Haren Myneni
2021-05-21 9:35 ` Haren Myneni
2021-06-04 11:52 ` Michael Ellerman
2021-06-04 11:52 ` Michael Ellerman
2021-06-04 21:53 ` Haren Myneni
2021-06-04 21:53 ` Haren Myneni
2021-05-21 9:38 ` [PATCH v4 10/16] powerpc/pseries/vas: Implement getting capabilities from hypervisor Haren Myneni
2021-05-21 9:38 ` Haren Myneni
2021-05-21 9:39 ` [PATCH v4 11/16] powerpc/pseries/vas: Integrate API with open/close windows Haren Myneni
2021-05-21 9:39 ` Haren Myneni
2021-05-21 9:39 ` [PATCH v4 12/16] powerpc/pseries/vas: Setup IRQ and fault handling Haren Myneni
2021-05-21 9:39 ` Haren Myneni
2021-06-03 5:48 ` Nicholas Piggin
2021-06-03 5:48 ` Nicholas Piggin
2021-06-04 1:19 ` Haren Myneni
2021-06-04 1:19 ` Haren Myneni
2021-06-05 0:43 ` Nicholas Piggin
2021-06-05 0:43 ` Nicholas Piggin
2021-05-21 9:40 ` [PATCH v4 13/16] crypto/nx: Rename nx-842-pseries file name to nx-common-pseries Haren Myneni
2021-05-21 9:40 ` Haren Myneni
2021-05-21 9:41 ` [PATCH v4 14/16] crypto/nx: Register and unregister VAS interface Haren Myneni
2021-05-21 9:41 ` Haren Myneni
2021-06-03 4:59 ` Nicholas Piggin
2021-06-03 4:59 ` Nicholas Piggin
2021-05-21 9:41 ` [PATCH v4 15/16] crypto/nx: Get NX capabilities for GZIP coprocessor type Haren Myneni
2021-05-21 9:41 ` Haren Myneni
2021-05-21 9:42 ` [PATCH v4 16/16] crypto/nx: Add sysfs interface to export NX capabilities Haren Myneni
2021-05-21 9:42 ` Haren Myneni
2021-06-03 4:57 ` Nicholas Piggin
2021-06-03 4:57 ` Nicholas Piggin
2021-06-04 1:02 ` Haren Myneni
2021-06-04 1:02 ` Haren Myneni
2021-06-04 11:52 ` Michael Ellerman [this message]
2021-06-04 11:52 ` Michael Ellerman
2021-06-04 17:23 ` Haren Myneni
2021-06-04 17:23 ` Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmx1g83i.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=haren@linux.ibm.com \
--cc=haren@us.ibm.com \
--cc=hbabu@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.