All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register
@ 2021-02-24 16:37 Marcus Folkesson
  2021-02-24 16:43 ` Kalle Valo
  2021-03-15  8:26 ` Kalle Valo
  0 siblings, 2 replies; 7+ messages in thread
From: Marcus Folkesson @ 2021-02-24 16:37 UTC (permalink / raw)
  To: Ajay Singh, Claudiu Beznea, Kalle Valo, David S . Miller,
	Jakub Kicinski, Greg Kroah-Hartman
  Cc: linux-wireless, netdev, linux-kernel, Marcus Folkesson

Write the value instead of reading it twice.

Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file")

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
index 351ff909ab1c..e14b9fc2c67a 100644
--- a/drivers/net/wireless/microchip/wilc1000/sdio.c
+++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
@@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint)
 			for (i = 0; (i < 3) && (nint > 0); i++, nint--)
 				reg |= BIT(i);
 
-			ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
+			ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg);
 			if (ret) {
 				dev_err(&func->dev,
 					"Failed write reg (%08x)...\n",
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register
  2021-02-24 16:37 [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register Marcus Folkesson
@ 2021-02-24 16:43 ` Kalle Valo
  2021-02-25  5:06   ` Ajay.Kathat
  2021-03-15  8:26 ` Kalle Valo
  1 sibling, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2021-02-24 16:43 UTC (permalink / raw)
  To: Marcus Folkesson
  Cc: Ajay Singh, Claudiu Beznea, David S . Miller, Jakub Kicinski,
	Greg Kroah-Hartman, linux-wireless, netdev, linux-kernel

Marcus Folkesson <marcus.folkesson@gmail.com> writes:

> Write the value instead of reading it twice.
>
> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file")
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>  drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
> index 351ff909ab1c..e14b9fc2c67a 100644
> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
> @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint)
>  			for (i = 0; (i < 3) && (nint > 0); i++, nint--)
>  				reg |= BIT(i);
>  
> -			ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
> +			ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg);

To me it looks like the bug existed before commit 5e63a598441a:

-			ret = sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
+			ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);

https://git.kernel.org/linus/5e63a598441a

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register
  2021-02-24 16:43 ` Kalle Valo
@ 2021-02-25  5:06   ` Ajay.Kathat
  2021-02-25  7:09     ` Kalle Valo
  0 siblings, 1 reply; 7+ messages in thread
From: Ajay.Kathat @ 2021-02-25  5:06 UTC (permalink / raw)
  To: kvalo, marcus.folkesson
  Cc: Claudiu.Beznea, davem, kuba, gregkh, linux-wireless, netdev,
	linux-kernel



On 24/02/21 10:13 pm, Kalle Valo wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
> 
>> Write the value instead of reading it twice.
>>
>> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file")
>>
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>> ---
>>  drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
>> index 351ff909ab1c..e14b9fc2c67a 100644
>> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
>> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
>> @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint)
>>                       for (i = 0; (i < 3) && (nint > 0); i++, nint--)
>>                               reg |= BIT(i);
>>
>> -                     ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
>> +                     ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg);
> 
> To me it looks like the bug existed before commit 5e63a598441a:


Yes, you are correct. The bug existed from commit c5c77ba18ea6:

https://git.kernel.org/linus/c5c77ba18ea6

Regards,
Ajay

> 
> -                       ret = sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
> +                       ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
> 
> https://git.kernel.org/linus/5e63a598441a
> 
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register
  2021-02-25  5:06   ` Ajay.Kathat
@ 2021-02-25  7:09     ` Kalle Valo
  2021-02-25  7:35       ` Ajay.Kathat
  2021-02-25  8:02       ` Marcus Folkesson
  0 siblings, 2 replies; 7+ messages in thread
From: Kalle Valo @ 2021-02-25  7:09 UTC (permalink / raw)
  To: Ajay.Kathat
  Cc: marcus.folkesson, Claudiu.Beznea, davem, kuba, gregkh,
	linux-wireless, netdev, linux-kernel

<Ajay.Kathat@microchip.com> writes:

> On 24/02/21 10:13 pm, Kalle Valo wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>> 
>> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
>> 
>>> Write the value instead of reading it twice.
>>>
>>> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file")
>>>
>>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>>> ---
>>>  drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
>>> index 351ff909ab1c..e14b9fc2c67a 100644
>>> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
>>> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
>>> @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint)
>>>                       for (i = 0; (i < 3) && (nint > 0); i++, nint--)
>>>                               reg |= BIT(i);
>>>
>>> -                     ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
>>> +                     ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg);
>> 
>> To me it looks like the bug existed before commit 5e63a598441a:
>
>
> Yes, you are correct. The bug existed from commit c5c77ba18ea6:
>
> https://git.kernel.org/linus/c5c77ba18ea6

So the fixes tag should be:

Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")

I can change that during commit, ok?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register
  2021-02-25  7:09     ` Kalle Valo
@ 2021-02-25  7:35       ` Ajay.Kathat
  2021-02-25  8:02       ` Marcus Folkesson
  1 sibling, 0 replies; 7+ messages in thread
From: Ajay.Kathat @ 2021-02-25  7:35 UTC (permalink / raw)
  To: kvalo
  Cc: marcus.folkesson, Claudiu.Beznea, davem, kuba, gregkh,
	linux-wireless, netdev, linux-kernel



On 25/02/21 12:39 pm, Kalle Valo wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> <Ajay.Kathat@microchip.com> writes:
> 
>> On 24/02/21 10:13 pm, Kalle Valo wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>>> know the content is safe
>>>
>>> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
>>>
>>>> Write the value instead of reading it twice.
>>>>
>>>> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file")
>>>>
>>>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>>>> ---
>>>>  drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
>>>> index 351ff909ab1c..e14b9fc2c67a 100644
>>>> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
>>>> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
>>>> @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint)
>>>>                       for (i = 0; (i < 3) && (nint > 0); i++, nint--)
>>>>                               reg |= BIT(i);
>>>>
>>>> -                     ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
>>>> +                     ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg);
>>>
>>> To me it looks like the bug existed before commit 5e63a598441a:
>>
>>
>> Yes, you are correct. The bug existed from commit c5c77ba18ea6:
>>
>> https://git.kernel.org/linus/c5c77ba18ea6
> 
> So the fixes tag should be:
> 
> Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
> 
> I can change that during commit, ok?

Yes. Thanks.

Regards,
Ajay

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register
  2021-02-25  7:09     ` Kalle Valo
  2021-02-25  7:35       ` Ajay.Kathat
@ 2021-02-25  8:02       ` Marcus Folkesson
  1 sibling, 0 replies; 7+ messages in thread
From: Marcus Folkesson @ 2021-02-25  8:02 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Ajay.Kathat, Claudiu.Beznea, davem, kuba, gregkh, linux-wireless,
	netdev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

Hi,

On Thu, Feb 25, 2021 at 09:09:30AM +0200, Kalle Valo wrote:
> <Ajay.Kathat@microchip.com> writes:
> 
> > On 24/02/21 10:13 pm, Kalle Valo wrote:
> >> EXTERNAL EMAIL: Do not click links or open attachments unless you
> >> know the content is safe
> >> 
> >> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
> >> 
> >>> Write the value instead of reading it twice.
> >>>
> >>> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file")
> >>>
> >>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> >>> ---
> >>>  drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
> >>> index 351ff909ab1c..e14b9fc2c67a 100644
> >>> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
> >>> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
> >>> @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint)
> >>>                       for (i = 0; (i < 3) && (nint > 0); i++, nint--)
> >>>                               reg |= BIT(i);
> >>>
> >>> -                     ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
> >>> +                     ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg);
> >> 
> >> To me it looks like the bug existed before commit 5e63a598441a:
> >
> >
> > Yes, you are correct. The bug existed from commit c5c77ba18ea6:
> >
> > https://git.kernel.org/linus/c5c77ba18ea6
> 
> So the fixes tag should be:
> 
> Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")

You are right.

> 
> I can change that during commit, ok?

Please do, thanks!

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Best regards
Marcus Folkesson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: wilc1000: write value to WILC_INTR2_ENABLE register
  2021-02-24 16:37 [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register Marcus Folkesson
  2021-02-24 16:43 ` Kalle Valo
@ 2021-03-15  8:26 ` Kalle Valo
  1 sibling, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2021-03-15  8:26 UTC (permalink / raw)
  To: Marcus Folkesson
  Cc: Ajay Singh, Claudiu Beznea, David S . Miller, Jakub Kicinski,
	Greg Kroah-Hartman, linux-wireless, netdev, linux-kernel,
	Marcus Folkesson

Marcus Folkesson <marcus.folkesson@gmail.com> wrote:

> Write the value instead of reading it twice.
> 
> Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

e21b6e5a5462 wilc1000: write value to WILC_INTR2_ENABLE register

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210224163706.519658-1-marcus.folkesson@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-15  8:27 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24 16:37 [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register Marcus Folkesson
2021-02-24 16:43 ` Kalle Valo
2021-02-25  5:06   ` Ajay.Kathat
2021-02-25  7:09     ` Kalle Valo
2021-02-25  7:35       ` Ajay.Kathat
2021-02-25  8:02       ` Marcus Folkesson
2021-03-15  8:26 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.