* [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-07-19 10:00 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-07-19 10:00 UTC (permalink / raw)
To: Zhang Rui, edubezval, Geert Uytterhoeven
Cc: linux-kernel, linux-renesas-soc, linux-pm, yoshihiro.shimoda.uh,
cm-hiep, PhucBui
Hi Zhang
These are resend patches for rcar-thermal hwmon.
Kuninori Morimoto (2):
thermal: rcar-thermal: enable hwmon when thermal_zone
thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
drivers/thermal/thermal_hwmon.c | 2 ++
2 files changed, 20 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-07-19 10:00 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-07-19 10:00 UTC (permalink / raw)
To: Zhang Rui, edubezval, Geert Uytterhoeven
Cc: linux-kernel, linux-renesas-soc, linux-pm, yoshihiro.shimoda.uh,
cm-hiep, PhucBui
Hi Zhang
These are resend patches for rcar-thermal hwmon.
Kuninori Morimoto (2):
thermal: rcar-thermal: enable hwmon when thermal_zone
thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
drivers/thermal/thermal_hwmon.c | 2 ++
2 files changed, 20 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 1/2] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
2016-07-19 10:00 ` Kuninori Morimoto
@ 2016-07-19 10:01 ` Kuninori Morimoto
-1 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-07-19 10:01 UTC (permalink / raw)
To: Zhang Rui, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, hucBui
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
thermal_add_hwmon_sysfs()/thermal_remove_hwmon_sysfs() need
EXPORT_SYMBOL_GPL(). Otherwise we will have ERROR
>> ERROR: "thermal_remove_hwmon_sysfs" [drivers/thermal/rcar_thermal.ko] undefined!
>> ERROR: "thermal_add_hwmon_sysfs" [drivers/thermal/rcar_thermal.ko] undefined!
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/thermal/thermal_hwmon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index 06fd2ed9..c41c774 100644
--- a/drivers/thermal/thermal_hwmon.c
+++ b/drivers/thermal/thermal_hwmon.c
@@ -232,6 +232,7 @@ int thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
return result;
}
+EXPORT_SYMBOL_GPL(thermal_add_hwmon_sysfs);
void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz)
{
@@ -270,3 +271,4 @@ void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz)
hwmon_device_unregister(hwmon->device);
kfree(hwmon);
}
+EXPORT_SYMBOL_GPL(thermal_remove_hwmon_sysfs);
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 1/2] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-07-19 10:01 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-07-19 10:01 UTC (permalink / raw)
To: Zhang Rui, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, hucBui
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
thermal_add_hwmon_sysfs()/thermal_remove_hwmon_sysfs() need
EXPORT_SYMBOL_GPL(). Otherwise we will have ERROR
>> ERROR: "thermal_remove_hwmon_sysfs" [drivers/thermal/rcar_thermal.ko] undefined!
>> ERROR: "thermal_add_hwmon_sysfs" [drivers/thermal/rcar_thermal.ko] undefined!
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/thermal/thermal_hwmon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index 06fd2ed9..c41c774 100644
--- a/drivers/thermal/thermal_hwmon.c
+++ b/drivers/thermal/thermal_hwmon.c
@@ -232,6 +232,7 @@ int thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
return result;
}
+EXPORT_SYMBOL_GPL(thermal_add_hwmon_sysfs);
void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz)
{
@@ -270,3 +271,4 @@ void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz)
hwmon_device_unregister(hwmon->device);
kfree(hwmon);
}
+EXPORT_SYMBOL_GPL(thermal_remove_hwmon_sysfs);
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
2016-07-19 10:00 ` Kuninori Morimoto
@ 2016-07-19 10:01 ` Kuninori Morimoto
-1 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-07-19 10:01 UTC (permalink / raw)
To: Zhang Rui, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, hucBui
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
rcar-thermal is supporting both thermal_zone_of_sensor_register() and
thermal_zone_device_register(). But thermal_zone_of_sensor_register()
doesn't enable hwmon as default.
This patch enables it to keep compatibility
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 71a3392..4d07644 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -31,6 +31,8 @@
#include <linux/spinlock.h>
#include <linux/thermal.h>
+#include "thermal_hwmon.h"
+
#define IDLE_INTERVAL 5000
#define COMMON_STR 0x00
@@ -75,6 +77,8 @@ struct rcar_thermal_priv {
#define rcar_priv_to_dev(priv) ((priv)->common->dev)
#define rcar_has_irq_support(priv) ((priv)->common->base)
#define rcar_id_to_shift(priv) ((priv)->id * 8)
+#define rcar_of_data(dev) ((unsigned long)of_device_get_match_data(dev))
+#define rcar_use_of_thermal(dev) (rcar_of_data(dev) == USE_OF_THERMAL)
#define USE_OF_THERMAL 1
static const struct of_device_id rcar_thermal_dt_ids[] = {
@@ -416,6 +420,8 @@ static int rcar_thermal_remove(struct platform_device *pdev)
rcar_thermal_for_each_priv(priv, common) {
rcar_thermal_irq_disable(priv);
thermal_zone_device_unregister(priv->zone);
+ if (rcar_use_of_thermal(dev))
+ thermal_remove_hwmon_sysfs(priv->zone);
}
pm_runtime_put(dev);
@@ -430,7 +436,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
struct rcar_thermal_priv *priv;
struct device *dev = &pdev->dev;
struct resource *res, *irq;
- unsigned long of_data = (unsigned long)of_device_get_match_data(dev);
int mres = 0;
int i;
int ret = -ENODEV;
@@ -491,7 +496,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
if (ret < 0)
goto error_unregister;
- if (of_data == USE_OF_THERMAL)
+ if (rcar_use_of_thermal(dev))
priv->zone = devm_thermal_zone_of_sensor_register(
dev, i, priv,
&rcar_thermal_zone_of_ops);
@@ -507,6 +512,17 @@ static int rcar_thermal_probe(struct platform_device *pdev)
goto error_unregister;
}
+ if (rcar_use_of_thermal(dev)) {
+ /*
+ * thermal_zone doesn't enable hwmon as default,
+ * but, enable it here to keep compatible
+ */
+ priv->zone->tzp->no_hwmon = false;
+ ret = thermal_add_hwmon_sysfs(priv->zone);
+ if (ret)
+ goto error_unregister;
+ }
+
rcar_thermal_irq_enable(priv);
list_move_tail(&priv->list, &common->head);
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
@ 2016-07-19 10:01 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-07-19 10:01 UTC (permalink / raw)
To: Zhang Rui, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, hucBui
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
rcar-thermal is supporting both thermal_zone_of_sensor_register() and
thermal_zone_device_register(). But thermal_zone_of_sensor_register()
doesn't enable hwmon as default.
This patch enables it to keep compatibility
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 71a3392..4d07644 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -31,6 +31,8 @@
#include <linux/spinlock.h>
#include <linux/thermal.h>
+#include "thermal_hwmon.h"
+
#define IDLE_INTERVAL 5000
#define COMMON_STR 0x00
@@ -75,6 +77,8 @@ struct rcar_thermal_priv {
#define rcar_priv_to_dev(priv) ((priv)->common->dev)
#define rcar_has_irq_support(priv) ((priv)->common->base)
#define rcar_id_to_shift(priv) ((priv)->id * 8)
+#define rcar_of_data(dev) ((unsigned long)of_device_get_match_data(dev))
+#define rcar_use_of_thermal(dev) (rcar_of_data(dev) == USE_OF_THERMAL)
#define USE_OF_THERMAL 1
static const struct of_device_id rcar_thermal_dt_ids[] = {
@@ -416,6 +420,8 @@ static int rcar_thermal_remove(struct platform_device *pdev)
rcar_thermal_for_each_priv(priv, common) {
rcar_thermal_irq_disable(priv);
thermal_zone_device_unregister(priv->zone);
+ if (rcar_use_of_thermal(dev))
+ thermal_remove_hwmon_sysfs(priv->zone);
}
pm_runtime_put(dev);
@@ -430,7 +436,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
struct rcar_thermal_priv *priv;
struct device *dev = &pdev->dev;
struct resource *res, *irq;
- unsigned long of_data = (unsigned long)of_device_get_match_data(dev);
int mres = 0;
int i;
int ret = -ENODEV;
@@ -491,7 +496,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
if (ret < 0)
goto error_unregister;
- if (of_data == USE_OF_THERMAL)
+ if (rcar_use_of_thermal(dev))
priv->zone = devm_thermal_zone_of_sensor_register(
dev, i, priv,
&rcar_thermal_zone_of_ops);
@@ -507,6 +512,17 @@ static int rcar_thermal_probe(struct platform_device *pdev)
goto error_unregister;
}
+ if (rcar_use_of_thermal(dev)) {
+ /*
+ * thermal_zone doesn't enable hwmon as default,
+ * but, enable it here to keep compatible
+ */
+ priv->zone->tzp->no_hwmon = false;
+ ret = thermal_add_hwmon_sysfs(priv->zone);
+ if (ret)
+ goto error_unregister;
+ }
+
rcar_thermal_irq_enable(priv);
list_move_tail(&priv->list, &common->head);
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
2016-07-19 10:00 ` Kuninori Morimoto
@ 2016-08-03 2:00 ` Kuninori Morimoto
-1 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-03 2:00 UTC (permalink / raw)
To: Zhang Rui
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, PhucBui
Hi Zhang
ping ??
> These are resend patches for rcar-thermal hwmon.
>
> Kuninori Morimoto (2):
> thermal: rcar-thermal: enable hwmon when thermal_zone
> thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
>
> drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> drivers/thermal/thermal_hwmon.c | 2 ++
> 2 files changed, 20 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-08-03 2:00 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-03 2:00 UTC (permalink / raw)
To: Zhang Rui
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, PhucBui
Hi Zhang
ping ??
> These are resend patches for rcar-thermal hwmon.
>
> Kuninori Morimoto (2):
> thermal: rcar-thermal: enable hwmon when thermal_zone
> thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
>
> drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> drivers/thermal/thermal_hwmon.c | 2 ++
> 2 files changed, 20 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
2016-08-03 2:00 ` Kuninori Morimoto
@ 2016-08-10 2:10 ` Kuninori Morimoto
-1 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-10 2:10 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Zhang Rui, edubezval, Geert Uytterhoeven, linux-kernel,
linux-renesas-soc, linux-pm, yoshihiro.shimoda.uh, cm-hiep,
PhucBui
Hi Linux-PM, Linux-Kernel ML
I posted thermal driver patch 2month ago, but no response and nothing happen.
I'm following scripts/get_maintainer.pl, but am I wrong ??
Who is the maintainer of these patches ??
> Hi Zhang
>
> ping ??
>
> > These are resend patches for rcar-thermal hwmon.
> >
> > Kuninori Morimoto (2):
> > thermal: rcar-thermal: enable hwmon when thermal_zone
> > thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
> >
> > drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> > drivers/thermal/thermal_hwmon.c | 2 ++
> > 2 files changed, 20 insertions(+), 2 deletions(-)
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-08-10 2:10 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-10 2:10 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Zhang Rui, edubezval, Geert Uytterhoeven, linux-kernel,
linux-renesas-soc, linux-pm, yoshihiro.shimoda.uh, cm-hiep,
PhucBui
Hi Linux-PM, Linux-Kernel ML
I posted thermal driver patch 2month ago, but no response and nothing happen.
I'm following scripts/get_maintainer.pl, but am I wrong ??
Who is the maintainer of these patches ??
> Hi Zhang
>
> ping ??
>
> > These are resend patches for rcar-thermal hwmon.
> >
> > Kuninori Morimoto (2):
> > thermal: rcar-thermal: enable hwmon when thermal_zone
> > thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
> >
> > drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> > drivers/thermal/thermal_hwmon.c | 2 ++
> > 2 files changed, 20 insertions(+), 2 deletions(-)
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 28+ messages in thread
* RE: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
2016-08-10 2:10 ` Kuninori Morimoto
@ 2016-08-10 2:46 ` Zhang, Rui
-1 siblings, 0 replies; 28+ messages in thread
From: Zhang, Rui @ 2016-08-10 2:46 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, PhucBui
> -----Original Message-----
> From: Kuninori Morimoto [mailto:kuninori.morimoto.gx@renesas.com]
> Sent: Wednesday, August 10, 2016 10:10 AM
> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Zhang, Rui <rui.zhang@intel.com>; edubezval@gmail.com; Geert
> Uytterhoeven <geert@linux-m68k.org>; linux-kernel@vger.kernel.org; linux-
> renesas-soc@vger.kernel.org; linux-pm@vger.kernel.org;
> yoshihiro.shimoda.uh@renesas.com; cm-hiep@jinso.co.jp; PhucBui <bd-
> phuc@jinso.co.jp>
> Subject: Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for
> thermal hwmon sysfs
> Importance: High
>
>
> Hi Linux-PM, Linux-Kernel ML
>
> I posted thermal driver patch 2month ago, but no response and nothing
> happen.
> I'm following scripts/get_maintainer.pl, but am I wrong ??
> Who is the maintainer of these patches ??
>
The patch is queued for 4.8-rc2.
As you can see at https://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/log/?h=next
Thanks,
Rui
> > Hi Zhang
> >
> > ping ??
> >
> > > These are resend patches for rcar-thermal hwmon.
> > >
> > > Kuninori Morimoto (2):
> > > thermal: rcar-thermal: enable hwmon when thermal_zone
> > > thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
> > >
> > > drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> > > drivers/thermal/thermal_hwmon.c | 2 ++
> > > 2 files changed, 20 insertions(+), 2 deletions(-)
>
>
> Best regards
> ---
> Kuninori Morimoto
^ permalink raw reply [flat|nested] 28+ messages in thread
* RE: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-08-10 2:46 ` Zhang, Rui
0 siblings, 0 replies; 28+ messages in thread
From: Zhang, Rui @ 2016-08-10 2:46 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, PhucBui
> -----Original Message-----
> From: Kuninori Morimoto [mailto:kuninori.morimoto.gx@renesas.com]
> Sent: Wednesday, August 10, 2016 10:10 AM
> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Zhang, Rui <rui.zhang@intel.com>; edubezval@gmail.com; Geert
> Uytterhoeven <geert@linux-m68k.org>; linux-kernel@vger.kernel.org; linux-
> renesas-soc@vger.kernel.org; linux-pm@vger.kernel.org;
> yoshihiro.shimoda.uh@renesas.com; cm-hiep@jinso.co.jp; PhucBui <bd-
> phuc@jinso.co.jp>
> Subject: Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for
> thermal hwmon sysfs
> Importance: High
>
>
> Hi Linux-PM, Linux-Kernel ML
>
> I posted thermal driver patch 2month ago, but no response and nothing
> happen.
> I'm following scripts/get_maintainer.pl, but am I wrong ??
> Who is the maintainer of these patches ??
>
The patch is queued for 4.8-rc2.
As you can see at https://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/log/?h=next
Thanks,
Rui
> > Hi Zhang
> >
> > ping ??
> >
> > > These are resend patches for rcar-thermal hwmon.
> > >
> > > Kuninori Morimoto (2):
> > > thermal: rcar-thermal: enable hwmon when thermal_zone
> > > thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
> > >
> > > drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> > > drivers/thermal/thermal_hwmon.c | 2 ++
> > > 2 files changed, 20 insertions(+), 2 deletions(-)
>
>
> Best regards
> ---
> Kuninori Morimoto
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
2016-08-10 2:46 ` Zhang, Rui
@ 2016-08-10 2:54 ` Kuninori Morimoto
-1 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-10 2:54 UTC (permalink / raw)
To: Zhang, Rui
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, PhucBui
Hi Zhang
> > Hi Linux-PM, Linux-Kernel ML
> >
> > I posted thermal driver patch 2month ago, but no response and nothing
> > happen.
> > I'm following scripts/get_maintainer.pl, but am I wrong ??
> > Who is the maintainer of these patches ??
> >
> The patch is queued for 4.8-rc2.
> As you can see at https://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/log/?h=next
Oh, thanks
But, I think it doesn't include [1/2] patch, is it rejected ?
> > > > Kuninori Morimoto (2):
> > > > thermal: rcar-thermal: enable hwmon when thermal_zone
> > > > thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-08-10 2:54 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-10 2:54 UTC (permalink / raw)
To: Zhang, Rui
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, PhucBui
Hi Zhang
> > Hi Linux-PM, Linux-Kernel ML
> >
> > I posted thermal driver patch 2month ago, but no response and nothing
> > happen.
> > I'm following scripts/get_maintainer.pl, but am I wrong ??
> > Who is the maintainer of these patches ??
> >
> The patch is queued for 4.8-rc2.
> As you can see at https://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/log/?h=next
Oh, thanks
But, I think it doesn't include [1/2] patch, is it rejected ?
> > > > Kuninori Morimoto (2):
> > > > thermal: rcar-thermal: enable hwmon when thermal_zone
> > > > thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
2016-08-10 2:54 ` Kuninori Morimoto
@ 2016-08-10 7:40 ` Zhang Rui
-1 siblings, 0 replies; 28+ messages in thread
From: Zhang Rui @ 2016-08-10 7:40 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, PhucBui
On 三, 2016-08-10 at 02:54 +0000, Kuninori Morimoto wrote:
> Hi Zhang
>
> >
> > >
> > > Hi Linux-PM, Linux-Kernel ML
> > >
> > > I posted thermal driver patch 2month ago, but no response and
> > > nothing
> > > happen.
> > > I'm following scripts/get_maintainer.pl, but am I wrong ??
> > > Who is the maintainer of these patches ??
> > >
> > The patch is queued for 4.8-rc2.
> > As you can see at https://git.kernel.org/cgit/linux/kernel/git/rzha
> > ng/linux.git/log/?h=next
> Oh, thanks
> But, I think it doesn't include [1/2] patch, is it rejected ?
>
Usually, soc thermal driver changes should go to Eduardo' tree first.
I can also take soc thermal driver changes only if they've got ACK from
either Eduardo or the driver Author.
In your case, I can take patch 1/2, but let's see what Eduardo says
first.
thanks,
rui
>
> >
> > >
> > > >
> > > > >
> > > > > Kuninori Morimoto (2):
> > > > > thermal: rcar-thermal: enable hwmon when thermal_zone
> > > > > thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon
> > > > > sysfs
>
> Best regards
> ---
> Kuninori Morimoto
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-08-10 7:40 ` Zhang Rui
0 siblings, 0 replies; 28+ messages in thread
From: Zhang Rui @ 2016-08-10 7:40 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, PhucBui
On 三, 2016-08-10 at 02:54 +0000, Kuninori Morimoto wrote:
> Hi Zhang
>
> >
> > >
> > > Hi Linux-PM, Linux-Kernel ML
> > >
> > > I posted thermal driver patch 2month ago, but no response and
> > > nothing
> > > happen.
> > > I'm following scripts/get_maintainer.pl, but am I wrong ??
> > > Who is the maintainer of these patches ??
> > >
> > The patch is queued for 4.8-rc2.
> > As you can see at https://git.kernel.org/cgit/linux/kernel/git/rzha
> > ng/linux.git/log/?h=next
> Oh, thanks
> But, I think it doesn't include [1/2] patch, is it rejected ?
>
Usually, soc thermal driver changes should go to Eduardo' tree first.
I can also take soc thermal driver changes only if they've got ACK from
either Eduardo or the driver Author.
In your case, I can take patch 1/2, but let's see what Eduardo says
first.
thanks,
rui
>
> >
> > >
> > > >
> > > > >
> > > > > Kuninori Morimoto (2):
> > > > > thermal: rcar-thermal: enable hwmon when thermal_zone
> > > > > thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon
> > > > > sysfs
>
> Best regards
> ---
> Kuninori Morimoto
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
2016-08-10 7:40 ` Zhang Rui
@ 2016-08-11 0:13 ` Kuninori Morimoto
-1 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-11 0:13 UTC (permalink / raw)
To: Zhang Rui, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, PhucBui
Hi Zhang, Eduardo
> > > > I posted thermal driver patch 2month ago, but no response and
> > > > nothing
> > > > happen.
> > > > I'm following scripts/get_maintainer.pl, but am I wrong ??
> > > > Who is the maintainer of these patches ??
> > > >
> > > The patch is queued for 4.8-rc2.
> > > As you can see at https://git.kernel.org/cgit/linux/kernel/git/rzha
> > > ng/linux.git/log/?h=next
> > Oh, thanks
> > But, I think it doesn't include [1/2] patch, is it rejected ?
> >
> Usually, soc thermal driver changes should go to Eduardo' tree first.
> I can also take soc thermal driver changes only if they've got ACK from
> either Eduardo or the driver Author.
> In your case, I can take patch 1/2, but let's see what Eduardo says
> first.
OK, I see
Eduardo, I need your feedback.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs
@ 2016-08-11 0:13 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-11 0:13 UTC (permalink / raw)
To: Zhang Rui, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, PhucBui
Hi Zhang, Eduardo
> > > > I posted thermal driver patch 2month ago, but no response and
> > > > nothing
> > > > happen.
> > > > I'm following scripts/get_maintainer.pl, but am I wrong ??
> > > > Who is the maintainer of these patches ??
> > > >
> > > The patch is queued for 4.8-rc2.
> > > As you can see at https://git.kernel.org/cgit/linux/kernel/git/rzha
> > > ng/linux.git/log/?h=next
> > Oh, thanks
> > But, I think it doesn't include [1/2] patch, is it rejected ?
> >
> Usually, soc thermal driver changes should go to Eduardo' tree first.
> I can also take soc thermal driver changes only if they've got ACK from
> either Eduardo or the driver Author.
> In your case, I can take patch 1/2, but let's see what Eduardo says
> first.
OK, I see
Eduardo, I need your feedback.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
2016-07-19 10:01 ` Kuninori Morimoto
@ 2016-08-19 11:35 ` Zhang Rui
-1 siblings, 0 replies; 28+ messages in thread
From: Zhang Rui @ 2016-08-19 11:35 UTC (permalink / raw)
To: Kuninori Morimoto, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, hucBui
On 二, 2016-07-19 at 10:01 +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> rcar-thermal is supporting both thermal_zone_of_sensor_register() and
> thermal_zone_device_register(). But thermal_zone_of_sensor_register()
> doesn't enable hwmon as default.
> This patch enables it to keep compatibility
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Queued for 4.9
thanks,
rui
> ---
> drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c
> b/drivers/thermal/rcar_thermal.c
> index 71a3392..4d07644 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -31,6 +31,8 @@
> #include <linux/spinlock.h>
> #include <linux/thermal.h>
>
> +#include "thermal_hwmon.h"
> +
> #define IDLE_INTERVAL 5000
>
> #define COMMON_STR 0x00
> @@ -75,6 +77,8 @@ struct rcar_thermal_priv {
> #define rcar_priv_to_dev(priv) ((priv)->common->dev)
> #define rcar_has_irq_support(priv) ((priv)->common->base)
> #define rcar_id_to_shift(priv) ((priv)->id * 8)
> +#define rcar_of_data(dev) ((unsigned
> long)of_device_get_match_data(dev))
> +#define rcar_use_of_thermal(dev) (rcar_of_data(dev) ==
> USE_OF_THERMAL)
>
> #define USE_OF_THERMAL 1
> static const struct of_device_id rcar_thermal_dt_ids[] = {
> @@ -416,6 +420,8 @@ static int rcar_thermal_remove(struct
> platform_device *pdev)
> rcar_thermal_for_each_priv(priv, common) {
> rcar_thermal_irq_disable(priv);
> thermal_zone_device_unregister(priv->zone);
> + if (rcar_use_of_thermal(dev))
> + thermal_remove_hwmon_sysfs(priv->zone);
> }
>
> pm_runtime_put(dev);
> @@ -430,7 +436,6 @@ static int rcar_thermal_probe(struct
> platform_device *pdev)
> struct rcar_thermal_priv *priv;
> struct device *dev = &pdev->dev;
> struct resource *res, *irq;
> - unsigned long of_data = (unsigned
> long)of_device_get_match_data(dev);
> int mres = 0;
> int i;
> int ret = -ENODEV;
> @@ -491,7 +496,7 @@ static int rcar_thermal_probe(struct
> platform_device *pdev)
> if (ret < 0)
> goto error_unregister;
>
> - if (of_data == USE_OF_THERMAL)
> + if (rcar_use_of_thermal(dev))
> priv->zone =
> devm_thermal_zone_of_sensor_register(
> dev, i, priv,
> &rcar_thermal_zone_o
> f_ops);
> @@ -507,6 +512,17 @@ static int rcar_thermal_probe(struct
> platform_device *pdev)
> goto error_unregister;
> }
>
> + if (rcar_use_of_thermal(dev)) {
> + /*
> + * thermal_zone doesn't enable hwmon as
> default,
> + * but, enable it here to keep compatible
> + */
> + priv->zone->tzp->no_hwmon = false;
> + ret = thermal_add_hwmon_sysfs(priv->zone);
> + if (ret)
> + goto error_unregister;
> + }
> +
> rcar_thermal_irq_enable(priv);
>
> list_move_tail(&priv->list, &common->head);
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
@ 2016-08-19 11:35 ` Zhang Rui
0 siblings, 0 replies; 28+ messages in thread
From: Zhang Rui @ 2016-08-19 11:35 UTC (permalink / raw)
To: Kuninori Morimoto, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, hucBui
On 二, 2016-07-19 at 10:01 +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> rcar-thermal is supporting both thermal_zone_of_sensor_register() and
> thermal_zone_device_register(). But thermal_zone_of_sensor_register()
> doesn't enable hwmon as default.
> This patch enables it to keep compatibility
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Queued for 4.9
thanks,
rui
> ---
> drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c
> b/drivers/thermal/rcar_thermal.c
> index 71a3392..4d07644 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -31,6 +31,8 @@
> #include <linux/spinlock.h>
> #include <linux/thermal.h>
>
> +#include "thermal_hwmon.h"
> +
> #define IDLE_INTERVAL 5000
>
> #define COMMON_STR 0x00
> @@ -75,6 +77,8 @@ struct rcar_thermal_priv {
> #define rcar_priv_to_dev(priv) ((priv)->common->dev)
> #define rcar_has_irq_support(priv) ((priv)->common->base)
> #define rcar_id_to_shift(priv) ((priv)->id * 8)
> +#define rcar_of_data(dev) ((unsigned
> long)of_device_get_match_data(dev))
> +#define rcar_use_of_thermal(dev) (rcar_of_data(dev) ==
> USE_OF_THERMAL)
>
> #define USE_OF_THERMAL 1
> static const struct of_device_id rcar_thermal_dt_ids[] = {
> @@ -416,6 +420,8 @@ static int rcar_thermal_remove(struct
> platform_device *pdev)
> rcar_thermal_for_each_priv(priv, common) {
> rcar_thermal_irq_disable(priv);
> thermal_zone_device_unregister(priv->zone);
> + if (rcar_use_of_thermal(dev))
> + thermal_remove_hwmon_sysfs(priv->zone);
> }
>
> pm_runtime_put(dev);
> @@ -430,7 +436,6 @@ static int rcar_thermal_probe(struct
> platform_device *pdev)
> struct rcar_thermal_priv *priv;
> struct device *dev = &pdev->dev;
> struct resource *res, *irq;
> - unsigned long of_data = (unsigned
> long)of_device_get_match_data(dev);
> int mres = 0;
> int i;
> int ret = -ENODEV;
> @@ -491,7 +496,7 @@ static int rcar_thermal_probe(struct
> platform_device *pdev)
> if (ret < 0)
> goto error_unregister;
>
> - if (of_data == USE_OF_THERMAL)
> + if (rcar_use_of_thermal(dev))
> priv->zone =
> devm_thermal_zone_of_sensor_register(
> dev, i, priv,
> &rcar_thermal_zone_o
> f_ops);
> @@ -507,6 +512,17 @@ static int rcar_thermal_probe(struct
> platform_device *pdev)
> goto error_unregister;
> }
>
> + if (rcar_use_of_thermal(dev)) {
> + /*
> + * thermal_zone doesn't enable hwmon as
> default,
> + * but, enable it here to keep compatible
> + */
> + priv->zone->tzp->no_hwmon = false;
> + ret = thermal_add_hwmon_sysfs(priv->zone);
> + if (ret)
> + goto error_unregister;
> + }
> +
> rcar_thermal_irq_enable(priv);
>
> list_move_tail(&priv->list, &common->head);
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
2016-08-19 11:35 ` Zhang Rui
@ 2016-08-24 7:51 ` Zhang Rui
-1 siblings, 0 replies; 28+ messages in thread
From: Zhang Rui @ 2016-08-24 7:51 UTC (permalink / raw)
To: Kuninori Morimoto, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, hucBui
On 五, 2016-08-19 at 19:35 +0800, Zhang Rui wrote:
> On 二, 2016-07-19 at 10:01 +0000, Kuninori Morimoto wrote:
> >
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > rcar-thermal is supporting both thermal_zone_of_sensor_register()
> > and
> > thermal_zone_device_register(). But
> > thermal_zone_of_sensor_register()
> > doesn't enable hwmon as default.
> > This patch enables it to keep compatibility
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Queued for 4.9
>
the subject should be "thermal:rcar-theraml: enable hwmon when
thermal_zone_of_sensor_register is used", right?
thanks,
rui
> thanks,
> rui
> >
> > ---
> > drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> > 1 file changed, 18 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/rcar_thermal.c
> > b/drivers/thermal/rcar_thermal.c
> > index 71a3392..4d07644 100644
> > --- a/drivers/thermal/rcar_thermal.c
> > +++ b/drivers/thermal/rcar_thermal.c
> > @@ -31,6 +31,8 @@
> > #include <linux/spinlock.h>
> > #include <linux/thermal.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> > #define IDLE_INTERVAL 5000
> >
> > #define COMMON_STR 0x00
> > @@ -75,6 +77,8 @@ struct rcar_thermal_priv {
> > #define rcar_priv_to_dev(priv) ((priv)->common-
> > >dev)
> > #define rcar_has_irq_support(priv) ((priv)->common->base)
> > #define rcar_id_to_shift(priv) ((priv)->id * 8)
> > +#define rcar_of_data(dev) ((unsigned
> > long)of_device_get_match_data(dev))
> > +#define rcar_use_of_thermal(dev) (rcar_of_data(dev) ==
> > USE_OF_THERMAL)
> >
> > #define USE_OF_THERMAL 1
> > static const struct of_device_id rcar_thermal_dt_ids[] = {
> > @@ -416,6 +420,8 @@ static int rcar_thermal_remove(struct
> > platform_device *pdev)
> > rcar_thermal_for_each_priv(priv, common) {
> > rcar_thermal_irq_disable(priv);
> > thermal_zone_device_unregister(priv->zone);
> > + if (rcar_use_of_thermal(dev))
> > + thermal_remove_hwmon_sysfs(priv->zone);
> > }
> >
> > pm_runtime_put(dev);
> > @@ -430,7 +436,6 @@ static int rcar_thermal_probe(struct
> > platform_device *pdev)
> > struct rcar_thermal_priv *priv;
> > struct device *dev = &pdev->dev;
> > struct resource *res, *irq;
> > - unsigned long of_data = (unsigned
> > long)of_device_get_match_data(dev);
> > int mres = 0;
> > int i;
> > int ret = -ENODEV;
> > @@ -491,7 +496,7 @@ static int rcar_thermal_probe(struct
> > platform_device *pdev)
> > if (ret < 0)
> > goto error_unregister;
> >
> > - if (of_data == USE_OF_THERMAL)
> > + if (rcar_use_of_thermal(dev))
> > priv->zone =
> > devm_thermal_zone_of_sensor_register(
> > dev, i, priv,
> > &rcar_thermal_zone
> > _o
> > f_ops);
> > @@ -507,6 +512,17 @@ static int rcar_thermal_probe(struct
> > platform_device *pdev)
> > goto error_unregister;
> > }
> >
> > + if (rcar_use_of_thermal(dev)) {
> > + /*
> > + * thermal_zone doesn't enable hwmon as
> > default,
> > + * but, enable it here to keep compatible
> > + */
> > + priv->zone->tzp->no_hwmon = false;
> > + ret = thermal_add_hwmon_sysfs(priv->zone);
> > + if (ret)
> > + goto error_unregister;
> > + }
> > +
> > rcar_thermal_irq_enable(priv);
> >
> > list_move_tail(&priv->list, &common->head);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
@ 2016-08-24 7:51 ` Zhang Rui
0 siblings, 0 replies; 28+ messages in thread
From: Zhang Rui @ 2016-08-24 7:51 UTC (permalink / raw)
To: Kuninori Morimoto, edubezval
Cc: Geert Uytterhoeven, linux-kernel, linux-renesas-soc, linux-pm,
yoshihiro.shimoda.uh, cm-hiep, hucBui
On 五, 2016-08-19 at 19:35 +0800, Zhang Rui wrote:
> On 二, 2016-07-19 at 10:01 +0000, Kuninori Morimoto wrote:
> >
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > rcar-thermal is supporting both thermal_zone_of_sensor_register()
> > and
> > thermal_zone_device_register(). But
> > thermal_zone_of_sensor_register()
> > doesn't enable hwmon as default.
> > This patch enables it to keep compatibility
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Queued for 4.9
>
the subject should be "thermal:rcar-theraml: enable hwmon when
thermal_zone_of_sensor_register is used", right?
thanks,
rui
> thanks,
> rui
> >
> > ---
> > drivers/thermal/rcar_thermal.c | 20 ++++++++++++++++++--
> > 1 file changed, 18 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/rcar_thermal.c
> > b/drivers/thermal/rcar_thermal.c
> > index 71a3392..4d07644 100644
> > --- a/drivers/thermal/rcar_thermal.c
> > +++ b/drivers/thermal/rcar_thermal.c
> > @@ -31,6 +31,8 @@
> > #include <linux/spinlock.h>
> > #include <linux/thermal.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> > #define IDLE_INTERVAL 5000
> >
> > #define COMMON_STR 0x00
> > @@ -75,6 +77,8 @@ struct rcar_thermal_priv {
> > #define rcar_priv_to_dev(priv) ((priv)->common-
> > >dev)
> > #define rcar_has_irq_support(priv) ((priv)->common->base)
> > #define rcar_id_to_shift(priv) ((priv)->id * 8)
> > +#define rcar_of_data(dev) ((unsigned
> > long)of_device_get_match_data(dev))
> > +#define rcar_use_of_thermal(dev) (rcar_of_data(dev) ==
> > USE_OF_THERMAL)
> >
> > #define USE_OF_THERMAL 1
> > static const struct of_device_id rcar_thermal_dt_ids[] = {
> > @@ -416,6 +420,8 @@ static int rcar_thermal_remove(struct
> > platform_device *pdev)
> > rcar_thermal_for_each_priv(priv, common) {
> > rcar_thermal_irq_disable(priv);
> > thermal_zone_device_unregister(priv->zone);
> > + if (rcar_use_of_thermal(dev))
> > + thermal_remove_hwmon_sysfs(priv->zone);
> > }
> >
> > pm_runtime_put(dev);
> > @@ -430,7 +436,6 @@ static int rcar_thermal_probe(struct
> > platform_device *pdev)
> > struct rcar_thermal_priv *priv;
> > struct device *dev = &pdev->dev;
> > struct resource *res, *irq;
> > - unsigned long of_data = (unsigned
> > long)of_device_get_match_data(dev);
> > int mres = 0;
> > int i;
> > int ret = -ENODEV;
> > @@ -491,7 +496,7 @@ static int rcar_thermal_probe(struct
> > platform_device *pdev)
> > if (ret < 0)
> > goto error_unregister;
> >
> > - if (of_data == USE_OF_THERMAL)
> > + if (rcar_use_of_thermal(dev))
> > priv->zone =
> > devm_thermal_zone_of_sensor_register(
> > dev, i, priv,
> > &rcar_thermal_zone
> > _o
> > f_ops);
> > @@ -507,6 +512,17 @@ static int rcar_thermal_probe(struct
> > platform_device *pdev)
> > goto error_unregister;
> > }
> >
> > + if (rcar_use_of_thermal(dev)) {
> > + /*
> > + * thermal_zone doesn't enable hwmon as
> > default,
> > + * but, enable it here to keep compatible
> > + */
> > + priv->zone->tzp->no_hwmon = false;
> > + ret = thermal_add_hwmon_sysfs(priv->zone);
> > + if (ret)
> > + goto error_unregister;
> > + }
> > +
> > rcar_thermal_irq_enable(priv);
> >
> > list_move_tail(&priv->list, &common->head);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
2016-08-24 7:51 ` Zhang Rui
@ 2016-08-24 8:17 ` Kuninori Morimoto
-1 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-24 8:17 UTC (permalink / raw)
To: Zhang Rui
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, hucBui
Hi Zhang
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > rcar-thermal is supporting both thermal_zone_of_sensor_register()
> > > and
> > > thermal_zone_device_register(). But
> > > thermal_zone_of_sensor_register()
> > > doesn't enable hwmon as default.
> > > This patch enables it to keep compatibility
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Queued for 4.9
> >
> the subject should be "thermal:rcar-theraml: enable hwmon when
> thermal_zone_of_sensor_register is used", right?
Yes exactly.
Should I resend v2 patch ?
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
@ 2016-08-24 8:17 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-24 8:17 UTC (permalink / raw)
To: Zhang Rui
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, hucBui
Hi Zhang
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > rcar-thermal is supporting both thermal_zone_of_sensor_register()
> > > and
> > > thermal_zone_device_register(). But
> > > thermal_zone_of_sensor_register()
> > > doesn't enable hwmon as default.
> > > This patch enables it to keep compatibility
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Queued for 4.9
> >
> the subject should be "thermal:rcar-theraml: enable hwmon when
> thermal_zone_of_sensor_register is used", right?
Yes exactly.
Should I resend v2 patch ?
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
2016-08-24 8:17 ` Kuninori Morimoto
@ 2016-08-24 8:26 ` Zhang Rui
-1 siblings, 0 replies; 28+ messages in thread
From: Zhang Rui @ 2016-08-24 8:26 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, hucBui
On 三, 2016-08-24 at 08:17 +0000, Kuninori Morimoto wrote:
> Hi Zhang
>
> >
> > >
> > > >
> > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > >
> > > > rcar-thermal is supporting both
> > > > thermal_zone_of_sensor_register()
> > > > and
> > > > thermal_zone_device_register(). But
> > > > thermal_zone_of_sensor_register()
> > > > doesn't enable hwmon as default.
> > > > This patch enables it to keep compatibility
> > > >
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.
> > > > com>
> > > Queued for 4.9
> > >
> > the subject should be "thermal:rcar-theraml: enable hwmon when
> > thermal_zone_of_sensor_register is used", right?
> Yes exactly.
> Should I resend v2 patch ?
>
nop. I've already updated the patch subject.
thanks,
rui
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
@ 2016-08-24 8:26 ` Zhang Rui
0 siblings, 0 replies; 28+ messages in thread
From: Zhang Rui @ 2016-08-24 8:26 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, hucBui
On 三, 2016-08-24 at 08:17 +0000, Kuninori Morimoto wrote:
> Hi Zhang
>
> >
> > >
> > > >
> > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > >
> > > > rcar-thermal is supporting both
> > > > thermal_zone_of_sensor_register()
> > > > and
> > > > thermal_zone_device_register(). But
> > > > thermal_zone_of_sensor_register()
> > > > doesn't enable hwmon as default.
> > > > This patch enables it to keep compatibility
> > > >
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.
> > > > com>
> > > Queued for 4.9
> > >
> > the subject should be "thermal:rcar-theraml: enable hwmon when
> > thermal_zone_of_sensor_register is used", right?
> Yes exactly.
> Should I resend v2 patch ?
>
nop. I've already updated the patch subject.
thanks,
rui
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
2016-08-24 8:26 ` Zhang Rui
@ 2016-08-24 8:32 ` Kuninori Morimoto
-1 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-24 8:32 UTC (permalink / raw)
To: Zhang Rui
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, hucBui
Hi Zhang
> > > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > >
> > > > > rcar-thermal is supporting both
> > > > > thermal_zone_of_sensor_register()
> > > > > and
> > > > > thermal_zone_device_register(). But
> > > > > thermal_zone_of_sensor_register()
> > > > > doesn't enable hwmon as default.
> > > > > This patch enables it to keep compatibility
> > > > >
> > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.
> > > > > com>
> > > > Queued for 4.9
> > > >
> > > the subject should be "thermal:rcar-theraml: enable hwmon when
> > > thermal_zone_of_sensor_register is used", right?
> > Yes exactly.
> > Should I resend v2 patch ?
> >
> nop. I've already updated the patch subject.
Thank you for your help
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone
@ 2016-08-24 8:32 ` Kuninori Morimoto
0 siblings, 0 replies; 28+ messages in thread
From: Kuninori Morimoto @ 2016-08-24 8:32 UTC (permalink / raw)
To: Zhang Rui
Cc: edubezval, Geert Uytterhoeven, linux-kernel, linux-renesas-soc,
linux-pm, yoshihiro.shimoda.uh, cm-hiep, hucBui
Hi Zhang
> > > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > >
> > > > > rcar-thermal is supporting both
> > > > > thermal_zone_of_sensor_register()
> > > > > and
> > > > > thermal_zone_device_register(). But
> > > > > thermal_zone_of_sensor_register()
> > > > > doesn't enable hwmon as default.
> > > > > This patch enables it to keep compatibility
> > > > >
> > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.
> > > > > com>
> > > > Queued for 4.9
> > > >
> > > the subject should be "thermal:rcar-theraml: enable hwmon when
> > > thermal_zone_of_sensor_register is used", right?
> > Yes exactly.
> > Should I resend v2 patch ?
> >
> nop. I've already updated the patch subject.
Thank you for your help
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2016-08-24 8:36 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-19 10:00 [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs Kuninori Morimoto
2016-07-19 10:00 ` Kuninori Morimoto
2016-07-19 10:01 ` [PATCH 1/2] " Kuninori Morimoto
2016-07-19 10:01 ` Kuninori Morimoto
2016-07-19 10:01 ` [PATCH 2/2] thermal: rcar-thermal: enable hwmon when thermal_zone Kuninori Morimoto
2016-07-19 10:01 ` Kuninori Morimoto
2016-08-19 11:35 ` Zhang Rui
2016-08-19 11:35 ` Zhang Rui
2016-08-24 7:51 ` Zhang Rui
2016-08-24 7:51 ` Zhang Rui
2016-08-24 8:17 ` Kuninori Morimoto
2016-08-24 8:17 ` Kuninori Morimoto
2016-08-24 8:26 ` Zhang Rui
2016-08-24 8:26 ` Zhang Rui
2016-08-24 8:32 ` Kuninori Morimoto
2016-08-24 8:32 ` Kuninori Morimoto
2016-08-03 2:00 ` [PATCH][RESEND] thermal: hwmon: EXPORT_SYMBOL_GPL for thermal hwmon sysfs Kuninori Morimoto
2016-08-03 2:00 ` Kuninori Morimoto
2016-08-10 2:10 ` Kuninori Morimoto
2016-08-10 2:10 ` Kuninori Morimoto
2016-08-10 2:46 ` Zhang, Rui
2016-08-10 2:46 ` Zhang, Rui
2016-08-10 2:54 ` Kuninori Morimoto
2016-08-10 2:54 ` Kuninori Morimoto
2016-08-10 7:40 ` Zhang Rui
2016-08-10 7:40 ` Zhang Rui
2016-08-11 0:13 ` Kuninori Morimoto
2016-08-11 0:13 ` Kuninori Morimoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.