All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state
Date: Wed, 20 Aug 2014 18:47:11 +0200	[thread overview]
Message-ID: <87ppfvqfao.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20140820153431.15111.3916.stgit@fimbulvetr.bsc.es> (=?utf-8?Q?=22Llu=C3=ADs?= Vilanova"'s message of "Wed, 20 Aug 2014 17:34:32 +0200")

Lluís Vilanova <vilanova@ac.upc.edu> writes:

> Also removes old "trace-event", "trace-file" and "info trace-events" HMP
> commands.

We gain the ability to control trace via QMP, but lose the ability to
control it via HMP, correct?

>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  hmp-commands.hx     |   35 -----------------------
>  monitor.c           |   61 ----------------------------------------
>  qapi-schema.json    |    3 ++
>  qmp-commands.hx     |   27 ++++++++++++++++++
>  trace/Makefile.objs |    1 +
>  trace/commands.json |   44 +++++++++++++++++++++++++++++

There's no precedence for keeping schema bits anywhere but in qapi/.
If we decide we want to keep them with their related C parts instead, we
should do so consistently, not just for trace.

>  trace/control.c     |   13 ---------
>  trace/control.h     |    7 -----
>  trace/qmp.c         |   77 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  trace/simple.c      |   10 +------
>  trace/simple.h      |    3 --
>  11 files changed, 154 insertions(+), 127 deletions(-)
>  create mode 100644 trace/commands.json
>  create mode 100644 trace/qmp.c
[...]

  reply	other threads:[~2014-08-20 16:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20 15:34 [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state Lluís Vilanova
2014-08-20 16:47 ` Markus Armbruster [this message]
2014-08-20 18:30   ` Lluís Vilanova
2014-08-20 19:02     ` Markus Armbruster
2014-08-20 19:28       ` Lluís Vilanova
2014-08-21  7:14         ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppfvqfao.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.