All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] clocksource: add device-tree support for PXA timer
Date: Thu, 03 Jul 2014 19:39:49 +0200	[thread overview]
Message-ID: <87pphmnxy2.fsf@free.fr> (raw)
In-Reply-To: <87tx6ynybb.fsf@free.fr> (Robert Jarzmik's message of "Thu, 03 Jul 2014 19:31:52 +0200")

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> Daniel Lezcano <daniel.lezcano@linaro.org> writes:
>
>>> -#include <mach/regs-ost.h>
>>>   #include <mach/irqs.h>
>>> +#include <mach/hardware.h>
>>
>> Now as the driver is in 'drivers', do not reference the headers files in
>> mach. Moving the driver to the drivers directory implies some cleanup with the
>> headers dependencies.
> I don't see that very possible.
> Or said another way, I don't see how the irq number, IRQ_OST0 (in mach/irqs.h)
> can be guessed for non device-tree configuration.
Oh yeah, a simple parameter to pxa_init_timer() will do the trick ...

> Another question brought up by this : if I remove all 'mach/' includes, I loose
> io_p2v() right ? How can I guess timer_base then ?
And same answer here, a simple parameter to pxa_init_timer() will solve this
too.

Cheers.

--
Robert

WARNING: multiple messages have this Message-ID (diff)
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clocksource: add device-tree support for PXA timer
Date: Thu, 03 Jul 2014 19:39:49 +0200	[thread overview]
Message-ID: <87pphmnxy2.fsf@free.fr> (raw)
In-Reply-To: <87tx6ynybb.fsf@free.fr> (Robert Jarzmik's message of "Thu, 03 Jul 2014 19:31:52 +0200")

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> Daniel Lezcano <daniel.lezcano@linaro.org> writes:
>
>>> -#include <mach/regs-ost.h>
>>>   #include <mach/irqs.h>
>>> +#include <mach/hardware.h>
>>
>> Now as the driver is in 'drivers', do not reference the headers files in
>> mach. Moving the driver to the drivers directory implies some cleanup with the
>> headers dependencies.
> I don't see that very possible.
> Or said another way, I don't see how the irq number, IRQ_OST0 (in mach/irqs.h)
> can be guessed for non device-tree configuration.
Oh yeah, a simple parameter to pxa_init_timer() will do the trick ...

> Another question brought up by this : if I remove all 'mach/' includes, I loose
> io_p2v() right ? How can I guess timer_base then ?
And same answer here, a simple parameter to pxa_init_timer() will solve this
too.

Cheers.

--
Robert

  reply	other threads:[~2014-07-03 17:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-21 22:09 [PATCH 1/3] clocksource: move PXA timer to clocksource framework Robert Jarzmik
2014-06-21 22:09 ` Robert Jarzmik
2014-06-21 22:09 ` [PATCH 2/3] clocksource: add device-tree support for PXA timer Robert Jarzmik
2014-06-21 22:09   ` Robert Jarzmik
2014-07-03 12:05   ` Daniel Lezcano
2014-07-03 12:05     ` Daniel Lezcano
2014-07-03 17:31     ` Robert Jarzmik
2014-07-03 17:31       ` Robert Jarzmik
2014-07-03 17:39       ` Robert Jarzmik [this message]
2014-07-03 17:39         ` Robert Jarzmik
2014-07-04  6:18       ` Daniel Lezcano
2014-07-04  6:18         ` Daniel Lezcano
2014-07-04 19:46         ` Robert Jarzmik
2014-07-04 19:46           ` Robert Jarzmik
2014-06-21 22:09 ` [PATCH 3/3] ARM: add CLKSRC_OF dependency for PXA Robert Jarzmik
2014-06-21 22:09   ` Robert Jarzmik
2014-06-29 14:15 ` [PATCH 1/3] clocksource: move PXA timer to clocksource framework Robert Jarzmik
2014-06-29 14:15   ` Robert Jarzmik
2014-07-03  4:37 ` Haojian Zhuang
2014-07-03  4:37   ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pphmnxy2.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=daniel.lezcano@linaro.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.