* [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables
@ 2022-03-13 9:21 Fabrice Fontaine
2022-03-13 9:21 ` [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build Fabrice Fontaine
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-03-13 9:21 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
openssl is mandatory since bump to version 9.16.26 in commit
8adeaec8afacbc680edebae91524f6144926ac92 so move openssl variables in
the beginning of bind.mk instead of keeping them in the middle of the
file. Moreover, drop "BIND_DEPENDENCIES += host-pkgconf zlib" as
host-pkgconf is already mandatory
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/bind/bind.mk | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/package/bind/bind.mk b/package/bind/bind.mk
index 5ddf7652eb..e0c81152e1 100644
--- a/package/bind/bind.mk
+++ b/package/bind/bind.mk
@@ -28,7 +28,8 @@ BIND_TARGET_SERVER_SBIN += dnssec-keyfromlabel dnssec-signzone tsig-keygen
BIND_TARGET_TOOLS_BIN = dig host nslookup nsupdate
BIND_CONF_ENV = \
BUILD_CC="$(TARGET_CC)" \
- BUILD_CFLAGS="$(TARGET_CFLAGS)"
+ BUILD_CFLAGS="$(TARGET_CFLAGS)" \
+ LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
BIND_CONF_OPTS = \
$(if $(BR2_TOOLCHAIN_HAS_THREADS),--enable-threads,--disable-threads) \
--without-lmdb \
@@ -36,14 +37,17 @@ BIND_CONF_OPTS = \
--with-randomdev=/dev/urandom \
--enable-epoll \
--enable-filter-aaaa \
- --disable-backtrace
+ --disable-backtrace \
+ --with-openssl=$(STAGING_DIR)/usr \
+ --with-ecdsa=yes \
+ --with-eddsa=no \
+ --with-aes=yes
-BIND_DEPENDENCIES = libuv
+BIND_DEPENDENCIES = host-pkgconf libuv openssl
ifeq ($(BR2_PACKAGE_ZLIB),y)
BIND_CONF_OPTS += --with-zlib
BIND_DEPENDENCIES += zlib
-BIND_DEPENDENCIES += host-pkgconf zlib
else
BIND_CONF_OPTS += --without-zlib
endif
@@ -76,13 +80,6 @@ else
BIND_CONF_OPTS += --with-libxml2=no
endif
-BIND_DEPENDENCIES += host-pkgconf openssl
-BIND_CONF_OPTS += \
- --with-openssl=$(STAGING_DIR)/usr \
- --with-ecdsa=yes \
- --with-eddsa=no \
- --with-aes=yes
-BIND_CONF_ENV += LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
# GOST cipher support requires openssl extra engines
ifeq ($(BR2_PACKAGE_OPENSSL_ENGINES),y)
BIND_CONF_OPTS += --with-gost=yes
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build
2022-03-13 9:21 [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables Fabrice Fontaine
@ 2022-03-13 9:21 ` Fabrice Fontaine
2022-03-14 18:15 ` James Hilliard
2022-03-23 21:11 ` Peter Korsgaard
2022-03-21 21:17 ` [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables Arnout Vandecappelle
2022-03-23 21:10 ` Peter Korsgaard
2 siblings, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-03-13 9:21 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Fix the following build failure with libxml2 raised since bump to
version 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92:
configure: error: Specifying libxml2 installation path is not supported, adjust PKG_CONFIG_PATH instead
Fixes:
- http://autobuild.buildroot.org/results/648d29e4cfa6a40bb6e54793c044e9c834f03a1b
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/bind/bind.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/bind/bind.mk b/package/bind/bind.mk
index e0c81152e1..63cc948c73 100644
--- a/package/bind/bind.mk
+++ b/package/bind/bind.mk
@@ -74,7 +74,7 @@ BIND_CONF_OPTS += --with-gssapi=no
endif
ifeq ($(BR2_PACKAGE_LIBXML2),y)
-BIND_CONF_OPTS += --with-libxml2=$(STAGING_DIR)/usr
+BIND_CONF_OPTS += --with-libxml2
BIND_DEPENDENCIES += libxml2
else
BIND_CONF_OPTS += --with-libxml2=no
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build
2022-03-13 9:21 ` [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build Fabrice Fontaine
@ 2022-03-14 18:15 ` James Hilliard
2022-03-23 21:11 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: James Hilliard @ 2022-03-14 18:15 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
On Sun, Mar 13, 2022 at 3:23 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Fix the following build failure with libxml2 raised since bump to
> version 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92:
>
> configure: error: Specifying libxml2 installation path is not supported, adjust PKG_CONFIG_PATH instead
>
> Fixes:
> - http://autobuild.buildroot.org/results/648d29e4cfa6a40bb6e54793c044e9c834f03a1b
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/bind/bind.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/bind/bind.mk b/package/bind/bind.mk
> index e0c81152e1..63cc948c73 100644
> --- a/package/bind/bind.mk
> +++ b/package/bind/bind.mk
> @@ -74,7 +74,7 @@ BIND_CONF_OPTS += --with-gssapi=no
> endif
>
> ifeq ($(BR2_PACKAGE_LIBXML2),y)
> -BIND_CONF_OPTS += --with-libxml2=$(STAGING_DIR)/usr
> +BIND_CONF_OPTS += --with-libxml2
> BIND_DEPENDENCIES += libxml2
> else
> BIND_CONF_OPTS += --with-libxml2=no
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build
2022-03-13 9:21 ` [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build Fabrice Fontaine
2022-03-14 18:15 ` James Hilliard
@ 2022-03-23 21:11 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2022-03-23 21:11 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fix the following build failure with libxml2 raised since bump to
> version 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92:
> configure: error: Specifying libxml2 installation path is not
> supported, adjust PKG_CONFIG_PATH instead
> Fixes:
> - http://autobuild.buildroot.org/results/648d29e4cfa6a40bb6e54793c044e9c834f03a1b
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables
2022-03-13 9:21 [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables Fabrice Fontaine
2022-03-13 9:21 ` [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build Fabrice Fontaine
@ 2022-03-21 21:17 ` Arnout Vandecappelle
2022-03-23 21:10 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2022-03-21 21:17 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot
On 13/03/2022 10:21, Fabrice Fontaine wrote:
> openssl is mandatory since bump to version 9.16.26 in commit
> 8adeaec8afacbc680edebae91524f6144926ac92 so move openssl variables in
> the beginning of bind.mk instead of keeping them in the middle of the
> file. Moreover, drop "BIND_DEPENDENCIES += host-pkgconf zlib" as
> host-pkgconf is already mandatory
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied both to master, thanks.
Regards,
Arnout
> ---
> package/bind/bind.mk | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/package/bind/bind.mk b/package/bind/bind.mk
> index 5ddf7652eb..e0c81152e1 100644
> --- a/package/bind/bind.mk
> +++ b/package/bind/bind.mk
> @@ -28,7 +28,8 @@ BIND_TARGET_SERVER_SBIN += dnssec-keyfromlabel dnssec-signzone tsig-keygen
> BIND_TARGET_TOOLS_BIN = dig host nslookup nsupdate
> BIND_CONF_ENV = \
> BUILD_CC="$(TARGET_CC)" \
> - BUILD_CFLAGS="$(TARGET_CFLAGS)"
> + BUILD_CFLAGS="$(TARGET_CFLAGS)" \
> + LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
> BIND_CONF_OPTS = \
> $(if $(BR2_TOOLCHAIN_HAS_THREADS),--enable-threads,--disable-threads) \
> --without-lmdb \
> @@ -36,14 +37,17 @@ BIND_CONF_OPTS = \
> --with-randomdev=/dev/urandom \
> --enable-epoll \
> --enable-filter-aaaa \
> - --disable-backtrace
> + --disable-backtrace \
> + --with-openssl=$(STAGING_DIR)/usr \
> + --with-ecdsa=yes \
> + --with-eddsa=no \
> + --with-aes=yes
>
> -BIND_DEPENDENCIES = libuv
> +BIND_DEPENDENCIES = host-pkgconf libuv openssl
>
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> BIND_CONF_OPTS += --with-zlib
> BIND_DEPENDENCIES += zlib
> -BIND_DEPENDENCIES += host-pkgconf zlib
> else
> BIND_CONF_OPTS += --without-zlib
> endif
> @@ -76,13 +80,6 @@ else
> BIND_CONF_OPTS += --with-libxml2=no
> endif
>
> -BIND_DEPENDENCIES += host-pkgconf openssl
> -BIND_CONF_OPTS += \
> - --with-openssl=$(STAGING_DIR)/usr \
> - --with-ecdsa=yes \
> - --with-eddsa=no \
> - --with-aes=yes
> -BIND_CONF_ENV += LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
> # GOST cipher support requires openssl extra engines
> ifeq ($(BR2_PACKAGE_OPENSSL_ENGINES),y)
> BIND_CONF_OPTS += --with-gost=yes
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables
2022-03-13 9:21 [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables Fabrice Fontaine
2022-03-13 9:21 ` [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build Fabrice Fontaine
2022-03-21 21:17 ` [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables Arnout Vandecappelle
@ 2022-03-23 21:10 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2022-03-23 21:10 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> openssl is mandatory since bump to version 9.16.26 in commit
> 8adeaec8afacbc680edebae91524f6144926ac92 so move openssl variables in
> the beginning of bind.mk instead of keeping them in the middle of the
> file. Moreover, drop "BIND_DEPENDENCIES += host-pkgconf zlib" as
> host-pkgconf is already mandatory
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-23 21:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-13 9:21 [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables Fabrice Fontaine
2022-03-13 9:21 ` [Buildroot] [PATCH 2/2] package/bind: fix libxml2 build Fabrice Fontaine
2022-03-14 18:15 ` James Hilliard
2022-03-23 21:11 ` Peter Korsgaard
2022-03-21 21:17 ` [Buildroot] [PATCH 1/2] package/bind: reorder openssl variables Arnout Vandecappelle
2022-03-23 21:10 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.