* [Buildroot] [PATCH 1/1] package/dav1d: don't override TARGET_LDFLAGS
@ 2021-12-14 21:28 Fabrice Fontaine
2021-12-16 18:19 ` Arnout Vandecappelle
2022-01-15 15:17 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-12-14 21:28 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Fabrice Fontaine
TARGET_LDFLAGS is overriden since the addition of the package in commit
8d66bc940d6e4707f9773aeb052e94d45fa439ad
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/dav1d/dav1d.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/dav1d/dav1d.mk b/package/dav1d/dav1d.mk
index 7a798bbd4f..d7224625c8 100644
--- a/package/dav1d/dav1d.mk
+++ b/package/dav1d/dav1d.mk
@@ -25,7 +25,7 @@ endif
# Uses __atomic_fetch_add_4
ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
-DAV1D_LDFLAGS += -latomic
+DAV1D_LDFLAGS += $(TARGET_LDFLAGS) -latomic
endif
$(eval $(meson-package))
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/dav1d: don't override TARGET_LDFLAGS
2021-12-14 21:28 [Buildroot] [PATCH 1/1] package/dav1d: don't override TARGET_LDFLAGS Fabrice Fontaine
@ 2021-12-16 18:19 ` Arnout Vandecappelle
2022-01-15 15:17 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2021-12-16 18:19 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Bernd Kuhls
On 14/12/2021 22:28, Fabrice Fontaine wrote:
> TARGET_LDFLAGS is overriden since the addition of the package in commit
> 8d66bc940d6e4707f9773aeb052e94d45fa439ad
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/dav1d/dav1d.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/dav1d/dav1d.mk b/package/dav1d/dav1d.mk
> index 7a798bbd4f..d7224625c8 100644
> --- a/package/dav1d/dav1d.mk
> +++ b/package/dav1d/dav1d.mk
> @@ -25,7 +25,7 @@ endif
>
> # Uses __atomic_fetch_add_4
> ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> -DAV1D_LDFLAGS += -latomic
> +DAV1D_LDFLAGS += $(TARGET_LDFLAGS) -latomic
I'm personally more inclined towareds:
FOO = ...
ifeq (...)
FOO += ...
endif
but that's bikeshedding, so OK.
Applied to master as is, thanks.
Regards,
Arnout
> endif
>
> $(eval $(meson-package))
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/dav1d: don't override TARGET_LDFLAGS
2021-12-14 21:28 [Buildroot] [PATCH 1/1] package/dav1d: don't override TARGET_LDFLAGS Fabrice Fontaine
2021-12-16 18:19 ` Arnout Vandecappelle
@ 2022-01-15 15:17 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-01-15 15:17 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> TARGET_LDFLAGS is overriden since the addition of the package in commit
> 8d66bc940d6e4707f9773aeb052e94d45fa439ad
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-15 15:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 21:28 [Buildroot] [PATCH 1/1] package/dav1d: don't override TARGET_LDFLAGS Fabrice Fontaine
2021-12-16 18:19 ` Arnout Vandecappelle
2022-01-15 15:17 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.