[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Thomas De Schampheleire]

From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

As xenomai release tarballs ship with a configure script, there is only a
need for autoreconfiguring when patches are applied.

The last patch was removed with git commit
de993bc23aab100e16026cb4cabebed48b9e1989 but the AUTORECONF line remained.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
 package/xenomai/xenomai.mk | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
index 6bf08edfbc..d88e969adb 100644
--- a/package/xenomai/xenomai.mk
+++ b/package/xenomai/xenomai.mk
@@ -24,8 +24,6 @@ XENOMAI_LICENSE_FILES = debian/copyright include/COPYING kernel/cobalt/COPYING \
 
 XENOMAI_DEPENDENCIES = host-pkgconf
 
-# 0002-boilerplate-build-obstack-support-conditionally.patch
-XENOMAI_AUTORECONF = YES
 
 XENOMAI_INSTALL_STAGING = YES
 XENOMAI_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-user
-- 
2.18.1

[Buildroot] [PATCH 2/2] DEVELOPERS: add Thomas De Schampheleire for xenomai

[Thomas De Schampheleire]

From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
 DEVELOPERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/DEVELOPERS b/DEVELOPERS
index e561739fab..3b3923ae4f 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2076,6 +2076,7 @@ F:	package/perl-net-snmp/
 F:	package/perl-net-ssh2/
 F:	package/perl-net-telnet/
 F:	package/pigz/
+F:	package/xenomai/
 F:	support/scripts/size-stats
 F:	utils/size-stats-compare
 F:	toolchain/
-- 
2.18.1

[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > As xenomai release tarballs ship with a configure script, there is only a
 > need for autoreconfiguring when patches are applied.

 > The last patch was removed with git commit
 > de993bc23aab100e16026cb4cabebed48b9e1989 but the AUTORECONF line remained.

 > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/2] DEVELOPERS: add Thomas De Schampheleire for xenomai

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Yann E. MORIN]

Thomas DS, All,

On 2019-01-08 21:38 +0100, Thomas De Schampheleire spake thusly:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> 
> As xenomai release tarballs ship with a configure script, there is only a
> need for autoreconfiguring when patches are applied.
> 
> The last patch was removed with git commit
> de993bc23aab100e16026cb4cabebed48b9e1989 but the AUTORECONF line remained.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
>  package/xenomai/xenomai.mk | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
> index 6bf08edfbc..d88e969adb 100644
> --- a/package/xenomai/xenomai.mk
> +++ b/package/xenomai/xenomai.mk
> @@ -24,8 +24,6 @@ XENOMAI_LICENSE_FILES = debian/copyright include/COPYING kernel/cobalt/COPYING \
>  
>  XENOMAI_DEPENDENCIES = host-pkgconf
>  
> -# 0002-boilerplate-build-obstack-support-conditionally.patch
> -XENOMAI_AUTORECONF = YES
>  

This is causing failures in the CI:

    https://gitlab.com/buildroot.org/buildroot/pipelines/42622285

because there are now two consecutive empty lines.

Regards,
Yann E. MORIN.

>  XENOMAI_INSTALL_STAGING = YES
>  XENOMAI_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-user
> -- 
> 2.18.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

Hi,

 >> -# 0002-boilerplate-build-obstack-support-conditionally.patch
 >> -XENOMAI_AUTORECONF = YES
 >> 

 > This is causing failures in the CI:

 >     https://gitlab.com/buildroot.org/buildroot/pipelines/42622285

 > because there are now two consecutive empty lines.

Fixed, thanks. Odd that my check-package post-commit hook didn't catch
it.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Thomas De Schampheleire]

El jue., 10 ene. 2019 a las 8:36, Peter Korsgaard
(<peter@korsgaard.com>) escribi?:
>
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> Hi,
>
>  >> -# 0002-boilerplate-build-obstack-support-conditionally.patch
>  >> -XENOMAI_AUTORECONF = YES
>  >>
>
>  > This is causing failures in the CI:
>
>  >     https://gitlab.com/buildroot.org/buildroot/pipelines/42622285
>
>  > because there are now two consecutive empty lines.
>
> Fixed, thanks. Odd that my check-package post-commit hook didn't catch
> it.

Oops, sorry.
Could you show me how to enable this as hook, then I'll add it locally too.

Thanks,
Thomas

[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 >> Fixed, thanks. Odd that my check-package post-commit hook didn't catch
 >> it.

 > Oops, sorry.
 > Could you show me how to enable this as hook, then I'll add it locally too.

I have in .git/hooks/post-commit:

#!/bin/sh

# check-package on added/changed files
git show --no-renames HEAD | \
        lsdiff -s | \
        awk '{ if ($1 != "-") print substr($2, 3) }' | \
        xargs -r ./utils/check-package

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Thomas De Schampheleire]

El jue., 10 ene. 2019 a las 10:30, Peter Korsgaard
(<peter@korsgaard.com>) escribi?:
>
> >>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
>
>  >> Fixed, thanks. Odd that my check-package post-commit hook didn't catch
>  >> it.
>
>  > Oops, sorry.
>  > Could you show me how to enable this as hook, then I'll add it locally too.
>
> I have in .git/hooks/post-commit:
>
> #!/bin/sh
>
> # check-package on added/changed files
> git show --no-renames HEAD | \
>         lsdiff -s | \
>         awk '{ if ($1 != "-") print substr($2, 3) }' | \
>         xargs -r ./utils/check-package


Thanks!

[Buildroot] [PATCH 1/2] xenomai: remove unnecessary autoreconf

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > As xenomai release tarballs ship with a configure script, there is only a
 > need for autoreconfiguring when patches are applied.

 > The last patch was removed with git commit
 > de993bc23aab100e16026cb4cabebed48b9e1989 but the AUTORECONF line remained.

 > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Committed to 2018.02.x and 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard