* [PATCH] mac80211-next: remove set but not used variable 'w_priv'
@ 2018-12-20 2:51 ` YueHaibing
0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-12-20 2:51 UTC (permalink / raw)
To: Kalle Valo; +Cc: YueHaibing, linux-wireless, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
drivers/net/wireless/virt_wifi.c:432:31: warning:
variable 'w_priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/virt_wifi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index 64b2186..ea10f58 100644
--- a/drivers/net/wireless/virt_wifi.c
+++ b/drivers/net/wireless/virt_wifi.c
@@ -429,13 +429,11 @@ static int virt_wifi_net_device_open(struct net_device *dev)
static int virt_wifi_net_device_stop(struct net_device *dev)
{
struct virt_wifi_netdev_priv *n_priv = netdev_priv(dev);
- struct virt_wifi_wiphy_priv *w_priv;
n_priv->is_up = false;
if (!dev->ieee80211_ptr)
return 0;
- w_priv = wiphy_priv(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_scan(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_connect(dev);
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] mac80211-next: remove set but not used variable 'w_priv'
@ 2018-12-20 2:51 ` YueHaibing
0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-12-20 2:51 UTC (permalink / raw)
To: Kalle Valo; +Cc: YueHaibing, linux-wireless, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
drivers/net/wireless/virt_wifi.c:432:31: warning:
variable 'w_priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/virt_wifi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index 64b2186..ea10f58 100644
--- a/drivers/net/wireless/virt_wifi.c
+++ b/drivers/net/wireless/virt_wifi.c
@@ -429,13 +429,11 @@ static int virt_wifi_net_device_open(struct net_device *dev)
static int virt_wifi_net_device_stop(struct net_device *dev)
{
struct virt_wifi_netdev_priv *n_priv = netdev_priv(dev);
- struct virt_wifi_wiphy_priv *w_priv;
n_priv->is_up = false;
if (!dev->ieee80211_ptr)
return 0;
- w_priv = wiphy_priv(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_scan(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_connect(dev);
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] mac80211-next: remove set but not used variable 'w_priv'
@ 2018-12-20 2:51 ` YueHaibing
0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-12-20 2:51 UTC (permalink / raw)
To: Kalle Valo
Cc: YueHaibing, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
drivers/net/wireless/virt_wifi.c:432:31: warning:
variable 'w_priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
drivers/net/wireless/virt_wifi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index 64b2186..ea10f58 100644
--- a/drivers/net/wireless/virt_wifi.c
+++ b/drivers/net/wireless/virt_wifi.c
@@ -429,13 +429,11 @@ static int virt_wifi_net_device_open(struct net_device *dev)
static int virt_wifi_net_device_stop(struct net_device *dev)
{
struct virt_wifi_netdev_priv *n_priv = netdev_priv(dev);
- struct virt_wifi_wiphy_priv *w_priv;
n_priv->is_up = false;
if (!dev->ieee80211_ptr)
return 0;
- w_priv = wiphy_priv(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_scan(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_connect(dev);
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] mac80211-next: remove set but not used variable 'w_priv'
2018-12-20 2:51 ` YueHaibing
@ 2019-01-16 12:24 ` YueHaibing
-1 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2019-01-16 12:24 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, netdev, kernel-janitors
ping...
On 2018/12/20 10:51, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
> drivers/net/wireless/virt_wifi.c:432:31: warning:
> variable 'w_priv' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/virt_wifi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
> index 64b2186..ea10f58 100644
> --- a/drivers/net/wireless/virt_wifi.c
> +++ b/drivers/net/wireless/virt_wifi.c
> @@ -429,13 +429,11 @@ static int virt_wifi_net_device_open(struct net_device *dev)
> static int virt_wifi_net_device_stop(struct net_device *dev)
> {
> struct virt_wifi_netdev_priv *n_priv = netdev_priv(dev);
> - struct virt_wifi_wiphy_priv *w_priv;
>
> n_priv->is_up = false;
>
> if (!dev->ieee80211_ptr)
> return 0;
> - w_priv = wiphy_priv(dev->ieee80211_ptr->wiphy);
>
> virt_wifi_cancel_scan(dev->ieee80211_ptr->wiphy);
> virt_wifi_cancel_connect(dev);
>
>
>
>
> .
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mac80211-next: remove set but not used variable 'w_priv'
@ 2019-01-16 12:24 ` YueHaibing
0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2019-01-16 12:24 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, netdev, kernel-janitors
ping...
On 2018/12/20 10:51, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
> drivers/net/wireless/virt_wifi.c:432:31: warning:
> variable 'w_priv' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/virt_wifi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
> index 64b2186..ea10f58 100644
> --- a/drivers/net/wireless/virt_wifi.c
> +++ b/drivers/net/wireless/virt_wifi.c
> @@ -429,13 +429,11 @@ static int virt_wifi_net_device_open(struct net_device *dev)
> static int virt_wifi_net_device_stop(struct net_device *dev)
> {
> struct virt_wifi_netdev_priv *n_priv = netdev_priv(dev);
> - struct virt_wifi_wiphy_priv *w_priv;
>
> n_priv->is_up = false;
>
> if (!dev->ieee80211_ptr)
> return 0;
> - w_priv = wiphy_priv(dev->ieee80211_ptr->wiphy);
>
> virt_wifi_cancel_scan(dev->ieee80211_ptr->wiphy);
> virt_wifi_cancel_connect(dev);
>
>
>
>
> .
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mac80211-next: remove set but not used variable 'w_priv'
2019-01-16 12:24 ` YueHaibing
@ 2019-01-16 16:09 ` Kalle Valo
-1 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2019-01-16 16:09 UTC (permalink / raw)
To: YueHaibing; +Cc: linux-wireless, netdev, kernel-janitors
YueHaibing <yuehaibing@huawei.com> writes:
> ping...
>
> On 2018/12/20 10:51, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
>> drivers/net/wireless/virt_wifi.c:432:31: warning:
>> variable 'w_priv' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Same here, the prefix should be "virt_wifi:".
--
Kalle Valo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mac80211-next: remove set but not used variable 'w_priv'
@ 2019-01-16 16:09 ` Kalle Valo
0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2019-01-16 16:09 UTC (permalink / raw)
To: YueHaibing; +Cc: linux-wireless, netdev, kernel-janitors
YueHaibing <yuehaibing@huawei.com> writes:
> ping...
>
> On 2018/12/20 10:51, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
>> drivers/net/wireless/virt_wifi.c:432:31: warning:
>> variable 'w_priv' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Same here, the prefix should be "virt_wifi:".
--
Kalle Valo
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] virt_wifi: remove set but not used variable 'w_priv'
2018-12-20 2:51 ` YueHaibing
@ 2019-01-17 3:17 ` YueHaibing
-1 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2019-01-17 3:17 UTC (permalink / raw)
To: Kalle Valo; +Cc: YueHaibing, linux-wireless, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
drivers/net/wireless/virt_wifi.c:432:31: warning:
variable 'w_priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix prefix to 'virt_wifi:'
---
drivers/net/wireless/virt_wifi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index 64b2186..ea10f58 100644
--- a/drivers/net/wireless/virt_wifi.c
+++ b/drivers/net/wireless/virt_wifi.c
@@ -429,13 +429,11 @@ static int virt_wifi_net_device_open(struct net_device *dev)
static int virt_wifi_net_device_stop(struct net_device *dev)
{
struct virt_wifi_netdev_priv *n_priv = netdev_priv(dev);
- struct virt_wifi_wiphy_priv *w_priv;
n_priv->is_up = false;
if (!dev->ieee80211_ptr)
return 0;
- w_priv = wiphy_priv(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_scan(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_connect(dev);
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2] virt_wifi: remove set but not used variable 'w_priv'
@ 2019-01-17 3:17 ` YueHaibing
0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2019-01-17 3:17 UTC (permalink / raw)
To: Kalle Valo; +Cc: YueHaibing, linux-wireless, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
drivers/net/wireless/virt_wifi.c:432:31: warning:
variable 'w_priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix prefix to 'virt_wifi:'
---
drivers/net/wireless/virt_wifi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index 64b2186..ea10f58 100644
--- a/drivers/net/wireless/virt_wifi.c
+++ b/drivers/net/wireless/virt_wifi.c
@@ -429,13 +429,11 @@ static int virt_wifi_net_device_open(struct net_device *dev)
static int virt_wifi_net_device_stop(struct net_device *dev)
{
struct virt_wifi_netdev_priv *n_priv = netdev_priv(dev);
- struct virt_wifi_wiphy_priv *w_priv;
n_priv->is_up = false;
if (!dev->ieee80211_ptr)
return 0;
- w_priv = wiphy_priv(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_scan(dev->ieee80211_ptr->wiphy);
virt_wifi_cancel_connect(dev);
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-01-17 3:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20 2:51 [PATCH] mac80211-next: remove set but not used variable 'w_priv' YueHaibing
2018-12-20 2:51 ` YueHaibing
2018-12-20 2:51 ` YueHaibing
2019-01-16 12:24 ` YueHaibing
2019-01-16 12:24 ` YueHaibing
2019-01-16 16:09 ` Kalle Valo
2019-01-16 16:09 ` Kalle Valo
2019-01-17 3:17 ` [PATCH v2] virt_wifi: " YueHaibing
2019-01-17 3:17 ` YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.