* [Qemu-devel] [PATCH] vl: Print error when using incorrect backend for debugcon
@ 2018-10-11 17:12 Philippe Mathieu-Daudé
2018-10-11 21:48 ` Marc-André Lureau
2018-10-19 6:18 ` Markus Armbruster
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-11 17:12 UTC (permalink / raw)
To: Paolo Bonzini, Marc-André Lureau
Cc: Philippe Mathieu-Daudé, qemu-devel
When using an incorrect backend for the debugcon, QEMU exits silently
without any error indication, which is confusing.
Add a message that the character backend is invalid.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 4e25c78bff..61305b5891 100644
--- a/vl.c
+++ b/vl.c
@@ -2466,6 +2466,7 @@ static int debugcon_parse(const char *devname)
QemuOpts *opts;
if (!qemu_chr_new_mux_mon("debugcon", devname)) {
+ error_report("invalid character backend '%s'", devname);
exit(1);
}
opts = qemu_opts_create(qemu_find_opts("device"), "debugcon", 1, NULL);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Print error when using incorrect backend for debugcon
2018-10-11 17:12 [Qemu-devel] [PATCH] vl: Print error when using incorrect backend for debugcon Philippe Mathieu-Daudé
@ 2018-10-11 21:48 ` Marc-André Lureau
2018-10-19 5:18 ` Philippe Mathieu-Daudé
2018-10-19 6:18 ` Markus Armbruster
1 sibling, 1 reply; 4+ messages in thread
From: Marc-André Lureau @ 2018-10-11 21:48 UTC (permalink / raw)
To: philmd; +Cc: Bonzini, Paolo, qemu-devel
On Thu, Oct 11, 2018 at 9:13 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> When using an incorrect backend for the debugcon, QEMU exits silently
> without any error indication, which is confusing.
> Add a message that the character backend is invalid.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 4e25c78bff..61305b5891 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2466,6 +2466,7 @@ static int debugcon_parse(const char *devname)
> QemuOpts *opts;
>
> if (!qemu_chr_new_mux_mon("debugcon", devname)) {
> + error_report("invalid character backend '%s'", devname);
> exit(1);
> }
> opts = qemu_opts_create(qemu_find_opts("device"), "debugcon", 1, NULL);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Print error when using incorrect backend for debugcon
2018-10-11 21:48 ` Marc-André Lureau
@ 2018-10-19 5:18 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-19 5:18 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: Bonzini, Paolo, qemu-devel, qemu-trivial
Cc'ing qemu-trivial@
On 11/10/2018 23:48, Marc-André Lureau wrote:
> On Thu, Oct 11, 2018 at 9:13 PM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
>>
>> When using an incorrect backend for the debugcon, QEMU exits silently
>> without any error indication, which is confusing.
>> Add a message that the character backend is invalid.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>> ---
>> vl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 4e25c78bff..61305b5891 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -2466,6 +2466,7 @@ static int debugcon_parse(const char *devname)
>> QemuOpts *opts;
>>
>> if (!qemu_chr_new_mux_mon("debugcon", devname)) {
>> + error_report("invalid character backend '%s'", devname);
>> exit(1);
>> }
>> opts = qemu_opts_create(qemu_find_opts("device"), "debugcon", 1, NULL);
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Print error when using incorrect backend for debugcon
2018-10-11 17:12 [Qemu-devel] [PATCH] vl: Print error when using incorrect backend for debugcon Philippe Mathieu-Daudé
2018-10-11 21:48 ` Marc-André Lureau
@ 2018-10-19 6:18 ` Markus Armbruster
1 sibling, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2018-10-19 6:18 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Paolo Bonzini, Marc-André Lureau, qemu-devel
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> When using an incorrect backend for the debugcon, QEMU exits silently
> without any error indication, which is confusing.
> Add a message that the character backend is invalid.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Queued, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-19 6:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11 17:12 [Qemu-devel] [PATCH] vl: Print error when using incorrect backend for debugcon Philippe Mathieu-Daudé
2018-10-11 21:48 ` Marc-André Lureau
2018-10-19 5:18 ` Philippe Mathieu-Daudé
2018-10-19 6:18 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.