From: Eric Anholt <eric@anholt.net>
To: Rob Herring <robh+dt@kernel.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <f.fainelli@gmail.com>,
"moderated list\:ARM\/FREESCALE IMX \/ MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>,
"moderated list\:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.
Date: Tue, 17 Apr 2018 14:48:17 -0700 [thread overview]
Message-ID: <87r2ndijxa.fsf@anholt.net> (raw)
In-Reply-To: <CAL_JsqJxG1b2NO6CJTge=7PuYJgLfD9uzit_GiXbH8B79v+aZQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]
Rob Herring <robh+dt@kernel.org> writes:
> On Mon, Apr 16, 2018 at 5:52 PM, Eric Anholt <eric@anholt.net> wrote:
>> The GPU subsystem node was a workaround to have a central device to
>> bind V3D and display to. Following the lead of 246774d17fc0
>> ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove
>> the subsystem node usage and just create a platform device for the DRM
>> device to attach to if any of the subsystem devices are present.
>>
>> v2: Simplify the DT walking code.
>> v3: Always put the node.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>> .../bindings/display/brcm,bcm-vc4.txt | 7 -----
>> drivers/gpu/drm/vc4/vc4_drv.c | 28 +++++++++++++------
>> drivers/gpu/drm/vc4/vc4_hvs.c | 1 +
>> drivers/gpu/drm/vc4/vc4_v3d.c | 1 +
>> 4 files changed, 22 insertions(+), 15 deletions(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Unfortunately, on further testing, this ends up broken. My guess is
that our new platform device isn't on the same bus, so we don't get our
dma-ranges translation when we use drm->dev, and that breaks caching
behavior.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>, Ray Jui <rjui@broadcom.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
bcm-kernel-feedback-list@broadcom.com,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.
Date: Tue, 17 Apr 2018 14:48:17 -0700 [thread overview]
Message-ID: <87r2ndijxa.fsf@anholt.net> (raw)
In-Reply-To: <CAL_JsqJxG1b2NO6CJTge=7PuYJgLfD9uzit_GiXbH8B79v+aZQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1162 bytes --]
Rob Herring <robh+dt@kernel.org> writes:
> On Mon, Apr 16, 2018 at 5:52 PM, Eric Anholt <eric@anholt.net> wrote:
>> The GPU subsystem node was a workaround to have a central device to
>> bind V3D and display to. Following the lead of 246774d17fc0
>> ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove
>> the subsystem node usage and just create a platform device for the DRM
>> device to attach to if any of the subsystem devices are present.
>>
>> v2: Simplify the DT walking code.
>> v3: Always put the node.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>> .../bindings/display/brcm,bcm-vc4.txt | 7 -----
>> drivers/gpu/drm/vc4/vc4_drv.c | 28 +++++++++++++------
>> drivers/gpu/drm/vc4/vc4_hvs.c | 1 +
>> drivers/gpu/drm/vc4/vc4_v3d.c | 1 +
>> 4 files changed, 22 insertions(+), 15 deletions(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Unfortunately, on further testing, this ends up broken. My guess is
that our new platform device isn't on the same bus, so we don't get our
dma-ranges translation when we use drm->dev, and that breaks caching
behavior.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.
Date: Tue, 17 Apr 2018 14:48:17 -0700 [thread overview]
Message-ID: <87r2ndijxa.fsf@anholt.net> (raw)
In-Reply-To: <CAL_JsqJxG1b2NO6CJTge=7PuYJgLfD9uzit_GiXbH8B79v+aZQ@mail.gmail.com>
Rob Herring <robh+dt@kernel.org> writes:
> On Mon, Apr 16, 2018 at 5:52 PM, Eric Anholt <eric@anholt.net> wrote:
>> The GPU subsystem node was a workaround to have a central device to
>> bind V3D and display to. Following the lead of 246774d17fc0
>> ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove
>> the subsystem node usage and just create a platform device for the DRM
>> device to attach to if any of the subsystem devices are present.
>>
>> v2: Simplify the DT walking code.
>> v3: Always put the node.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>> .../bindings/display/brcm,bcm-vc4.txt | 7 -----
>> drivers/gpu/drm/vc4/vc4_drv.c | 28 +++++++++++++------
>> drivers/gpu/drm/vc4/vc4_hvs.c | 1 +
>> drivers/gpu/drm/vc4/vc4_v3d.c | 1 +
>> 4 files changed, 22 insertions(+), 15 deletions(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Unfortunately, on further testing, this ends up broken. My guess is
that our new platform device isn't on the same bus, so we don't get our
dma-ranges translation when we use drm->dev, and that breaks caching
behavior.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180417/496ebf3b/attachment-0001.sig>
next prev parent reply other threads:[~2018-04-17 21:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 23:00 [PATCH 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node Eric Anholt
2018-04-09 23:00 ` Eric Anholt
2018-04-09 23:00 ` Eric Anholt
2018-04-09 23:00 ` [PATCH 2/3] ARM: dts: bcm283x: Remove the vc4 GPU subsystem node Eric Anholt
2018-04-09 23:00 ` Eric Anholt
2018-04-09 23:00 ` Eric Anholt
2018-04-09 23:00 ` [PATCH 3/3] ARM: dts: cygnus: " Eric Anholt
2018-04-09 23:00 ` Eric Anholt
2018-04-09 23:00 ` Eric Anholt
2018-04-10 18:28 ` [PATCH 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node Stefan Wahren
2018-04-10 18:28 ` Stefan Wahren
2018-04-10 19:39 ` Eric Anholt
2018-04-10 19:39 ` Eric Anholt
2018-04-10 19:39 ` Eric Anholt
2018-04-13 17:56 ` Rob Herring
2018-04-13 17:56 ` Rob Herring
2018-04-13 17:56 ` Rob Herring
2018-04-16 17:25 ` [PATCH v2 " Eric Anholt
2018-04-16 17:25 ` Eric Anholt
2018-04-16 17:25 ` Eric Anholt
2018-04-16 20:33 ` Rob Herring
2018-04-16 20:33 ` Rob Herring
2018-04-16 20:33 ` Rob Herring
2018-04-16 22:52 ` [PATCH v3 " Eric Anholt
2018-04-16 22:52 ` Eric Anholt
2018-04-17 13:09 ` Rob Herring
2018-04-17 13:09 ` Rob Herring
2018-04-17 13:09 ` Rob Herring
2018-04-17 21:48 ` Eric Anholt [this message]
2018-04-17 21:48 ` Eric Anholt
2018-04-17 21:48 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2ndijxa.fsf@anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.fainelli@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.