From: Jani Nikula <jani.nikula@linux.intel.com> To: "Srivatsa\, Anusha" <anusha.srivatsa@intel.com>, Ian W MORRISON <ianwmorrison@gmail.com> Cc: "Vivi\, Rodrigo" <rodrigo.vivi@intel.com>, "Wajdeczko\, Michal" <Michal.Wajdeczko@intel.com>, Greg KH <gregkh@linuxfoundation.org>, "airlied\@linux.ie" <airlied@linux.ie>, "joonas.lahtinen\@linux.intel.com" <joonas.lahtinen@linux.intel.com>, "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>, "stable\@vger.kernel.org" <stable@vger.kernel.org>, "intel-gfx\@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "dri-devel\@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: RE: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake Date: Tue, 17 Apr 2018 12:02:52 +0300 [thread overview] Message-ID: <87r2nefbnn.fsf@intel.com> (raw) In-Reply-To: <83F5C7385F545743AD4FB2A62F75B073338FD128@ORSMSX108.amr.corp.intel.com> On Mon, 16 Apr 2018, "Srivatsa, Anusha" <anusha.srivatsa@intel.com> wrote: >>-----Original Message----- >>From: Jani Nikula [mailto:jani.nikula@linux.intel.com] >>Sent: Wednesday, April 11, 2018 5:27 AM >>To: Ian W MORRISON <ianwmorrison@gmail.com> >>Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Srivatsa, Anusha >><anusha.srivatsa@intel.com>; Wajdeczko, Michal >><Michal.Wajdeczko@intel.com>; Greg KH <gregkh@linuxfoundation.org>; >>airlied@linux.ie; joonas.lahtinen@linux.intel.com; linux-kernel@vger.kernel.org; >>stable@vger.kernel.org; intel-gfx@lists.freedesktop.org; dri- >>devel@lists.freedesktop.org >>Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for >>Geminilake >> >>On Wed, 11 Apr 2018, Ian W MORRISON <ianwmorrison@gmail.com> wrote: >>> <snip> >>> >>>> >>>> NAK on indiscriminate Cc: stable. There are zero guarantees that >>>> older kernels will work with whatever firmware you throw at them. >>>> >>> >>> I included 'Cc: stable' so the patch would get added to the v4.16 and >>> v4.15 kernels which I have tested with the patch. I found that earlier >>> kernels didn't support the 'linux-firmware' package required to get >>> wifi working on Intel's new Gemini Lake NUC. >> >>You realize that this patch should have nothing to do with wifi? >> >>Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific >>versions of stable it is appropriate for. > > Hi Jani, > > The stable kernel version is 4.12 and beyond. > It is appropriate to add the CC: stable in my opinion Who tested the firmware with v4.12 and later? We only have the CI results against *current* drm-tip. We don't even know about v4.16. I'm not going to ack and take responsibility for the stable backports unless someone actually comes forward with credible Tested-bys. BR, Jani. > > Anusha >>BR, >>Jani. >> >>> >>>> >>>> PS. How is this a "RESEND"? I haven't seen this before. >>>> >>> >>> It is a 'RESEND' for that very reason. I initially sent the patch to >>> the same people as a similar patch >>> (https://patchwork.kernel.org/patch/10143637/) however after realising >>> this omitted required addresses I added them and resent the patch. >>> >>> Best regards, >>> Ian >> >>-- >>Jani Nikula, Intel Open Source Technology Center -- Jani Nikula, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com> To: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>, Ian W MORRISON <ianwmorrison@gmail.com> Cc: "airlied@linux.ie" <airlied@linux.ie>, Greg KH <gregkh@linuxfoundation.org>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "stable@vger.kernel.org" <stable@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "Vivi, Rodrigo" <rodrigo.vivi@intel.com>, "Wajdeczko, Michal" <Michal.Wajdeczko@intel.com> Subject: RE: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake Date: Tue, 17 Apr 2018 12:02:52 +0300 [thread overview] Message-ID: <87r2nefbnn.fsf@intel.com> (raw) In-Reply-To: <83F5C7385F545743AD4FB2A62F75B073338FD128@ORSMSX108.amr.corp.intel.com> On Mon, 16 Apr 2018, "Srivatsa, Anusha" <anusha.srivatsa@intel.com> wrote: >>-----Original Message----- >>From: Jani Nikula [mailto:jani.nikula@linux.intel.com] >>Sent: Wednesday, April 11, 2018 5:27 AM >>To: Ian W MORRISON <ianwmorrison@gmail.com> >>Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Srivatsa, Anusha >><anusha.srivatsa@intel.com>; Wajdeczko, Michal >><Michal.Wajdeczko@intel.com>; Greg KH <gregkh@linuxfoundation.org>; >>airlied@linux.ie; joonas.lahtinen@linux.intel.com; linux-kernel@vger.kernel.org; >>stable@vger.kernel.org; intel-gfx@lists.freedesktop.org; dri- >>devel@lists.freedesktop.org >>Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for >>Geminilake >> >>On Wed, 11 Apr 2018, Ian W MORRISON <ianwmorrison@gmail.com> wrote: >>> <snip> >>> >>>> >>>> NAK on indiscriminate Cc: stable. There are zero guarantees that >>>> older kernels will work with whatever firmware you throw at them. >>>> >>> >>> I included 'Cc: stable' so the patch would get added to the v4.16 and >>> v4.15 kernels which I have tested with the patch. I found that earlier >>> kernels didn't support the 'linux-firmware' package required to get >>> wifi working on Intel's new Gemini Lake NUC. >> >>You realize that this patch should have nothing to do with wifi? >> >>Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific >>versions of stable it is appropriate for. > > Hi Jani, > > The stable kernel version is 4.12 and beyond. > It is appropriate to add the CC: stable in my opinion Who tested the firmware with v4.12 and later? We only have the CI results against *current* drm-tip. We don't even know about v4.16. I'm not going to ack and take responsibility for the stable backports unless someone actually comes forward with credible Tested-bys. BR, Jani. > > Anusha >>BR, >>Jani. >> >>> >>>> >>>> PS. How is this a "RESEND"? I haven't seen this before. >>>> >>> >>> It is a 'RESEND' for that very reason. I initially sent the patch to >>> the same people as a similar patch >>> (https://patchwork.kernel.org/patch/10143637/) however after realising >>> this omitted required addresses I added them and resent the patch. >>> >>> Best regards, >>> Ian >> >>-- >>Jani Nikula, Intel Open Source Technology Center -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-17 9:00 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-11 4:42 [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake ianwmorrison 2018-04-11 9:24 ` Jani Nikula 2018-04-11 9:24 ` Jani Nikula 2018-04-11 10:41 ` Ian W MORRISON 2018-04-11 10:41 ` Ian W MORRISON 2018-04-11 12:27 ` Jani Nikula 2018-04-11 13:04 ` Ian W MORRISON 2018-04-16 22:47 ` Srivatsa, Anusha 2018-04-17 9:02 ` Jani Nikula [this message] 2018-04-17 9:02 ` Jani Nikula 2018-04-17 14:14 ` Joonas Lahtinen 2018-04-20 5:47 ` Ian W MORRISON 2018-04-20 7:50 ` Jani Nikula 2018-04-20 7:50 ` Jani Nikula 2018-04-20 8:25 ` Ian W MORRISON 2018-04-20 8:25 ` Ian W MORRISON 2018-04-20 18:03 ` Rodrigo Vivi 2018-04-20 18:03 ` Rodrigo Vivi 2018-04-20 18:30 ` Srivatsa, Anusha 2018-04-20 18:30 ` Srivatsa, Anusha 2018-04-21 1:22 ` Botello Ortega, Luis 2018-04-21 1:22 ` Botello Ortega, Luis 2018-04-21 22:46 ` Ian W MORRISON 2018-04-21 22:46 ` Ian W MORRISON 2018-04-25 23:15 ` Ian W MORRISON 2018-04-25 23:15 ` Ian W MORRISON 2018-04-27 9:20 ` Jani Nikula 2018-04-27 9:20 ` Jani Nikula 2018-04-30 7:58 ` Joonas Lahtinen 2018-04-11 10:54 ` ✓ Fi.CI.BAT: success for series starting with [RESEND,1/1] " Patchwork 2018-04-11 12:37 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87r2nefbnn.fsf@intel.com \ --to=jani.nikula@linux.intel.com \ --cc=Michal.Wajdeczko@intel.com \ --cc=airlied@linux.ie \ --cc=anusha.srivatsa@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=ianwmorrison@gmail.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=joonas.lahtinen@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rodrigo.vivi@intel.com \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.