* [PATCH] ib_core: Init subsys if compiled to vmlinuz-core
@ 2017-11-27 13:39 Dmitry Monakhov
[not found] ` <20171127133905.8231-1-dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Monakhov @ 2017-11-27 13:39 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Dmitry Monakhov
Once infiniband was compiled as core component it's subsystem must be
enabled before device initialization. Otherwise this result NULL pointer
dereference during mlx4_core init, calltrace:
->device_add
if (dev->class) {
deref dev->class->p =>NULLPTR
#Config
CONFIG_NET_DEVLINK=y
CONFIG_MAY_USE_DEVLINK=y
CONFIG_MLX4_EN=y
Signed-off-by: Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
---
drivers/infiniband/core/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 84fc32a..5e1be49 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -1253,5 +1253,5 @@ static void __exit ib_core_cleanup(void)
MODULE_ALIAS_RDMA_NETLINK(RDMA_NL_LS, 4);
-module_init(ib_core_init);
+subsys_initcall(ib_core_init);
module_exit(ib_core_cleanup);
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ib_core: Init subsys if compiled to vmlinuz-core
[not found] ` <20171127133905.8231-1-dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
@ 2017-11-27 13:43 ` Leon Romanovsky
2017-11-29 9:07 ` Dmitry Monakhov
2017-12-02 0:02 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2017-11-27 13:43 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Mon, Nov 27, 2017 at 01:39:05PM +0000, Dmitry Monakhov wrote:
> Once infiniband was compiled as core component it's subsystem must be
> enabled before device initialization. Otherwise this result NULL pointer
> dereference during mlx4_core init, calltrace:
> ->device_add
> if (dev->class) {
> deref dev->class->p =>NULLPTR
>
> #Config
> CONFIG_NET_DEVLINK=y
> CONFIG_MAY_USE_DEVLINK=y
> CONFIG_MLX4_EN=y
>
> Signed-off-by: Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
> ---
> drivers/infiniband/core/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ib_core: Init subsys if compiled to vmlinuz-core
[not found] ` <20171127133905.8231-1-dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2017-11-27 13:43 ` Leon Romanovsky
@ 2017-11-29 9:07 ` Dmitry Monakhov
2017-12-02 0:02 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Monakhov @ 2017-11-29 9:07 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> writes:
It is appeared that CM and SRP are also initalized incorrectly.
Please Ignore this one, I'll send updated patch.
> Once infiniband was compiled as core component it's subsystem must be
> enabled before device initialization. Otherwise this result NULL pointer
> dereference during mlx4_core init, calltrace:
> ->device_add
> if (dev->class) {
> deref dev->class->p =>NULLPTR
>
> #Config
> CONFIG_NET_DEVLINK=y
> CONFIG_MAY_USE_DEVLINK=y
> CONFIG_MLX4_EN=y
>
> Signed-off-by: Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
> ---
> drivers/infiniband/core/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 84fc32a..5e1be49 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -1253,5 +1253,5 @@ static void __exit ib_core_cleanup(void)
>
> MODULE_ALIAS_RDMA_NETLINK(RDMA_NL_LS, 4);
>
> -module_init(ib_core_init);
> +subsys_initcall(ib_core_init);
> module_exit(ib_core_cleanup);
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ib_core: Init subsys if compiled to vmlinuz-core
[not found] ` <20171127133905.8231-1-dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2017-11-27 13:43 ` Leon Romanovsky
2017-11-29 9:07 ` Dmitry Monakhov
@ 2017-12-02 0:02 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2017-12-02 0:02 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Mon, Nov 27, 2017 at 01:39:05PM +0000, Dmitry Monakhov wrote:
> Once infiniband was compiled as core component it's subsystem must be
> enabled before device initialization. Otherwise this result NULL pointer
> dereference during mlx4_core init, calltrace:
> ->device_add
> if (dev->class) {
> deref dev->class->p =>NULLPTR
>
> #Config
> CONFIG_NET_DEVLINK=y
> CONFIG_MAY_USE_DEVLINK=y
> CONFIG_MLX4_EN=y
>
> Signed-off-by: Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
> Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> drivers/infiniband/core/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-02 0:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27 13:39 [PATCH] ib_core: Init subsys if compiled to vmlinuz-core Dmitry Monakhov
[not found] ` <20171127133905.8231-1-dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2017-11-27 13:43 ` Leon Romanovsky
2017-11-29 9:07 ` Dmitry Monakhov
2017-12-02 0:02 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.