From: Eric Anholt <eric@anholt.net>
To: Boris Brezillon <boris.brezillon@free-electrons.com>Boris
Brezillon <boris.brezillon@free-electrons.com>,
Sean Paul <seanpaul@chromium.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Mark Yao <mark.yao@rock-chips.com>,
Shawn Guo <shawnguo@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Eben Upton <eben@raspberrypi.org>, Ray Jui <rjui@broadcom.com>,
Stephen Warren <swarren@wwwdotorg.org>,
bcm-kernel-feedback-list@broadcom.com, Lee Jones <lee@kernel.org>,
"Hollingworth, Gordon" <gordon@raspberrypi.org>,
"Cobley, Dom" <dom@raspberrypi.org>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver
Date: Fri, 14 Apr 2017 11:20:52 -0700 [thread overview]
Message-ID: <87r30uyhob.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1491928765-13995-1-git-send-email-boris.brezillon@free-electrons.com>
[-- Attachment #1.1: Type: text/plain, Size: 764 bytes --]
Boris Brezillon <boris.brezillon@free-electrons.com> writes:
> The HDMI driver is currently enabling all clks and probe time and keep
> the power-domain connected to the HDMI encoder enabled.
How about "The HDMI driver is currently enabling all clocks at probe
time and keeps the power domain..."?
> Move all activation code to vc4_hdmi_encoder_enable() and make sure
> the clks and power domain are released when the HDMI encoder is not used
> by adding deactivation steps in vc4_hdmi_encoder_disable().
>
> Note that the sequencing imposed by the IP requires that we move
> vc4_hdmi_encoder_mode_set() code into vc4_hdmi_encoder_enable().
I'm quite happy to see _mode_set() gone.
I'm hoping to go through a bunch of mode switching testing with this
Monday.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-04-14 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 16:39 [PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver Boris Brezillon
2017-04-14 18:20 ` Eric Anholt [this message]
2017-04-14 19:31 ` Boris Brezillon
2017-04-18 21:34 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r30uyhob.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dom@raspberrypi.org \
--cc=eben@raspberrypi.org \
--cc=f.fainelli@gmail.com \
--cc=gordon@raspberrypi.org \
--cc=lee@kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.