From: NeilBrown <neilb@suse.com> To: Shaohua Li <shli@kernel.org>, Jens Axboe <axboe@fb.com>, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig <hch@infradead.org> Cc: Ming Lei <tom.leiming@gmail.com> Subject: Re: [PATCH v3 03/14] md: prepare for managing resync I/O pages in clean way Date: Fri, 24 Mar 2017 17:00:00 +1100 [thread overview] Message-ID: <87r31n8ba7.fsf@notabene.neil.brown.name> (raw) In-Reply-To: <20170316161235.27110-4-tom.leiming@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2326 bytes --] On Fri, Mar 17 2017, Ming Lei wrote: > Now resync I/O use bio's bec table to manage pages, > this way is very hacky, and may not work any more > once multipage bvec is introduced. > > So introduce helpers and new data structure for > managing resync I/O pages more cleanly. > > Signed-off-by: Ming Lei <tom.leiming@gmail.com> > --- > drivers/md/md.h | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) I don't think this should go in md.h Maybe create a "raid1-10.h" or similar if you really want to. NeilBrown > > diff --git a/drivers/md/md.h b/drivers/md/md.h > index 1d63239a1be4..20c48032493b 100644 > --- a/drivers/md/md.h > +++ b/drivers/md/md.h > @@ -720,4 +720,54 @@ static inline void mddev_check_writesame(struct mddev *mddev, struct bio *bio) > #define RESYNC_BLOCK_SIZE (64*1024) > #define RESYNC_PAGES ((RESYNC_BLOCK_SIZE + PAGE_SIZE-1) / PAGE_SIZE) > > +/* for managing resync I/O pages */ > +struct resync_pages { > + unsigned idx; /* for get/put page from the pool */ > + void *raid_bio; > + struct page *pages[RESYNC_PAGES]; > +}; > + > +static inline int resync_alloc_pages(struct resync_pages *rp, > + gfp_t gfp_flags) > +{ > + int i; > + > + for (i = 0; i < RESYNC_PAGES; i++) { > + rp->pages[i] = alloc_page(gfp_flags); > + if (!rp->pages[i]) > + goto out_free; > + } > + > + return 0; > + > + out_free: > + while (--i >= 0) > + put_page(rp->pages[i]); > + return -ENOMEM; > +} > + > +static inline void resync_free_pages(struct resync_pages *rp) > +{ > + int i; > + > + for (i = 0; i < RESYNC_PAGES; i++) > + put_page(rp->pages[i]); > +} > + > +static inline void resync_get_all_pages(struct resync_pages *rp) > +{ > + int i; > + > + for (i = 0; i < RESYNC_PAGES; i++) > + get_page(rp->pages[i]); > +} > + > +static inline struct page *resync_fetch_page(struct resync_pages *rp, > + unsigned idx) > +{ > + if (WARN_ON_ONCE(idx >= RESYNC_PAGES)) > + return NULL; > + return rp->pages[idx]; > +} > + > #endif /* _MD_MD_H */ > -- > 2.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-raid" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: NeilBrown <neilb@suse.com> To: Ming Lei <tom.leiming@gmail.com>, Shaohua Li <shli@kernel.org>, Jens Axboe <axboe@fb.com>, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig <hch@infradead.org> Cc: Ming Lei <tom.leiming@gmail.com> Subject: Re: [PATCH v3 03/14] md: prepare for managing resync I/O pages in clean way Date: Fri, 24 Mar 2017 17:00:00 +1100 [thread overview] Message-ID: <87r31n8ba7.fsf@notabene.neil.brown.name> (raw) In-Reply-To: <20170316161235.27110-4-tom.leiming@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2326 bytes --] On Fri, Mar 17 2017, Ming Lei wrote: > Now resync I/O use bio's bec table to manage pages, > this way is very hacky, and may not work any more > once multipage bvec is introduced. > > So introduce helpers and new data structure for > managing resync I/O pages more cleanly. > > Signed-off-by: Ming Lei <tom.leiming@gmail.com> > --- > drivers/md/md.h | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) I don't think this should go in md.h Maybe create a "raid1-10.h" or similar if you really want to. NeilBrown > > diff --git a/drivers/md/md.h b/drivers/md/md.h > index 1d63239a1be4..20c48032493b 100644 > --- a/drivers/md/md.h > +++ b/drivers/md/md.h > @@ -720,4 +720,54 @@ static inline void mddev_check_writesame(struct mddev *mddev, struct bio *bio) > #define RESYNC_BLOCK_SIZE (64*1024) > #define RESYNC_PAGES ((RESYNC_BLOCK_SIZE + PAGE_SIZE-1) / PAGE_SIZE) > > +/* for managing resync I/O pages */ > +struct resync_pages { > + unsigned idx; /* for get/put page from the pool */ > + void *raid_bio; > + struct page *pages[RESYNC_PAGES]; > +}; > + > +static inline int resync_alloc_pages(struct resync_pages *rp, > + gfp_t gfp_flags) > +{ > + int i; > + > + for (i = 0; i < RESYNC_PAGES; i++) { > + rp->pages[i] = alloc_page(gfp_flags); > + if (!rp->pages[i]) > + goto out_free; > + } > + > + return 0; > + > + out_free: > + while (--i >= 0) > + put_page(rp->pages[i]); > + return -ENOMEM; > +} > + > +static inline void resync_free_pages(struct resync_pages *rp) > +{ > + int i; > + > + for (i = 0; i < RESYNC_PAGES; i++) > + put_page(rp->pages[i]); > +} > + > +static inline void resync_get_all_pages(struct resync_pages *rp) > +{ > + int i; > + > + for (i = 0; i < RESYNC_PAGES; i++) > + get_page(rp->pages[i]); > +} > + > +static inline struct page *resync_fetch_page(struct resync_pages *rp, > + unsigned idx) > +{ > + if (WARN_ON_ONCE(idx >= RESYNC_PAGES)) > + return NULL; > + return rp->pages[idx]; > +} > + > #endif /* _MD_MD_H */ > -- > 2.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-raid" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-03-24 6:00 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-16 16:12 [PATCH v3 00/14] md: cleanup on direct access to bvec table Ming Lei 2017-03-16 16:12 ` [PATCH v3 01/14] md: raid1/raid10: don't handle failure of bio_add_page() Ming Lei 2017-03-27 9:14 ` Christoph Hellwig 2017-03-16 16:12 ` [PATCH v3 02/14] md: move two macros into md.h Ming Lei 2017-03-24 5:57 ` NeilBrown 2017-03-24 5:57 ` NeilBrown 2017-03-24 6:30 ` Ming Lei 2017-03-24 16:53 ` Shaohua Li 2017-03-27 9:15 ` Christoph Hellwig 2017-03-27 9:52 ` NeilBrown 2017-03-27 9:52 ` NeilBrown 2017-03-16 16:12 ` [PATCH v3 03/14] md: prepare for managing resync I/O pages in clean way Ming Lei 2017-03-24 6:00 ` NeilBrown [this message] 2017-03-24 6:00 ` NeilBrown 2017-03-16 16:12 ` [PATCH v3 04/14] md: raid1: simplify r1buf_pool_free() Ming Lei 2017-03-16 16:12 ` [PATCH v3 05/14] md: raid1: don't use bio's vec table to manage resync pages Ming Lei 2017-07-09 23:09 ` NeilBrown 2017-07-09 23:09 ` NeilBrown 2017-07-10 3:35 ` Ming Lei 2017-07-10 4:13 ` Ming Lei 2017-07-10 4:38 ` NeilBrown 2017-07-10 4:38 ` NeilBrown 2017-07-10 7:25 ` Ming Lei 2017-07-10 7:25 ` Ming Lei 2017-07-10 19:05 ` Shaohua Li 2017-07-10 22:54 ` Ming Lei 2017-07-10 23:14 ` NeilBrown 2017-07-10 23:14 ` NeilBrown 2017-07-12 1:40 ` Ming Lei 2017-07-12 16:30 ` Shaohua Li 2017-07-13 1:22 ` Ming Lei 2017-03-16 16:12 ` [PATCH v3 06/14] md: raid1: retrieve page from pre-allocated resync page array Ming Lei 2017-03-16 16:12 ` [PATCH v3 07/14] md: raid1: use bio helper in process_checks() Ming Lei 2017-03-16 16:12 ` [PATCH v3 08/14] block: introduce bio_copy_data_partial Ming Lei 2017-03-24 5:34 ` Shaohua Li 2017-03-24 5:34 ` Shaohua Li 2017-03-24 16:41 ` Jens Axboe 2017-03-24 16:41 ` Jens Axboe 2017-03-16 16:12 ` [PATCH v3 09/14] md: raid1: move 'offset' out of loop Ming Lei 2017-03-16 16:12 ` [PATCH v3 10/14] md: raid1: improve write behind Ming Lei 2017-03-16 16:12 ` [PATCH v3 11/14] md: raid10: refactor code of read reshape's .bi_end_io Ming Lei 2017-03-16 16:12 ` [PATCH v3 12/14] md: raid10: don't use bio's vec table to manage resync pages Ming Lei 2017-03-16 16:12 ` [PATCH v3 13/14] md: raid10: retrieve page from preallocated resync page array Ming Lei 2017-03-16 16:12 ` [PATCH v3 14/14] md: raid10: avoid direct access to bvec table in handle_reshape_read_error Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87r31n8ba7.fsf@notabene.neil.brown.name \ --to=neilb@suse.com \ --cc=axboe@fb.com \ --cc=hch@infradead.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-raid@vger.kernel.org \ --cc=shli@kernel.org \ --cc=tom.leiming@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.