All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fbdev <linux-fbdev@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mathieu Malaterre <malat@debian.org>
Subject: Re: [GIT PULL] fbdev fixes for 4.9
Date: Wed, 16 Nov 2016 17:15:40 +1100	[thread overview]
Message-ID: <87r36cx84z.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <c1cf7b43-0cf8-3f7e-5ad8-56c3c5589563@ti.com>

Tomi Valkeinen <tomi.valkeinen@ti.com> writes:

> [ Unknown signature status ]
> On 14/11/16 18:25, Linus Torvalds wrote:
>> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>>
>>> Please pull two fbdev fixes for 4.9.
>> 
>> No.
>> 
>> This has obviously never even been test-compiled. It introduces two
>> new annoying warnings.
>
> Sorry about that. I dropped the patch for now and here's a new pull request.
>
> I did test compile, and I would have noticed errors but I missed the warnings
> (I blame the flu...). I need to improve my testing methods, but I couldn't find
> a way to add -Werror to kernel builds.

You can turn it on per-directory, eg:

diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
index ee8c81405a7f..2ee96810d26d 100644
--- a/drivers/video/fbdev/Makefile
+++ b/drivers/video/fbdev/Makefile
@@ -4,6 +4,8 @@
 
 # Each configuration option enables a list of files.
 
+subdir-ccflags-y := -Werror
+
 obj-y				+= core/
 
 obj-$(CONFIG_FB_MACMODES)      += macmodes.o


cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fbdev <linux-fbdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mathieu Malaterre <malat@debian.org>
Subject: Re: [GIT PULL] fbdev fixes for 4.9
Date: Wed, 16 Nov 2016 06:15:40 +0000	[thread overview]
Message-ID: <87r36cx84z.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <c1cf7b43-0cf8-3f7e-5ad8-56c3c5589563@ti.com>

Tomi Valkeinen <tomi.valkeinen@ti.com> writes:

> [ Unknown signature status ]
> On 14/11/16 18:25, Linus Torvalds wrote:
>> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>>
>>> Please pull two fbdev fixes for 4.9.
>> 
>> No.
>> 
>> This has obviously never even been test-compiled. It introduces two
>> new annoying warnings.
>
> Sorry about that. I dropped the patch for now and here's a new pull request.
>
> I did test compile, and I would have noticed errors but I missed the warnings
> (I blame the flu...). I need to improve my testing methods, but I couldn't find
> a way to add -Werror to kernel builds.

You can turn it on per-directory, eg:

diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
index ee8c81405a7f..2ee96810d26d 100644
--- a/drivers/video/fbdev/Makefile
+++ b/drivers/video/fbdev/Makefile
@@ -4,6 +4,8 @@
 
 # Each configuration option enables a list of files.
 
+subdir-ccflags-y := -Werror
+
 obj-y				+= core/
 
 obj-$(CONFIG_FB_MACMODES)      += macmodes.o


cheers

  parent reply	other threads:[~2016-11-16  6:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 11:44 [GIT PULL] fbdev fixes for 4.9 Tomi Valkeinen
2016-11-14 11:44 ` Tomi Valkeinen
2016-11-14 16:25 ` Linus Torvalds
2016-11-14 16:25   ` Linus Torvalds
2016-11-15 11:40   ` Tomi Valkeinen
2016-11-15 11:40     ` Tomi Valkeinen
2016-11-15 16:30     ` Linus Torvalds
2016-11-15 16:30       ` Linus Torvalds
2016-11-16  6:15     ` Michael Ellerman [this message]
2016-11-16  6:15       ` Michael Ellerman
2016-11-14 20:01 ` Mathieu Malaterre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r36cx84z.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malat@debian.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.