All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: "edubezval@gmail.com" <edubezval@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"yoshihiro.shimoda.uh@renesas.com"
	<yoshihiro.shimoda.uh@renesas.com>,
	"cm-hiep@jinso.co.jp" <cm-hiep@jinso.co.jp>
Subject: Re: lm-senser can't detect thermal on thermal_zone
Date: Thu, 16 Jun 2016 00:23:12 +0000	[thread overview]
Message-ID: <87r3bykmxy.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <1465910658.9422.9.camel@intel.com>


Hi Zhang

Thank you for your feedback

> > > > > > *thermal_zone_device_register(xxxx)
> > > > > > {
> > > > > > 	...
> > > > > > 	if (!tz->tzp || !tz->tzp->no_hwmon) {
> > > > > > 		result = thermal_add_hwmon_sysfs(tz);
> > > > > > 		...
> > > > > > 	}
> > > > > > 	...
> > > > > > }
(snip)
> I don't know if there is a solid reason that we can not expose the
> hwmon interface. But just like the comment says, "/* No hwmon because
> there might be hwmon drivers registering */", given that of_thermal
> just parses THERMAL data of device tree, it is reasonable to me for
> exposing thermal interfaces only.

I see.
I will re-consider my driver, and will send patch.
Thanks

  reply	other threads:[~2016-06-16  0:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12  8:09 lm-senser can't detect thermal on thermal_zone Kuninori Morimoto
2016-05-12  8:09 ` Kuninori Morimoto
2016-05-13  0:44 ` Zhang, Rui
2016-05-13  0:44   ` Zhang, Rui
2016-05-13  2:04   ` Kuninori Morimoto
2016-05-13  2:04     ` Kuninori Morimoto
2016-05-30  6:28     ` Kuninori Morimoto
2016-05-30  6:28       ` Kuninori Morimoto
2016-06-09  3:07       ` Kuninori Morimoto
2016-06-09  3:07         ` Kuninori Morimoto
2016-06-14  6:32         ` Zhang Rui
2016-06-14  6:32           ` Zhang Rui
2016-06-14  7:03           ` Kuninori Morimoto
2016-06-14  7:03             ` Kuninori Morimoto
2016-06-14 13:24             ` Zhang Rui
2016-06-14 13:24               ` Zhang Rui
2016-06-16  0:23               ` Kuninori Morimoto [this message]
2016-06-16  0:23                 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3bykmxy.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=cm-hiep@jinso.co.jp \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.