All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/9] atm: solos-pci: use to_pci_dev()
@ 2015-12-27 10:45 Geliang Tang
  2015-12-27 10:45   ` Geliang Tang
                   ` (8 more replies)
  0 siblings, 9 replies; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:45 UTC (permalink / raw)
  To: Chas Williams; +Cc: Geliang Tang, linux-atm-general, netdev, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/atm/solos-pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 0c2b4ba0..6ac2b2b 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -525,7 +525,7 @@ struct geos_gpio_attr {
 static ssize_t geos_gpio_store(struct device *dev, struct device_attribute *attr,
 			       const char *buf, size_t count)
 {
-	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(dev);
 	struct geos_gpio_attr *gattr = container_of(attr, struct geos_gpio_attr, attr);
 	struct solos_card *card = pci_get_drvdata(pdev);
 	uint32_t data32;
@@ -551,7 +551,7 @@ static ssize_t geos_gpio_store(struct device *dev, struct device_attribute *attr
 static ssize_t geos_gpio_show(struct device *dev, struct device_attribute *attr,
 			      char *buf)
 {
-	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(dev);
 	struct geos_gpio_attr *gattr = container_of(attr, struct geos_gpio_attr, attr);
 	struct solos_card *card = pci_get_drvdata(pdev);
 	uint32_t data32;
@@ -565,7 +565,7 @@ static ssize_t geos_gpio_show(struct device *dev, struct device_attribute *attr,
 static ssize_t hardware_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)
 {
-	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(dev);
 	struct geos_gpio_attr *gattr = container_of(attr, struct geos_gpio_attr, attr);
 	struct solos_card *card = pci_get_drvdata(pdev);
 	uint32_t data32;
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 2/9] drm/gma500: use to_pci_dev()
  2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
@ 2015-12-27 10:45   ` Geliang Tang
  2015-12-27 10:45 ` [PATCH 3/9] i2c: designware: " Geliang Tang
                     ` (7 subsequent siblings)
  8 siblings, 0 replies; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:45 UTC (permalink / raw)
  To: Patrik Jakobsson, David Airlie; +Cc: Geliang Tang, dri-devel, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/gpu/drm/gma500/power.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c
index b6b135f..bea8578 100644
--- a/drivers/gpu/drm/gma500/power.c
+++ b/drivers/gpu/drm/gma500/power.c
@@ -187,7 +187,7 @@ static bool gma_resume_pci(struct pci_dev *pdev)
  */
 int gma_power_suspend(struct device *_dev)
 {
-	struct pci_dev *pdev = container_of(_dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(_dev);
 	struct drm_device *dev = pci_get_drvdata(pdev);
 	struct drm_psb_private *dev_priv = dev->dev_private;
 
@@ -214,7 +214,7 @@ int gma_power_suspend(struct device *_dev)
  */
 int gma_power_resume(struct device *_dev)
 {
-	struct pci_dev *pdev = container_of(_dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(_dev);
 	struct drm_device *dev = pci_get_drvdata(pdev);
 
 	mutex_lock(&power_mutex);
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 2/9] drm/gma500: use to_pci_dev()
@ 2015-12-27 10:45   ` Geliang Tang
  0 siblings, 0 replies; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:45 UTC (permalink / raw)
  To: Patrik Jakobsson, David Airlie; +Cc: Geliang Tang, linux-kernel, dri-devel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/gpu/drm/gma500/power.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c
index b6b135f..bea8578 100644
--- a/drivers/gpu/drm/gma500/power.c
+++ b/drivers/gpu/drm/gma500/power.c
@@ -187,7 +187,7 @@ static bool gma_resume_pci(struct pci_dev *pdev)
  */
 int gma_power_suspend(struct device *_dev)
 {
-	struct pci_dev *pdev = container_of(_dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(_dev);
 	struct drm_device *dev = pci_get_drvdata(pdev);
 	struct drm_psb_private *dev_priv = dev->dev_private;
 
@@ -214,7 +214,7 @@ int gma_power_suspend(struct device *_dev)
  */
 int gma_power_resume(struct device *_dev)
 {
-	struct pci_dev *pdev = container_of(_dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(_dev);
 	struct drm_device *dev = pci_get_drvdata(pdev);
 
 	mutex_lock(&power_mutex);
-- 
2.5.0


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 3/9] i2c: designware: use to_pci_dev()
  2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
  2015-12-27 10:45   ` Geliang Tang
@ 2015-12-27 10:45 ` Geliang Tang
  2015-12-27 12:40   ` Andy Shevchenko
  2016-01-03 18:54   ` Wolfram Sang
  2015-12-27 10:46 ` [PATCH 4/9] mmc: sdhci-pci: " Geliang Tang
                   ` (6 subsequent siblings)
  8 siblings, 2 replies; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:45 UTC (permalink / raw)
  To: Andy Shevchenko, Jarkko Nikula, Mika Westerberg, Wolfram Sang
  Cc: Geliang Tang, linux-i2c, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/i2c/busses/i2c-designware-pcidrv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index 1543d35d..7368be0 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -162,7 +162,7 @@ static struct dw_pci_controller dw_pci_controllers[] = {
 #ifdef CONFIG_PM
 static int i2c_dw_pci_suspend(struct device *dev)
 {
-	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(dev);
 
 	i2c_dw_disable(pci_get_drvdata(pdev));
 	return 0;
@@ -170,7 +170,7 @@ static int i2c_dw_pci_suspend(struct device *dev)
 
 static int i2c_dw_pci_resume(struct device *dev)
 {
-	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(dev);
 
 	return i2c_dw_init(pci_get_drvdata(pdev));
 }
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 4/9] mmc: sdhci-pci: use to_pci_dev()
  2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
  2015-12-27 10:45   ` Geliang Tang
  2015-12-27 10:45 ` [PATCH 3/9] i2c: designware: " Geliang Tang
@ 2015-12-27 10:46 ` Geliang Tang
  2015-12-28 13:29   ` Ulf Hansson
  2015-12-27 10:46   ` Geliang Tang
                   ` (5 subsequent siblings)
  8 siblings, 1 reply; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:46 UTC (permalink / raw)
  To: Ulf Hansson, Adrian Hunter, Peter Guo
  Cc: Geliang Tang, linux-mmc, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/mmc/host/sdhci-pci-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 08f4a9f..cc851b0 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -1464,7 +1464,7 @@ static int sdhci_pci_resume(struct device *dev)
 
 static int sdhci_pci_runtime_suspend(struct device *dev)
 {
-	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(dev);
 	struct sdhci_pci_chip *chip;
 	struct sdhci_pci_slot *slot;
 	int i, ret;
@@ -1500,7 +1500,7 @@ err_pci_runtime_suspend:
 
 static int sdhci_pci_runtime_resume(struct device *dev)
 {
-	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(dev);
 	struct sdhci_pci_chip *chip;
 	struct sdhci_pci_slot *slot;
 	int i, ret;
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 5/9] ipw2x00: sdhci-pci: use to_pci_dev()
@ 2015-12-27 10:46   ` Geliang Tang
  0 siblings, 0 replies; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:46 UTC (permalink / raw)
  To: Stanislav Yakovlev, Kalle Valo
  Cc: Geliang Tang, linux-wireless, netdev, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index 36818c7..121294f 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -3514,7 +3514,7 @@ static void ipw2100_msg_free(struct ipw2100_priv *priv)
 static ssize_t show_pci(struct device *d, struct device_attribute *attr,
 			char *buf)
 {
-	struct pci_dev *pci_dev = container_of(d, struct pci_dev, dev);
+	struct pci_dev *pci_dev = to_pci_dev(d);
 	char *out = buf;
 	int i, j;
 	u32 val;
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 5/9] ipw2x00: sdhci-pci: use to_pci_dev()
@ 2015-12-27 10:46   ` Geliang Tang
  0 siblings, 0 replies; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:46 UTC (permalink / raw)
  To: Stanislav Yakovlev, Kalle Valo
  Cc: Geliang Tang, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org>
---
 drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index 36818c7..121294f 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -3514,7 +3514,7 @@ static void ipw2100_msg_free(struct ipw2100_priv *priv)
 static ssize_t show_pci(struct device *d, struct device_attribute *attr,
 			char *buf)
 {
-	struct pci_dev *pci_dev = container_of(d, struct pci_dev, dev);
+	struct pci_dev *pci_dev = to_pci_dev(d);
 	char *out = buf;
 	int i, j;
 	u32 val;
-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 6/9] ssb: use to_pci_dev()
  2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
                   ` (3 preceding siblings ...)
  2015-12-27 10:46   ` Geliang Tang
@ 2015-12-27 10:46 ` Geliang Tang
  2015-12-27 10:46 ` [PATCH 7/9] serial: 8250_pci: " Geliang Tang
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:46 UTC (permalink / raw)
  To: Michael Buesch; +Cc: Geliang Tang, netdev, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/ssb/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 0f28c08..67428f4 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -1130,7 +1130,7 @@ static ssize_t ssb_pci_attr_sprom_show(struct device *pcidev,
 				       struct device_attribute *attr,
 				       char *buf)
 {
-	struct pci_dev *pdev = container_of(pcidev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(pcidev);
 	struct ssb_bus *bus;
 
 	bus = ssb_pci_dev_to_bus(pdev);
@@ -1144,7 +1144,7 @@ static ssize_t ssb_pci_attr_sprom_store(struct device *pcidev,
 					struct device_attribute *attr,
 					const char *buf, size_t count)
 {
-	struct pci_dev *pdev = container_of(pcidev, struct pci_dev, dev);
+	struct pci_dev *pdev = to_pci_dev(pcidev);
 	struct ssb_bus *bus;
 
 	bus = ssb_pci_dev_to_bus(pdev);
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 7/9] serial: 8250_pci: use to_pci_dev()
  2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
                   ` (4 preceding siblings ...)
  2015-12-27 10:46 ` [PATCH 6/9] ssb: " Geliang Tang
@ 2015-12-27 10:46 ` Geliang Tang
  2015-12-27 12:39   ` Andy Shevchenko
  2015-12-27 10:46 ` [PATCH 8/9] vme: vme_ca91cx42.c: " Geliang Tang
                   ` (2 subsequent siblings)
  8 siblings, 1 reply; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Andy Shevchenko
  Cc: Geliang Tang, linux-serial, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/tty/serial/8250/8250_pci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 4097f3f..afdd2c67 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -1538,8 +1538,7 @@ static int pci_fintek_rs485_config(struct uart_port *port,
 {
 	u8 setting;
 	u8 *index = (u8 *) port->private_data;
-	struct pci_dev *pci_dev = container_of(port->dev, struct pci_dev,
-						dev);
+	struct pci_dev *pci_dev = to_pci_dev(port->dev);
 
 	pci_read_config_byte(pci_dev, 0x40 + 8 * *index + 7, &setting);
 
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 8/9] vme: vme_ca91cx42.c: use to_pci_dev()
  2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
                   ` (5 preceding siblings ...)
  2015-12-27 10:46 ` [PATCH 7/9] serial: 8250_pci: " Geliang Tang
@ 2015-12-27 10:46 ` Geliang Tang
  2015-12-27 16:46   ` Martyn Welch
  2015-12-27 10:46 ` [PATCH 9/9] devres: " Geliang Tang
  2015-12-29 20:47 ` [PATCH 1/9] atm: solos-pci: " David Miller
  8 siblings, 1 reply; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:46 UTC (permalink / raw)
  To: Martyn Welch, Manohar Vanga, Greg Kroah-Hartman
  Cc: Geliang Tang, devel, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/vme/bridges/vme_ca91cx42.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c
index b79a74a..5fbeab3 100644
--- a/drivers/vme/bridges/vme_ca91cx42.c
+++ b/drivers/vme/bridges/vme_ca91cx42.c
@@ -202,7 +202,7 @@ static int ca91cx42_irq_init(struct vme_bridge *ca91cx42_bridge)
 	bridge = ca91cx42_bridge->driver_priv;
 
 	/* Need pdev */
-	pdev = container_of(ca91cx42_bridge->parent, struct pci_dev, dev);
+	pdev = to_pci_dev(ca91cx42_bridge->parent);
 
 	INIT_LIST_HEAD(&ca91cx42_bridge->vme_error_handlers);
 
@@ -293,8 +293,7 @@ static void ca91cx42_irq_set(struct vme_bridge *ca91cx42_bridge, int level,
 	iowrite32(tmp, bridge->base + LINT_EN);
 
 	if ((state == 0) && (sync != 0)) {
-		pdev = container_of(ca91cx42_bridge->parent, struct pci_dev,
-			dev);
+		pdev = to_pci_dev(ca91cx42_bridge->parent);
 
 		synchronize_irq(pdev->irq);
 	}
@@ -518,7 +517,7 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
 		dev_err(ca91cx42_bridge->parent, "Dev entry NULL\n");
 		return -EINVAL;
 	}
-	pdev = container_of(ca91cx42_bridge->parent, struct pci_dev, dev);
+	pdev = to_pci_dev(ca91cx42_bridge->parent);
 
 	existing_size = (unsigned long long)(image->bus_resource.end -
 		image->bus_resource.start);
@@ -1519,7 +1518,7 @@ static void *ca91cx42_alloc_consistent(struct device *parent, size_t size,
 	struct pci_dev *pdev;
 
 	/* Find pci_dev container of dev */
-	pdev = container_of(parent, struct pci_dev, dev);
+	pdev = to_pci_dev(parent);
 
 	return pci_alloc_consistent(pdev, size, dma);
 }
@@ -1530,7 +1529,7 @@ static void ca91cx42_free_consistent(struct device *parent, size_t size,
 	struct pci_dev *pdev;
 
 	/* Find pci_dev container of dev */
-	pdev = container_of(parent, struct pci_dev, dev);
+	pdev = to_pci_dev(parent);
 
 	pci_free_consistent(pdev, size, vaddr, dma);
 }
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 9/9] devres: use to_pci_dev()
  2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
                   ` (6 preceding siblings ...)
  2015-12-27 10:46 ` [PATCH 8/9] vme: vme_ca91cx42.c: " Geliang Tang
@ 2015-12-27 10:46 ` Geliang Tang
  2015-12-28 16:19   ` Tejun Heo
  2015-12-29 20:47 ` [PATCH 1/9] atm: solos-pci: " David Miller
  8 siblings, 1 reply; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 10:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Tejun Heo, Abhilash Kesavan
  Cc: Geliang Tang, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 lib/devres.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/devres.c b/lib/devres.c
index 8c85672..cb1464c 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -236,7 +236,7 @@ struct pcim_iomap_devres {
 
 static void pcim_iomap_release(struct device *gendev, void *res)
 {
-	struct pci_dev *dev = container_of(gendev, struct pci_dev, dev);
+	struct pci_dev *dev = to_pci_dev(gendev);
 	struct pcim_iomap_devres *this = res;
 	int i;
 
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 7/9] serial: 8250_pci: use to_pci_dev()
  2015-12-27 10:46 ` [PATCH 7/9] serial: 8250_pci: " Geliang Tang
@ 2015-12-27 12:39   ` Andy Shevchenko
  2015-12-27 14:29     ` [PATCH 7/9 v2] " Geliang Tang
  0 siblings, 1 reply; 23+ messages in thread
From: Andy Shevchenko @ 2015-12-27 12:39 UTC (permalink / raw)
  To: Geliang Tang
  Cc: Greg Kroah-Hartman, Jiri Slaby, Andy Shevchenko, linux-serial,
	linux-kernel

On Sun, Dec 27, 2015 at 12:46 PM, Geliang Tang <geliangtang@163.com> wrote:
> Use to_pci_dev() instead of open-coding it.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 4097f3f..afdd2c67 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -1538,8 +1538,7 @@ static int pci_fintek_rs485_config(struct uart_port *port,
>  {
>         u8 setting;
>         u8 *index = (u8 *) port->private_data;
> -       struct pci_dev *pci_dev = container_of(port->dev, struct pci_dev,
> -                                               dev);
> +       struct pci_dev *pci_dev = to_pci_dev(port->dev);

I would make it first line in this block.
Otherwise,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

>
>         pci_read_config_byte(pci_dev, 0x40 + 8 * *index + 7, &setting);
>


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/9] i2c: designware: use to_pci_dev()
  2015-12-27 10:45 ` [PATCH 3/9] i2c: designware: " Geliang Tang
@ 2015-12-27 12:40   ` Andy Shevchenko
  2016-01-03 18:54   ` Wolfram Sang
  1 sibling, 0 replies; 23+ messages in thread
From: Andy Shevchenko @ 2015-12-27 12:40 UTC (permalink / raw)
  To: Geliang Tang
  Cc: Andy Shevchenko, Jarkko Nikula, Mika Westerberg, Wolfram Sang,
	linux-i2c, linux-kernel

On Sun, Dec 27, 2015 at 12:45 PM, Geliang Tang <geliangtang@163.com> wrote:
> Use to_pci_dev() instead of open-coding it.
>

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  drivers/i2c/busses/i2c-designware-pcidrv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 1543d35d..7368be0 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -162,7 +162,7 @@ static struct dw_pci_controller dw_pci_controllers[] = {
>  #ifdef CONFIG_PM
>  static int i2c_dw_pci_suspend(struct device *dev)
>  {
> -       struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
> +       struct pci_dev *pdev = to_pci_dev(dev);
>
>         i2c_dw_disable(pci_get_drvdata(pdev));
>         return 0;
> @@ -170,7 +170,7 @@ static int i2c_dw_pci_suspend(struct device *dev)
>
>  static int i2c_dw_pci_resume(struct device *dev)
>  {
> -       struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
> +       struct pci_dev *pdev = to_pci_dev(dev);
>
>         return i2c_dw_init(pci_get_drvdata(pdev));
>  }
> --
> 2.5.0
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 7/9 v2] serial: 8250_pci: use to_pci_dev()
  2015-12-27 12:39   ` Andy Shevchenko
@ 2015-12-27 14:29     ` Geliang Tang
  0 siblings, 0 replies; 23+ messages in thread
From: Geliang Tang @ 2015-12-27 14:29 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Andy Shevchenko
  Cc: Geliang Tang, linux-serial, linux-kernel

Use to_pci_dev() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Changes in v2:
 - Made it first line in this block.
---
 drivers/tty/serial/8250/8250_pci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 4097f3f..75182c9 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -1536,10 +1536,9 @@ pci_brcm_trumanage_setup(struct serial_private *priv,
 static int pci_fintek_rs485_config(struct uart_port *port,
 			       struct serial_rs485 *rs485)
 {
+	struct pci_dev *pci_dev = to_pci_dev(port->dev);
 	u8 setting;
 	u8 *index = (u8 *) port->private_data;
-	struct pci_dev *pci_dev = container_of(port->dev, struct pci_dev,
-						dev);
 
 	pci_read_config_byte(pci_dev, 0x40 + 8 * *index + 7, &setting);
 
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 8/9] vme: vme_ca91cx42.c: use to_pci_dev()
  2015-12-27 10:46 ` [PATCH 8/9] vme: vme_ca91cx42.c: " Geliang Tang
@ 2015-12-27 16:46   ` Martyn Welch
  0 siblings, 0 replies; 23+ messages in thread
From: Martyn Welch @ 2015-12-27 16:46 UTC (permalink / raw)
  To: Geliang Tang, Manohar Vanga, Greg Kroah-Hartman; +Cc: devel, linux-kernel

On 27/12/15 10:46, Geliang Tang wrote:
> Use to_pci_dev() instead of open-coding it.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Acked-by: Martyn Welch <martyn@welchs.me.uk>

> ---
>   drivers/vme/bridges/vme_ca91cx42.c | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c
> index b79a74a..5fbeab3 100644
> --- a/drivers/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/vme/bridges/vme_ca91cx42.c
> @@ -202,7 +202,7 @@ static int ca91cx42_irq_init(struct vme_bridge *ca91cx42_bridge)
>   	bridge = ca91cx42_bridge->driver_priv;
>   
>   	/* Need pdev */
> -	pdev = container_of(ca91cx42_bridge->parent, struct pci_dev, dev);
> +	pdev = to_pci_dev(ca91cx42_bridge->parent);
>   
>   	INIT_LIST_HEAD(&ca91cx42_bridge->vme_error_handlers);
>   
> @@ -293,8 +293,7 @@ static void ca91cx42_irq_set(struct vme_bridge *ca91cx42_bridge, int level,
>   	iowrite32(tmp, bridge->base + LINT_EN);
>   
>   	if ((state == 0) && (sync != 0)) {
> -		pdev = container_of(ca91cx42_bridge->parent, struct pci_dev,
> -			dev);
> +		pdev = to_pci_dev(ca91cx42_bridge->parent);
>   
>   		synchronize_irq(pdev->irq);
>   	}
> @@ -518,7 +517,7 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
>   		dev_err(ca91cx42_bridge->parent, "Dev entry NULL\n");
>   		return -EINVAL;
>   	}
> -	pdev = container_of(ca91cx42_bridge->parent, struct pci_dev, dev);
> +	pdev = to_pci_dev(ca91cx42_bridge->parent);
>   
>   	existing_size = (unsigned long long)(image->bus_resource.end -
>   		image->bus_resource.start);
> @@ -1519,7 +1518,7 @@ static void *ca91cx42_alloc_consistent(struct device *parent, size_t size,
>   	struct pci_dev *pdev;
>   
>   	/* Find pci_dev container of dev */
> -	pdev = container_of(parent, struct pci_dev, dev);
> +	pdev = to_pci_dev(parent);
>   
>   	return pci_alloc_consistent(pdev, size, dma);
>   }
> @@ -1530,7 +1529,7 @@ static void ca91cx42_free_consistent(struct device *parent, size_t size,
>   	struct pci_dev *pdev;
>   
>   	/* Find pci_dev container of dev */
> -	pdev = container_of(parent, struct pci_dev, dev);
> +	pdev = to_pci_dev(parent);
>   
>   	pci_free_consistent(pdev, size, vaddr, dma);
>   }


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 4/9] mmc: sdhci-pci: use to_pci_dev()
  2015-12-27 10:46 ` [PATCH 4/9] mmc: sdhci-pci: " Geliang Tang
@ 2015-12-28 13:29   ` Ulf Hansson
  0 siblings, 0 replies; 23+ messages in thread
From: Ulf Hansson @ 2015-12-28 13:29 UTC (permalink / raw)
  To: Geliang Tang; +Cc: Adrian Hunter, Peter Guo, linux-mmc, linux-kernel

On 27 December 2015 at 11:46, Geliang Tang <geliangtang@163.com> wrote:
> Use to_pci_dev() instead of open-coding it.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-pci-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 08f4a9f..cc851b0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1464,7 +1464,7 @@ static int sdhci_pci_resume(struct device *dev)
>
>  static int sdhci_pci_runtime_suspend(struct device *dev)
>  {
> -       struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
> +       struct pci_dev *pdev = to_pci_dev(dev);
>         struct sdhci_pci_chip *chip;
>         struct sdhci_pci_slot *slot;
>         int i, ret;
> @@ -1500,7 +1500,7 @@ err_pci_runtime_suspend:
>
>  static int sdhci_pci_runtime_resume(struct device *dev)
>  {
> -       struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
> +       struct pci_dev *pdev = to_pci_dev(dev);
>         struct sdhci_pci_chip *chip;
>         struct sdhci_pci_slot *slot;
>         int i, ret;
> --
> 2.5.0
>
>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 9/9] devres: use to_pci_dev()
  2015-12-27 10:46 ` [PATCH 9/9] devres: " Geliang Tang
@ 2015-12-28 16:19   ` Tejun Heo
  0 siblings, 0 replies; 23+ messages in thread
From: Tejun Heo @ 2015-12-28 16:19 UTC (permalink / raw)
  To: Geliang Tang; +Cc: Greg Kroah-Hartman, Abhilash Kesavan, linux-kernel

On Sun, Dec 27, 2015 at 06:46:05PM +0800, Geliang Tang wrote:
> Use to_pci_dev() instead of open-coding it.
> 
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 1/9] atm: solos-pci: use to_pci_dev()
  2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
                   ` (7 preceding siblings ...)
  2015-12-27 10:46 ` [PATCH 9/9] devres: " Geliang Tang
@ 2015-12-29 20:47 ` David Miller
  8 siblings, 0 replies; 23+ messages in thread
From: David Miller @ 2015-12-29 20:47 UTC (permalink / raw)
  To: geliangtang; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel

From: Geliang Tang <geliangtang@163.com>
Date: Sun, 27 Dec 2015 18:45:57 +0800

> Use to_pci_dev() instead of open-coding it.
> 
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Applied.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/9] ipw2x00: sdhci-pci: use to_pci_dev()
@ 2015-12-31  8:30     ` Kalle Valo
  0 siblings, 0 replies; 23+ messages in thread
From: Kalle Valo @ 2015-12-31  8:30 UTC (permalink / raw)
  To: Geliang Tang; +Cc: Stanislav Yakovlev, linux-wireless, netdev, linux-kernel

Geliang Tang <geliangtang@163.com> writes:

> Use to_pci_dev() instead of open-coding it.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>

The title is wrong, it should be just "ipw2x00: use to_pci_dev()".

And please state clearly to what tree you are planning to submit these.
I only saw this patch 5, not rest of the patches, so I have no clue
what's going to happen with this patchset. Please resend.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/9] ipw2x00: sdhci-pci: use to_pci_dev()
@ 2015-12-31  8:30     ` Kalle Valo
  0 siblings, 0 replies; 23+ messages in thread
From: Kalle Valo @ 2015-12-31  8:30 UTC (permalink / raw)
  To: Geliang Tang
  Cc: Stanislav Yakovlev, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org> writes:

> Use to_pci_dev() instead of open-coding it.
>
> Signed-off-by: Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org>

The title is wrong, it should be just "ipw2x00: use to_pci_dev()".

And please state clearly to what tree you are planning to submit these.
I only saw this patch 5, not rest of the patches, so I have no clue
what's going to happen with this patchset. Please resend.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/9] i2c: designware: use to_pci_dev()
  2015-12-27 10:45 ` [PATCH 3/9] i2c: designware: " Geliang Tang
  2015-12-27 12:40   ` Andy Shevchenko
@ 2016-01-03 18:54   ` Wolfram Sang
  1 sibling, 0 replies; 23+ messages in thread
From: Wolfram Sang @ 2016-01-03 18:54 UTC (permalink / raw)
  To: Geliang Tang
  Cc: Andy Shevchenko, Jarkko Nikula, Mika Westerberg, linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

On Sun, Dec 27, 2015 at 06:45:59PM +0800, Geliang Tang wrote:
> Use to_pci_dev() instead of open-coding it.
> 
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/9] drm/gma500: use to_pci_dev()
  2015-12-27 10:45   ` Geliang Tang
@ 2016-01-04  6:59     ` Daniel Vetter
  -1 siblings, 0 replies; 23+ messages in thread
From: Daniel Vetter @ 2016-01-04  6:59 UTC (permalink / raw)
  To: Geliang Tang; +Cc: Patrik Jakobsson, David Airlie, linux-kernel, dri-devel

On Sun, Dec 27, 2015 at 06:45:58PM +0800, Geliang Tang wrote:
> Use to_pci_dev() instead of open-coding it.
> 
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/gma500/power.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c
> index b6b135f..bea8578 100644
> --- a/drivers/gpu/drm/gma500/power.c
> +++ b/drivers/gpu/drm/gma500/power.c
> @@ -187,7 +187,7 @@ static bool gma_resume_pci(struct pci_dev *pdev)
>   */
>  int gma_power_suspend(struct device *_dev)
>  {
> -	struct pci_dev *pdev = container_of(_dev, struct pci_dev, dev);
> +	struct pci_dev *pdev = to_pci_dev(_dev);
>  	struct drm_device *dev = pci_get_drvdata(pdev);
>  	struct drm_psb_private *dev_priv = dev->dev_private;
>  
> @@ -214,7 +214,7 @@ int gma_power_suspend(struct device *_dev)
>   */
>  int gma_power_resume(struct device *_dev)
>  {
> -	struct pci_dev *pdev = container_of(_dev, struct pci_dev, dev);
> +	struct pci_dev *pdev = to_pci_dev(_dev);
>  	struct drm_device *dev = pci_get_drvdata(pdev);
>  
>  	mutex_lock(&power_mutex);
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/9] drm/gma500: use to_pci_dev()
@ 2016-01-04  6:59     ` Daniel Vetter
  0 siblings, 0 replies; 23+ messages in thread
From: Daniel Vetter @ 2016-01-04  6:59 UTC (permalink / raw)
  To: Geliang Tang; +Cc: dri-devel, linux-kernel

On Sun, Dec 27, 2015 at 06:45:58PM +0800, Geliang Tang wrote:
> Use to_pci_dev() instead of open-coding it.
> 
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/gma500/power.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c
> index b6b135f..bea8578 100644
> --- a/drivers/gpu/drm/gma500/power.c
> +++ b/drivers/gpu/drm/gma500/power.c
> @@ -187,7 +187,7 @@ static bool gma_resume_pci(struct pci_dev *pdev)
>   */
>  int gma_power_suspend(struct device *_dev)
>  {
> -	struct pci_dev *pdev = container_of(_dev, struct pci_dev, dev);
> +	struct pci_dev *pdev = to_pci_dev(_dev);
>  	struct drm_device *dev = pci_get_drvdata(pdev);
>  	struct drm_psb_private *dev_priv = dev->dev_private;
>  
> @@ -214,7 +214,7 @@ int gma_power_suspend(struct device *_dev)
>   */
>  int gma_power_resume(struct device *_dev)
>  {
> -	struct pci_dev *pdev = container_of(_dev, struct pci_dev, dev);
> +	struct pci_dev *pdev = to_pci_dev(_dev);
>  	struct drm_device *dev = pci_get_drvdata(pdev);
>  
>  	mutex_lock(&power_mutex);
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2016-01-04  6:59 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-27 10:45 [PATCH 1/9] atm: solos-pci: use to_pci_dev() Geliang Tang
2015-12-27 10:45 ` [PATCH 2/9] drm/gma500: " Geliang Tang
2015-12-27 10:45   ` Geliang Tang
2016-01-04  6:59   ` Daniel Vetter
2016-01-04  6:59     ` Daniel Vetter
2015-12-27 10:45 ` [PATCH 3/9] i2c: designware: " Geliang Tang
2015-12-27 12:40   ` Andy Shevchenko
2016-01-03 18:54   ` Wolfram Sang
2015-12-27 10:46 ` [PATCH 4/9] mmc: sdhci-pci: " Geliang Tang
2015-12-28 13:29   ` Ulf Hansson
2015-12-27 10:46 ` [PATCH 5/9] ipw2x00: " Geliang Tang
2015-12-27 10:46   ` Geliang Tang
2015-12-31  8:30   ` Kalle Valo
2015-12-31  8:30     ` Kalle Valo
2015-12-27 10:46 ` [PATCH 6/9] ssb: " Geliang Tang
2015-12-27 10:46 ` [PATCH 7/9] serial: 8250_pci: " Geliang Tang
2015-12-27 12:39   ` Andy Shevchenko
2015-12-27 14:29     ` [PATCH 7/9 v2] " Geliang Tang
2015-12-27 10:46 ` [PATCH 8/9] vme: vme_ca91cx42.c: " Geliang Tang
2015-12-27 16:46   ` Martyn Welch
2015-12-27 10:46 ` [PATCH 9/9] devres: " Geliang Tang
2015-12-28 16:19   ` Tejun Heo
2015-12-29 20:47 ` [PATCH 1/9] atm: solos-pci: " David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.