* [Buildroot] [PATCH] arch/arm: fix-up the ARM Kconfig warning
@ 2013-02-07 19:04 Yann E. MORIN
2013-02-07 19:43 ` Peter Korsgaard
2013-02-07 22:10 ` Arnout Vandecappelle
0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2013-02-07 19:04 UTC (permalink / raw)
To: buildroot
Kconfig does not accepts that a symbol that is part of a choice
be affected a default value.
Fix this by introducing a dummy EABI symbol., and nake the real
EABI symbol a prompt-less option that depends on !OABI.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Cc: Arnout Vandecappelle <arnout@mind.be>
---
arch/Config.in.arm | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index 37152c0..ecb45ab 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -76,7 +76,7 @@ choice
Note:
Using OABI is discouraged.
-config BR2_ARM_EABI
+config BR2_ARM_EABI_DUMMY
bool "EABI"
config BR2_ARM_OABI
bool "OABI"
@@ -84,8 +84,9 @@ config BR2_ARM_OABI
endchoice
config BR2_ARM_EABI
- default y
- depends on !BR2_DEPRECATED
+ def_bool y
+ depends on BR2_arm || BR2_armeb
+ depends on !BR2_ARM_OABI
config BR2_ARM_ENABLE_NEON
bool "Enable NEON SIMD extension support"
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] arch/arm: fix-up the ARM Kconfig warning
2013-02-07 19:04 [Buildroot] [PATCH] arch/arm: fix-up the ARM Kconfig warning Yann E. MORIN
@ 2013-02-07 19:43 ` Peter Korsgaard
2013-02-07 22:10 ` Arnout Vandecappelle
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-02-07 19:43 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
Yann> Kconfig does not accepts that a symbol that is part of a choice
Yann> be affected a default value.
Yann> Fix this by introducing a dummy EABI symbol., and nake the real
Yann> EABI symbol a prompt-less option that depends on !OABI.
Thanks, committed with small fixups (s/nake/make and below).
Yann> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Yann> Cc: Peter Korsgaard <jacmet@uclibc.org>
Yann> Cc: Arnout Vandecappelle <arnout@mind.be>
Yann> ---
Yann> arch/Config.in.arm | 7 ++++---
Yann> 1 files changed, 4 insertions(+), 3 deletions(-)
Yann> diff --git a/arch/Config.in.arm b/arch/Config.in.arm
Yann> index 37152c0..ecb45ab 100644
Yann> --- a/arch/Config.in.arm
Yann> +++ b/arch/Config.in.arm
Yann> @@ -76,7 +76,7 @@ choice
Yann> Note:
Yann> Using OABI is discouraged.
Yann> -config BR2_ARM_EABI
Yann> +config BR2_ARM_EABI_DUMMY
I renamed this to BR2_ARM_EABI_CHOICE
Yann> bool "EABI"
Yann> config BR2_ARM_OABI
Yann> bool "OABI"
Yann> @@ -84,8 +84,9 @@ config BR2_ARM_OABI
Yann> endchoice
Yann> config BR2_ARM_EABI
Yann> - default y
Yann> - depends on !BR2_DEPRECATED
Yann> + def_bool y
Yann> + depends on BR2_arm || BR2_armeb
The entire file is only sourced for arm || armeb, so this can be
dropped.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] arch/arm: fix-up the ARM Kconfig warning
2013-02-07 19:04 [Buildroot] [PATCH] arch/arm: fix-up the ARM Kconfig warning Yann E. MORIN
2013-02-07 19:43 ` Peter Korsgaard
@ 2013-02-07 22:10 ` Arnout Vandecappelle
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2013-02-07 22:10 UTC (permalink / raw)
To: buildroot
On 07/02/13 20:04, Yann E. MORIN wrote:
> Kconfig does not accepts that a symbol that is part of a choice
> be affected a default value.
Weird, I thought I tested this...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-07 22:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-07 19:04 [Buildroot] [PATCH] arch/arm: fix-up the ARM Kconfig warning Yann E. MORIN
2013-02-07 19:43 ` Peter Korsgaard
2013-02-07 22:10 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.