From: Kevin Hilman <khilman@ti.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: davinci-linux-open-source@linux.davincidsp.com, "Rajashekhara,
Sudhakar" <sudhakar.raj@ti.com>,
alsa-devel@alsa-project.org, dansharon@nanometrics.ca,
stable@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] davinci: da8xx/omap-l1xx: match codec_name with i2c ids
Date: Mon, 24 Jan 2011 15:09:21 -0800 [thread overview]
Message-ID: <87r5c15272.fsf@ti.com> (raw)
In-Reply-To: <8739oh6h5i.fsf@ti.com> (Kevin Hilman's message of "Mon, 24 Jan 2011 15:00:57 -0800")
Kevin Hilman <khilman@ti.com> writes:
> Liam Girdwood <lrg@slimlogic.co.uk> writes:
>
>> On Fri, 2011-01-21 at 19:54 +0530, Rajashekhara, Sudhakar wrote:
>>> The codec_name entry for da8xx evm in sound/soc/davinci/davinci-evm.c
>>> is not matching with the i2c ids in the board file. Without this fix the
>>> soundcard does not get detected on da850/omap-l138/am18x evm.
>>>
>>> Signed-off-by: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
>>> Tested-by: Dan Sharon <dansharon@nanometrics.ca>
>>> ---
>>> This patch applies to Linus's kernel tree.
>>>
>>> sound/soc/davinci/davinci-evm.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c
>>> index 0c2d6ba..b36f0b3 100644
>>> --- a/sound/soc/davinci/davinci-evm.c
>>> +++ b/sound/soc/davinci/davinci-evm.c
>>> @@ -223,7 +223,7 @@ static struct snd_soc_dai_link da8xx_evm_dai = {
>>> .stream_name = "AIC3X",
>>> .cpu_dai_name= "davinci-mcasp.0",
>>> .codec_dai_name = "tlv320aic3x-hifi",
>>> - .codec_name = "tlv320aic3x-codec.0-001a",
>>> + .codec_name = "tlv320aic3x-codec.1-0018",
>>> .platform_name = "davinci-pcm-audio",
>>> .init = evm_aic3x_init,
>>> .ops = &evm_ops,
>>
>> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>
> Liam,
>
> I'm assuming you'll merge this one via the ASoC tree?
>
On second thought, these should probably merge for .38-rc3.
If you're OK with it, I can merge this and the platform fix together for
.38-rc3.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] davinci: da8xx/omap-l1xx: match codec_name with i2c ids
Date: Mon, 24 Jan 2011 15:09:21 -0800 [thread overview]
Message-ID: <87r5c15272.fsf@ti.com> (raw)
In-Reply-To: <8739oh6h5i.fsf@ti.com> (Kevin Hilman's message of "Mon, 24 Jan 2011 15:00:57 -0800")
Kevin Hilman <khilman@ti.com> writes:
> Liam Girdwood <lrg@slimlogic.co.uk> writes:
>
>> On Fri, 2011-01-21 at 19:54 +0530, Rajashekhara, Sudhakar wrote:
>>> The codec_name entry for da8xx evm in sound/soc/davinci/davinci-evm.c
>>> is not matching with the i2c ids in the board file. Without this fix the
>>> soundcard does not get detected on da850/omap-l138/am18x evm.
>>>
>>> Signed-off-by: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
>>> Tested-by: Dan Sharon <dansharon@nanometrics.ca>
>>> ---
>>> This patch applies to Linus's kernel tree.
>>>
>>> sound/soc/davinci/davinci-evm.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c
>>> index 0c2d6ba..b36f0b3 100644
>>> --- a/sound/soc/davinci/davinci-evm.c
>>> +++ b/sound/soc/davinci/davinci-evm.c
>>> @@ -223,7 +223,7 @@ static struct snd_soc_dai_link da8xx_evm_dai = {
>>> .stream_name = "AIC3X",
>>> .cpu_dai_name= "davinci-mcasp.0",
>>> .codec_dai_name = "tlv320aic3x-hifi",
>>> - .codec_name = "tlv320aic3x-codec.0-001a",
>>> + .codec_name = "tlv320aic3x-codec.1-0018",
>>> .platform_name = "davinci-pcm-audio",
>>> .init = evm_aic3x_init,
>>> .ops = &evm_ops,
>>
>> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>
> Liam,
>
> I'm assuming you'll merge this one via the ASoC tree?
>
On second thought, these should probably merge for .38-rc3.
If you're OK with it, I can merge this and the platform fix together for
.38-rc3.
Kevin
next prev parent reply other threads:[~2011-01-24 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 14:24 [PATCH] davinci: da8xx/omap-l1xx: match codec_name with i2c ids Rajashekhara, Sudhakar
2011-01-21 14:24 ` Rajashekhara, Sudhakar
2011-01-21 14:38 ` Liam Girdwood
2011-01-21 14:38 ` Liam Girdwood
2011-01-24 23:00 ` Kevin Hilman
2011-01-24 23:00 ` Kevin Hilman
2011-01-24 23:09 ` Kevin Hilman [this message]
2011-01-24 23:09 ` Kevin Hilman
2011-01-25 10:59 ` Liam Girdwood
2011-01-25 10:59 ` [alsa-devel] " Liam Girdwood
2011-01-25 12:35 ` Mark Brown
2011-01-25 12:35 ` [alsa-devel] " Mark Brown
2011-01-25 18:36 ` Kevin Hilman
2011-01-25 18:36 ` [alsa-devel] " Kevin Hilman
[not found] <1295620801-6530-1-git-send-email-sudhakar.raj@ti.com>
2011-01-21 18:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5c15272.fsf@ti.com \
--to=khilman@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=dansharon@nanometrics.ca \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=stable@kernel.org \
--cc=sudhakar.raj@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.