[PATCH] ath9k_htc: Enable fastcc for HTC devices.

[PATCH] ath9k_htc: Enable fastcc for HTC devices.

[Rajkumar Manoharan]

By enabling fastcc, the scan time reduced to half.

Signed-off-by: Rajkumar Manoharan <rmanoharan@atheros.com>
---
 drivers/net/wireless/ath/ath9k/htc_drv_main.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index f467207..bab8948 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -137,8 +137,6 @@ static int ath9k_htc_set_channel(struct ath9k_htc_priv *priv,
 	if (priv->op_flags & OP_FULL_RESET)
 		fastcc = false;
 
-	/* Fiddle around with fastcc later on, for now just use full reset */
-	fastcc = false;
 	ath9k_htc_ps_wakeup(priv);
 	htc_stop(priv->htc);
 	WMI_CMD(WMI_DISABLE_INTR_CMDID);
@@ -146,9 +144,10 @@ static int ath9k_htc_set_channel(struct ath9k_htc_priv *priv,
 	WMI_CMD(WMI_STOP_RECV_CMDID);
 
 	ath_print(common, ATH_DBG_CONFIG,
-		  "(%u MHz) -> (%u MHz), HT: %d, HT40: %d\n",
+		  "(%u MHz) -> (%u MHz), HT: %d, HT40: %d fastcc: %d\n",
 		  priv->ah->curchan->channel,
-		  channel->center_freq, conf_is_ht(conf), conf_is_ht40(conf));
+		  channel->center_freq, conf_is_ht(conf), conf_is_ht40(conf),
+		  fastcc);
 
 	caldata = &priv->caldata[channel->hw_value];
 	ret = ath9k_hw_reset(ah, hchan, caldata, fastcc);
-- 
1.7.2.2

Re: [PATCH] ath9k_htc: Enable fastcc for HTC devices.

[Kalle Valo]

Rajkumar Manoharan <rmanoharan@atheros.com> writes:

> By enabling fastcc, the scan time reduced to half.

It helps the users if a patch like this describes what fastcc really
is and why it reduces the scan time. And what might be the side
effects. This is valuable information especially when someone is
debugging regressions. So please try to be as informative as possible,
especially when enabling new features.

For example, I have no idea what fastcc means. Fast C Compiler? ;)

-- 
Kalle Valo

RE: [PATCH] ath9k_htc: Enable fastcc for HTC devices.

[Rajkumar Manoharan]

Rajkumar Manoharan <rmanoharan@atheros.com> writes:
>
>> By enabling fastcc, the scan time reduced to half.
>
>It helps the users if a patch like this describes what fastcc really
>is and why it reduces the scan time. And what might be the side
>effects. This is valuable information especially when someone is
>debugging regressions. So please try to be as informative as possible,
>especially when enabling new features.
>
>For example, I have no idea what fastcc means. Fast C Compiler? ;)
>
>--
>Kalle Valo

On every channel set, the full hw reset happens which issue mutiple register writes.
For HTC devices, the host issue wmi commands. These register ops are time consumable one.
Instead of full hw reset, ath9k is doing partial reset which is fast channel change (fastcc).
By doing fast channel change, the scan period is considerably reduced. 

Thanks for your input Kalle. :)

Thanks,
Rajkumar

Re: [PATCH] ath9k_htc: Enable fastcc for HTC devices.

[Kalle Valo]

Rajkumar Manoharan <Rajkumar.Manoharan@Atheros.com> writes:

>>For example, I have no idea what fastcc means. Fast C Compiler? ;)
>
> On every channel set, the full hw reset happens which issue mutiple
> register writes. For HTC devices, the host issue wmi commands. These
> register ops are time consumable one. Instead of full hw reset,
> ath9k is doing partial reset which is fast channel change (fastcc).
> By doing fast channel change, the scan period is considerably
> reduced.

Now this is a good commit message. I can understand what the change is
actually about without browsing through ath9k source. Of course it
takes few minutes to write this but on the other hand you save a lot
of time from others. And possibly avoid answering to stupid questions
like the one I had :)

Thanks.

-- 
Kalle Valo