From: Michael Poole <mdpoole@troilus.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid-magicmouse: Coding style and probe failure fixes.
Date: Thu, 11 Feb 2010 18:10:25 -0500 [thread overview]
Message-ID: <87r5orcqse.fsf@troilus.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1002111124030.30967@pobox.suse.cz> (Jiri Kosina's message of "Thu, 11 Feb 2010 11:26:22 +0100 (CET)")
Jiri Kosina writes:
> On Thu, 11 Feb 2010, Michael Poole wrote:
>
>> I haven't had a chance to run-test these changes yet -- hid/for-next
>> causes corrupt X display on my laptop, whereas v2.6.33-rc6 and -rc7 are
>> fine;
>
> That's indeed quite strange. I'd be curious to see the result of the
> bisection, thanks a lot for doing this.
The problem was introduced by 859ddf0 and reverted in 6f14a66 (both only
touching lib/idr.c). You just happened to merge from master during an
unfortunate window :)
Cherry-picking the revert (6f14a66) on top of commit 093657 (details
shown below for reference) yields a working kernel with a working Magic
Mouse driver. I expect that merging the rest of master would also work.
commit 09365737da8b3af76abd9d811d435d3ce379903a
Merge: 1b97e37 71b38bd
Author: Jiri Kosina <jkosina@suse.cz>
Date: Thu Feb 11 11:22:52 2010 +0100
Merge branch 'apple_magic_mouse' into for-next
Michael Poole
next prev parent reply other threads:[~2010-02-11 23:10 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 14:20 [PATCH 0/3] HID: make raw output callback more flexible Jiri Kosina
2010-01-29 14:20 ` [PATCH 1/3] HID: make raw reports possible for both feature and output reports Jiri Kosina
2010-01-29 14:20 ` [PATCH 2/3] HID: Implement Wacom quirk in the kernel Jiri Kosina
2010-01-29 17:14 ` Ping Cheng
2010-02-03 14:50 ` Jiri Kosina
2010-01-29 14:21 ` [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth Jiri Kosina
2010-01-29 16:39 ` [PATCH 0/3] HID: make raw output callback more flexible Bastien Nocera
2010-01-30 0:46 ` Michael Poole
2010-01-30 0:46 ` Michael Poole
2010-01-30 14:11 ` Bastien Nocera
2010-01-31 3:27 ` Michael Poole
2010-01-31 3:27 ` Michael Poole
2010-02-03 1:25 ` Michael Poole
2010-02-03 1:25 ` Michael Poole
2010-02-03 9:47 ` Bastien Nocera
[not found] ` <alpine.LNX.2.00.1002031202040.15395@pobox.suse.cz>
2010-02-03 12:48 ` Jiri Kosina
2010-02-03 12:49 ` [PATCH 1/3] HID: make raw reports possible for both feature and output reports Jiri Kosina
2010-02-03 14:14 ` Marcel Holtmann
2010-02-03 14:37 ` Jiri Kosina
2010-02-03 12:49 ` [PATCH 2/3] HID: Implement Wacom quirk in the kernel Jiri Kosina
2010-02-03 14:19 ` Marcel Holtmann
2010-02-03 14:40 ` Jiri Kosina
2010-02-03 12:50 ` [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth Jiri Kosina
2010-02-03 14:17 ` Marcel Holtmann
2010-02-03 14:42 ` Jiri Kosina
2010-02-04 12:26 ` [PATCH] Bluetooth: Keep a copy of each HID device's report descriptor Michael Poole
2010-02-04 14:23 ` Marcel Holtmann
2010-02-05 17:23 ` Michael Poole
2010-02-05 17:23 ` Michael Poole
2010-02-05 17:51 ` Marcel Holtmann
2010-02-09 2:06 ` Ed Tomlinson
2010-02-09 7:22 ` Justin Mattock
2010-02-09 7:22 ` Justin Mattock
2010-02-09 10:14 ` Bastien Nocera
2010-02-09 10:14 ` Bastien Nocera
2010-02-09 12:36 ` Ed Tomlinson
2010-02-09 12:40 ` Jiri Kosina
2010-02-09 13:10 ` [PATCH 0/2] Provide a driver for the Apple Magic Mouse Michael Poole
2010-02-09 13:10 ` Michael Poole
2010-02-09 13:11 ` [PATCH 1/2] " Michael Poole
2010-02-09 13:11 ` Michael Poole
2010-02-09 13:11 ` Michael Poole
2010-02-09 13:13 ` [PATCH 2/2] Add a device " Michael Poole
2010-02-09 13:13 ` Michael Poole
2010-02-10 13:06 ` Jiri Kosina
2010-02-10 13:06 ` Jiri Kosina
2010-02-10 13:58 ` Jiri Kosina
2010-02-10 13:58 ` Jiri Kosina
2010-02-10 18:20 ` Dmitry Torokhov
2010-02-10 20:31 ` Michael Poole
2010-02-10 20:31 ` Michael Poole
2010-02-10 20:31 ` Michael Poole
2010-02-11 5:32 ` [PATCH] hid-magicmouse: Coding style and probe failure fixes Michael Poole
2010-02-11 5:32 ` Michael Poole
2010-02-11 6:55 ` Dmitry Torokhov
2010-02-11 6:55 ` Dmitry Torokhov
2010-02-11 10:26 ` Jiri Kosina
2010-02-11 23:10 ` Michael Poole [this message]
2010-02-11 3:05 ` [PATCH 2/2] Add a device driver for the Apple Magic Mouse Ed Tomlinson
2010-02-11 3:05 ` Ed Tomlinson
2010-02-11 3:20 ` Michael Poole
2010-02-11 3:20 ` Michael Poole
2010-02-11 3:20 ` Michael Poole
2010-02-11 12:51 ` [PATCH 2/2] Add a device driver for the Apple Magic Mouse (2.6.32.8) Ed Tomlinson
2010-02-09 21:37 ` [PATCH 0/2] Provide a driver for the Apple Magic Mouse Justin P. Mattock
2010-02-09 21:37 ` Justin P. Mattock
2010-02-10 13:57 ` Jiri Kosina
2010-02-10 13:57 ` Jiri Kosina
2010-02-13 19:29 ` [PATCH 0/2] Provide a driver for the Apple Magic Mouse - opps Ed Tomlinson
2010-02-14 8:03 ` Dmitry Torokhov
2010-02-14 14:22 ` Ed Tomlinson
2010-02-14 14:22 ` Ed Tomlinson
2010-02-15 7:11 ` Dmitry Torokhov
2010-02-15 12:42 ` Ed Tomlinson
2010-02-15 12:42 ` Ed Tomlinson
2010-02-15 12:44 ` Ed Tomlinson
2010-02-16 12:57 ` Jiri Kosina
2010-02-16 12:34 ` Ed Tomlinson
2010-02-16 12:55 ` Jiri Kosina
2010-02-14 22:24 ` [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse Ed Tomlinson
2010-02-14 22:24 ` Ed Tomlinson
2010-02-14 22:51 ` Michael Poole
2010-02-14 22:51 ` Michael Poole
2010-02-14 23:58 ` Ed Tomlinson
2010-02-14 23:58 ` Ed Tomlinson
2010-02-15 7:18 ` Dmitry Torokhov
2010-02-15 12:50 ` Ed Tomlinson
2010-02-15 12:50 ` Ed Tomlinson
2010-02-15 0:18 ` Ed Tomlinson
2010-02-09 15:03 ` [PATCH] Bluetooth: Keep a copy of each HID device's report descriptor Justin P. Mattock
2010-02-05 12:49 ` Bastien Nocera
2010-02-05 13:27 ` Marcel Holtmann
2010-01-30 14:13 ` [PATCH 0/3] HID: make raw output callback more flexible Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5orcqse.fsf@troilus.org \
--to=mdpoole@troilus.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.