From: Ed Tomlinson <edt@aei.ca> To: Michael Poole <mdpoole@troilus.org> Cc: Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse Date: Sun, 14 Feb 2010 18:58:26 -0500 [thread overview] Message-ID: <201002141858.26917.edt@aei.ca> (raw) In-Reply-To: <87zl3bbfdo.fsf@troilus.org> On Sunday 14 February 2010 17:51:15 Michael Poole wrote: > Ed Tomlinson writes: > > > Hi, > > > > Here is a patch that enables xy scrolling with the magic mouse. I have also > > changed the accelleration logic to work better with xy scrolling. > > Hi Ed, > > Your other patch to call input_unregister_device() looks good -- thanks! Thanks. One question about it though. Do we have to check if msc is null before the unregister? > I've never used a horizontal scroll wheel -- what are the common uses > for it? Why should the acceleration be separate for the two directions > rather than using the same factor? Why does the kernel need to emulate > this rather than having user-space implement the emulation? Its usefull for scrolling left and right while browsing. If you use kde it can be used to scroll between applications on the taskbar. Here most applications with a horizontial scrollbar work as expected. I first tried with a single acceleration value for both axies. It leads to confusing things happening. For example. I quickly scroll down, then nudge the window to the left. This works as expect with two values. With one the nudge is accelerated and moves too far. My personal goal is to have the basic, apple defined, gestures working from kernel space. This way the device works as expected without needing to fiddle with X or other managers (think wayland and/or chromeOS). > (If the answers to the last two questions justify putting this feature > in the kernel, my only suggestions on the patch are style-related: > scroll_accel{x,y} should probably be spelled scroll_accel_{x,y}, and > there are missing spaces around the / operator when calculating stepx > and stepy.) I'll fix up the style and resubmit. Thanks Ed
WARNING: multiple messages have this Message-ID (diff)
From: Ed Tomlinson <edt-Yad3+ZauZac@public.gmane.org> To: Michael Poole <mdpoole-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org> Cc: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse Date: Sun, 14 Feb 2010 18:58:26 -0500 [thread overview] Message-ID: <201002141858.26917.edt@aei.ca> (raw) In-Reply-To: <87zl3bbfdo.fsf-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org> On Sunday 14 February 2010 17:51:15 Michael Poole wrote: > Ed Tomlinson writes: > > > Hi, > > > > Here is a patch that enables xy scrolling with the magic mouse. I have also > > changed the accelleration logic to work better with xy scrolling. > > Hi Ed, > > Your other patch to call input_unregister_device() looks good -- thanks! Thanks. One question about it though. Do we have to check if msc is null before the unregister? > I've never used a horizontal scroll wheel -- what are the common uses > for it? Why should the acceleration be separate for the two directions > rather than using the same factor? Why does the kernel need to emulate > this rather than having user-space implement the emulation? Its usefull for scrolling left and right while browsing. If you use kde it can be used to scroll between applications on the taskbar. Here most applications with a horizontial scrollbar work as expected. I first tried with a single acceleration value for both axies. It leads to confusing things happening. For example. I quickly scroll down, then nudge the window to the left. This works as expect with two values. With one the nudge is accelerated and moves too far. My personal goal is to have the basic, apple defined, gestures working from kernel space. This way the device works as expected without needing to fiddle with X or other managers (think wayland and/or chromeOS). > (If the answers to the last two questions justify putting this feature > in the kernel, my only suggestions on the patch are style-related: > scroll_accel{x,y} should probably be spelled scroll_accel_{x,y}, and > there are missing spaces around the / operator when calculating stepx > and stepy.) I'll fix up the style and resubmit. Thanks Ed
next prev parent reply other threads:[~2010-02-15 0:01 UTC|newest] Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-29 14:20 [PATCH 0/3] HID: make raw output callback more flexible Jiri Kosina 2010-01-29 14:20 ` [PATCH 1/3] HID: make raw reports possible for both feature and output reports Jiri Kosina 2010-01-29 14:20 ` [PATCH 2/3] HID: Implement Wacom quirk in the kernel Jiri Kosina 2010-01-29 17:14 ` Ping Cheng 2010-02-03 14:50 ` Jiri Kosina 2010-01-29 14:21 ` [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth Jiri Kosina 2010-01-29 16:39 ` [PATCH 0/3] HID: make raw output callback more flexible Bastien Nocera 2010-01-30 0:46 ` Michael Poole 2010-01-30 0:46 ` Michael Poole 2010-01-30 14:11 ` Bastien Nocera 2010-01-31 3:27 ` Michael Poole 2010-01-31 3:27 ` Michael Poole 2010-02-03 1:25 ` Michael Poole 2010-02-03 1:25 ` Michael Poole 2010-02-03 9:47 ` Bastien Nocera [not found] ` <alpine.LNX.2.00.1002031202040.15395@pobox.suse.cz> 2010-02-03 12:48 ` Jiri Kosina 2010-02-03 12:49 ` [PATCH 1/3] HID: make raw reports possible for both feature and output reports Jiri Kosina 2010-02-03 14:14 ` Marcel Holtmann 2010-02-03 14:37 ` Jiri Kosina 2010-02-03 12:49 ` [PATCH 2/3] HID: Implement Wacom quirk in the kernel Jiri Kosina 2010-02-03 14:19 ` Marcel Holtmann 2010-02-03 14:40 ` Jiri Kosina 2010-02-03 12:50 ` [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth Jiri Kosina 2010-02-03 14:17 ` Marcel Holtmann 2010-02-03 14:42 ` Jiri Kosina 2010-02-04 12:26 ` [PATCH] Bluetooth: Keep a copy of each HID device's report descriptor Michael Poole 2010-02-04 14:23 ` Marcel Holtmann 2010-02-05 17:23 ` Michael Poole 2010-02-05 17:23 ` Michael Poole 2010-02-05 17:51 ` Marcel Holtmann 2010-02-09 2:06 ` Ed Tomlinson 2010-02-09 7:22 ` Justin Mattock 2010-02-09 7:22 ` Justin Mattock 2010-02-09 10:14 ` Bastien Nocera 2010-02-09 10:14 ` Bastien Nocera 2010-02-09 12:36 ` Ed Tomlinson 2010-02-09 12:40 ` Jiri Kosina 2010-02-09 13:10 ` [PATCH 0/2] Provide a driver for the Apple Magic Mouse Michael Poole 2010-02-09 13:10 ` Michael Poole 2010-02-09 13:11 ` [PATCH 1/2] " Michael Poole 2010-02-09 13:11 ` Michael Poole 2010-02-09 13:11 ` Michael Poole 2010-02-09 13:13 ` [PATCH 2/2] Add a device " Michael Poole 2010-02-09 13:13 ` Michael Poole 2010-02-10 13:06 ` Jiri Kosina 2010-02-10 13:06 ` Jiri Kosina 2010-02-10 13:58 ` Jiri Kosina 2010-02-10 13:58 ` Jiri Kosina 2010-02-10 18:20 ` Dmitry Torokhov 2010-02-10 20:31 ` Michael Poole 2010-02-10 20:31 ` Michael Poole 2010-02-10 20:31 ` Michael Poole 2010-02-11 5:32 ` [PATCH] hid-magicmouse: Coding style and probe failure fixes Michael Poole 2010-02-11 5:32 ` Michael Poole 2010-02-11 6:55 ` Dmitry Torokhov 2010-02-11 6:55 ` Dmitry Torokhov 2010-02-11 10:26 ` Jiri Kosina 2010-02-11 23:10 ` Michael Poole 2010-02-11 3:05 ` [PATCH 2/2] Add a device driver for the Apple Magic Mouse Ed Tomlinson 2010-02-11 3:05 ` Ed Tomlinson 2010-02-11 3:20 ` Michael Poole 2010-02-11 3:20 ` Michael Poole 2010-02-11 3:20 ` Michael Poole 2010-02-11 12:51 ` [PATCH 2/2] Add a device driver for the Apple Magic Mouse (2.6.32.8) Ed Tomlinson 2010-02-09 21:37 ` [PATCH 0/2] Provide a driver for the Apple Magic Mouse Justin P. Mattock 2010-02-09 21:37 ` Justin P. Mattock 2010-02-10 13:57 ` Jiri Kosina 2010-02-10 13:57 ` Jiri Kosina 2010-02-13 19:29 ` [PATCH 0/2] Provide a driver for the Apple Magic Mouse - opps Ed Tomlinson 2010-02-14 8:03 ` Dmitry Torokhov 2010-02-14 14:22 ` Ed Tomlinson 2010-02-14 14:22 ` Ed Tomlinson 2010-02-15 7:11 ` Dmitry Torokhov 2010-02-15 12:42 ` Ed Tomlinson 2010-02-15 12:42 ` Ed Tomlinson 2010-02-15 12:44 ` Ed Tomlinson 2010-02-16 12:57 ` Jiri Kosina 2010-02-16 12:34 ` Ed Tomlinson 2010-02-16 12:55 ` Jiri Kosina 2010-02-14 22:24 ` [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse Ed Tomlinson 2010-02-14 22:24 ` Ed Tomlinson 2010-02-14 22:51 ` Michael Poole 2010-02-14 22:51 ` Michael Poole 2010-02-14 23:58 ` Ed Tomlinson [this message] 2010-02-14 23:58 ` Ed Tomlinson 2010-02-15 7:18 ` Dmitry Torokhov 2010-02-15 12:50 ` Ed Tomlinson 2010-02-15 12:50 ` Ed Tomlinson 2010-02-15 0:18 ` Ed Tomlinson 2010-02-09 15:03 ` [PATCH] Bluetooth: Keep a copy of each HID device's report descriptor Justin P. Mattock 2010-02-05 12:49 ` Bastien Nocera 2010-02-05 13:27 ` Marcel Holtmann 2010-01-30 14:13 ` [PATCH 0/3] HID: make raw output callback more flexible Marcel Holtmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201002141858.26917.edt@aei.ca \ --to=edt@aei.ca \ --cc=jkosina@suse.cz \ --cc=linux-bluetooth@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marcel@holtmann.org \ --cc=mdpoole@troilus.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.