All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry
@ 2022-06-27 10:59 Arun R Murthy
  2022-06-28  2:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (11 more replies)
  0 siblings, 12 replies; 25+ messages in thread
From: Arun R Murthy @ 2022-06-27 10:59 UTC (permalink / raw)
  To: intel-gfx; +Cc: tprevite, paulo.r.zanoni

On linktraining error/timeout before retry need to wait for 400usec as
per the DP CTS spec1.2
The patch with commit id
74ebf294a1dd816bdc248ac733009a8915d59eb5
drm/i915: Add a delay in Displayport AUX transactions for
compliance testing
removes this delay mentioning the hardware already meets this
requirement, but as per the spec the delay mentioned in the spec
specifies how long to wait for the receiver response before timeout. So
the delay here to wait for timeout and not a delay after timeout. The DP
spec specifies a delay after timeout and hence adding this delay.

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 2bc119374555..a1fef1645d6a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -286,13 +286,9 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 			/*
 			 * DP CTS 1.2 Core Rev 1.1, 4.2.1.1 & 4.2.1.2
 			 *   400us delay required for errors and timeouts
-			 *   Timeout errors from the HW already meet this
-			 *   requirement so skip to next iteration
 			 */
-			if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR)
-				continue;
-
-			if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
+			if (status & (DP_AUX_CH_CTL_RECEIVE_ERROR |
+						DP_AUX_CH_CTL_TIME_OUT_ERROR)) {
 				usleep_range(400, 500);
 				continue;
 			}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread
end of thread, other threads:[~2022-07-26 17:05 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 10:59 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry Arun R Murthy
2022-06-28  2:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-06-28  2:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-06-28 15:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-01 10:11 ` [Intel-gfx] [PATCH] " Jani Nikula
2022-07-01 10:24   ` Murthy, Arun R
2022-07-01 10:48 ` [Intel-gfx] [PATCHv2] " Arun R Murthy
2022-07-01 10:54   ` Jani Nikula
2022-07-01 11:03 ` [Intel-gfx] [PATCHv3] " Arun R Murthy
2022-07-01 11:14   ` Jani Nikula
2022-07-04  5:24     ` Shankar, Uma
2022-07-04  5:37       ` Murthy, Arun R
2022-07-04  6:31         ` Shankar, Uma
2022-07-01 11:35 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry (rev2) Patchwork
2022-07-01 12:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry (rev3) Patchwork
2022-07-02  4:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-04  7:23 ` [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry Arun R Murthy
2022-07-04 12:27   ` Shankar, Uma
2022-07-04 14:11   ` Ville Syrjälä
2022-07-04 16:01     ` Murthy, Arun R
2022-07-26 17:04       ` Imre Deak
2022-07-18 11:18     ` Murthy, Arun R
2022-07-19  8:12       ` Shankar, Uma
2022-07-04 18:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry (rev4) Patchwork
2022-07-04 22:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.