* [PATCH] mt76: mt7915: remove set but not used variable 'msta'
@ 2020-05-28 7:48 YueHaibing
2020-05-29 15:14 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-05-28 7:48 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Kalle Valo,
Jakub Kicinski, Matthias Brugger
Cc: YueHaibing, linux-wireless, Hulk Robot
Cc: linux-wireless@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c: In function 'mt7915_mcu_sta_txbf_type':
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:1805:21: warning:
variable 'msta' set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index 99eeea42478f..7e803a5c94ef 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -1802,15 +1802,12 @@ static u8
mt7915_mcu_sta_txbf_type(struct mt7915_phy *phy, struct ieee80211_vif *vif,
struct ieee80211_sta *sta)
{
- struct mt7915_sta *msta;
u8 type = 0;
if (vif->type != NL80211_IFTYPE_STATION &&
vif->type != NL80211_IFTYPE_AP)
return 0;
- msta = (struct mt7915_sta *)sta->drv_priv;
-
if (sta->he_cap.has_he) {
struct ieee80211_he_cap_elem *pe;
const struct ieee80211_he_cap_elem *ve;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt76: mt7915: remove set but not used variable 'msta'
2020-05-28 7:48 [PATCH] mt76: mt7915: remove set but not used variable 'msta' YueHaibing
@ 2020-05-29 15:14 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-05-29 15:14 UTC (permalink / raw)
To: YueHaibing
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Jakub Kicinski,
Matthias Brugger, linux-wireless, Hulk Robot
YueHaibing <yuehaibing@huawei.com> writes:
> Cc: linux-wireless@vger.kernel.org,
> linux-arm-kernel@lists.infradead.org,
> linux-mediatek@lists.infradead.org,
> netdev@vger.kernel.org,
> kernel-janitors@vger.kernel.org
This patch got already applied but please don't include Cc field to the
commit log in the future.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-29 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 7:48 [PATCH] mt76: mt7915: remove set but not used variable 'msta' YueHaibing
2020-05-29 15:14 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.