* [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support
@ 2019-01-13 21:47 Peter Seiderer
2019-06-23 19:39 ` Yann E. MORIN
2019-06-23 19:46 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Peter Seiderer @ 2019-01-13 21:47 UTC (permalink / raw)
To: buildroot
Delivered libcdaudio configure tries to run a C++ check with the
host C preprocessor. Fix it by enabling autoreconf (needs
a patch for configure.ac/Makefile.am removing ancient lines).
Fixes [1]:
checking how to run the C++ preprocessor... /lib/cpp
configure: error: C++ preprocessor "/lib/cpp" fails sanity check
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
.../0001-libcdaudio-enable-autoreconf.patch | 43 +++++++++++++++++++
package/libcdaudio/libcdaudio.mk | 3 ++
2 files changed, 46 insertions(+)
create mode 100644 package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
diff --git a/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch b/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
new file mode 100644
index 0000000000..ab2296c042
--- /dev/null
+++ b/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
@@ -0,0 +1,43 @@
+From 9c2873b1d9292bcf43c862b6777d41c40521424c Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Sun, 13 Jan 2019 22:27:42 +0100
+Subject: [PATCH] libcdaudio: enable autoreconf
+
+Fixes the following two autoreconf errors (by simple removing of the
+two offending lines):
+
+ configure.ac:20: error: automatic de-ANSI-fication support has been removed
+
+ Makefile.am:2: error: automatic de-ANSI-fication support has been removed
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ Makefile.am | 1 -
+ configure.ac | 1 -
+ 2 files changed, 2 deletions(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index f639dd8..a32cfe6 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,5 +1,4 @@
+ ## Process this file with automake to produce Makefile.in
+-AUTOMAKE_OPTIONS = ansi2knr
+ SUBDIRS = src
+
+ bin_SCRIPTS = libcdaudio-config
+diff --git a/configure.ac b/configure.ac
+index bbdd42d..6699ceb 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -17,7 +17,6 @@ AM_CONFIG_HEADER(config.h)
+ AC_PROG_AWK
+ AC_PROG_CC
+ AC_PROG_CPP
+-AM_C_PROTOTYPES
+ AM_PROG_CC_STDC
+ AC_PROG_INSTALL
+ AC_PROG_LN_S
+--
+2.20.1
+
diff --git a/package/libcdaudio/libcdaudio.mk b/package/libcdaudio/libcdaudio.mk
index 5d421eba7a..e2c1496287 100644
--- a/package/libcdaudio/libcdaudio.mk
+++ b/package/libcdaudio/libcdaudio.mk
@@ -11,4 +11,7 @@ LIBCDAUDIO_CONFIG_SCRIPTS = libcdaudio-config
LIBCDAUDIO_LICENSE = GPL-2.0+
LIBCDAUDIO_LICENSE_FILES = COPYING
+# fix configure failure on host systems without C++ support
+LIBCDAUDIO_AUTORECONF = YES
+
$(eval $(autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support
2019-01-13 21:47 [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support Peter Seiderer
@ 2019-06-23 19:39 ` Yann E. MORIN
2019-06-23 19:46 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2019-06-23 19:39 UTC (permalink / raw)
To: buildroot
Peter, All,
On 2019-01-13 22:47 +0100, Peter Seiderer spake thusly:
> Delivered libcdaudio configure tries to run a C++ check with the
> host C preprocessor. Fix it by enabling autoreconf (needs
> a patch for configure.ac/Makefile.am removing ancient lines).
>
> Fixes [1]:
>
> checking how to run the C++ preprocessor... /lib/cpp
> configure: error: C++ preprocessor "/lib/cpp" fails sanity check
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> .../0001-libcdaudio-enable-autoreconf.patch | 43 +++++++++++++++++++
> package/libcdaudio/libcdaudio.mk | 3 ++
> 2 files changed, 46 insertions(+)
> create mode 100644 package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
>
> diff --git a/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch b/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
> new file mode 100644
> index 0000000000..ab2296c042
> --- /dev/null
> +++ b/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
> @@ -0,0 +1,43 @@
> +From 9c2873b1d9292bcf43c862b6777d41c40521424c Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Sun, 13 Jan 2019 22:27:42 +0100
> +Subject: [PATCH] libcdaudio: enable autoreconf
> +
> +Fixes the following two autoreconf errors (by simple removing of the
> +two offending lines):
> +
> + configure.ac:20: error: automatic de-ANSI-fication support has been removed
> +
> + Makefile.am:2: error: automatic de-ANSI-fication support has been removed
> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + Makefile.am | 1 -
> + configure.ac | 1 -
> + 2 files changed, 2 deletions(-)
> +
> +diff --git a/Makefile.am b/Makefile.am
> +index f639dd8..a32cfe6 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -1,5 +1,4 @@
> + ## Process this file with automake to produce Makefile.in
> +-AUTOMAKE_OPTIONS = ansi2knr
> + SUBDIRS = src
> +
> + bin_SCRIPTS = libcdaudio-config
> +diff --git a/configure.ac b/configure.ac
> +index bbdd42d..6699ceb 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -17,7 +17,6 @@ AM_CONFIG_HEADER(config.h)
> + AC_PROG_AWK
> + AC_PROG_CC
> + AC_PROG_CPP
> +-AM_C_PROTOTYPES
> + AM_PROG_CC_STDC
> + AC_PROG_INSTALL
> + AC_PROG_LN_S
> +--
> +2.20.1
> +
> diff --git a/package/libcdaudio/libcdaudio.mk b/package/libcdaudio/libcdaudio.mk
> index 5d421eba7a..e2c1496287 100644
> --- a/package/libcdaudio/libcdaudio.mk
> +++ b/package/libcdaudio/libcdaudio.mk
> @@ -11,4 +11,7 @@ LIBCDAUDIO_CONFIG_SCRIPTS = libcdaudio-config
> LIBCDAUDIO_LICENSE = GPL-2.0+
> LIBCDAUDIO_LICENSE_FILES = COPYING
>
> +# fix configure failure on host systems without C++ support
> +LIBCDAUDIO_AUTORECONF = YES
> +
> $(eval $(autotools-package))
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support
2019-01-13 21:47 [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support Peter Seiderer
2019-06-23 19:39 ` Yann E. MORIN
@ 2019-06-23 19:46 ` Thomas Petazzoni
2019-06-25 9:05 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2019-06-23 19:46 UTC (permalink / raw)
To: buildroot
On Sun, 13 Jan 2019 22:47:22 +0100
Peter Seiderer <ps.report@gmx.net> wrote:
> Delivered libcdaudio configure tries to run a C++ check with the
> host C preprocessor. Fix it by enabling autoreconf (needs
> a patch for configure.ac/Makefile.am removing ancient lines).
>
> Fixes [1]:
>
> checking how to run the C++ preprocessor... /lib/cpp
> configure: error: C++ preprocessor "/lib/cpp" fails sanity check
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Contrary to what your commit title says, the problem does not occur
when the host system lacks C++ support, it's when the target toolchain
doesn't have C++ support. I have an Arch Linux system here (which is
where the failure happens), and the host system has C++ support, but
doesn't provide /lib/cpp.
I fixed up the commit title, commit log, and comment in the .mk file
and applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support
2019-06-23 19:46 ` Thomas Petazzoni
@ 2019-06-25 9:05 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-06-25 9:05 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> On Sun, 13 Jan 2019 22:47:22 +0100
> Peter Seiderer <ps.report@gmx.net> wrote:
>> Delivered libcdaudio configure tries to run a C++ check with the
>> host C preprocessor. Fix it by enabling autoreconf (needs
>> a patch for configure.ac/Makefile.am removing ancient lines).
>>
>> Fixes [1]:
>>
>> checking how to run the C++ preprocessor... /lib/cpp
>> configure: error: C++ preprocessor "/lib/cpp" fails sanity check
>>
>> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> Contrary to what your commit title says, the problem does not occur
> when the host system lacks C++ support, it's when the target toolchain
> doesn't have C++ support. I have an Arch Linux system here (which is
> where the failure happens), and the host system has C++ support, but
> doesn't provide /lib/cpp.
> I fixed up the commit title, commit log, and comment in the .mk file
> and applied.
Committed to 2019.02.x and 2019.05.x with the same fixes, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-25 9:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-13 21:47 [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support Peter Seiderer
2019-06-23 19:39 ` Yann E. MORIN
2019-06-23 19:46 ` Thomas Petazzoni
2019-06-25 9:05 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.