From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Bhagavathi Perumal S <bperumal@codeaurora.org>,
johannes@sipsolutions.net, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Cc: Bhagavathi Perumal S <bperumal@codeaurora.org>
Subject: Re: [PATCH] mac80211: Fix kernel panic due to use of txq after free
Date: Tue, 16 Apr 2019 09:49:07 +0100 [thread overview]
Message-ID: <87sguiuygs.fsf@toke.dk> (raw)
In-Reply-To: <1555399480-30537-1-git-send-email-bperumal@codeaurora.org>
Bhagavathi Perumal S <bperumal@codeaurora.org> writes:
> The txq of vif is added to active_txqs list for ATF TXQ scheduling
> in the function ieee80211_queue_skb(), but it was not properly removed
> before freeing the txq object. It was causing use after free of the txq
> objects from the active_txqs list, result was kernel panic
> due to invalid memory access.
>
> Fix kernel invalid memory access by properly removing txq object
> from active_txqs list before free the object.
>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
Nice catch, thanks!
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
This should probably have a fixes tag:
Fixes: 1866760096bf ("mac80211: Add TXQ scheduling API")
-Toke
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Bhagavathi Perumal S <bperumal@codeaurora.org>,
johannes@sipsolutions.net, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix kernel panic due to use of txq after free
Date: Tue, 16 Apr 2019 09:49:07 +0100 [thread overview]
Message-ID: <87sguiuygs.fsf@toke.dk> (raw)
In-Reply-To: <1555399480-30537-1-git-send-email-bperumal@codeaurora.org>
Bhagavathi Perumal S <bperumal@codeaurora.org> writes:
> The txq of vif is added to active_txqs list for ATF TXQ scheduling
> in the function ieee80211_queue_skb(), but it was not properly removed
> before freeing the txq object. It was causing use after free of the txq
> objects from the active_txqs list, result was kernel panic
> due to invalid memory access.
>
> Fix kernel invalid memory access by properly removing txq object
> from active_txqs list before free the object.
>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
Nice catch, thanks!
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
This should probably have a fixes tag:
Fixes: 1866760096bf ("mac80211: Add TXQ scheduling API")
-Toke
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-04-16 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 7:24 [PATCH] mac80211: Fix kernel panic due to use of txq after free Bhagavathi Perumal S
2019-04-16 7:24 ` Bhagavathi Perumal S
2019-04-16 8:49 ` Toke Høiland-Jørgensen [this message]
2019-04-16 8:49 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sguiuygs.fsf@toke.dk \
--to=toke@redhat.com \
--cc=ath10k@lists.infradead.org \
--cc=bperumal@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.