From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath6kl: remove redundant check of status != 0
Date: Thu, 04 Apr 2019 17:33:28 +0300 [thread overview]
Message-ID: <87sguxsuvb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190404134723.24667-1-colin.king@canonical.com> (Colin King's message of "Thu, 4 Apr 2019 14:47:23 +0100")
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check on status not being zero is redundant as previous code
> paths that set status to an error value break out of the while
> loop and hence status is never non-zero at the check. Remove
> this redundant code.
>
> Addresses-Coverity: ("Logically dead code")
Is the coverity id missing?
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath6kl: remove redundant check of status != 0
Date: Thu, 04 Apr 2019 14:33:28 +0000 [thread overview]
Message-ID: <87sguxsuvb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190404134723.24667-1-colin.king@canonical.com> (Colin King's message of "Thu, 4 Apr 2019 14:47:23 +0100")
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check on status not being zero is redundant as previous code
> paths that set status to an error value break out of the while
> loop and hence status is never non-zero at the check. Remove
> this redundant code.
>
> Addresses-Coverity: ("Logically dead code")
Is the coverity id missing?
--
Kalle Valo
next prev parent reply other threads:[~2019-04-04 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 13:47 [PATCH] ath6kl: remove redundant check of status != 0 Colin King
2019-04-04 13:47 ` Colin King
2019-04-04 14:33 ` Kalle Valo [this message]
2019-04-04 14:33 ` Kalle Valo
2019-04-05 6:50 ` Mukesh Ojha
2019-04-05 6:50 ` Mukesh Ojha
2019-04-29 14:50 ` Kalle Valo
2019-04-29 14:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sguxsuvb.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.