[Buildroot] [PATCH/next] acpid: use shutdown for poweroff, if available, not /sbin/poweroff

[Buildroot] [PATCH/next] acpid: use shutdown for poweroff, if available, not /sbin/poweroff

[Carlos Santos]

It's preferable to use "shutdown -hP now" to ensure that the runlevel is
known, preventing this message on the system console and log:

  WARNING: could not determine runlevel - doing soft poweroff
    (it's better to use shutdown instead of poweroff from the command line)

Signed-off-by: Carlos Santos <casantos@datacom.com.br>
---
 package/acpid/acpid.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/acpid/acpid.mk b/package/acpid/acpid.mk
index 2141a1a9e0..87378d8106 100644
--- a/package/acpid/acpid.mk
+++ b/package/acpid/acpid.mk
@@ -15,9 +15,15 @@ define ACPID_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S02acpid
 endef
 
+ifeq ($(BR2_INIT_SYSV)$(BR2_INIT_SYSTEMD),y)
+ACPID_POWEROFF_CMD = /sbin/shutdown -hP now
+else
+ACPID_POWEROFF_CMD = /sbin/poweroff
+endif
+
 define ACPID_SET_EVENTS
 	mkdir -p $(TARGET_DIR)/etc/acpi/events
-	printf "event=button[ /]power\naction=/sbin/poweroff\n" \
+	printf 'event=button[ /]power\naction=%s\n' '$(ACPID_POWEROFF_CMD)' \
 		>$(TARGET_DIR)/etc/acpi/events/powerbtn
 endef
 
-- 
2.14.4

[Buildroot] [PATCH/next] acpid: use shutdown for poweroff, if available, not /sbin/poweroff

[Thomas Petazzoni]

Hello,

On Thu, 30 Aug 2018 10:21:20 -0300, Carlos Santos wrote:
> It's preferable to use "shutdown -hP now" to ensure that the runlevel is
> known, preventing this message on the system console and log:
> 
>   WARNING: could not determine runlevel - doing soft poweroff
>     (it's better to use shutdown instead of poweroff from the command line)
> 
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
> ---
>  package/acpid/acpid.mk | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Nobody complained about this since ~2 weeks and it looks reasonable, so
I've applied.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH/next] acpid: use shutdown for poweroff, if available, not /sbin/poweroff

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello,
 > On Thu, 30 Aug 2018 10:21:20 -0300, Carlos Santos wrote:
 >> It's preferable to use "shutdown -hP now" to ensure that the runlevel is
 >> known, preventing this message on the system console and log:
 >> 
 >> WARNING: could not determine runlevel - doing soft poweroff
 >> (it's better to use shutdown instead of poweroff from the command line)
 >> 
 >> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
 >> ---
 >> package/acpid/acpid.mk | 8 +++++++-
 >> 1 file changed, 7 insertions(+), 1 deletion(-)

Committed to 2018.02.x, 2018.05.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard