All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: guangrong.xiao@gmail.com
Cc: kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com,
	Xiao Guangrong <xiaoguangrong@tencent.com>,
	dgilbert@redhat.com, peterx@redhat.com, qemu-devel@nongnu.org,
	wei.w.wang@intel.com, jiang.biao2@zte.com.cn,
	pbonzini@redhat.com
Subject: Re: [PATCH v6 1/3] migration: do not flush_compressed_data at the end of iteration
Date: Thu, 06 Sep 2018 11:38:03 +0200	[thread overview]
Message-ID: <87sh2n3r0k.fsf@trasno.org> (raw)
In-Reply-To: <20180906070101.27280-2-xiaoguangrong@tencent.com> (guangrong xiao's message of "Thu, 6 Sep 2018 15:00:59 +0800")

guangrong.xiao@gmail.com wrote:
> From: Xiao Guangrong <xiaoguangrong@tencent.com>
>
> flush_compressed_data() needs to wait all compression threads to
> finish their work, after that all threads are free until the
> migration feeds new request to them, reducing its call can improve
> the throughput and use CPU resource more effectively
>
> We do not need to flush all threads at the end of iteration, the
> data can be kept locally until the memory block is changed or
> memory migration starts over in that case we will meet a dirtied
> page which may still exists in compression threads's ring
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@tencent.com>


Reviewed-by: Juan Quintela <quintela@redhat.com>

WARNING: multiple messages have this Message-ID
From: Juan Quintela <quintela@redhat.com>
To: guangrong.xiao@gmail.com
Cc: pbonzini@redhat.com, mst@redhat.com, mtosatti@redhat.com,
	qemu-devel@nongnu.org, kvm@vger.kernel.org, dgilbert@redhat.com,
	peterx@redhat.com, wei.w.wang@intel.com, jiang.biao2@zte.com.cn,
	eblake@redhat.com, Xiao Guangrong <xiaoguangrong@tencent.com>
Subject: Re: [Qemu-devel] [PATCH v6 1/3] migration: do not flush_compressed_data at the end of iteration
Date: Thu, 06 Sep 2018 11:38:03 +0200	[thread overview]
Message-ID: <87sh2n3r0k.fsf@trasno.org> (raw)
In-Reply-To: <20180906070101.27280-2-xiaoguangrong@tencent.com> (guangrong xiao's message of "Thu, 6 Sep 2018 15:00:59 +0800")

guangrong.xiao@gmail.com wrote:
> From: Xiao Guangrong <xiaoguangrong@tencent.com>
>
> flush_compressed_data() needs to wait all compression threads to
> finish their work, after that all threads are free until the
> migration feeds new request to them, reducing its call can improve
> the throughput and use CPU resource more effectively
>
> We do not need to flush all threads at the end of iteration, the
> data can be kept locally until the memory block is changed or
> memory migration starts over in that case we will meet a dirtied
> page which may still exists in compression threads's ring
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@tencent.com>


Reviewed-by: Juan Quintela <quintela@redhat.com>

  reply	other threads:[~2018-09-06  9:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06  7:00 [PATCH v6 0/3] migration: compression optimization guangrong.xiao
2018-09-06  7:00 ` [Qemu-devel] " guangrong.xiao
2018-09-06  7:00 ` [PATCH v6 1/3] migration: do not flush_compressed_data at the end of iteration guangrong.xiao
2018-09-06  7:00   ` [Qemu-devel] " guangrong.xiao
2018-09-06  9:38   ` Juan Quintela [this message]
2018-09-06  9:38     ` Juan Quintela
2018-09-06  7:01 ` [PATCH v6 2/3] migration: show the statistics of compression guangrong.xiao
2018-09-06  7:01   ` [Qemu-devel] " guangrong.xiao
2018-09-06  7:01 ` [PATCH v6 3/3] migration: use save_page_use_compression in flush_compressed_data guangrong.xiao
2018-09-06  7:01   ` [Qemu-devel] " guangrong.xiao
2018-09-06  9:49   ` Juan Quintela
2018-09-06  9:49     ` [Qemu-devel] " Juan Quintela
2018-09-06 11:03 ` [PATCH v6 0/3] migration: compression optimization Juan Quintela
2018-09-06 11:03   ` [Qemu-devel] " Juan Quintela
2018-09-13  7:45   ` Xiao Guangrong
2018-09-13  7:45     ` [Qemu-devel] " Xiao Guangrong
2018-09-13 13:26     ` Juan Quintela
2018-09-13 13:26       ` [Qemu-devel] " Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh2n3r0k.fsf@trasno.org \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=guangrong.xiao@gmail.com \
    --cc=jiang.biao2@zte.com.cn \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wei.w.wang@intel.com \
    --cc=xiaoguangrong@tencent.com \
    --subject='Re: [PATCH v6 1/3] migration: do not flush_compressed_data at the end of iteration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.