All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: "David S. Miller" <davem@davemloft.net>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Nicolas Pitre <nico@fluxnic.net>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround
Date: Sat, 15 Oct 2016 23:11:56 +0200	[thread overview]
Message-ID: <87shrx5nc3.fsf@belgarion.home> (raw)
In-Reply-To: <1476559670-25056-2-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sat, 15 Oct 2016 21:27:48 +0200")

Sorry David, I just noticed you weren't in the "To:" of this serie, but I won't
forget you for the v3 I need to release anyway
(https://lkml.org/lkml/2016/10/15/104).

Robert Jarzmik <robert.jarzmik@free.fr> writes:
> +	lp->half_word_align4 =
> +		machine_is_mainstone() || machine_is_stargate2() ||
> +		machine_is_pxa_idp();

Bah this one is not good enough.

First, machine_is_*() is not defined if CONFIG_ARM=n, and this part is not under
a #ifdef CONFIG_ARM.

Moreover, I think it is a good occasion to go further, and :
 - enhance smc91x_platdata and add a pxa_u16_align4 boolean
 - transform this statement into :
	lp->half_word_align4 = lp->cfg.pxa_u16_align4

This will remove the machine_*() calls from the smc91x driver, which looks a
good move, doesn't it ?

Cheers.

--
Robert

WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
To: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Nicolas Pitre <nico-vtqb6HGKxmzR7s880joybQ@public.gmane.org>,
	Russell King - ARM Linux
	<linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround
Date: Sat, 15 Oct 2016 23:11:56 +0200	[thread overview]
Message-ID: <87shrx5nc3.fsf@belgarion.home> (raw)
In-Reply-To: <1476559670-25056-2-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org> (Robert Jarzmik's message of "Sat, 15 Oct 2016 21:27:48 +0200")

Sorry David, I just noticed you weren't in the "To:" of this serie, but I won't
forget you for the v3 I need to release anyway
(https://lkml.org/lkml/2016/10/15/104).

Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org> writes:
> +	lp->half_word_align4 =
> +		machine_is_mainstone() || machine_is_stargate2() ||
> +		machine_is_pxa_idp();

Bah this one is not good enough.

First, machine_is_*() is not defined if CONFIG_ARM=n, and this part is not under
a #ifdef CONFIG_ARM.

Moreover, I think it is a good occasion to go further, and :
 - enhance smc91x_platdata and add a pxa_u16_align4 boolean
 - transform this statement into :
	lp->half_word_align4 = lp->cfg.pxa_u16_align4

This will remove the machine_*() calls from the smc91x driver, which looks a
good move, doesn't it ?

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-10-15 21:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-15 19:27 [PATCH v2 0/3] support smc91x on mainstone and devicetree Robert Jarzmik
2016-10-15 19:27 ` Robert Jarzmik
2016-10-15 19:27 ` [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround Robert Jarzmik
2016-10-15 21:11   ` Robert Jarzmik [this message]
2016-10-15 21:11     ` Robert Jarzmik
2016-10-16 10:05   ` Robert Jarzmik
2016-10-15 19:27 ` [PATCH v2 2/3] net: smc91x: take into account half-word workaround Robert Jarzmik
2016-10-15 19:27 ` [PATCH v2 3/3] net: smsc91x: add u16 workaround for pxa platforms Robert Jarzmik
  -- strict thread matches above, loose matches on Subject: below --
2016-10-09 20:33 [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround Robert Jarzmik
2016-10-09 21:55 ` Andy Shevchenko
2016-10-10  6:30   ` Robert Jarzmik
2016-10-10  6:30     ` Robert Jarzmik
2016-10-10  6:30     ` Robert Jarzmik
2016-10-13 13:50 ` David Miller
2016-10-13 13:50   ` David Miller
2016-10-14  6:12   ` Robert Jarzmik
2016-10-14  6:12     ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shrx5nc3.fsf@belgarion.home \
    --to=robert.jarzmik@free.fr \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.