* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-10 5:18 [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Tejas Upadhyay
@ 2021-12-10 10:48 ` Jani Nikula
2021-12-10 10:50 ` Surendrakumar Upadhyay, TejaskumarX
2021-12-10 12:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/adl-n: Enable ADL-N platform (rev3) Patchwork
` (5 subsequent siblings)
6 siblings, 1 reply; 22+ messages in thread
From: Jani Nikula @ 2021-12-10 10:48 UTC (permalink / raw)
To: Tejas Upadhyay, intel-gfx
On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
> Adding PCI device ids and enabling ADL-N platform.
> ADL-N from i915 point of view is subplatform of ADL-P.
>
> BSpec: 68397
>
> Changes since V2:
> - Added version log history
> Changes since V1:
> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
> arch/x86/kernel/early-quirks.c | 1 +
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> include/drm/i915_pciids.h | 6 ++++++
> 6 files changed, 20 insertions(+)
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index fd2d3ab38ebb..1ca3a56fdc2d 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_RKL_IDS(&gen11_early_ops),
> INTEL_ADLS_IDS(&gen11_early_ops),
> INTEL_ADLP_IDS(&gen11_early_ops),
> + INTEL_ADLN_IDS(&gen11_early_ops),
> INTEL_RPLS_IDS(&gen11_early_ops),
> };
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index a0f54a69b11d..b2ec85a3e40a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
> IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
> #define IS_ADLS_RPLS(dev_priv) \
> IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL_S)
> +#define IS_ADLP_N(dev_priv) \
> + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P, INTEL_SUBPLATFORM_N)
Oh, what do you need to use this for?
BR,
Jani.
> #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> (INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
> #define IS_BDW_ULT(dev_priv) \
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 708a23415e9c..6a19e9da53cc 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
> INTEL_RKL_IDS(&rkl_info),
> INTEL_ADLS_IDS(&adl_s_info),
> INTEL_ADLP_IDS(&adl_p_info),
> + INTEL_ADLN_IDS(&adl_p_info),
> INTEL_DG1_IDS(&dg1_info),
> INTEL_RPLS_IDS(&adl_s_info),
> {0, 0, 0}
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a3446a2abcb2..54944d87cd3c 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
> INTEL_ICL_PORT_F_IDS(0),
> };
>
> +static const u16 subplatform_n_ids[] = {
> + INTEL_ADLN_IDS(0),
> +};
> +
> static const u16 subplatform_rpls_ids[] = {
> INTEL_RPLS_IDS(0),
> };
> @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
> } else if (find_devid(devid, subplatform_portf_ids,
> ARRAY_SIZE(subplatform_portf_ids))) {
> mask = BIT(INTEL_SUBPLATFORM_PORTF);
> + } else if (find_devid(devid, subplatform_n_ids,
> + ARRAY_SIZE(subplatform_n_ids))) {
> + mask = BIT(INTEL_SUBPLATFORM_N);
> } else if (find_devid(devid, subplatform_rpls_ids,
> ARRAY_SIZE(subplatform_rpls_ids))) {
> mask = BIT(INTEL_SUBPLATFORM_RPL_S);
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index 213ae2c07126..e341d90f28a2 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -113,6 +113,9 @@ enum intel_platform {
> /* ADL-S */
> #define INTEL_SUBPLATFORM_RPL_S 0
>
> +/* ADL-P */
> +#define INTEL_SUBPLATFORM_N 0
> +
> enum intel_ppgtt_type {
> INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
> INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING,
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index baf3d1d3d566..533890dc9da1 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -666,6 +666,12 @@
> INTEL_VGA_DEVICE(0x46C2, info), \
> INTEL_VGA_DEVICE(0x46C3, info)
>
> +/* ADL-N */
> +#define INTEL_ADLN_IDS(info) \
> + INTEL_VGA_DEVICE(0x46D0, info), \
> + INTEL_VGA_DEVICE(0x46D1, info), \
> + INTEL_VGA_DEVICE(0x46D2, info)
> +
> /* RPL-S */
> #define INTEL_RPLS_IDS(info) \
> INTEL_VGA_DEVICE(0xA780, info), \
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-10 10:48 ` Jani Nikula
@ 2021-12-10 10:50 ` Surendrakumar Upadhyay, TejaskumarX
2021-12-16 11:49 ` Surendrakumar Upadhyay, TejaskumarX
0 siblings, 1 reply; 22+ messages in thread
From: Surendrakumar Upadhyay, TejaskumarX @ 2021-12-10 10:50 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: 10 December 2021 16:18
> To: Surendrakumar Upadhyay, TejaskumarX
> <tejaskumarx.surendrakumar.upadhyay@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
>
> On Fri, 10 Dec 2021, Tejas Upadhyay
> <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
> > Adding PCI device ids and enabling ADL-N platform.
> > ADL-N from i915 point of view is subplatform of ADL-P.
> >
> > BSpec: 68397
> >
> > Changes since V2:
> > - Added version log history
> > Changes since V1:
> > - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
> >
> > Signed-off-by: Tejas Upadhyay
> > <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > ---
> > arch/x86/kernel/early-quirks.c | 1 +
> > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > drivers/gpu/drm/i915/i915_pci.c | 1 +
> > drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> > drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> > include/drm/i915_pciids.h | 6 ++++++
> > 6 files changed, 20 insertions(+)
> >
> > diff --git a/arch/x86/kernel/early-quirks.c
> > b/arch/x86/kernel/early-quirks.c index fd2d3ab38ebb..1ca3a56fdc2d
> > 100644
> > --- a/arch/x86/kernel/early-quirks.c
> > +++ b/arch/x86/kernel/early-quirks.c
> > @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[]
> __initconst = {
> > INTEL_RKL_IDS(&gen11_early_ops),
> > INTEL_ADLS_IDS(&gen11_early_ops),
> > INTEL_ADLP_IDS(&gen11_early_ops),
> > + INTEL_ADLN_IDS(&gen11_early_ops),
> > INTEL_RPLS_IDS(&gen11_early_ops),
> > };
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h index a0f54a69b11d..b2ec85a3e40a
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct drm_i915_private
> *i915,
> > IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
> #define
> > IS_ADLS_RPLS(dev_priv) \
> > IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S,
> INTEL_SUBPLATFORM_RPL_S)
> > +#define IS_ADLP_N(dev_priv) \
> > + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P,
> INTEL_SUBPLATFORM_N)
>
> Oh, what do you need to use this for?
>
Tejas : This is readiness for ADL-N specific workarounds.
> BR,
> Jani.
>
>
> > #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> > (INTEL_DEVID(dev_priv) & 0xFF00) ==
> 0x0C00) #define
> > IS_BDW_ULT(dev_priv) \ diff --git a/drivers/gpu/drm/i915/i915_pci.c
> > b/drivers/gpu/drm/i915/i915_pci.c index 708a23415e9c..6a19e9da53cc
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
> > INTEL_RKL_IDS(&rkl_info),
> > INTEL_ADLS_IDS(&adl_s_info),
> > INTEL_ADLP_IDS(&adl_p_info),
> > + INTEL_ADLN_IDS(&adl_p_info),
> > INTEL_DG1_IDS(&dg1_info),
> > INTEL_RPLS_IDS(&adl_s_info),
> > {0, 0, 0}
> > diff --git a/drivers/gpu/drm/i915/intel_device_info.c
> > b/drivers/gpu/drm/i915/intel_device_info.c
> > index a3446a2abcb2..54944d87cd3c 100644
> > --- a/drivers/gpu/drm/i915/intel_device_info.c
> > +++ b/drivers/gpu/drm/i915/intel_device_info.c
> > @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
> > INTEL_ICL_PORT_F_IDS(0),
> > };
> >
> > +static const u16 subplatform_n_ids[] = {
> > + INTEL_ADLN_IDS(0),
> > +};
> > +
> > static const u16 subplatform_rpls_ids[] = {
> > INTEL_RPLS_IDS(0),
> > };
> > @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct
> drm_i915_private *i915)
> > } else if (find_devid(devid, subplatform_portf_ids,
> > ARRAY_SIZE(subplatform_portf_ids))) {
> > mask = BIT(INTEL_SUBPLATFORM_PORTF);
> > + } else if (find_devid(devid, subplatform_n_ids,
> > + ARRAY_SIZE(subplatform_n_ids))) {
> > + mask = BIT(INTEL_SUBPLATFORM_N);
> > } else if (find_devid(devid, subplatform_rpls_ids,
> > ARRAY_SIZE(subplatform_rpls_ids))) {
> > mask = BIT(INTEL_SUBPLATFORM_RPL_S); diff --git
> > a/drivers/gpu/drm/i915/intel_device_info.h
> > b/drivers/gpu/drm/i915/intel_device_info.h
> > index 213ae2c07126..e341d90f28a2 100644
> > --- a/drivers/gpu/drm/i915/intel_device_info.h
> > +++ b/drivers/gpu/drm/i915/intel_device_info.h
> > @@ -113,6 +113,9 @@ enum intel_platform {
> > /* ADL-S */
> > #define INTEL_SUBPLATFORM_RPL_S 0
> >
> > +/* ADL-P */
> > +#define INTEL_SUBPLATFORM_N 0
> > +
> > enum intel_ppgtt_type {
> > INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
> > INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING, diff --git
> > a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index
> > baf3d1d3d566..533890dc9da1 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -666,6 +666,12 @@
> > INTEL_VGA_DEVICE(0x46C2, info), \
> > INTEL_VGA_DEVICE(0x46C3, info)
> >
> > +/* ADL-N */
> > +#define INTEL_ADLN_IDS(info) \
> > + INTEL_VGA_DEVICE(0x46D0, info), \
> > + INTEL_VGA_DEVICE(0x46D1, info), \
> > + INTEL_VGA_DEVICE(0x46D2, info)
> > +
> > /* RPL-S */
> > #define INTEL_RPLS_IDS(info) \
> > INTEL_VGA_DEVICE(0xA780, info), \
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-10 10:50 ` Surendrakumar Upadhyay, TejaskumarX
@ 2021-12-16 11:49 ` Surendrakumar Upadhyay, TejaskumarX
0 siblings, 0 replies; 22+ messages in thread
From: Surendrakumar Upadhyay, TejaskumarX @ 2021-12-16 11:49 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
> -----Original Message-----
> From: Surendrakumar Upadhyay, TejaskumarX
> Sent: 10 December 2021 16:21
> To: Jani Nikula <jani.nikula@linux.intel.com>; intel-gfx@lists.freedesktop.org
> Subject: RE: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
>
>
>
> > -----Original Message-----
> > From: Jani Nikula <jani.nikula@linux.intel.com>
> > Sent: 10 December 2021 16:18
> > To: Surendrakumar Upadhyay, TejaskumarX
> > <tejaskumarx.surendrakumar.upadhyay@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N
> > platform
> >
> > On Fri, 10 Dec 2021, Tejas Upadhyay
> > <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
> > > Adding PCI device ids and enabling ADL-N platform.
> > > ADL-N from i915 point of view is subplatform of ADL-P.
> > >
> > > BSpec: 68397
> > >
> > > Changes since V2:
> > > - Added version log history
> > > Changes since V1:
> > > - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
> > >
> > > Signed-off-by: Tejas Upadhyay
> > > <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > > ---
> > > arch/x86/kernel/early-quirks.c | 1 +
> > > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > > drivers/gpu/drm/i915/i915_pci.c | 1 +
> > > drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> > > drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> > > include/drm/i915_pciids.h | 6 ++++++
> > > 6 files changed, 20 insertions(+)
> > >
> > > diff --git a/arch/x86/kernel/early-quirks.c
> > > b/arch/x86/kernel/early-quirks.c index fd2d3ab38ebb..1ca3a56fdc2d
> > > 100644
> > > --- a/arch/x86/kernel/early-quirks.c
> > > +++ b/arch/x86/kernel/early-quirks.c
> > > @@ -554,6 +554,7 @@ static const struct pci_device_id
> > > intel_early_ids[]
> > __initconst = {
> > > INTEL_RKL_IDS(&gen11_early_ops),
> > > INTEL_ADLS_IDS(&gen11_early_ops),
> > > INTEL_ADLP_IDS(&gen11_early_ops),
> > > + INTEL_ADLN_IDS(&gen11_early_ops),
> > > INTEL_RPLS_IDS(&gen11_early_ops),
> > > };
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > > b/drivers/gpu/drm/i915/i915_drv.h index a0f54a69b11d..b2ec85a3e40a
> > > 100644
> > > --- a/drivers/gpu/drm/i915/i915_drv.h
> > > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > > @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct
> drm_i915_private
> > *i915,
> > > IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
> > #define
> > > IS_ADLS_RPLS(dev_priv) \
> > > IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S,
> > INTEL_SUBPLATFORM_RPL_S)
> > > +#define IS_ADLP_N(dev_priv) \
> > > + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P,
> > INTEL_SUBPLATFORM_N)
> >
> > Oh, what do you need to use this for?
> >
>
> Tejas : This is readiness for ADL-N specific workarounds.
>
> > BR,
> > Jani.
> >
Hi Jani, you want any changes for this patch? Or we can go ahead and ack/merge?
Thanks,
Tejas
> >
> > > #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> > > (INTEL_DEVID(dev_priv) & 0xFF00) ==
> > 0x0C00) #define
> > > IS_BDW_ULT(dev_priv) \ diff --git a/drivers/gpu/drm/i915/i915_pci.c
> > > b/drivers/gpu/drm/i915/i915_pci.c index 708a23415e9c..6a19e9da53cc
> > > 100644
> > > --- a/drivers/gpu/drm/i915/i915_pci.c
> > > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > > @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
> > > INTEL_RKL_IDS(&rkl_info),
> > > INTEL_ADLS_IDS(&adl_s_info),
> > > INTEL_ADLP_IDS(&adl_p_info),
> > > + INTEL_ADLN_IDS(&adl_p_info),
> > > INTEL_DG1_IDS(&dg1_info),
> > > INTEL_RPLS_IDS(&adl_s_info),
> > > {0, 0, 0}
> > > diff --git a/drivers/gpu/drm/i915/intel_device_info.c
> > > b/drivers/gpu/drm/i915/intel_device_info.c
> > > index a3446a2abcb2..54944d87cd3c 100644
> > > --- a/drivers/gpu/drm/i915/intel_device_info.c
> > > +++ b/drivers/gpu/drm/i915/intel_device_info.c
> > > @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
> > > INTEL_ICL_PORT_F_IDS(0),
> > > };
> > >
> > > +static const u16 subplatform_n_ids[] = {
> > > + INTEL_ADLN_IDS(0),
> > > +};
> > > +
> > > static const u16 subplatform_rpls_ids[] = {
> > > INTEL_RPLS_IDS(0),
> > > };
> > > @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct
> > drm_i915_private *i915)
> > > } else if (find_devid(devid, subplatform_portf_ids,
> > > ARRAY_SIZE(subplatform_portf_ids))) {
> > > mask = BIT(INTEL_SUBPLATFORM_PORTF);
> > > + } else if (find_devid(devid, subplatform_n_ids,
> > > + ARRAY_SIZE(subplatform_n_ids))) {
> > > + mask = BIT(INTEL_SUBPLATFORM_N);
> > > } else if (find_devid(devid, subplatform_rpls_ids,
> > > ARRAY_SIZE(subplatform_rpls_ids))) {
> > > mask = BIT(INTEL_SUBPLATFORM_RPL_S); diff --git
> > > a/drivers/gpu/drm/i915/intel_device_info.h
> > > b/drivers/gpu/drm/i915/intel_device_info.h
> > > index 213ae2c07126..e341d90f28a2 100644
> > > --- a/drivers/gpu/drm/i915/intel_device_info.h
> > > +++ b/drivers/gpu/drm/i915/intel_device_info.h
> > > @@ -113,6 +113,9 @@ enum intel_platform {
> > > /* ADL-S */
> > > #define INTEL_SUBPLATFORM_RPL_S 0
> > >
> > > +/* ADL-P */
> > > +#define INTEL_SUBPLATFORM_N 0
> > > +
> > > enum intel_ppgtt_type {
> > > INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
> > > INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING, diff --git
> > > a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index
> > > baf3d1d3d566..533890dc9da1 100644
> > > --- a/include/drm/i915_pciids.h
> > > +++ b/include/drm/i915_pciids.h
> > > @@ -666,6 +666,12 @@
> > > INTEL_VGA_DEVICE(0x46C2, info), \
> > > INTEL_VGA_DEVICE(0x46C3, info)
> > >
> > > +/* ADL-N */
> > > +#define INTEL_ADLN_IDS(info) \
> > > + INTEL_VGA_DEVICE(0x46D0, info), \
> > > + INTEL_VGA_DEVICE(0x46D1, info), \
> > > + INTEL_VGA_DEVICE(0x46D2, info)
> > > +
> > > /* RPL-S */
> > > #define INTEL_RPLS_IDS(info) \
> > > INTEL_VGA_DEVICE(0xA780, info), \
> >
> > --
> > Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/adl-n: Enable ADL-N platform (rev3)
2021-12-10 5:18 [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Tejas Upadhyay
2021-12-10 10:48 ` Jani Nikula
@ 2021-12-10 12:45 ` Patchwork
2021-12-10 12:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2021-12-10 12:45 UTC (permalink / raw)
To: Surendrakumar Upadhyay, TejaskumarX; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/adl-n: Enable ADL-N platform (rev3)
URL : https://patchwork.freedesktop.org/series/97406/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7d0f0f58c665 drm/i915/adl-n: Enable ADL-N platform
-:103: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#103: FILE: include/drm/i915_pciids.h:670:
+#define INTEL_ADLN_IDS(info) \
+ INTEL_VGA_DEVICE(0x46D0, info), \
+ INTEL_VGA_DEVICE(0x46D1, info), \
+ INTEL_VGA_DEVICE(0x46D2, info)
-:103: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#103: FILE: include/drm/i915_pciids.h:670:
+#define INTEL_ADLN_IDS(info) \
+ INTEL_VGA_DEVICE(0x46D0, info), \
+ INTEL_VGA_DEVICE(0x46D1, info), \
+ INTEL_VGA_DEVICE(0x46D2, info)
total: 1 errors, 0 warnings, 1 checks, 62 lines checked
^ permalink raw reply [flat|nested] 22+ messages in thread* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/adl-n: Enable ADL-N platform (rev3)
2021-12-10 5:18 [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Tejas Upadhyay
2021-12-10 10:48 ` Jani Nikula
2021-12-10 12:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/adl-n: Enable ADL-N platform (rev3) Patchwork
@ 2021-12-10 12:46 ` Patchwork
2021-12-10 13:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2021-12-10 12:46 UTC (permalink / raw)
To: Surendrakumar Upadhyay, TejaskumarX; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/adl-n: Enable ADL-N platform (rev3)
URL : https://patchwork.freedesktop.org/series/97406/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 22+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl-n: Enable ADL-N platform (rev3)
2021-12-10 5:18 [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Tejas Upadhyay
` (2 preceding siblings ...)
2021-12-10 12:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2021-12-10 13:14 ` Patchwork
2021-12-11 8:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2021-12-10 13:14 UTC (permalink / raw)
To: Surendrakumar Upadhyay, TejaskumarX; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 2895 bytes --]
== Series Details ==
Series: drm/i915/adl-n: Enable ADL-N platform (rev3)
URL : https://patchwork.freedesktop.org/series/97406/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21818
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/index.html
Participating hosts (45 -> 34)
------------------------------
Missing (11): fi-ilk-m540 bat-dg1-6 fi-tgl-u2 bat-dg1-5 fi-hsw-4200u fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-jsl-2 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_21818 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][1] ([fdo#109271]) +18 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: [PASS][2] -> [FAIL][3] ([i915#1888])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][4] -> [DMESG-WARN][5] ([i915#4269])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [FAIL][6] ([i915#4547]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
Build changes
-------------
* Linux: CI_DRM_10988 -> Patchwork_21818
CI-20190529: 20190529
CI_DRM_10988: 24a4093e85c578905d39ebe14225dbeb5b6f07d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6305: 136258e86a093fdb50a7a341de1c09ac9a076fea @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21818: 7d0f0f58c66539cdd5f35772f78c1a061334f1fd @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7d0f0f58c665 drm/i915/adl-n: Enable ADL-N platform
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/index.html
[-- Attachment #2: Type: text/html, Size: 3579 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/adl-n: Enable ADL-N platform (rev3)
2021-12-10 5:18 [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Tejas Upadhyay
` (3 preceding siblings ...)
2021-12-10 13:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-12-11 8:34 ` Patchwork
2021-12-16 11:57 ` [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Jani Nikula
2021-12-17 13:27 ` Jani Nikula
6 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2021-12-11 8:34 UTC (permalink / raw)
To: Surendrakumar Upadhyay, TejaskumarX; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 24509 bytes --]
== Series Details ==
Series: drm/i915/adl-n: Enable ADL-N platform (rev3)
URL : https://patchwork.freedesktop.org/series/97406/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10988_full -> Patchwork_21818_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21818_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21818_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21818_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane_cursor@pipe-a-viewport-size-64:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-glk1/igt@kms_plane_cursor@pipe-a-viewport-size-64.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-glk2/igt@kms_plane_cursor@pipe-a-viewport-size-64.html
Known issues
------------
Here are the changes found in Patchwork_21818_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@engines-hostile-preempt:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-snb7/igt@gem_ctx_persistence@engines-hostile-preempt.html
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][6] ([i915#280])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-tglb8/igt@gem_ctx_sseu@engines.html
* igt@gem_eio@in-flight-suspend:
- shard-snb: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-snb2/igt@gem_eio@in-flight-suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-snb6/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][13] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][14] -> [SKIP][15] ([i915#2190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-tglb8/igt@gem_huc_copy@huc-copy.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-kbl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@gem_lmem_swapping@parallel-random-verify.html
* igt@gem_lmem_swapping@verify:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl6/igt@gem_lmem_swapping@verify.html
* igt@gem_workarounds@suspend-resume-context:
- shard-kbl: NOTRUN -> [DMESG-WARN][18] ([i915#180])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][19] -> [SKIP][20] ([i915#4281])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-iclb7/igt@i915_pm_dc@dc9-dpms.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#1937])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing@dp-1-pipe-b:
- shard-apl: NOTRUN -> [DMESG-WARN][22] ([i915#165] / [i915#180])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl6/igt@kms_atomic_transition@plane-all-modeset-transition-fencing@dp-1-pipe-b.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3777]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3777])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271]) +100 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3886])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl7/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886]) +5 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_cdclk@mode-transition:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271]) +116 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl6/igt@kms_cdclk@mode-transition.html
* igt@kms_chamelium@hdmi-audio:
- shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +10 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl1/igt@kms_chamelium@hdmi-audio.html
* igt@kms_color_chamelium@pipe-a-degamma:
- shard-snb: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-snb7/igt@kms_color_chamelium@pipe-a-degamma.html
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +7 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_color_chamelium@pipe-b-ctm-0-25.html
* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][33] ([i915#1319])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][34] ([i915#2105])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_content_protection@uevent.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#2346]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#79])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#2122]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [PASS][41] -> [SKIP][42] ([i915#3701])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_flip_tiling@flip-change-tiling@dp-1-pipe-a-y-to-yf-ccs:
- shard-apl: NOTRUN -> [DMESG-WARN][43] ([i915#1226])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl4/igt@kms_flip_tiling@flip-change-tiling@dp-1-pipe-a-y-to-yf-ccs.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt:
- shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271]) +42 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-snb7/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-apl: [PASS][45] -> [DMESG-WARN][46] ([i915#180]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-apl7/igt@kms_hdr@bpc-switch-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl2/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#533])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl1/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#533])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl3/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][49] ([i915#265])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][50] ([i915#265])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][51] ([fdo#108145] / [i915#265]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#658]) +3 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#658]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl7/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_writeback@writeback-check-output:
- shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2437])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@kms_writeback@writeback-check-output.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][56] -> [FAIL][57] ([i915#1542])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-glk7/igt@perf@polling-parameterized.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-glk6/igt@perf@polling-parameterized.html
* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2994]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl6/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][59] ([i915#2842]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][61] ([i915#2842]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [FAIL][63] ([i915#2842]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-tglb8/igt@gem_exec_fair@basic-pace@vecs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-tglb6/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-sync@rcs0:
- shard-kbl: [SKIP][65] ([fdo#109271]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-kbl3/igt@gem_exec_fair@basic-sync@rcs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl3/igt@gem_exec_fair@basic-sync@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][67] ([i915#2842]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-rkl-1/igt@gem_exec_fair@basic-throttle@rcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-rkl-1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [DMESG-WARN][69] ([i915#118]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-glk4/igt@gem_exec_whisper@basic-contexts-all.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-glk9/igt@gem_exec_whisper@basic-contexts-all.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][71] ([i915#3921]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-snb6/igt@i915_selftest@live@hangcheck.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-snb7/igt@i915_selftest@live@hangcheck.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][73] ([i915#180]) -> [PASS][74] +4 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
- shard-apl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [FAIL][77] ([i915#2122]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-skl10/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl4/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][79] ([i915#1188]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][81] ([fdo#108145] / [i915#265]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][83] ([fdo#109441]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-iclb6/igt@kms_psr@psr2_suspend.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][85] ([i915#180] / [i915#295]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf_pmu@module-unload:
- shard-skl: [DMESG-WARN][87] ([i915#1982] / [i915#262]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-skl10/igt@perf_pmu@module-unload.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl10/igt@perf_pmu@module-unload.html
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [FAIL][89] ([i915#1731]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-skl1/igt@sysfs_heartbeat_interval@mixed@rcs0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-skl7/igt@sysfs_heartbeat_interval@mixed@rcs0.html
#### Warnings ####
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][91] ([i915#658]) -> [SKIP][92] ([i915#2920]) +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-iclb5/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][93] ([i915#2920]) -> [SKIP][94] ([i915#658]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [FAIL][95] ([i915#4148]) -> [SKIP][96] ([i915#658])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/shard-iclb6/igt@kms_psr2_su@page_flip-xrgb8888.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4148]: https://gitlab.freedesktop.org/drm/intel/issues/4148
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_10988 -> Patchwork_21818
CI-20190529: 20190529
CI_DRM_10988: 24a4093e85c578905d39ebe14225dbeb5b6f07d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6305: 136258e86a093fdb50a7a341de1c09ac9a076fea @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21818: 7d0f0f58c66539cdd5f35772f78c1a061334f1fd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21818/index.html
[-- Attachment #2: Type: text/html, Size: 29894 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-10 5:18 [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Tejas Upadhyay
` (4 preceding siblings ...)
2021-12-11 8:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-12-16 11:57 ` Jani Nikula
2021-12-17 10:37 ` Srivatsa, Anusha
2021-12-17 13:27 ` Jani Nikula
6 siblings, 1 reply; 22+ messages in thread
From: Jani Nikula @ 2021-12-16 11:57 UTC (permalink / raw)
To: Tejas Upadhyay, intel-gfx
On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
> Adding PCI device ids and enabling ADL-N platform.
> ADL-N from i915 point of view is subplatform of ADL-P.
>
> BSpec: 68397
>
> Changes since V2:
> - Added version log history
> Changes since V1:
> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
> ---
> arch/x86/kernel/early-quirks.c | 1 +
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> include/drm/i915_pciids.h | 6 ++++++
> 6 files changed, 20 insertions(+)
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index fd2d3ab38ebb..1ca3a56fdc2d 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_RKL_IDS(&gen11_early_ops),
> INTEL_ADLS_IDS(&gen11_early_ops),
> INTEL_ADLP_IDS(&gen11_early_ops),
> + INTEL_ADLN_IDS(&gen11_early_ops),
> INTEL_RPLS_IDS(&gen11_early_ops),
> };
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index a0f54a69b11d..b2ec85a3e40a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
> IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
> #define IS_ADLS_RPLS(dev_priv) \
> IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL_S)
> +#define IS_ADLP_N(dev_priv) \
> + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P, INTEL_SUBPLATFORM_N)
> #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> (INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
> #define IS_BDW_ULT(dev_priv) \
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 708a23415e9c..6a19e9da53cc 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
> INTEL_RKL_IDS(&rkl_info),
> INTEL_ADLS_IDS(&adl_s_info),
> INTEL_ADLP_IDS(&adl_p_info),
> + INTEL_ADLN_IDS(&adl_p_info),
> INTEL_DG1_IDS(&dg1_info),
> INTEL_RPLS_IDS(&adl_s_info),
> {0, 0, 0}
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a3446a2abcb2..54944d87cd3c 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
> INTEL_ICL_PORT_F_IDS(0),
> };
>
> +static const u16 subplatform_n_ids[] = {
> + INTEL_ADLN_IDS(0),
> +};
> +
> static const u16 subplatform_rpls_ids[] = {
> INTEL_RPLS_IDS(0),
> };
> @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
> } else if (find_devid(devid, subplatform_portf_ids,
> ARRAY_SIZE(subplatform_portf_ids))) {
> mask = BIT(INTEL_SUBPLATFORM_PORTF);
> + } else if (find_devid(devid, subplatform_n_ids,
> + ARRAY_SIZE(subplatform_n_ids))) {
> + mask = BIT(INTEL_SUBPLATFORM_N);
> } else if (find_devid(devid, subplatform_rpls_ids,
> ARRAY_SIZE(subplatform_rpls_ids))) {
> mask = BIT(INTEL_SUBPLATFORM_RPL_S);
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index 213ae2c07126..e341d90f28a2 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -113,6 +113,9 @@ enum intel_platform {
> /* ADL-S */
> #define INTEL_SUBPLATFORM_RPL_S 0
>
> +/* ADL-P */
> +#define INTEL_SUBPLATFORM_N 0
> +
> enum intel_ppgtt_type {
> INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
> INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING,
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index baf3d1d3d566..533890dc9da1 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -666,6 +666,12 @@
> INTEL_VGA_DEVICE(0x46C2, info), \
> INTEL_VGA_DEVICE(0x46C3, info)
>
> +/* ADL-N */
> +#define INTEL_ADLN_IDS(info) \
> + INTEL_VGA_DEVICE(0x46D0, info), \
> + INTEL_VGA_DEVICE(0x46D1, info), \
> + INTEL_VGA_DEVICE(0x46D2, info)
> +
> /* RPL-S */
> #define INTEL_RPLS_IDS(info) \
> INTEL_VGA_DEVICE(0xA780, info), \
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-16 11:57 ` [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Jani Nikula
@ 2021-12-17 10:37 ` Srivatsa, Anusha
0 siblings, 0 replies; 22+ messages in thread
From: Srivatsa, Anusha @ 2021-12-17 10:37 UTC (permalink / raw)
To: Jani Nikula, Surendrakumar Upadhyay, TejaskumarX, intel-gfx
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Thursday, December 16, 2021 5:28 PM
> To: Surendrakumar Upadhyay, TejaskumarX
> <tejaskumarx.surendrakumar.upadhyay@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
>
> On Fri, 10 Dec 2021, Tejas Upadhyay
> <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
> > Adding PCI device ids and enabling ADL-N platform.
> > ADL-N from i915 point of view is subplatform of ADL-P.
> >
> > BSpec: 68397
> >
> > Changes since V2:
> > - Added version log history
> > Changes since V1:
> > - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
> >
> > Signed-off-by: Tejas Upadhyay
> > <tejaskumarx.surendrakumar.upadhyay@intel.com>
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
Checked the changes with Bspec,
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>
>
> > ---
> > arch/x86/kernel/early-quirks.c | 1 +
> > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > drivers/gpu/drm/i915/i915_pci.c | 1 +
> > drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> > drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> > include/drm/i915_pciids.h | 6 ++++++
> > 6 files changed, 20 insertions(+)
> >
> > diff --git a/arch/x86/kernel/early-quirks.c
> > b/arch/x86/kernel/early-quirks.c index fd2d3ab38ebb..1ca3a56fdc2d
> > 100644
> > --- a/arch/x86/kernel/early-quirks.c
> > +++ b/arch/x86/kernel/early-quirks.c
> > @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[]
> __initconst = {
> > INTEL_RKL_IDS(&gen11_early_ops),
> > INTEL_ADLS_IDS(&gen11_early_ops),
> > INTEL_ADLP_IDS(&gen11_early_ops),
> > + INTEL_ADLN_IDS(&gen11_early_ops),
> > INTEL_RPLS_IDS(&gen11_early_ops),
> > };
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h index a0f54a69b11d..b2ec85a3e40a
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct drm_i915_private
> *i915,
> > IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
> #define
> > IS_ADLS_RPLS(dev_priv) \
> > IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S,
> INTEL_SUBPLATFORM_RPL_S)
> > +#define IS_ADLP_N(dev_priv) \
> > + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P,
> INTEL_SUBPLATFORM_N)
> > #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> > (INTEL_DEVID(dev_priv) & 0xFF00) ==
> 0x0C00) #define
> > IS_BDW_ULT(dev_priv) \ diff --git a/drivers/gpu/drm/i915/i915_pci.c
> > b/drivers/gpu/drm/i915/i915_pci.c index 708a23415e9c..6a19e9da53cc
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
> > INTEL_RKL_IDS(&rkl_info),
> > INTEL_ADLS_IDS(&adl_s_info),
> > INTEL_ADLP_IDS(&adl_p_info),
> > + INTEL_ADLN_IDS(&adl_p_info),
> > INTEL_DG1_IDS(&dg1_info),
> > INTEL_RPLS_IDS(&adl_s_info),
> > {0, 0, 0}
> > diff --git a/drivers/gpu/drm/i915/intel_device_info.c
> > b/drivers/gpu/drm/i915/intel_device_info.c
> > index a3446a2abcb2..54944d87cd3c 100644
> > --- a/drivers/gpu/drm/i915/intel_device_info.c
> > +++ b/drivers/gpu/drm/i915/intel_device_info.c
> > @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
> > INTEL_ICL_PORT_F_IDS(0),
> > };
> >
> > +static const u16 subplatform_n_ids[] = {
> > + INTEL_ADLN_IDS(0),
> > +};
> > +
> > static const u16 subplatform_rpls_ids[] = {
> > INTEL_RPLS_IDS(0),
> > };
> > @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct
> drm_i915_private *i915)
> > } else if (find_devid(devid, subplatform_portf_ids,
> > ARRAY_SIZE(subplatform_portf_ids))) {
> > mask = BIT(INTEL_SUBPLATFORM_PORTF);
> > + } else if (find_devid(devid, subplatform_n_ids,
> > + ARRAY_SIZE(subplatform_n_ids))) {
> > + mask = BIT(INTEL_SUBPLATFORM_N);
> > } else if (find_devid(devid, subplatform_rpls_ids,
> > ARRAY_SIZE(subplatform_rpls_ids))) {
> > mask = BIT(INTEL_SUBPLATFORM_RPL_S); diff --git
> > a/drivers/gpu/drm/i915/intel_device_info.h
> > b/drivers/gpu/drm/i915/intel_device_info.h
> > index 213ae2c07126..e341d90f28a2 100644
> > --- a/drivers/gpu/drm/i915/intel_device_info.h
> > +++ b/drivers/gpu/drm/i915/intel_device_info.h
> > @@ -113,6 +113,9 @@ enum intel_platform {
> > /* ADL-S */
> > #define INTEL_SUBPLATFORM_RPL_S 0
> >
> > +/* ADL-P */
> > +#define INTEL_SUBPLATFORM_N 0
> > +
> > enum intel_ppgtt_type {
> > INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
> > INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING, diff --git
> > a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index
> > baf3d1d3d566..533890dc9da1 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -666,6 +666,12 @@
> > INTEL_VGA_DEVICE(0x46C2, info), \
> > INTEL_VGA_DEVICE(0x46C3, info)
> >
> > +/* ADL-N */
> > +#define INTEL_ADLN_IDS(info) \
> > + INTEL_VGA_DEVICE(0x46D0, info), \
> > + INTEL_VGA_DEVICE(0x46D1, info), \
> > + INTEL_VGA_DEVICE(0x46D2, info)
> > +
> > /* RPL-S */
> > #define INTEL_RPLS_IDS(info) \
> > INTEL_VGA_DEVICE(0xA780, info), \
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-10 5:18 [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform Tejas Upadhyay
@ 2021-12-17 13:27 ` Jani Nikula
2021-12-10 12:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/adl-n: Enable ADL-N platform (rev3) Patchwork
` (5 subsequent siblings)
6 siblings, 0 replies; 22+ messages in thread
From: Jani Nikula @ 2021-12-17 13:27 UTC (permalink / raw)
To: Tejas Upadhyay, intel-gfx
Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
Bjorn Helgaas, x86, linux-pci
On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
> Adding PCI device ids and enabling ADL-N platform.
> ADL-N from i915 point of view is subplatform of ADL-P.
>
> BSpec: 68397
>
> Changes since V2:
> - Added version log history
> Changes since V1:
> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc: x86 maintainers & lists
Ack for merging the arch/x86/kernel/early-quirks.c PCI ID update via
drm-intel?
I note not all such changes in git log have your acks recorded, though
most do. Do you want us to be more careful about Cc'ing you for acks on
PCI ID changes every time going forward?
BR,
Jani.
> ---
> arch/x86/kernel/early-quirks.c | 1 +
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> include/drm/i915_pciids.h | 6 ++++++
> 6 files changed, 20 insertions(+)
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index fd2d3ab38ebb..1ca3a56fdc2d 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_RKL_IDS(&gen11_early_ops),
> INTEL_ADLS_IDS(&gen11_early_ops),
> INTEL_ADLP_IDS(&gen11_early_ops),
> + INTEL_ADLN_IDS(&gen11_early_ops),
> INTEL_RPLS_IDS(&gen11_early_ops),
> };
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index a0f54a69b11d..b2ec85a3e40a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
> IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
> #define IS_ADLS_RPLS(dev_priv) \
> IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL_S)
> +#define IS_ADLP_N(dev_priv) \
> + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P, INTEL_SUBPLATFORM_N)
> #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> (INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
> #define IS_BDW_ULT(dev_priv) \
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 708a23415e9c..6a19e9da53cc 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
> INTEL_RKL_IDS(&rkl_info),
> INTEL_ADLS_IDS(&adl_s_info),
> INTEL_ADLP_IDS(&adl_p_info),
> + INTEL_ADLN_IDS(&adl_p_info),
> INTEL_DG1_IDS(&dg1_info),
> INTEL_RPLS_IDS(&adl_s_info),
> {0, 0, 0}
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a3446a2abcb2..54944d87cd3c 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
> INTEL_ICL_PORT_F_IDS(0),
> };
>
> +static const u16 subplatform_n_ids[] = {
> + INTEL_ADLN_IDS(0),
> +};
> +
> static const u16 subplatform_rpls_ids[] = {
> INTEL_RPLS_IDS(0),
> };
> @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
> } else if (find_devid(devid, subplatform_portf_ids,
> ARRAY_SIZE(subplatform_portf_ids))) {
> mask = BIT(INTEL_SUBPLATFORM_PORTF);
> + } else if (find_devid(devid, subplatform_n_ids,
> + ARRAY_SIZE(subplatform_n_ids))) {
> + mask = BIT(INTEL_SUBPLATFORM_N);
> } else if (find_devid(devid, subplatform_rpls_ids,
> ARRAY_SIZE(subplatform_rpls_ids))) {
> mask = BIT(INTEL_SUBPLATFORM_RPL_S);
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index 213ae2c07126..e341d90f28a2 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -113,6 +113,9 @@ enum intel_platform {
> /* ADL-S */
> #define INTEL_SUBPLATFORM_RPL_S 0
>
> +/* ADL-P */
> +#define INTEL_SUBPLATFORM_N 0
> +
> enum intel_ppgtt_type {
> INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
> INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING,
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index baf3d1d3d566..533890dc9da1 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -666,6 +666,12 @@
> INTEL_VGA_DEVICE(0x46C2, info), \
> INTEL_VGA_DEVICE(0x46C3, info)
>
> +/* ADL-N */
> +#define INTEL_ADLN_IDS(info) \
> + INTEL_VGA_DEVICE(0x46D0, info), \
> + INTEL_VGA_DEVICE(0x46D1, info), \
> + INTEL_VGA_DEVICE(0x46D2, info)
> +
> /* RPL-S */
> #define INTEL_RPLS_IDS(info) \
> INTEL_VGA_DEVICE(0xA780, info), \
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
@ 2021-12-17 13:27 ` Jani Nikula
0 siblings, 0 replies; 22+ messages in thread
From: Jani Nikula @ 2021-12-17 13:27 UTC (permalink / raw)
To: Tejas Upadhyay, intel-gfx
Cc: x86, linux-pci, Dave Hansen, Ingo Molnar, Borislav Petkov,
Bjorn Helgaas, Thomas Gleixner
On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
> Adding PCI device ids and enabling ADL-N platform.
> ADL-N from i915 point of view is subplatform of ADL-P.
>
> BSpec: 68397
>
> Changes since V2:
> - Added version log history
> Changes since V1:
> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc: x86 maintainers & lists
Ack for merging the arch/x86/kernel/early-quirks.c PCI ID update via
drm-intel?
I note not all such changes in git log have your acks recorded, though
most do. Do you want us to be more careful about Cc'ing you for acks on
PCI ID changes every time going forward?
BR,
Jani.
> ---
> arch/x86/kernel/early-quirks.c | 1 +
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> include/drm/i915_pciids.h | 6 ++++++
> 6 files changed, 20 insertions(+)
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index fd2d3ab38ebb..1ca3a56fdc2d 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_RKL_IDS(&gen11_early_ops),
> INTEL_ADLS_IDS(&gen11_early_ops),
> INTEL_ADLP_IDS(&gen11_early_ops),
> + INTEL_ADLN_IDS(&gen11_early_ops),
> INTEL_RPLS_IDS(&gen11_early_ops),
> };
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index a0f54a69b11d..b2ec85a3e40a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
> IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
> #define IS_ADLS_RPLS(dev_priv) \
> IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL_S)
> +#define IS_ADLP_N(dev_priv) \
> + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P, INTEL_SUBPLATFORM_N)
> #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> (INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
> #define IS_BDW_ULT(dev_priv) \
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 708a23415e9c..6a19e9da53cc 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
> INTEL_RKL_IDS(&rkl_info),
> INTEL_ADLS_IDS(&adl_s_info),
> INTEL_ADLP_IDS(&adl_p_info),
> + INTEL_ADLN_IDS(&adl_p_info),
> INTEL_DG1_IDS(&dg1_info),
> INTEL_RPLS_IDS(&adl_s_info),
> {0, 0, 0}
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a3446a2abcb2..54944d87cd3c 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
> INTEL_ICL_PORT_F_IDS(0),
> };
>
> +static const u16 subplatform_n_ids[] = {
> + INTEL_ADLN_IDS(0),
> +};
> +
> static const u16 subplatform_rpls_ids[] = {
> INTEL_RPLS_IDS(0),
> };
> @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
> } else if (find_devid(devid, subplatform_portf_ids,
> ARRAY_SIZE(subplatform_portf_ids))) {
> mask = BIT(INTEL_SUBPLATFORM_PORTF);
> + } else if (find_devid(devid, subplatform_n_ids,
> + ARRAY_SIZE(subplatform_n_ids))) {
> + mask = BIT(INTEL_SUBPLATFORM_N);
> } else if (find_devid(devid, subplatform_rpls_ids,
> ARRAY_SIZE(subplatform_rpls_ids))) {
> mask = BIT(INTEL_SUBPLATFORM_RPL_S);
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index 213ae2c07126..e341d90f28a2 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -113,6 +113,9 @@ enum intel_platform {
> /* ADL-S */
> #define INTEL_SUBPLATFORM_RPL_S 0
>
> +/* ADL-P */
> +#define INTEL_SUBPLATFORM_N 0
> +
> enum intel_ppgtt_type {
> INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
> INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING,
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index baf3d1d3d566..533890dc9da1 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -666,6 +666,12 @@
> INTEL_VGA_DEVICE(0x46C2, info), \
> INTEL_VGA_DEVICE(0x46C3, info)
>
> +/* ADL-N */
> +#define INTEL_ADLN_IDS(info) \
> + INTEL_VGA_DEVICE(0x46D0, info), \
> + INTEL_VGA_DEVICE(0x46D1, info), \
> + INTEL_VGA_DEVICE(0x46D2, info)
> +
> /* RPL-S */
> #define INTEL_RPLS_IDS(info) \
> INTEL_VGA_DEVICE(0xA780, info), \
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-17 13:27 ` Jani Nikula
@ 2021-12-18 9:31 ` Thomas Gleixner
-1 siblings, 0 replies; 22+ messages in thread
From: Thomas Gleixner @ 2021-12-18 9:31 UTC (permalink / raw)
To: Jani Nikula, Tejas Upadhyay, intel-gfx
Cc: Ingo Molnar, Borislav Petkov, Dave Hansen, Bjorn Helgaas, x86, linux-pci
On Fri, Dec 17 2021 at 15:27, Jani Nikula wrote:
> On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>> Adding PCI device ids and enabling ADL-N platform.
>> ADL-N from i915 point of view is subplatform of ADL-P.
>>
>> BSpec: 68397
>>
>> Changes since V2:
>> - Added version log history
>> Changes since V1:
>> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>>
>> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
>
> Cc: x86 maintainers & lists
>
> Ack for merging the arch/x86/kernel/early-quirks.c PCI ID update via
> drm-intel?
Acked-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
@ 2021-12-18 9:31 ` Thomas Gleixner
0 siblings, 0 replies; 22+ messages in thread
From: Thomas Gleixner @ 2021-12-18 9:31 UTC (permalink / raw)
To: Jani Nikula, Tejas Upadhyay, intel-gfx
Cc: x86, linux-pci, Dave Hansen, Ingo Molnar, Borislav Petkov, Bjorn Helgaas
On Fri, Dec 17 2021 at 15:27, Jani Nikula wrote:
> On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>> Adding PCI device ids and enabling ADL-N platform.
>> ADL-N from i915 point of view is subplatform of ADL-P.
>>
>> BSpec: 68397
>>
>> Changes since V2:
>> - Added version log history
>> Changes since V1:
>> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>>
>> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
>
> Cc: x86 maintainers & lists
>
> Ack for merging the arch/x86/kernel/early-quirks.c PCI ID update via
> drm-intel?
Acked-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-18 9:31 ` Thomas Gleixner
@ 2021-12-22 8:17 ` Jani Nikula
-1 siblings, 0 replies; 22+ messages in thread
From: Jani Nikula @ 2021-12-22 8:17 UTC (permalink / raw)
To: Thomas Gleixner, Tejas Upadhyay, intel-gfx
Cc: Ingo Molnar, Borislav Petkov, Dave Hansen, Bjorn Helgaas, x86, linux-pci
On Sat, 18 Dec 2021, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, Dec 17 2021 at 15:27, Jani Nikula wrote:
>> On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>>> Adding PCI device ids and enabling ADL-N platform.
>>> ADL-N from i915 point of view is subplatform of ADL-P.
>>>
>>> BSpec: 68397
>>>
>>> Changes since V2:
>>> - Added version log history
>>> Changes since V1:
>>> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>>>
>>> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
>>
>> Cc: x86 maintainers & lists
>>
>> Ack for merging the arch/x86/kernel/early-quirks.c PCI ID update via
>> drm-intel?
>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
Thanks, pushed to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
@ 2021-12-22 8:17 ` Jani Nikula
0 siblings, 0 replies; 22+ messages in thread
From: Jani Nikula @ 2021-12-22 8:17 UTC (permalink / raw)
To: Thomas Gleixner, Tejas Upadhyay, intel-gfx
Cc: x86, linux-pci, Dave Hansen, Ingo Molnar, Borislav Petkov, Bjorn Helgaas
On Sat, 18 Dec 2021, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, Dec 17 2021 at 15:27, Jani Nikula wrote:
>> On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>>> Adding PCI device ids and enabling ADL-N platform.
>>> ADL-N from i915 point of view is subplatform of ADL-P.
>>>
>>> BSpec: 68397
>>>
>>> Changes since V2:
>>> - Added version log history
>>> Changes since V1:
>>> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>>>
>>> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
>>
>> Cc: x86 maintainers & lists
>>
>> Ack for merging the arch/x86/kernel/early-quirks.c PCI ID update via
>> drm-intel?
>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
Thanks, pushed to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-17 13:27 ` Jani Nikula
@ 2021-12-19 8:49 ` Lucas De Marchi
-1 siblings, 0 replies; 22+ messages in thread
From: Lucas De Marchi @ 2021-12-19 8:49 UTC (permalink / raw)
To: Jani Nikula
Cc: Tejas Upadhyay, intel-gfx, x86, linux-pci, Dave Hansen,
Ingo Molnar, Borislav Petkov, Bjorn Helgaas, Thomas Gleixner
On Fri, Dec 17, 2021 at 03:27:57PM +0200, Jani Nikula wrote:
>On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>> Adding PCI device ids and enabling ADL-N platform.
>> ADL-N from i915 point of view is subplatform of ADL-P.
>>
>> BSpec: 68397
>>
>> Changes since V2:
>> - Added version log history
>> Changes since V1:
>> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>>
>> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
>
>Cc: x86 maintainers & lists
>
>Ack for merging the arch/x86/kernel/early-quirks.c PCI ID update via
>drm-intel?
>
>I note not all such changes in git log have your acks recorded, though
>most do. Do you want us to be more careful about Cc'ing you for acks on
>PCI ID changes every time going forward?
That's what Borislav asked in
https://lore.kernel.org/all/20200520093025.GD1457@zn.tnic/
Lucas De Marchi
>
>BR,
>Jani.
>
>
>> ---
>> arch/x86/kernel/early-quirks.c | 1 +
>> drivers/gpu/drm/i915/i915_drv.h | 2 ++
>> drivers/gpu/drm/i915/i915_pci.c | 1 +
>> drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
>> drivers/gpu/drm/i915/intel_device_info.h | 3 +++
>> include/drm/i915_pciids.h | 6 ++++++
>> 6 files changed, 20 insertions(+)
>>
>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>> index fd2d3ab38ebb..1ca3a56fdc2d 100644
>> --- a/arch/x86/kernel/early-quirks.c
>> +++ b/arch/x86/kernel/early-quirks.c
>> @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>> INTEL_RKL_IDS(&gen11_early_ops),
>> INTEL_ADLS_IDS(&gen11_early_ops),
>> INTEL_ADLP_IDS(&gen11_early_ops),
>> + INTEL_ADLN_IDS(&gen11_early_ops),
>> INTEL_RPLS_IDS(&gen11_early_ops),
>> };
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index a0f54a69b11d..b2ec85a3e40a 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
>> IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
>> #define IS_ADLS_RPLS(dev_priv) \
>> IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL_S)
>> +#define IS_ADLP_N(dev_priv) \
>> + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P, INTEL_SUBPLATFORM_N)
>> #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
>> (INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
>> #define IS_BDW_ULT(dev_priv) \
>> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
>> index 708a23415e9c..6a19e9da53cc 100644
>> --- a/drivers/gpu/drm/i915/i915_pci.c
>> +++ b/drivers/gpu/drm/i915/i915_pci.c
>> @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
>> INTEL_RKL_IDS(&rkl_info),
>> INTEL_ADLS_IDS(&adl_s_info),
>> INTEL_ADLP_IDS(&adl_p_info),
>> + INTEL_ADLN_IDS(&adl_p_info),
>> INTEL_DG1_IDS(&dg1_info),
>> INTEL_RPLS_IDS(&adl_s_info),
>> {0, 0, 0}
>> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
>> index a3446a2abcb2..54944d87cd3c 100644
>> --- a/drivers/gpu/drm/i915/intel_device_info.c
>> +++ b/drivers/gpu/drm/i915/intel_device_info.c
>> @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
>> INTEL_ICL_PORT_F_IDS(0),
>> };
>>
>> +static const u16 subplatform_n_ids[] = {
>> + INTEL_ADLN_IDS(0),
>> +};
>> +
>> static const u16 subplatform_rpls_ids[] = {
>> INTEL_RPLS_IDS(0),
>> };
>> @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
>> } else if (find_devid(devid, subplatform_portf_ids,
>> ARRAY_SIZE(subplatform_portf_ids))) {
>> mask = BIT(INTEL_SUBPLATFORM_PORTF);
>> + } else if (find_devid(devid, subplatform_n_ids,
>> + ARRAY_SIZE(subplatform_n_ids))) {
>> + mask = BIT(INTEL_SUBPLATFORM_N);
>> } else if (find_devid(devid, subplatform_rpls_ids,
>> ARRAY_SIZE(subplatform_rpls_ids))) {
>> mask = BIT(INTEL_SUBPLATFORM_RPL_S);
>> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
>> index 213ae2c07126..e341d90f28a2 100644
>> --- a/drivers/gpu/drm/i915/intel_device_info.h
>> +++ b/drivers/gpu/drm/i915/intel_device_info.h
>> @@ -113,6 +113,9 @@ enum intel_platform {
>> /* ADL-S */
>> #define INTEL_SUBPLATFORM_RPL_S 0
>>
>> +/* ADL-P */
>> +#define INTEL_SUBPLATFORM_N 0
>> +
>> enum intel_ppgtt_type {
>> INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
>> INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING,
>> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
>> index baf3d1d3d566..533890dc9da1 100644
>> --- a/include/drm/i915_pciids.h
>> +++ b/include/drm/i915_pciids.h
>> @@ -666,6 +666,12 @@
>> INTEL_VGA_DEVICE(0x46C2, info), \
>> INTEL_VGA_DEVICE(0x46C3, info)
>>
>> +/* ADL-N */
>> +#define INTEL_ADLN_IDS(info) \
>> + INTEL_VGA_DEVICE(0x46D0, info), \
>> + INTEL_VGA_DEVICE(0x46D1, info), \
>> + INTEL_VGA_DEVICE(0x46D2, info)
>> +
>> /* RPL-S */
>> #define INTEL_RPLS_IDS(info) \
>> INTEL_VGA_DEVICE(0xA780, info), \
>
>--
>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
@ 2021-12-19 8:49 ` Lucas De Marchi
0 siblings, 0 replies; 22+ messages in thread
From: Lucas De Marchi @ 2021-12-19 8:49 UTC (permalink / raw)
To: Jani Nikula
Cc: x86, linux-pci, intel-gfx, Dave Hansen, Ingo Molnar,
Borislav Petkov, Bjorn Helgaas, Thomas Gleixner
On Fri, Dec 17, 2021 at 03:27:57PM +0200, Jani Nikula wrote:
>On Fri, 10 Dec 2021, Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>> Adding PCI device ids and enabling ADL-N platform.
>> ADL-N from i915 point of view is subplatform of ADL-P.
>>
>> BSpec: 68397
>>
>> Changes since V2:
>> - Added version log history
>> Changes since V1:
>> - replace IS_ALDERLAKE_N with IS_ADLP_N - Jani Nikula
>>
>> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
>
>Cc: x86 maintainers & lists
>
>Ack for merging the arch/x86/kernel/early-quirks.c PCI ID update via
>drm-intel?
>
>I note not all such changes in git log have your acks recorded, though
>most do. Do you want us to be more careful about Cc'ing you for acks on
>PCI ID changes every time going forward?
That's what Borislav asked in
https://lore.kernel.org/all/20200520093025.GD1457@zn.tnic/
Lucas De Marchi
>
>BR,
>Jani.
>
>
>> ---
>> arch/x86/kernel/early-quirks.c | 1 +
>> drivers/gpu/drm/i915/i915_drv.h | 2 ++
>> drivers/gpu/drm/i915/i915_pci.c | 1 +
>> drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
>> drivers/gpu/drm/i915/intel_device_info.h | 3 +++
>> include/drm/i915_pciids.h | 6 ++++++
>> 6 files changed, 20 insertions(+)
>>
>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>> index fd2d3ab38ebb..1ca3a56fdc2d 100644
>> --- a/arch/x86/kernel/early-quirks.c
>> +++ b/arch/x86/kernel/early-quirks.c
>> @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>> INTEL_RKL_IDS(&gen11_early_ops),
>> INTEL_ADLS_IDS(&gen11_early_ops),
>> INTEL_ADLP_IDS(&gen11_early_ops),
>> + INTEL_ADLN_IDS(&gen11_early_ops),
>> INTEL_RPLS_IDS(&gen11_early_ops),
>> };
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index a0f54a69b11d..b2ec85a3e40a 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1283,6 +1283,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
>> IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
>> #define IS_ADLS_RPLS(dev_priv) \
>> IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL_S)
>> +#define IS_ADLP_N(dev_priv) \
>> + IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_P, INTEL_SUBPLATFORM_N)
>> #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
>> (INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
>> #define IS_BDW_ULT(dev_priv) \
>> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
>> index 708a23415e9c..6a19e9da53cc 100644
>> --- a/drivers/gpu/drm/i915/i915_pci.c
>> +++ b/drivers/gpu/drm/i915/i915_pci.c
>> @@ -1132,6 +1132,7 @@ static const struct pci_device_id pciidlist[] = {
>> INTEL_RKL_IDS(&rkl_info),
>> INTEL_ADLS_IDS(&adl_s_info),
>> INTEL_ADLP_IDS(&adl_p_info),
>> + INTEL_ADLN_IDS(&adl_p_info),
>> INTEL_DG1_IDS(&dg1_info),
>> INTEL_RPLS_IDS(&adl_s_info),
>> {0, 0, 0}
>> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
>> index a3446a2abcb2..54944d87cd3c 100644
>> --- a/drivers/gpu/drm/i915/intel_device_info.c
>> +++ b/drivers/gpu/drm/i915/intel_device_info.c
>> @@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
>> INTEL_ICL_PORT_F_IDS(0),
>> };
>>
>> +static const u16 subplatform_n_ids[] = {
>> + INTEL_ADLN_IDS(0),
>> +};
>> +
>> static const u16 subplatform_rpls_ids[] = {
>> INTEL_RPLS_IDS(0),
>> };
>> @@ -210,6 +214,9 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
>> } else if (find_devid(devid, subplatform_portf_ids,
>> ARRAY_SIZE(subplatform_portf_ids))) {
>> mask = BIT(INTEL_SUBPLATFORM_PORTF);
>> + } else if (find_devid(devid, subplatform_n_ids,
>> + ARRAY_SIZE(subplatform_n_ids))) {
>> + mask = BIT(INTEL_SUBPLATFORM_N);
>> } else if (find_devid(devid, subplatform_rpls_ids,
>> ARRAY_SIZE(subplatform_rpls_ids))) {
>> mask = BIT(INTEL_SUBPLATFORM_RPL_S);
>> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
>> index 213ae2c07126..e341d90f28a2 100644
>> --- a/drivers/gpu/drm/i915/intel_device_info.h
>> +++ b/drivers/gpu/drm/i915/intel_device_info.h
>> @@ -113,6 +113,9 @@ enum intel_platform {
>> /* ADL-S */
>> #define INTEL_SUBPLATFORM_RPL_S 0
>>
>> +/* ADL-P */
>> +#define INTEL_SUBPLATFORM_N 0
>> +
>> enum intel_ppgtt_type {
>> INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
>> INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING,
>> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
>> index baf3d1d3d566..533890dc9da1 100644
>> --- a/include/drm/i915_pciids.h
>> +++ b/include/drm/i915_pciids.h
>> @@ -666,6 +666,12 @@
>> INTEL_VGA_DEVICE(0x46C2, info), \
>> INTEL_VGA_DEVICE(0x46C3, info)
>>
>> +/* ADL-N */
>> +#define INTEL_ADLN_IDS(info) \
>> + INTEL_VGA_DEVICE(0x46D0, info), \
>> + INTEL_VGA_DEVICE(0x46D1, info), \
>> + INTEL_VGA_DEVICE(0x46D2, info)
>> +
>> /* RPL-S */
>> #define INTEL_RPLS_IDS(info) \
>> INTEL_VGA_DEVICE(0xA780, info), \
>
>--
>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-19 8:49 ` Lucas De Marchi
@ 2021-12-20 11:33 ` Borislav Petkov
-1 siblings, 0 replies; 22+ messages in thread
From: Borislav Petkov @ 2021-12-20 11:33 UTC (permalink / raw)
To: Lucas De Marchi
Cc: Jani Nikula, Tejas Upadhyay, intel-gfx, x86, linux-pci,
Dave Hansen, Ingo Molnar, Bjorn Helgaas, Thomas Gleixner
On Sun, Dec 19, 2021 at 12:49:21AM -0800, Lucas De Marchi wrote:
> > I note not all such changes in git log have your acks recorded, though
> > most do. Do you want us to be more careful about Cc'ing you for acks on
> > PCI ID changes every time going forward?
>
> That's what Borislav asked in
> https://lore.kernel.org/all/20200520093025.GD1457@zn.tnic/
Right, I guess in the interest of not holding you guys up, if the patch
is only a trivial oneliner like below adding a GPU generation to the
list of quirks, you can only Cc x86@kernel.org so that we're aware and
proceed with it further without our ACK.
More involved stuff would need normal review, ofc.
Thx.
> > > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> > > index fd2d3ab38ebb..1ca3a56fdc2d 100644
> > > --- a/arch/x86/kernel/early-quirks.c
> > > +++ b/arch/x86/kernel/early-quirks.c
> > > @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> > > INTEL_RKL_IDS(&gen11_early_ops),
> > > INTEL_ADLS_IDS(&gen11_early_ops),
> > > INTEL_ADLP_IDS(&gen11_early_ops),
> > > + INTEL_ADLN_IDS(&gen11_early_ops),
> > > INTEL_RPLS_IDS(&gen11_early_ops),
> > > };
> > >
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
@ 2021-12-20 11:33 ` Borislav Petkov
0 siblings, 0 replies; 22+ messages in thread
From: Borislav Petkov @ 2021-12-20 11:33 UTC (permalink / raw)
To: Lucas De Marchi
Cc: x86, linux-pci, intel-gfx, Dave Hansen, Ingo Molnar,
Bjorn Helgaas, Thomas Gleixner
On Sun, Dec 19, 2021 at 12:49:21AM -0800, Lucas De Marchi wrote:
> > I note not all such changes in git log have your acks recorded, though
> > most do. Do you want us to be more careful about Cc'ing you for acks on
> > PCI ID changes every time going forward?
>
> That's what Borislav asked in
> https://lore.kernel.org/all/20200520093025.GD1457@zn.tnic/
Right, I guess in the interest of not holding you guys up, if the patch
is only a trivial oneliner like below adding a GPU generation to the
list of quirks, you can only Cc x86@kernel.org so that we're aware and
proceed with it further without our ACK.
More involved stuff would need normal review, ofc.
Thx.
> > > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> > > index fd2d3ab38ebb..1ca3a56fdc2d 100644
> > > --- a/arch/x86/kernel/early-quirks.c
> > > +++ b/arch/x86/kernel/early-quirks.c
> > > @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> > > INTEL_RKL_IDS(&gen11_early_ops),
> > > INTEL_ADLS_IDS(&gen11_early_ops),
> > > INTEL_ADLP_IDS(&gen11_early_ops),
> > > + INTEL_ADLN_IDS(&gen11_early_ops),
> > > INTEL_RPLS_IDS(&gen11_early_ops),
> > > };
> > >
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
2021-12-20 11:33 ` Borislav Petkov
@ 2021-12-22 8:18 ` Jani Nikula
-1 siblings, 0 replies; 22+ messages in thread
From: Jani Nikula @ 2021-12-22 8:18 UTC (permalink / raw)
To: Borislav Petkov, Lucas De Marchi
Cc: Tejas Upadhyay, intel-gfx, x86, linux-pci, Dave Hansen,
Ingo Molnar, Bjorn Helgaas, Thomas Gleixner
On Mon, 20 Dec 2021, Borislav Petkov <bp@alien8.de> wrote:
> On Sun, Dec 19, 2021 at 12:49:21AM -0800, Lucas De Marchi wrote:
>> > I note not all such changes in git log have your acks recorded, though
>> > most do. Do you want us to be more careful about Cc'ing you for acks on
>> > PCI ID changes every time going forward?
>>
>> That's what Borislav asked in
>> https://lore.kernel.org/all/20200520093025.GD1457@zn.tnic/
>
> Right, I guess in the interest of not holding you guys up, if the patch
> is only a trivial oneliner like below adding a GPU generation to the
> list of quirks, you can only Cc x86@kernel.org so that we're aware and
> proceed with it further without our ACK.
>
> More involved stuff would need normal review, ofc.
Thanks, seems fair.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform
@ 2021-12-22 8:18 ` Jani Nikula
0 siblings, 0 replies; 22+ messages in thread
From: Jani Nikula @ 2021-12-22 8:18 UTC (permalink / raw)
To: Borislav Petkov, Lucas De Marchi
Cc: x86, linux-pci, intel-gfx, Dave Hansen, Ingo Molnar,
Bjorn Helgaas, Thomas Gleixner
On Mon, 20 Dec 2021, Borislav Petkov <bp@alien8.de> wrote:
> On Sun, Dec 19, 2021 at 12:49:21AM -0800, Lucas De Marchi wrote:
>> > I note not all such changes in git log have your acks recorded, though
>> > most do. Do you want us to be more careful about Cc'ing you for acks on
>> > PCI ID changes every time going forward?
>>
>> That's what Borislav asked in
>> https://lore.kernel.org/all/20200520093025.GD1457@zn.tnic/
>
> Right, I guess in the interest of not holding you guys up, if the patch
> is only a trivial oneliner like below adding a GPU generation to the
> list of quirks, you can only Cc x86@kernel.org so that we're aware and
> proceed with it further without our ACK.
>
> More involved stuff would need normal review, ofc.
Thanks, seems fair.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 22+ messages in thread