All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libjson: fix build with gcc 11
@ 2021-08-01 22:00 Fabrice Fontaine
  2021-08-03 15:49 ` Arnout Vandecappelle
  2021-08-08  7:41 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-08-01 22:00 UTC (permalink / raw)
  To: buildroot; +Cc: Simon Dawson, Fabrice Fontaine

Fix the following build failure with gcc 11:

In file included from _internal/Source/JSONDefs.h:12,
                 from _internal/Source/JSONDebug.h:4,
                 from _internal/Source/JSONNode.h:4,
                 from _internal/Source/JSONNode.cpp:1:
_internal/Source/JSONDefs/GNU_C.h:58:28: error: ISO C++17 does not allow dynamic exception specifications
   58 |     #define json_throws(x) throw(x)
      |                            ^~~~~

Fixes:
 - http://autobuild.buildroot.org/results/1e66dff705bbb38e7e0f0e5864ce794b4345dcc6

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libjson/libjson.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libjson/libjson.mk b/package/libjson/libjson.mk
index d04ddc40f3..73268c9ccf 100644
--- a/package/libjson/libjson.mk
+++ b/package/libjson/libjson.mk
@@ -11,7 +11,7 @@ LIBJSON_INSTALL_STAGING = YES
 LIBJSON_LICENSE = BSD-2-Clause
 LIBJSON_LICENSE_FILES = License.txt
 
-LIBJSON_CXXFLAGS = $(TARGET_CFLAGS) -DNDEBUG
+LIBJSON_CXXFLAGS = $(TARGET_CFLAGS) -DNDEBUG -std=c++11
 
 ifeq ($(BR2_STATIC_LIBS),y)
 LIBJSON_MAKE_OPTS += SHARED=0
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libjson: fix build with gcc 11
  2021-08-01 22:00 [Buildroot] [PATCH 1/1] package/libjson: fix build with gcc 11 Fabrice Fontaine
@ 2021-08-03 15:49 ` Arnout Vandecappelle
  2021-08-08  7:41 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2021-08-03 15:49 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Simon Dawson



On 02/08/2021 00:00, Fabrice Fontaine wrote:
> Fix the following build failure with gcc 11:

 I've added "GCC 11 defaults to C++17." here, which is the real problem and
which nicely explains why -std=c++11 is the solution. It's all more or less
implied by the error message, but making it explicit is better.


 Applied to master, thanks.

 Regards,
 Arnout



> 
> In file included from _internal/Source/JSONDefs.h:12,
>                  from _internal/Source/JSONDebug.h:4,
>                  from _internal/Source/JSONNode.h:4,
>                  from _internal/Source/JSONNode.cpp:1:
> _internal/Source/JSONDefs/GNU_C.h:58:28: error: ISO C++17 does not allow dynamic exception specifications
>    58 |     #define json_throws(x) throw(x)
>       |                            ^~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/1e66dff705bbb38e7e0f0e5864ce794b4345dcc6
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libjson/libjson.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libjson/libjson.mk b/package/libjson/libjson.mk
> index d04ddc40f3..73268c9ccf 100644
> --- a/package/libjson/libjson.mk
> +++ b/package/libjson/libjson.mk
> @@ -11,7 +11,7 @@ LIBJSON_INSTALL_STAGING = YES
>  LIBJSON_LICENSE = BSD-2-Clause
>  LIBJSON_LICENSE_FILES = License.txt
>  
> -LIBJSON_CXXFLAGS = $(TARGET_CFLAGS) -DNDEBUG
> +LIBJSON_CXXFLAGS = $(TARGET_CFLAGS) -DNDEBUG -std=c++11
>  
>  ifeq ($(BR2_STATIC_LIBS),y)
>  LIBJSON_MAKE_OPTS += SHARED=0
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libjson: fix build with gcc 11
  2021-08-01 22:00 [Buildroot] [PATCH 1/1] package/libjson: fix build with gcc 11 Fabrice Fontaine
  2021-08-03 15:49 ` Arnout Vandecappelle
@ 2021-08-08  7:41 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-08-08  7:41 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Simon Dawson, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure with gcc 11:
 > In file included from _internal/Source/JSONDefs.h:12,
 >                  from _internal/Source/JSONDebug.h:4,
 >                  from _internal/Source/JSONNode.h:4,
 >                  from _internal/Source/JSONNode.cpp:1:
 > _internal/Source/JSONDefs/GNU_C.h:58:28: error: ISO C++17 does not allow dynamic exception specifications
 >    58 |     #define json_throws(x) throw(x)
 >       |                            ^~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/1e66dff705bbb38e7e0f0e5864ce794b4345dcc6

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-08  7:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-01 22:00 [Buildroot] [PATCH 1/1] package/libjson: fix build with gcc 11 Fabrice Fontaine
2021-08-03 15:49 ` Arnout Vandecappelle
2021-08-08  7:41 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.