* [PATCH] mac80211: include <linux/rbtree.h>
@ 2021-07-15 16:02 Johannes Berg
2021-07-19 12:31 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2021-07-15 16:02 UTC (permalink / raw)
To: linux-wireless; +Cc: Toke Høiland-Jørgensen, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
This is needed for the rbtree, and we shouldn't just rely
on it getting included somewhere implicitly. Include it
explicitly.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/mac80211/ieee80211_i.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 22549b95d1aa..1c14cecf9813 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -25,6 +25,7 @@
#include <linux/leds.h>
#include <linux/idr.h>
#include <linux/rhashtable.h>
+#include <linux/rbtree.h>
#include <net/ieee80211_radiotap.h>
#include <net/cfg80211.h>
#include <net/mac80211.h>
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mac80211: include <linux/rbtree.h>
2021-07-15 16:02 [PATCH] mac80211: include <linux/rbtree.h> Johannes Berg
@ 2021-07-19 12:31 ` Toke Høiland-Jørgensen
2021-07-19 12:34 ` Johannes Berg
0 siblings, 1 reply; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2021-07-19 12:31 UTC (permalink / raw)
To: Johannes Berg, linux-wireless; +Cc: Johannes Berg
Johannes Berg <johannes@sipsolutions.net> writes:
> From: Johannes Berg <johannes.berg@intel.com>
>
> This is needed for the rbtree, and we shouldn't just rely
> on it getting included somewhere implicitly. Include it
> explicitly.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Does this need a Fixes: tag?
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mac80211: include <linux/rbtree.h>
2021-07-19 12:31 ` Toke Høiland-Jørgensen
@ 2021-07-19 12:34 ` Johannes Berg
2021-07-19 12:39 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2021-07-19 12:34 UTC (permalink / raw)
To: Toke Høiland-Jørgensen, linux-wireless
On Mon, 2021-07-19 at 14:31 +0200, Toke Høiland-Jørgensen wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > This is needed for the rbtree, and we shouldn't just rely
> > on it getting included somewhere implicitly. Include it
> > explicitly.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>
> Does this need a Fixes: tag?
We seem to always get it implicitly in the current kernel, so I guess
not really necessary to backport or anything, I'd say no.
I just ran into it while preparing a new backports import to our
internal tree.
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mac80211: include <linux/rbtree.h>
2021-07-19 12:34 ` Johannes Berg
@ 2021-07-19 12:39 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2021-07-19 12:39 UTC (permalink / raw)
To: Johannes Berg, linux-wireless
Johannes Berg <johannes@sipsolutions.net> writes:
> On Mon, 2021-07-19 at 14:31 +0200, Toke Høiland-Jørgensen wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>> > From: Johannes Berg <johannes.berg@intel.com>
>> >
>> > This is needed for the rbtree, and we shouldn't just rely
>> > on it getting included somewhere implicitly. Include it
>> > explicitly.
>> >
>> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>
>> Does this need a Fixes: tag?
>
> We seem to always get it implicitly in the current kernel, so I guess
> not really necessary to backport or anything, I'd say no.
>
> I just ran into it while preparing a new backports import to our
> internal tree.
Alright, fair enough :)
-Toke
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-19 12:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 16:02 [PATCH] mac80211: include <linux/rbtree.h> Johannes Berg
2021-07-19 12:31 ` Toke Høiland-Jørgensen
2021-07-19 12:34 ` Johannes Berg
2021-07-19 12:39 ` Toke Høiland-Jørgensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.