From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Support Opensource <support.opensource@diasemi.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Heiko Stuebner <heiko@sntech.de>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic
Date: Tue, 06 Apr 2021 12:32:58 +0300 [thread overview]
Message-ID: <87tuojlpv9.fsf@intel.com> (raw)
In-Reply-To: <20210406073036.26857-1-u.kleine-koenig@pengutronix.de>
On Tue, 06 Apr 2021, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Given that lowlevel drivers usually cannot implement exactly what a
> consumer requests with pwm_apply_state() there is some rounding involved.
>
> pwm_get_state() traditionally returned the setting that was requested most
> recently by the consumer (opposed to what was actually implemented in
> hardware in reply to the last request). To make this semantic obvious
> rename the function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +--
Acked-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Support Opensource <support.opensource@diasemi.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Heiko Stuebner <heiko@sntech.de>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic
Date: Tue, 06 Apr 2021 12:32:58 +0300 [thread overview]
Message-ID: <87tuojlpv9.fsf@intel.com> (raw)
In-Reply-To: <20210406073036.26857-1-u.kleine-koenig@pengutronix.de>
On Tue, 06 Apr 2021, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Given that lowlevel drivers usually cannot implement exactly what a
> consumer requests with pwm_apply_state() there is some rounding involved.
>
> pwm_get_state() traditionally returned the setting that was requested most
> recently by the consumer (opposed to what was actually implemented in
> hardware in reply to the last request). To make this semantic obvious
> rename the function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +--
Acked-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-doc@vger.kernel.org, David Airlie <airlied@linux.ie>,
Michael Turquette <mturquette@baylibre.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Liam Girdwood <lgirdwood@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
linux-clk@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jonathan Corbet <corbet@lwn.net>, Chen-Yu Tsai <wens@csie.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-rockchip@lists.infradead.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-input@vger.kernel.org, intel-gfx@lists.freedesktop.org,
linux-pwm@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Maxime Ripard <mripard@kernel.org>,
Mark Brown <broonie@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Daniel Vetter <daniel@ffwll.ch>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
linux-arm-kernel@lists.infradead.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Support Opensource <support.opensource@diasemi.com>,
Stephen Boyd <sboyd@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic
Date: Tue, 06 Apr 2021 12:32:58 +0300 [thread overview]
Message-ID: <87tuojlpv9.fsf@intel.com> (raw)
In-Reply-To: <20210406073036.26857-1-u.kleine-koenig@pengutronix.de>
On Tue, 06 Apr 2021, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Given that lowlevel drivers usually cannot implement exactly what a
> consumer requests with pwm_apply_state() there is some rounding involved.
>
> pwm_get_state() traditionally returned the setting that was requested most
> recently by the consumer (opposed to what was actually implemented in
> hardware in reply to the last request). To make this semantic obvious
> rename the function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +--
Acked-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-doc@vger.kernel.org, David Airlie <airlied@linux.ie>,
Michael Turquette <mturquette@baylibre.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-clk@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jonathan Corbet <corbet@lwn.net>, Chen-Yu Tsai <wens@csie.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-rockchip@lists.infradead.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-input@vger.kernel.org, intel-gfx@lists.freedesktop.org,
linux-pwm@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Mark Brown <broonie@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
linux-arm-kernel@lists.infradead.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Support Opensource <support.opensource@diasemi.com>,
Stephen Boyd <sboyd@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic
Date: Tue, 06 Apr 2021 12:32:58 +0300 [thread overview]
Message-ID: <87tuojlpv9.fsf@intel.com> (raw)
In-Reply-To: <20210406073036.26857-1-u.kleine-koenig@pengutronix.de>
On Tue, 06 Apr 2021, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Given that lowlevel drivers usually cannot implement exactly what a
> consumer requests with pwm_apply_state() there is some rounding involved.
>
> pwm_get_state() traditionally returned the setting that was requested most
> recently by the consumer (opposed to what was actually implemented in
> hardware in reply to the last request). To make this semantic obvious
> rename the function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +--
Acked-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-doc@vger.kernel.org, David Airlie <airlied@linux.ie>,
Michael Turquette <mturquette@baylibre.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Liam Girdwood <lgirdwood@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
linux-clk@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jonathan Corbet <corbet@lwn.net>, Chen-Yu Tsai <wens@csie.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-rockchip@lists.infradead.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-input@vger.kernel.org, intel-gfx@lists.freedesktop.org,
linux-pwm@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Maxime Ripard <mripard@kernel.org>,
Mark Brown <broonie@kernel.org>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
linux-arm-kernel@lists.infradead.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Support Opensource <support.opensource@diasemi.com>,
Stephen Boyd <sboyd@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [Intel-gfx] [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic
Date: Tue, 06 Apr 2021 12:32:58 +0300 [thread overview]
Message-ID: <87tuojlpv9.fsf@intel.com> (raw)
In-Reply-To: <20210406073036.26857-1-u.kleine-koenig@pengutronix.de>
On Tue, 06 Apr 2021, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Given that lowlevel drivers usually cannot implement exactly what a
> consumer requests with pwm_apply_state() there is some rounding involved.
>
> pwm_get_state() traditionally returned the setting that was requested most
> recently by the consumer (opposed to what was actually implemented in
> hardware in reply to the last request). To make this semantic obvious
> rename the function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +--
Acked-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-06 9:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 7:30 [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic Uwe Kleine-König
2021-04-06 7:30 ` [Intel-gfx] " Uwe Kleine-König
2021-04-06 7:30 ` Uwe Kleine-König
2021-04-06 7:30 ` Uwe Kleine-König
2021-04-06 7:30 ` Uwe Kleine-König
2021-04-06 9:32 ` Jani Nikula [this message]
2021-04-06 9:32 ` [Intel-gfx] " Jani Nikula
2021-04-06 9:32 ` Jani Nikula
2021-04-06 9:32 ` Jani Nikula
2021-04-06 9:32 ` Jani Nikula
2021-04-06 11:16 ` Thierry Reding
2021-04-06 11:16 ` [Intel-gfx] " Thierry Reding
2021-04-06 11:16 ` Thierry Reding
2021-04-06 11:16 ` Thierry Reding
2021-04-06 11:16 ` Thierry Reding
2021-04-06 13:43 ` Uwe Kleine-König
2021-04-06 13:43 ` [Intel-gfx] " Uwe Kleine-König
2021-04-06 13:43 ` Uwe Kleine-König
2021-04-06 13:43 ` Uwe Kleine-König
2021-04-06 13:43 ` Uwe Kleine-König
2021-04-09 12:09 ` Thierry Reding
2021-04-09 12:09 ` [Intel-gfx] " Thierry Reding
2021-04-09 12:09 ` Thierry Reding
2021-04-09 12:09 ` Thierry Reding
2021-04-09 12:09 ` Thierry Reding
2021-04-06 11:43 ` Mark Brown
2021-04-06 11:43 ` [Intel-gfx] " Mark Brown
2021-04-06 11:43 ` Mark Brown
2021-04-06 11:43 ` Mark Brown
2021-04-06 11:43 ` Mark Brown
2021-04-06 12:30 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-06 12:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-06 13:22 ` [PATCH] " Roy Im
2021-04-06 13:22 ` [Intel-gfx] " Roy Im
2021-04-06 13:22 ` Roy Im
2021-04-06 13:22 ` Roy Im
2021-04-06 13:22 ` Roy Im
2021-04-06 14:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuojlpv9.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrice.gasnier@st.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jingoohan1@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ludovic.desroches@microchip.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=rodrigo.vivi@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.