* [PATCH 0/3] ALSA: add snd_card_disconnect_sync()
@ 2017-10-11 6:30 Kuninori Morimoto
0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2017-10-11 6:30 UTC (permalink / raw)
To: Mark Brown, Takashi Iwai; +Cc: Linux-ALSA, Simon
Hi Takashi-san, Mark
Current ALSA (SoC) might be kernel panic if user
unbinds sound driver during playback.
> aplay xxx.wav &
> echo xxxx > /sys/bus/platform/drivers/xxxx/unbind
Main issue is we *can't* skip unbind with return -Exxx,
because unbind operation doesn't checks return value from each driver.
Thus, we *must* stop driver immediately when unbind.
1) is for ALSA
2) is for ALSA SoC
3) is for Renesas sound driver.
I think almost all driver want to have 3) type patch on .remove
but this patch-set doesn't care at this point.
Please let me know if they should have it.
Takashi Iwai (1):
1) ALSA: add snd_card_disconnect_sync()
Kuninori Morimoto (2):
2) ASoC: add snd_soc_card_disconnect_sync()
3) ASoC: rsnd: call snd_soc_card_disconnect_sync() when remove
include/sound/core.h | 2 ++
include/sound/soc.h | 2 ++
sound/core/init.c | 18 ++++++++++++++++++
sound/core/pcm.c | 4 ++++
sound/soc/sh/rcar/core.c | 2 ++
sound/soc/soc-core.c | 10 ++++++++++
6 files changed, 38 insertions(+)
--
1.9.1
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 0/3] ALSA: add snd_card_disconnect_sync()
@ 2017-10-11 6:33 Kuninori Morimoto
0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2017-10-11 6:33 UTC (permalink / raw)
To: Mark Brown, Takashi Iwai; +Cc: Linux-ALSA, Simon
Hi Takashi-san, Mark
Current ALSA (SoC) might be kernel panic if user
unbinds sound driver during playback.
> aplay xxx.wav &
> echo xxxx > /sys/bus/platform/drivers/xxxx/unbind
Main issue is we *can't* skip unbind with return -Exxx,
because unbind operation doesn't checks return value from each driver.
Thus, we *must* stop driver immediately when unbind.
1) is for ALSA
2) is for ALSA SoC
3) is for Renesas sound driver.
I think almost all driver want to have 3) type patch on .remove
but this patch-set doesn't care at this point.
Please let me know if they should have it.
Takashi Iwai (1):
1) ALSA: add snd_card_disconnect_sync()
Kuninori Morimoto (2):
2) ASoC: add snd_soc_card_disconnect_sync()
3) ASoC: rsnd: call snd_soc_card_disconnect_sync() when remove
include/sound/core.h | 2 ++
include/sound/soc.h | 2 ++
sound/core/init.c | 18 ++++++++++++++++++
sound/core/pcm.c | 4 ++++
sound/soc/sh/rcar/core.c | 2 ++
sound/soc/soc-core.c | 10 ++++++++++
6 files changed, 38 insertions(+)
--
1.9.1
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 0/3] ALSA: add snd_card_disconnect_sync()
@ 2017-10-11 6:26 Kuninori Morimoto
0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2017-10-11 6:26 UTC (permalink / raw)
To: Mark Brown, Takashi Iwai; +Cc: Linux-ALSA, Simon
Hi Takashi-san, Mark
Current ALSA (SoC) might be kernel panic if user
unbinds sound driver during playback.
> aplay xxx.wav &
> echo xxxx > /sys/bus/platform/drivers/xxxx/unbind
Main issue is we *can't* skip unbind with return -Exxx,
because unbind operation doesn't checks return value from each driver.
Thus, we *must* stop driver immediately when unbind.
1) is for ALSA
2) is for ALSA SoC
3) is for Renesas sound driver.
I think almost all driver want to have 3) type patch on .remove
but this patch-set doesn't care at this point.
Please let me know if they should have it.
Takashi Iwai (1):
1) ALSA: add snd_card_disconnect_sync()
Kuninori Morimoto (2):
2) ASoC: add snd_soc_card_disconnect_sync()
3) ASoC: rsnd: call snd_soc_card_disconnect_sync() when remove
include/sound/core.h | 2 ++
include/sound/soc.h | 2 ++
sound/core/init.c | 18 ++++++++++++++++++
sound/core/pcm.c | 4 ++++
sound/soc/sh/rcar/core.c | 2 ++
sound/soc/soc-core.c | 10 ++++++++++
6 files changed, 38 insertions(+)
--
1.9.1
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 6:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 6:30 [PATCH 0/3] ALSA: add snd_card_disconnect_sync() Kuninori Morimoto
-- strict thread matches above, loose matches on Subject: below --
2017-10-11 6:33 Kuninori Morimoto
2017-10-11 6:26 Kuninori Morimoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.