* [PATCH v2 01/10] pinctrl: sh-pfc: r8a7796: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
@ 2017-05-12 0:12 ` Kuninori Morimoto
2017-05-12 11:24 ` Geert Uytterhoeven
2017-05-12 0:13 ` [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support Kuninori Morimoto
` (10 subsequent siblings)
11 siblings, 1 reply; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:12 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Based on Rev 0.50 or later R-Car Gen3 datasheet.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index 668c688..c0f3763 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -204,8 +204,8 @@
#define GPSR6_4 F_(SSI_SDATA2_A, IP15_7_4)
#define GPSR6_3 F_(SSI_SDATA1_A, IP15_3_0)
#define GPSR6_2 F_(SSI_SDATA0, IP14_31_28)
-#define GPSR6_1 F_(SSI_WS0129, IP14_27_24)
-#define GPSR6_0 F_(SSI_SCK0129, IP14_23_20)
+#define GPSR6_1 F_(SSI_WS01239, IP14_27_24)
+#define GPSR6_0 F_(SSI_SCK01239, IP14_23_20)
/* GPSR7 */
#define GPSR7_3 FM(GP7_03)
@@ -338,8 +338,8 @@
#define IP14_11_8 FM(MLB_CLK) F_(0, 0) FM(MSIOF1_SCK_F) F_(0, 0) FM(SCL1_B) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
#define IP14_15_12 FM(MLB_SIG) FM(RX1_B) FM(MSIOF1_SYNC_F) F_(0, 0) FM(SDA1_B) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
#define IP14_19_16 FM(MLB_DAT) FM(TX1_B) FM(MSIOF1_RXD_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP14_23_20 FM(SSI_SCK0129) F_(0, 0) FM(MSIOF1_TXD_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP14_27_24 FM(SSI_WS0129) F_(0, 0) FM(MSIOF1_SS1_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP14_23_20 FM(SSI_SCK01239) F_(0, 0) FM(MSIOF1_TXD_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP14_27_24 FM(SSI_WS01239) F_(0, 0) FM(MSIOF1_SS1_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
/* IPSRx */ /* 0 */ /* 1 */ /* 2 */ /* 3 */ /* 4 */ /* 5 */ /* 6 */ /* 7 */ /* 8 */ /* 9 */ /* A */ /* B */ /* C - F */
#define IP14_31_28 FM(SSI_SDATA0) F_(0, 0) FM(MSIOF1_SS2_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
@@ -1304,10 +1304,10 @@ enum {
PINMUX_IPSR_MSEL(IP14_19_16, TX1_B, SEL_SCIF1_1),
PINMUX_IPSR_MSEL(IP14_19_16, MSIOF1_RXD_F, SEL_MSIOF1_5),
- PINMUX_IPSR_GPSR(IP14_23_20, SSI_SCK0129),
+ PINMUX_IPSR_GPSR(IP14_23_20, SSI_SCK01239),
PINMUX_IPSR_MSEL(IP14_23_20, MSIOF1_TXD_F, SEL_MSIOF1_5),
- PINMUX_IPSR_GPSR(IP14_27_24, SSI_WS0129),
+ PINMUX_IPSR_GPSR(IP14_27_24, SSI_WS01239),
PINMUX_IPSR_MSEL(IP14_27_24, MSIOF1_SS1_F, SEL_MSIOF1_5),
PINMUX_IPSR_GPSR(IP14_31_28, SSI_SDATA0),
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH v2 01/10] pinctrl: sh-pfc: r8a7796: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239
2017-05-12 0:12 ` [PATCH v2 01/10] pinctrl: sh-pfc: r8a7796: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 Kuninori Morimoto
@ 2017-05-12 11:24 ` Geert Uytterhoeven
0 siblings, 0 replies; 26+ messages in thread
From: Geert Uytterhoeven @ 2017-05-12 11:24 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Simon, Magnus, Linux-Renesas
On Fri, May 12, 2017 at 2:12 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Based on Rev 0.50 or later R-Car Gen3 datasheet.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I.e. will queue in sh-pfc-for-v4.13.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
2017-05-12 0:12 ` [PATCH v2 01/10] pinctrl: sh-pfc: r8a7796: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 Kuninori Morimoto
@ 2017-05-12 0:13 ` Kuninori Morimoto
2017-05-12 11:58 ` Geert Uytterhoeven
2017-05-12 0:13 ` [PATCH v2 03/10] pinctrl: sh-pfc: r8a7796: add Audio clock " Kuninori Morimoto
` (9 subsequent siblings)
11 siblings, 1 reply; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:13 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 231 +++++++++++++++++++++++++++++++++++
1 file changed, 231 insertions(+)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index c0f3763..de2b6d7 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -3475,6 +3475,183 @@ enum {
SD3_DS_MARK,
};
+/* - SSI -------------------------------------------------------------------- */
+static const unsigned int ssi0_data_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 2),
+};
+static const unsigned int ssi0_data_mux[] = {
+ SSI_SDATA0_MARK,
+};
+static const unsigned int ssi01239_ctrl_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 0), RCAR_GP_PIN(6, 1),
+};
+static const unsigned int ssi01239_ctrl_mux[] = {
+ SSI_SCK01239_MARK, SSI_WS01239_MARK,
+};
+static const unsigned int ssi1_data_a_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 3),
+};
+static const unsigned int ssi1_data_a_mux[] = {
+ SSI_SDATA1_A_MARK,
+};
+static const unsigned int ssi1_data_b_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(5, 12),
+};
+static const unsigned int ssi1_data_b_mux[] = {
+ SSI_SDATA1_B_MARK,
+};
+static const unsigned int ssi1_ctrl_a_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 26), RCAR_GP_PIN(6, 27),
+};
+static const unsigned int ssi1_ctrl_a_mux[] = {
+ SSI_SCK1_A_MARK, SSI_WS1_A_MARK,
+};
+static const unsigned int ssi1_ctrl_b_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 4), RCAR_GP_PIN(6, 21),
+};
+static const unsigned int ssi1_ctrl_b_mux[] = {
+ SSI_SCK1_B_MARK, SSI_WS1_B_MARK,
+};
+static const unsigned int ssi2_data_a_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 4),
+};
+static const unsigned int ssi2_data_a_mux[] = {
+ SSI_SDATA2_A_MARK,
+};
+static const unsigned int ssi2_data_b_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(5, 13),
+};
+static const unsigned int ssi2_data_b_mux[] = {
+ SSI_SDATA2_B_MARK,
+};
+static const unsigned int ssi2_ctrl_a_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(5, 19), RCAR_GP_PIN(5, 21),
+};
+static const unsigned int ssi2_ctrl_a_mux[] = {
+ SSI_SCK2_A_MARK, SSI_WS2_A_MARK,
+};
+static const unsigned int ssi2_ctrl_b_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 28), RCAR_GP_PIN(6, 29),
+};
+static const unsigned int ssi2_ctrl_b_mux[] = {
+ SSI_SCK2_B_MARK, SSI_WS2_B_MARK,
+};
+static const unsigned int ssi3_data_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 7),
+};
+static const unsigned int ssi3_data_mux[] = {
+ SSI_SDATA3_MARK,
+};
+static const unsigned int ssi34_ctrl_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 5), RCAR_GP_PIN(6, 6),
+};
+static const unsigned int ssi34_ctrl_mux[] = {
+ SSI_SCK34_MARK, SSI_WS34_MARK,
+};
+static const unsigned int ssi4_data_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 10),
+};
+static const unsigned int ssi4_data_mux[] = {
+ SSI_SDATA4_MARK,
+};
+static const unsigned int ssi4_ctrl_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 8), RCAR_GP_PIN(6, 9),
+};
+static const unsigned int ssi4_ctrl_mux[] = {
+ SSI_SCK4_MARK, SSI_WS4_MARK,
+};
+static const unsigned int ssi5_data_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 13),
+};
+static const unsigned int ssi5_data_mux[] = {
+ SSI_SDATA5_MARK,
+};
+static const unsigned int ssi5_ctrl_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 11), RCAR_GP_PIN(6, 12),
+};
+static const unsigned int ssi5_ctrl_mux[] = {
+ SSI_SCK5_MARK, SSI_WS5_MARK,
+};
+static const unsigned int ssi6_data_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 16),
+};
+static const unsigned int ssi6_data_mux[] = {
+ SSI_SDATA6_MARK,
+};
+static const unsigned int ssi6_ctrl_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 14), RCAR_GP_PIN(6, 15),
+};
+static const unsigned int ssi6_ctrl_mux[] = {
+ SSI_SCK6_MARK, SSI_WS6_MARK,
+};
+static const unsigned int ssi7_data_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 19),
+};
+static const unsigned int ssi7_data_mux[] = {
+ SSI_SDATA7_MARK,
+};
+static const unsigned int ssi78_ctrl_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 17), RCAR_GP_PIN(6, 18),
+};
+static const unsigned int ssi78_ctrl_mux[] = {
+ SSI_SCK78_MARK, SSI_WS78_MARK,
+};
+static const unsigned int ssi8_data_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 20),
+};
+static const unsigned int ssi8_data_mux[] = {
+ SSI_SDATA8_MARK,
+};
+static const unsigned int ssi9_data_a_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(6, 21),
+};
+static const unsigned int ssi9_data_a_mux[] = {
+ SSI_SDATA9_A_MARK,
+};
+static const unsigned int ssi9_data_b_pins[] = {
+ /* SDATA */
+ RCAR_GP_PIN(5, 14),
+};
+static const unsigned int ssi9_data_b_mux[] = {
+ SSI_SDATA9_B_MARK,
+};
+static const unsigned int ssi9_ctrl_a_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(5, 15), RCAR_GP_PIN(5, 16),
+};
+static const unsigned int ssi9_ctrl_a_mux[] = {
+ SSI_SCK9_A_MARK, SSI_WS9_A_MARK,
+};
+static const unsigned int ssi9_ctrl_b_pins[] = {
+ /* SCK, WS */
+ RCAR_GP_PIN(6, 30), RCAR_GP_PIN(6, 31),
+};
+static const unsigned int ssi9_ctrl_b_mux[] = {
+ SSI_SCK9_B_MARK, SSI_WS9_B_MARK,
+};
+
static const struct sh_pfc_pin_group pinmux_groups[] = {
SH_PFC_PIN_GROUP(avb_link),
SH_PFC_PIN_GROUP(avb_magic),
@@ -3732,6 +3909,31 @@ enum {
SH_PFC_PIN_GROUP(sdhi3_cd),
SH_PFC_PIN_GROUP(sdhi3_wp),
SH_PFC_PIN_GROUP(sdhi3_ds),
+ SH_PFC_PIN_GROUP(ssi0_data),
+ SH_PFC_PIN_GROUP(ssi01239_ctrl),
+ SH_PFC_PIN_GROUP(ssi1_data_a),
+ SH_PFC_PIN_GROUP(ssi1_data_b),
+ SH_PFC_PIN_GROUP(ssi1_ctrl_a),
+ SH_PFC_PIN_GROUP(ssi1_ctrl_b),
+ SH_PFC_PIN_GROUP(ssi2_data_a),
+ SH_PFC_PIN_GROUP(ssi2_data_b),
+ SH_PFC_PIN_GROUP(ssi2_ctrl_a),
+ SH_PFC_PIN_GROUP(ssi2_ctrl_b),
+ SH_PFC_PIN_GROUP(ssi3_data),
+ SH_PFC_PIN_GROUP(ssi34_ctrl),
+ SH_PFC_PIN_GROUP(ssi4_data),
+ SH_PFC_PIN_GROUP(ssi4_ctrl),
+ SH_PFC_PIN_GROUP(ssi5_data),
+ SH_PFC_PIN_GROUP(ssi5_ctrl),
+ SH_PFC_PIN_GROUP(ssi6_data),
+ SH_PFC_PIN_GROUP(ssi6_ctrl),
+ SH_PFC_PIN_GROUP(ssi7_data),
+ SH_PFC_PIN_GROUP(ssi78_ctrl),
+ SH_PFC_PIN_GROUP(ssi8_data),
+ SH_PFC_PIN_GROUP(ssi9_data_a),
+ SH_PFC_PIN_GROUP(ssi9_data_b),
+ SH_PFC_PIN_GROUP(ssi9_ctrl_a),
+ SH_PFC_PIN_GROUP(ssi9_ctrl_b),
};
static const char * const avb_groups[] = {
@@ -4113,6 +4315,34 @@ enum {
"sdhi3_ds",
};
+static const char * const ssi_groups[] = {
+ "ssi0_data",
+ "ssi01239_ctrl",
+ "ssi1_data_a",
+ "ssi1_data_b",
+ "ssi1_ctrl_a",
+ "ssi1_ctrl_b",
+ "ssi2_data_a",
+ "ssi2_data_b",
+ "ssi2_ctrl_a",
+ "ssi2_ctrl_b",
+ "ssi3_data",
+ "ssi34_ctrl",
+ "ssi4_data",
+ "ssi4_ctrl",
+ "ssi5_data",
+ "ssi5_ctrl",
+ "ssi6_data",
+ "ssi6_ctrl",
+ "ssi7_data",
+ "ssi78_ctrl",
+ "ssi8_data",
+ "ssi9_data_a",
+ "ssi9_data_b",
+ "ssi9_ctrl_a",
+ "ssi9_ctrl_b",
+};
+
static const struct sh_pfc_function pinmux_functions[] = {
SH_PFC_FUNCTION(avb),
SH_PFC_FUNCTION(can0),
@@ -4155,6 +4385,7 @@ enum {
SH_PFC_FUNCTION(sdhi1),
SH_PFC_FUNCTION(sdhi2),
SH_PFC_FUNCTION(sdhi3),
+ SH_PFC_FUNCTION(ssi),
};
static const struct pinmux_cfg_reg pinmux_config_regs[] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
2017-05-12 0:13 ` [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support Kuninori Morimoto
@ 2017-05-12 11:58 ` Geert Uytterhoeven
2017-05-15 0:23 ` Kuninori Morimoto
0 siblings, 1 reply; 26+ messages in thread
From: Geert Uytterhoeven @ 2017-05-12 11:58 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Simon, Magnus, Linux-Renesas
Hi Morimoto-san,
On Fri, May 12, 2017 at 2:13 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
But before I queue it in sh-pfc-for-v4.13, I would like to have a
clarification.
> +static const unsigned int ssi34_ctrl_pins[] = {
> + /* SCK, WS */
> + RCAR_GP_PIN(6, 5), RCAR_GP_PIN(6, 6),
> +};
> +static const unsigned int ssi34_ctrl_mux[] = {
> + SSI_SCK34_MARK, SSI_WS34_MARK,
> +};
I'm a bit confused by this group: in the R-Car M3 Pin Function Rev. 0.54
sheet, these are named SCK349 resp. WS349. According to the history, the
change from {SCK,WS}34 to {SCK,WS}349 was made at the same time as the
change from {SCK,WS}0129 to {SCK,WS}01239.
However, the former change is not reflected in the PFC section of the
Hardware User's Manual.
So which is correct: {SCK,WS}34 or {SCK,WS}349?
Can you please enlighten me?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
2017-05-12 11:58 ` Geert Uytterhoeven
@ 2017-05-15 0:23 ` Kuninori Morimoto
2017-05-15 9:00 ` Geert Uytterhoeven
0 siblings, 1 reply; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-15 0:23 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Simon, Magnus, Linux-Renesas
Hi Geert
> > +static const unsigned int ssi34_ctrl_pins[] = {
> > + /* SCK, WS */
> > + RCAR_GP_PIN(6, 5), RCAR_GP_PIN(6, 6),
> > +};
> > +static const unsigned int ssi34_ctrl_mux[] = {
> > + SSI_SCK34_MARK, SSI_WS34_MARK,
> > +};
>
> I'm a bit confused by this group: in the R-Car M3 Pin Function Rev. 0.54
> sheet, these are named SCK349 resp. WS349. According to the history, the
> change from {SCK,WS}34 to {SCK,WS}349 was made at the same time as the
> change from {SCK,WS}0129 to {SCK,WS}01239.
> However, the former change is not reflected in the PFC section of the
> Hardware User's Manual.
>
> So which is correct: {SCK,WS}34 or {SCK,WS}349?
>
> Can you please enlighten me?
It seems
SSI_SCK 0129 -> 01239 was happen on v0.51 timing,
SSI_SCK 34 -> 349 was happen on v0.54 timing.
r8a7795 is still using old (= 34) naming now.
I can adjust it both r8a7795/6.
Do you want to v3 patch for r8a7796 ?
or incremental patch is OK with r8a7795 ?
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
2017-05-15 0:23 ` Kuninori Morimoto
@ 2017-05-15 9:00 ` Geert Uytterhoeven
2017-05-15 9:07 ` Kuninori Morimoto
0 siblings, 1 reply; 26+ messages in thread
From: Geert Uytterhoeven @ 2017-05-15 9:00 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Simon, Magnus, Linux-Renesas
Hi Morimoto-san,
On Mon, May 15, 2017 at 2:23 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > +static const unsigned int ssi34_ctrl_pins[] = {
>> > + /* SCK, WS */
>> > + RCAR_GP_PIN(6, 5), RCAR_GP_PIN(6, 6),
>> > +};
>> > +static const unsigned int ssi34_ctrl_mux[] = {
>> > + SSI_SCK34_MARK, SSI_WS34_MARK,
>> > +};
>>
>> I'm a bit confused by this group: in the R-Car M3 Pin Function Rev. 0.54
>> sheet, these are named SCK349 resp. WS349. According to the history, the
>> change from {SCK,WS}34 to {SCK,WS}349 was made at the same time as the
>> change from {SCK,WS}0129 to {SCK,WS}01239.
>> However, the former change is not reflected in the PFC section of the
>> Hardware User's Manual.
>>
>> So which is correct: {SCK,WS}34 or {SCK,WS}349?
>>
>> Can you please enlighten me?
>
> It seems
> SSI_SCK 0129 -> 01239 was happen on v0.51 timing,
> SSI_SCK 34 -> 349 was happen on v0.54 timing.
In the pin function spreadsheets, the changes were made together, in June 2016.
> r8a7795 is still using old (= 34) naming now.
Does this affect H3 ES1.0, too?
My main worry there is that the name "ssi34_ctrl" is part of the DT ABI,
so we have to keep that as an alias for "ssi349_ctrl".
> I can adjust it both r8a7795/6.
> Do you want to v3 patch for r8a7796 ?
> or incremental patch is OK with r8a7795 ?
As long as I haven't sent a pull request for sh-pfc-for-v4.13, it can still be
fixed incrementally.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
2017-05-15 9:00 ` Geert Uytterhoeven
@ 2017-05-15 9:07 ` Kuninori Morimoto
2017-05-15 9:17 ` Geert Uytterhoeven
0 siblings, 1 reply; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-15 9:07 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Simon, Magnus, Linux-Renesas
Hi Geert
> > r8a7795 is still using old (= 34) naming now.
>
> Does this affect H3 ES1.0, too?
> My main worry there is that the name "ssi34_ctrl" is part of the DT ABI,
> so we have to keep that as an alias for "ssi349_ctrl".
I think this is from Gen3, not ESx.
And no-one is using SSI34 on upstream code.
Should we care about out-of-tree user ?
> > I can adjust it both r8a7795/6.
> > Do you want to v3 patch for r8a7796 ?
> > or incremental patch is OK with r8a7795 ?
>
> As long as I haven't sent a pull request for sh-pfc-for-v4.13, it can still be
> fixed incrementally.
OK. will do in v3
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
2017-05-15 9:07 ` Kuninori Morimoto
@ 2017-05-15 9:17 ` Geert Uytterhoeven
2017-05-16 1:25 ` Kuninori Morimoto
0 siblings, 1 reply; 26+ messages in thread
From: Geert Uytterhoeven @ 2017-05-15 9:17 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Simon, Magnus, Linux-Renesas
Hi Morimoto-san,
On Mon, May 15, 2017 at 11:07 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > r8a7795 is still using old (= 34) naming now.
>>
>> Does this affect H3 ES1.0, too?
>> My main worry there is that the name "ssi34_ctrl" is part of the DT ABI,
>> so we have to keep that as an alias for "ssi349_ctrl".
>
> I think this is from Gen3, not ESx.
> And no-one is using SSI34 on upstream code.
> Should we care about out-of-tree user ?
Probably not, especially for H3 ES1.x.
>> > I can adjust it both r8a7795/6.
>> > Do you want to v3 patch for r8a7796 ?
>> > or incremental patch is OK with r8a7795 ?
>>
>> As long as I haven't sent a pull request for sh-pfc-for-v4.13, it can still be
>> fixed incrementally.
>
> OK. will do in v3
OK, thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
2017-05-15 9:17 ` Geert Uytterhoeven
@ 2017-05-16 1:25 ` Kuninori Morimoto
2017-05-16 7:15 ` Geert Uytterhoeven
0 siblings, 1 reply; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-16 1:25 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Simon, Magnus, Linux-Renesas
Hi Geert
> >> Does this affect H3 ES1.0, too?
> >> My main worry there is that the name "ssi34_ctrl" is part of the DT ABI,
> >> so we have to keep that as an alias for "ssi349_ctrl".
> >
> > I think this is from Gen3, not ESx.
> > And no-one is using SSI34 on upstream code.
> > Should we care about out-of-tree user ?
>
> Probably not, especially for H3 ES1.x.
Sorry, I didn't explain.
This is from Gen3, and ES1.x version datasheet has typo.
But datasheet team no more update for it.
For example on v0.5 datasheet (= for ES1.x)
6. Pin Function Controller (PFC)
6.2.2 GPIO/Peripheral Function Select Register (GPSR0-7)
This has SSI_xxx_0129 (= this is typo), but
41. Serial Sound Interface Unit (SSIU)
41.1.3 External Pins
This has SSI_xxx_01239
Can you agree about SSI_xxx_01239 / SSI_349 are from Gen3, not ES1.x ?
> > OK. will do in v3
>
> OK, thanks!
Oops, sorry, not v3, but incremental patch.
I will post this patch (= fixup SSI_349) if I could find my posted patches
on your sh-pfc-for-v4.13.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
2017-05-16 1:25 ` Kuninori Morimoto
@ 2017-05-16 7:15 ` Geert Uytterhoeven
0 siblings, 0 replies; 26+ messages in thread
From: Geert Uytterhoeven @ 2017-05-16 7:15 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Simon, Magnus, Linux-Renesas
Hi Morimoto-san,
On Tue, May 16, 2017 at 3:25 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> >> Does this affect H3 ES1.0, too?
>> >> My main worry there is that the name "ssi34_ctrl" is part of the DT ABI,
>> >> so we have to keep that as an alias for "ssi349_ctrl".
>> >
>> > I think this is from Gen3, not ESx.
>> > And no-one is using SSI34 on upstream code.
>> > Should we care about out-of-tree user ?
>>
>> Probably not, especially for H3 ES1.x.
>
> Sorry, I didn't explain.
> This is from Gen3, and ES1.x version datasheet has typo.
> But datasheet team no more update for it.
>
> For example on v0.5 datasheet (= for ES1.x)
>
> 6. Pin Function Controller (PFC)
> 6.2.2 GPIO/Peripheral Function Select Register (GPSR0-7)
>
> This has SSI_xxx_0129 (= this is typo), but
>
> 41. Serial Sound Interface Unit (SSIU)
> 41.1.3 External Pins
>
> This has SSI_xxx_01239
OK.
> Can you agree about SSI_xxx_01239 / SSI_349 are from Gen3, not ES1.x ?
Yes, I agree.
>> > OK. will do in v3
>>
>> OK, thanks!
>
> Oops, sorry, not v3, but incremental patch.
> I will post this patch (= fixup SSI_349) if I could find my posted patches
> on your sh-pfc-for-v4.13.
Oops,I thought I had pushed {clk-renesas,sh-pfc}-for-v4.13 yesterday, but
apparently I got interrupted. Done. But kernel.org mirroring seems to be slow
(latest are based on v4.12-rc1, not v4.11-rc1).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 03/10] pinctrl: sh-pfc: r8a7796: add Audio clock pin support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
2017-05-12 0:12 ` [PATCH v2 01/10] pinctrl: sh-pfc: r8a7796: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 Kuninori Morimoto
2017-05-12 0:13 ` [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support Kuninori Morimoto
@ 2017-05-12 0:13 ` Kuninori Morimoto
2017-05-12 12:06 ` Geert Uytterhoeven
2017-05-12 0:14 ` [PATCH v2 04/10] arm64: renesas: r8a7796: add AUDIO_DMAC support Kuninori Morimoto
` (8 subsequent siblings)
11 siblings, 1 reply; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:13 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 160 +++++++++++++++++++++++++++++++++++
1 file changed, 160 insertions(+)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index de2b6d7..4fb9d1f 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -1582,6 +1582,128 @@ enum {
SH_PFC_PIN_NAMED_CFG(ROW_GROUP_A('T'), 30, ASEBRK, CFG_FLAGS),
};
+/* - AUDIO CLOCK ------------------------------------------------------------ */
+static const unsigned int audio_clk_a_a_pins[] = {
+ /* CLK A */
+ RCAR_GP_PIN(6, 22),
+};
+static const unsigned int audio_clk_a_a_mux[] = {
+ AUDIO_CLKA_A_MARK,
+};
+static const unsigned int audio_clk_a_b_pins[] = {
+ /* CLK A */
+ RCAR_GP_PIN(5, 4),
+};
+static const unsigned int audio_clk_a_b_mux[] = {
+ AUDIO_CLKA_B_MARK,
+};
+static const unsigned int audio_clk_a_c_pins[] = {
+ /* CLK A */
+ RCAR_GP_PIN(5, 19),
+};
+static const unsigned int audio_clk_a_c_mux[] = {
+ AUDIO_CLKA_C_MARK,
+};
+static const unsigned int audio_clk_b_a_pins[] = {
+ /* CLK B */
+ RCAR_GP_PIN(5, 12),
+};
+static const unsigned int audio_clk_b_a_mux[] = {
+ AUDIO_CLKB_A_MARK,
+};
+static const unsigned int audio_clk_b_b_pins[] = {
+ /* CLK B */
+ RCAR_GP_PIN(6, 23),
+};
+static const unsigned int audio_clk_b_b_mux[] = {
+ AUDIO_CLKB_B_MARK,
+};
+static const unsigned int audio_clk_c_a_pins[] = {
+ /* CLK C */
+ RCAR_GP_PIN(5, 21),
+};
+static const unsigned int audio_clk_c_a_mux[] = {
+ AUDIO_CLKC_A_MARK,
+};
+static const unsigned int audio_clk_c_b_pins[] = {
+ /* CLK C */
+ RCAR_GP_PIN(5, 0),
+};
+static const unsigned int audio_clk_c_b_mux[] = {
+ AUDIO_CLKC_B_MARK,
+};
+static const unsigned int audio_clkout_a_pins[] = {
+ /* CLKOUT */
+ RCAR_GP_PIN(5, 18),
+};
+static const unsigned int audio_clkout_a_mux[] = {
+ AUDIO_CLKOUT_A_MARK,
+};
+static const unsigned int audio_clkout_b_pins[] = {
+ /* CLKOUT */
+ RCAR_GP_PIN(6, 28),
+};
+static const unsigned int audio_clkout_b_mux[] = {
+ AUDIO_CLKOUT_B_MARK,
+};
+static const unsigned int audio_clkout_c_pins[] = {
+ /* CLKOUT */
+ RCAR_GP_PIN(5, 3),
+};
+static const unsigned int audio_clkout_c_mux[] = {
+ AUDIO_CLKOUT_C_MARK,
+};
+static const unsigned int audio_clkout_d_pins[] = {
+ /* CLKOUT */
+ RCAR_GP_PIN(5, 21),
+};
+static const unsigned int audio_clkout_d_mux[] = {
+ AUDIO_CLKOUT_D_MARK,
+};
+static const unsigned int audio_clkout1_a_pins[] = {
+ /* CLKOUT1 */
+ RCAR_GP_PIN(5, 15),
+};
+static const unsigned int audio_clkout1_a_mux[] = {
+ AUDIO_CLKOUT1_A_MARK,
+};
+static const unsigned int audio_clkout1_b_pins[] = {
+ /* CLKOUT1 */
+ RCAR_GP_PIN(6, 29),
+};
+static const unsigned int audio_clkout1_b_mux[] = {
+ AUDIO_CLKOUT1_B_MARK,
+};
+static const unsigned int audio_clkout2_a_pins[] = {
+ /* CLKOUT2 */
+ RCAR_GP_PIN(5, 16),
+};
+static const unsigned int audio_clkout2_a_mux[] = {
+ AUDIO_CLKOUT2_A_MARK,
+};
+static const unsigned int audio_clkout2_b_pins[] = {
+ /* CLKOUT2 */
+ RCAR_GP_PIN(6, 30),
+};
+static const unsigned int audio_clkout2_b_mux[] = {
+ AUDIO_CLKOUT2_B_MARK,
+};
+
+static const unsigned int audio_clkout3_a_pins[] = {
+ /* CLKOUT3 */
+ RCAR_GP_PIN(5, 19),
+};
+static const unsigned int audio_clkout3_a_mux[] = {
+ AUDIO_CLKOUT3_A_MARK,
+};
+static const unsigned int audio_clkout3_b_pins[] = {
+ /* CLKOUT3 */
+ RCAR_GP_PIN(6, 31),
+};
+static const unsigned int audio_clkout3_b_mux[] = {
+ AUDIO_CLKOUT3_B_MARK,
+};
+
/* - EtherAVB --------------------------------------------------------------- */
static const unsigned int avb_link_pins[] = {
/* AVB_LINK */
@@ -3653,6 +3775,23 @@ enum {
};
static const struct sh_pfc_pin_group pinmux_groups[] = {
+ SH_PFC_PIN_GROUP(audio_clk_a_a),
+ SH_PFC_PIN_GROUP(audio_clk_a_b),
+ SH_PFC_PIN_GROUP(audio_clk_a_c),
+ SH_PFC_PIN_GROUP(audio_clk_b_a),
+ SH_PFC_PIN_GROUP(audio_clk_b_b),
+ SH_PFC_PIN_GROUP(audio_clk_c_a),
+ SH_PFC_PIN_GROUP(audio_clk_c_b),
+ SH_PFC_PIN_GROUP(audio_clkout_a),
+ SH_PFC_PIN_GROUP(audio_clkout_b),
+ SH_PFC_PIN_GROUP(audio_clkout_c),
+ SH_PFC_PIN_GROUP(audio_clkout_d),
+ SH_PFC_PIN_GROUP(audio_clkout1_a),
+ SH_PFC_PIN_GROUP(audio_clkout1_b),
+ SH_PFC_PIN_GROUP(audio_clkout2_a),
+ SH_PFC_PIN_GROUP(audio_clkout2_b),
+ SH_PFC_PIN_GROUP(audio_clkout3_a),
+ SH_PFC_PIN_GROUP(audio_clkout3_b),
SH_PFC_PIN_GROUP(avb_link),
SH_PFC_PIN_GROUP(avb_magic),
SH_PFC_PIN_GROUP(avb_phy_int),
@@ -3936,6 +4075,26 @@ enum {
SH_PFC_PIN_GROUP(ssi9_ctrl_b),
};
+static const char * const audio_clk_groups[] = {
+ "audio_clk_a_a",
+ "audio_clk_a_b",
+ "audio_clk_a_c",
+ "audio_clk_b_a",
+ "audio_clk_b_b",
+ "audio_clk_c_a",
+ "audio_clk_c_b",
+ "audio_clkout_a",
+ "audio_clkout_b",
+ "audio_clkout_c",
+ "audio_clkout_d",
+ "audio_clkout1_a",
+ "audio_clkout1_b",
+ "audio_clkout2_a",
+ "audio_clkout2_b",
+ "audio_clkout3_a",
+ "audio_clkout3_b",
+};
+
static const char * const avb_groups[] = {
"avb_link",
"avb_magic",
@@ -4344,6 +4503,7 @@ enum {
};
static const struct sh_pfc_function pinmux_functions[] = {
+ SH_PFC_FUNCTION(audio_clk),
SH_PFC_FUNCTION(avb),
SH_PFC_FUNCTION(can0),
SH_PFC_FUNCTION(can1),
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH v2 03/10] pinctrl: sh-pfc: r8a7796: add Audio clock pin support
2017-05-12 0:13 ` [PATCH v2 03/10] pinctrl: sh-pfc: r8a7796: add Audio clock " Kuninori Morimoto
@ 2017-05-12 12:06 ` Geert Uytterhoeven
0 siblings, 0 replies; 26+ messages in thread
From: Geert Uytterhoeven @ 2017-05-12 12:06 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Simon, Magnus, Linux-Renesas
On Fri, May 12, 2017 at 2:13 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I.e. will queue in sh-pfc-for-v4.13.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 04/10] arm64: renesas: r8a7796: add AUDIO_DMAC support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (2 preceding siblings ...)
2017-05-12 0:13 ` [PATCH v2 03/10] pinctrl: sh-pfc: r8a7796: add Audio clock " Kuninori Morimoto
@ 2017-05-12 0:14 ` Kuninori Morimoto
2017-05-12 0:14 ` [PATCH v2 05/10] arm64: renesas: r8a7796: add Sound SSI PIO support Kuninori Morimoto
` (7 subsequent siblings)
11 siblings, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:14 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- remove ipmmu property
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 68 ++++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 78549f8..7168f70 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1055,6 +1055,74 @@
dma-channels = <16>;
};
+ audma0: dma-controller@ec700000 {
+ compatible = "renesas,dmac-r8a7796",
+ "renesas,rcar-dmac";
+ reg = <0 0xec700000 0 0x10000>;
+ interrupts = <GIC_SPI 350 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 321 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 322 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 323 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 325 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 326 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 328 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 334 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error",
+ "ch0", "ch1", "ch2", "ch3",
+ "ch4", "ch5", "ch6", "ch7",
+ "ch8", "ch9", "ch10", "ch11",
+ "ch12", "ch13", "ch14", "ch15";
+ clocks = <&cpg CPG_MOD 502>;
+ clock-names = "fck";
+ power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+ resets = <&cpg 502>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ };
+
+ audma1: dma-controller@ec720000 {
+ compatible = "renesas,dmac-r8a7796",
+ "renesas,rcar-dmac";
+ reg = <0 0xec720000 0 0x10000>;
+ interrupts = <GIC_SPI 351 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 343 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 344 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 346 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 347 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 348 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 349 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 382 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 383 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error",
+ "ch0", "ch1", "ch2", "ch3",
+ "ch4", "ch5", "ch6", "ch7",
+ "ch8", "ch9", "ch10", "ch11",
+ "ch12", "ch13", "ch14", "ch15";
+ clocks = <&cpg CPG_MOD 501>;
+ clock-names = "fck";
+ power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+ resets = <&cpg 501>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ };
+
hsusb: usb@e6590000 {
/* placeholder */
};
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH v2 05/10] arm64: renesas: r8a7796: add Sound SSI PIO support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (3 preceding siblings ...)
2017-05-12 0:14 ` [PATCH v2 04/10] arm64: renesas: r8a7796: add AUDIO_DMAC support Kuninori Morimoto
@ 2017-05-12 0:14 ` Kuninori Morimoto
2017-05-12 9:43 ` Geert Uytterhoeven
2017-05-12 0:15 ` [PATCH v2 06/10] arm64: renesas: r8a7796: add Sound SSI DMA support Kuninori Morimoto
` (6 subsequent siblings)
11 siblings, 1 reply; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:14 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 64 +++++++++++++++++++++++++++++++-
1 file changed, 62 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 7168f70..be25a2a 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1259,7 +1259,42 @@
};
rcar_sound: sound@ec500000 {
- /* placeholder */
+ /*
+ * #sound-dai-cells is required
+ *
+ * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
+ * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
+ */
+ /*
+ * #clock-cells is required for audio_clkout0/1/2/3
+ *
+ * clkout : #clock-cells = <0>; <&rcar_sound>;
+ * clkout0/1/2/3: #clock-cells = <1>; <&rcar_sound N>;
+ */
+ compatible = "renesas,rcar_sound-r8a7796", "renesas,rcar_sound-gen3";
+ reg = <0 0xec500000 0 0x1000>, /* SCU */
+ <0 0xec5a0000 0 0x100>, /* ADG */
+ <0 0xec540000 0 0x1000>, /* SSIU */
+ <0 0xec541000 0 0x280>, /* SSI */
+ <0 0xec740000 0 0x200>; /* Audio DMAC peri peri*/
+ reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
+
+ clocks = <&cpg CPG_MOD 1005>,
+ <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>,
+ <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>,
+ <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
+ <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
+ <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+ <&audio_clk_a>, <&audio_clk_b>,
+ <&audio_clk_c>,
+ <&cpg CPG_CORE R8A7796_CLK_S0D4>;
+ clock-names = "ssi-all",
+ "ssi.9", "ssi.8", "ssi.7", "ssi.6",
+ "ssi.5", "ssi.4", "ssi.3", "ssi.2",
+ "ssi.1", "ssi.0",
+ "clk_a", "clk_b", "clk_c", "clk_i";
+ power-domains = <&cpg>;
+ status = "disabled";
rcar_sound,dvc {
dvc0: dvc-0 {
@@ -1278,9 +1313,34 @@
rcar_sound,ssi {
ssi0: ssi-0 {
+ interrupts = <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>;
};
-
ssi1: ssi-1 {
+ interrupts = <GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi2: ssi-2 {
+ interrupts = <GIC_SPI 372 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi3: ssi-3 {
+ interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi4: ssi-4 {
+ interrupts = <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi5: ssi-5 {
+ interrupts = <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi6: ssi-6 {
+ interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi7: ssi-7 {
+ interrupts = <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi8: ssi-8 {
+ interrupts = <GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi9: ssi-9 {
+ interrupts = <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>;
};
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH v2 05/10] arm64: renesas: r8a7796: add Sound SSI PIO support
2017-05-12 0:14 ` [PATCH v2 05/10] arm64: renesas: r8a7796: add Sound SSI PIO support Kuninori Morimoto
@ 2017-05-12 9:43 ` Geert Uytterhoeven
2017-05-15 1:01 ` [PATCH] arm64: dts: r8a7796: tidyup power-domains for R-Car Sound Kuninori Morimoto
2017-05-15 5:53 ` [PATCH v2 05/10] arm64: renesas: r8a7796: add Sound SSI PIO support Simon Horman
0 siblings, 2 replies; 26+ messages in thread
From: Geert Uytterhoeven @ 2017-05-12 9:43 UTC (permalink / raw)
To: Kuninori Morimoto, Simon; +Cc: Magnus, Linux-Renesas
Hi Morimoto-san, Simon,
On Fri, May 12, 2017 at 2:14 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -1259,7 +1259,42 @@
> };
>
> rcar_sound: sound@ec500000 {
[...]
> + power-domains = <&cpg>;
power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
(by comparing r8a779[66].dtsi).
Simon: As you have already applied this, can you please fix it up in your tree?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread* [PATCH] arm64: dts: r8a7796: tidyup power-domains for R-Car Sound
2017-05-12 9:43 ` Geert Uytterhoeven
@ 2017-05-15 1:01 ` Kuninori Morimoto
2017-05-15 5:53 ` [PATCH v2 05/10] arm64: renesas: r8a7796: add Sound SSI PIO support Simon Horman
1 sibling, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-15 1:01 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
commit a32681b13157f("arm64: dts: r8a7796: add Sound SSI PIO support")
added R-Car sound, but it used old style power-domains.
This patch tidyup it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index f815532..f21c5ce 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1323,7 +1323,7 @@
"ctu.1", "ctu.0",
"dvc.0", "dvc.1",
"clk_a", "clk_b", "clk_c", "clk_i";
- power-domains = <&cpg>;
+ power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
status = "disabled";
rcar_sound,dvc {
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH v2 05/10] arm64: renesas: r8a7796: add Sound SSI PIO support
2017-05-12 9:43 ` Geert Uytterhoeven
2017-05-15 1:01 ` [PATCH] arm64: dts: r8a7796: tidyup power-domains for R-Car Sound Kuninori Morimoto
@ 2017-05-15 5:53 ` Simon Horman
1 sibling, 0 replies; 26+ messages in thread
From: Simon Horman @ 2017-05-15 5:53 UTC (permalink / raw)
To: Geert Uytterhoeven, Kuninori Morimoto; +Cc: Magnus, Linux-Renesas
On Fri, May 12, 2017 at 11:43:39AM +0200, Geert Uytterhoeven wrote:
> Hi Morimoto-san, Simon,
>
> On Fri, May 12, 2017 at 2:14 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -1259,7 +1259,42 @@
> > };
> >
> > rcar_sound: sound@ec500000 {
>
> [...]
>
> > + power-domains = <&cpg>;
>
> power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
>
> (by comparing r8a779[66].dtsi).
>
> Simon: As you have already applied this, can you please fix it up in your tree?
Sure, I have squashed the batch below into the relevant patch in my local
tree which I plan to push later today.
Morimoto-san,
FYI, I did a s/renesas/dts/ in the subject of the patches in this series.
On Mon, May 15, 2017 at 01:01:23AM +0000, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> commit a32681b13157f("arm64: dts: r8a7796: add Sound SSI PIO support")
> added R-Car sound, but it used old style power-domains.
> This patch tidyup it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index f815532..f21c5ce 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -1323,7 +1323,7 @@
> "ctu.1", "ctu.0",
> "dvc.0", "dvc.1",
> "clk_a", "clk_b", "clk_c", "clk_i";
> - power-domains = <&cpg>;
> + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> status = "disabled";
>
> rcar_sound,dvc {
The patch I now have queued-up is as follows:
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
arm64: dts: r8a7796: add Sound SSI PIO support
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 64 +++++++++++++++++++++++++++++++-
1 file changed, 62 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 0a76a1c53082..5c6e54a1e27a 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1165,7 +1165,42 @@
};
rcar_sound: sound@ec500000 {
- /* placeholder */
+ /*
+ * #sound-dai-cells is required
+ *
+ * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
+ * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
+ */
+ /*
+ * #clock-cells is required for audio_clkout0/1/2/3
+ *
+ * clkout : #clock-cells = <0>; <&rcar_sound>;
+ * clkout0/1/2/3: #clock-cells = <1>; <&rcar_sound N>;
+ */
+ compatible = "renesas,rcar_sound-r8a7796", "renesas,rcar_sound-gen3";
+ reg = <0 0xec500000 0 0x1000>, /* SCU */
+ <0 0xec5a0000 0 0x100>, /* ADG */
+ <0 0xec540000 0 0x1000>, /* SSIU */
+ <0 0xec541000 0 0x280>, /* SSI */
+ <0 0xec740000 0 0x200>; /* Audio DMAC peri peri*/
+ reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
+
+ clocks = <&cpg CPG_MOD 1005>,
+ <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>,
+ <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>,
+ <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
+ <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
+ <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+ <&audio_clk_a>, <&audio_clk_b>,
+ <&audio_clk_c>,
+ <&cpg CPG_CORE R8A7796_CLK_S0D4>;
+ clock-names = "ssi-all",
+ "ssi.9", "ssi.8", "ssi.7", "ssi.6",
+ "ssi.5", "ssi.4", "ssi.3", "ssi.2",
+ "ssi.1", "ssi.0",
+ "clk_a", "clk_b", "clk_c", "clk_i";
+ power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+ status = "disabled";
rcar_sound,dvc {
dvc0: dvc-0 {
@@ -1184,9 +1219,34 @@
rcar_sound,ssi {
ssi0: ssi-0 {
+ interrupts = <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>;
};
-
ssi1: ssi-1 {
+ interrupts = <GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi2: ssi-2 {
+ interrupts = <GIC_SPI 372 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi3: ssi-3 {
+ interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi4: ssi-4 {
+ interrupts = <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi5: ssi-5 {
+ interrupts = <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi6: ssi-6 {
+ interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi7: ssi-7 {
+ interrupts = <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi8: ssi-8 {
+ interrupts = <GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ ssi9: ssi-9 {
+ interrupts = <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>;
};
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v2 06/10] arm64: renesas: r8a7796: add Sound SSI DMA support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (4 preceding siblings ...)
2017-05-12 0:14 ` [PATCH v2 05/10] arm64: renesas: r8a7796: add Sound SSI PIO support Kuninori Morimoto
@ 2017-05-12 0:15 ` Kuninori Morimoto
2017-05-12 0:15 ` [PATCH v2 07/10] arm64: renesas: r8a7796: add Sound SRC support Kuninori Morimoto
` (5 subsequent siblings)
11 siblings, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:15 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index be25a2a..ac85b51 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1314,33 +1314,53 @@
rcar_sound,ssi {
ssi0: ssi-0 {
interrupts = <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x01>, <&audma1 0x02>, <&audma0 0x15>, <&audma1 0x16>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi1: ssi-1 {
interrupts = <GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x03>, <&audma1 0x04>, <&audma0 0x49>, <&audma1 0x4a>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi2: ssi-2 {
interrupts = <GIC_SPI 372 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x05>, <&audma1 0x06>, <&audma0 0x63>, <&audma1 0x64>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi3: ssi-3 {
interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x07>, <&audma1 0x08>, <&audma0 0x6f>, <&audma1 0x70>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi4: ssi-4 {
interrupts = <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x09>, <&audma1 0x0a>, <&audma0 0x71>, <&audma1 0x72>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi5: ssi-5 {
interrupts = <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x0b>, <&audma1 0x0c>, <&audma0 0x73>, <&audma1 0x74>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi6: ssi-6 {
interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x0d>, <&audma1 0x0e>, <&audma0 0x75>, <&audma1 0x76>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi7: ssi-7 {
interrupts = <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x0f>, <&audma1 0x10>, <&audma0 0x79>, <&audma1 0x7a>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi8: ssi-8 {
interrupts = <GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x11>, <&audma1 0x12>, <&audma0 0x7b>, <&audma1 0x7c>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
ssi9: ssi-9 {
interrupts = <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x13>, <&audma1 0x14>, <&audma0 0x7d>, <&audma1 0x7e>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH v2 07/10] arm64: renesas: r8a7796: add Sound SRC support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (5 preceding siblings ...)
2017-05-12 0:15 ` [PATCH v2 06/10] arm64: renesas: r8a7796: add Sound SSI DMA support Kuninori Morimoto
@ 2017-05-12 0:15 ` Kuninori Morimoto
2017-05-12 0:15 ` [PATCH v2 08/10] arm64: renesas: r8a7796: add Sound DVC support Kuninori Morimoto
` (4 subsequent siblings)
11 siblings, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:15 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 54 ++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index ac85b51..cca8dae 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1285,6 +1285,11 @@
<&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
<&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
<&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+ <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>,
+ <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>,
+ <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
+ <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
+ <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
<&audio_clk_a>, <&audio_clk_b>,
<&audio_clk_c>,
<&cpg CPG_CORE R8A7796_CLK_S0D4>;
@@ -1292,6 +1297,9 @@
"ssi.9", "ssi.8", "ssi.7", "ssi.6",
"ssi.5", "ssi.4", "ssi.3", "ssi.2",
"ssi.1", "ssi.0",
+ "src.9", "src.8", "src.7", "src.6",
+ "src.5", "src.4", "src.3", "src.2",
+ "src.1", "src.0",
"clk_a", "clk_b", "clk_c", "clk_i";
power-domains = <&cpg>;
status = "disabled";
@@ -1306,8 +1314,54 @@
rcar_sound,src {
src0: src-0 {
+ interrupts = <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x85>, <&audma1 0x9a>;
+ dma-names = "rx", "tx";
};
src1: src-1 {
+ interrupts = <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x87>, <&audma1 0x9c>;
+ dma-names = "rx", "tx";
+ };
+ src2: src-2 {
+ interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x89>, <&audma1 0x9e>;
+ dma-names = "rx", "tx";
+ };
+ src3: src-3 {
+ interrupts = <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x8b>, <&audma1 0xa0>;
+ dma-names = "rx", "tx";
+ };
+ src4: src-4 {
+ interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x8d>, <&audma1 0xb0>;
+ dma-names = "rx", "tx";
+ };
+ src5: src-5 {
+ interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x8f>, <&audma1 0xb2>;
+ dma-names = "rx", "tx";
+ };
+ src6: src-6 {
+ interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x91>, <&audma1 0xb4>;
+ dma-names = "rx", "tx";
+ };
+ src7: src-7 {
+ interrupts = <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x93>, <&audma1 0xb6>;
+ dma-names = "rx", "tx";
+ };
+ src8: src-8 {
+ interrupts = <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x95>, <&audma1 0xb8>;
+ dma-names = "rx", "tx";
+ };
+ src9: src-9 {
+ interrupts = <GIC_SPI 361 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x97>, <&audma1 0xba>;
+ dma-names = "rx", "tx";
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH v2 08/10] arm64: renesas: r8a7796: add Sound DVC support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (6 preceding siblings ...)
2017-05-12 0:15 ` [PATCH v2 07/10] arm64: renesas: r8a7796: add Sound SRC support Kuninori Morimoto
@ 2017-05-12 0:15 ` Kuninori Morimoto
2017-05-12 0:16 ` [PATCH v2 09/10] arm64: renesas: r8a7796: add Sound CTU support Kuninori Morimoto
` (3 subsequent siblings)
11 siblings, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:15 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index cca8dae..353e412 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1290,6 +1290,7 @@
<&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
<&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
<&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+ <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
<&audio_clk_a>, <&audio_clk_b>,
<&audio_clk_c>,
<&cpg CPG_CORE R8A7796_CLK_S0D4>;
@@ -1300,15 +1301,19 @@
"src.9", "src.8", "src.7", "src.6",
"src.5", "src.4", "src.3", "src.2",
"src.1", "src.0",
+ "dvc.0", "dvc.1",
"clk_a", "clk_b", "clk_c", "clk_i";
power-domains = <&cpg>;
status = "disabled";
rcar_sound,dvc {
dvc0: dvc-0 {
+ dmas = <&audma1 0xbc>;
+ dma-names = "tx";
};
-
dvc1: dvc-1 {
+ dmas = <&audma1 0xbe>;
+ dma-names = "tx";
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH v2 09/10] arm64: renesas: r8a7796: add Sound CTU support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (7 preceding siblings ...)
2017-05-12 0:15 ` [PATCH v2 08/10] arm64: renesas: r8a7796: add Sound DVC support Kuninori Morimoto
@ 2017-05-12 0:16 ` Kuninori Morimoto
2017-05-12 0:16 ` [PATCH v2 10/10] arm64: renesas: r8a7796: add Sound MIX support Kuninori Morimoto
` (2 subsequent siblings)
11 siblings, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:16 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 353e412..d982b5f 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1290,6 +1290,7 @@
<&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
<&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
<&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+ <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
<&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
<&audio_clk_a>, <&audio_clk_b>,
<&audio_clk_c>,
@@ -1301,6 +1302,7 @@
"src.9", "src.8", "src.7", "src.6",
"src.5", "src.4", "src.3", "src.2",
"src.1", "src.0",
+ "ctu.1", "ctu.0",
"dvc.0", "dvc.1",
"clk_a", "clk_b", "clk_c", "clk_i";
power-domains = <&cpg>;
@@ -1317,6 +1319,17 @@
};
};
+ rcar_sound,ctu {
+ ctu00: ctu-0 { };
+ ctu01: ctu-1 { };
+ ctu02: ctu-2 { };
+ ctu03: ctu-3 { };
+ ctu10: ctu-4 { };
+ ctu11: ctu-5 { };
+ ctu12: ctu-6 { };
+ ctu13: ctu-7 { };
+ };
+
rcar_sound,src {
src0: src-0 {
interrupts = <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH v2 10/10] arm64: renesas: r8a7796: add Sound MIX support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (8 preceding siblings ...)
2017-05-12 0:16 ` [PATCH v2 09/10] arm64: renesas: r8a7796: add Sound CTU support Kuninori Morimoto
@ 2017-05-12 0:16 ` Kuninori Morimoto
2017-05-12 0:17 ` [PATCH v2 --/--] arm64: renesas: r8a7796: add IPMMU support for AUDIO DMAC Kuninori Morimoto
2017-05-12 7:57 ` [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Simon Horman
11 siblings, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:16 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index d982b5f..c7bd585 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1291,6 +1291,7 @@
<&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
<&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
<&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
+ <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
<&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
<&audio_clk_a>, <&audio_clk_b>,
<&audio_clk_c>,
@@ -1302,6 +1303,7 @@
"src.9", "src.8", "src.7", "src.6",
"src.5", "src.4", "src.3", "src.2",
"src.1", "src.0",
+ "mix.1", "mix.0",
"ctu.1", "ctu.0",
"dvc.0", "dvc.1",
"clk_a", "clk_b", "clk_c", "clk_i";
@@ -1319,6 +1321,11 @@
};
};
+ rcar_sound,mix {
+ mix0: mix-0 { };
+ mix1: mix-1 { };
+ };
+
rcar_sound,ctu {
ctu00: ctu-0 { };
ctu01: ctu-1 { };
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH v2 --/--] arm64: renesas: r8a7796: add IPMMU support for AUDIO DMAC
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (9 preceding siblings ...)
2017-05-12 0:16 ` [PATCH v2 10/10] arm64: renesas: r8a7796: add Sound MIX support Kuninori Morimoto
@ 2017-05-12 0:17 ` Kuninori Morimoto
2017-05-12 7:57 ` [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Simon Horman
11 siblings, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2017-05-12 0:17 UTC (permalink / raw)
To: Simon, Geert Uytterhoeven; +Cc: Magnus, Linux-Renesas
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
- This is for renesas-drivers
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index c7bd585..f815532 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1083,6 +1083,14 @@
"ch12", "ch13", "ch14", "ch15";
clocks = <&cpg CPG_MOD 502>;
clock-names = "fck";
+ iommus = <&ipmmu_mp0 0>, <&ipmmu_mp0 1>,
+ <&ipmmu_mp0 2>, <&ipmmu_mp0 3>,
+ <&ipmmu_mp0 4>, <&ipmmu_mp0 5>,
+ <&ipmmu_mp0 6>, <&ipmmu_mp0 7>,
+ <&ipmmu_mp0 8>, <&ipmmu_mp0 9>,
+ <&ipmmu_mp0 10>, <&ipmmu_mp0 11>,
+ <&ipmmu_mp0 12>, <&ipmmu_mp0 13>,
+ <&ipmmu_mp0 14>, <&ipmmu_mp0 15>;
power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
resets = <&cpg 502>;
#dma-cells = <1>;
@@ -1117,6 +1125,14 @@
"ch12", "ch13", "ch14", "ch15";
clocks = <&cpg CPG_MOD 501>;
clock-names = "fck";
+ iommus = <&ipmmu_mp0 16>, <&ipmmu_mp0 17>,
+ <&ipmmu_mp0 18>, <&ipmmu_mp0 19>,
+ <&ipmmu_mp0 20>, <&ipmmu_mp0 21>,
+ <&ipmmu_mp0 22>, <&ipmmu_mp0 23>,
+ <&ipmmu_mp0 24>, <&ipmmu_mp0 25>,
+ <&ipmmu_mp0 26>, <&ipmmu_mp0 27>,
+ <&ipmmu_mp0 28>, <&ipmmu_mp0 29>,
+ <&ipmmu_mp0 30>, <&ipmmu_mp0 31>;
power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
resets = <&cpg 501>;
#dma-cells = <1>;
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support
2017-05-12 0:11 [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Kuninori Morimoto
` (10 preceding siblings ...)
2017-05-12 0:17 ` [PATCH v2 --/--] arm64: renesas: r8a7796: add IPMMU support for AUDIO DMAC Kuninori Morimoto
@ 2017-05-12 7:57 ` Simon Horman
2017-05-12 8:54 ` Simon Horman
11 siblings, 1 reply; 26+ messages in thread
From: Simon Horman @ 2017-05-12 7:57 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Geert Uytterhoeven, Magnus, Linux-Renesas
On Fri, May 12, 2017 at 12:11:49AM +0000, Kuninori Morimoto wrote:
>
> Hi Simon, Geert
>
> These are v2 of r8a7796 sound support patch-set.
> I separated Audio DMAC ipmmu patch.
>
> Kuninori Morimoto (10):
> pinctrl: sh-pfc: r8a7796: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239
> pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
> pinctrl: sh-pfc: r8a7796: add Audio clock pin support
> arm64: renesas: r8a7796: add AUDIO_DMAC support
> arm64: renesas: r8a7796: add Sound SSI PIO support
> arm64: renesas: r8a7796: add Sound SSI DMA support
> arm64: renesas: r8a7796: add Sound SRC support
> arm64: renesas: r8a7796: add Sound DVC support
> arm64: renesas: r8a7796: add Sound CTU support
> arm64: renesas: r8a7796: add Sound MIX support
Other than the, presumably expected kernel logs below, I didn't notice
any problems with the above arm64 patches applied to the renesas tree
without the pinctrl changes. On the strength of that I have queued these up
for v4.13. Let me know if that was not the desired outcome.
[ 1.662712] sh-pfc e6060000.pin-controller: function 'ssi' not supported
[ 1.669496] sh-pfc e6060000.pin-controller: invalid function ssi in map table
[ 1.676667] sh-pfc e6060000.pin-controller: function 'ssi' not supported
[ 1.683398] sh-pfc e6060000.pin-controller: invalid function ssi in map table
[ 1.690561] sh-pfc e6060000.pin-controller: function 'ssi' not supported
[ 1.697290] sh-pfc e6060000.pin-controller: invalid function ssi in map table
[ 1.704449] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
[ 1.711679] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
[ 1.719365] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
[ 1.726594] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
[ 1.734262] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
[ 1.741492] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
[ 1.749174] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
[ 1.756403] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
[ 1.764084] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
[ 1.771313] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
[ 1.778983] rcar_sound: probe of ec500000.sound failed with error -22
> This is for renesas-drivers
> arm64: renesas: r8a7796: add IPMMU support for AUDIO DMAC
>
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 233 +++++++++++++++++-
> drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 403 ++++++++++++++++++++++++++++++-
> 2 files changed, 627 insertions(+), 9 deletions(-)
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support
2017-05-12 7:57 ` [PATCH v2 00/10] arm64: renesas: r8a7796: add Sound support Simon Horman
@ 2017-05-12 8:54 ` Simon Horman
0 siblings, 0 replies; 26+ messages in thread
From: Simon Horman @ 2017-05-12 8:54 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Geert Uytterhoeven, Magnus, Linux-Renesas
On Fri, May 12, 2017 at 09:57:02AM +0200, Simon Horman wrote:
> On Fri, May 12, 2017 at 12:11:49AM +0000, Kuninori Morimoto wrote:
> >
> > Hi Simon, Geert
> >
> > These are v2 of r8a7796 sound support patch-set.
> > I separated Audio DMAC ipmmu patch.
> >
> > Kuninori Morimoto (10):
> > pinctrl: sh-pfc: r8a7796: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239
> > pinctrl: sh-pfc: r8a7796: add Audio SSI pin support
> > pinctrl: sh-pfc: r8a7796: add Audio clock pin support
> > arm64: renesas: r8a7796: add AUDIO_DMAC support
> > arm64: renesas: r8a7796: add Sound SSI PIO support
> > arm64: renesas: r8a7796: add Sound SSI DMA support
> > arm64: renesas: r8a7796: add Sound SRC support
> > arm64: renesas: r8a7796: add Sound DVC support
> > arm64: renesas: r8a7796: add Sound CTU support
> > arm64: renesas: r8a7796: add Sound MIX support
>
> Other than the, presumably expected kernel logs below, I didn't notice
> any problems with the above arm64 patches applied to the renesas tree
> without the pinctrl changes. On the strength of that I have queued these up
> for v4.13. Let me know if that was not the desired outcome.
>
> [ 1.662712] sh-pfc e6060000.pin-controller: function 'ssi' not supported
> [ 1.669496] sh-pfc e6060000.pin-controller: invalid function ssi in map table
> [ 1.676667] sh-pfc e6060000.pin-controller: function 'ssi' not supported
> [ 1.683398] sh-pfc e6060000.pin-controller: invalid function ssi in map table
> [ 1.690561] sh-pfc e6060000.pin-controller: function 'ssi' not supported
> [ 1.697290] sh-pfc e6060000.pin-controller: invalid function ssi in map table
> [ 1.704449] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
> [ 1.711679] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
> [ 1.719365] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
> [ 1.726594] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
> [ 1.734262] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
> [ 1.741492] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
> [ 1.749174] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
> [ 1.756403] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
> [ 1.764084] sh-pfc e6060000.pin-controller: function 'audio_clk' not supported
> [ 1.771313] sh-pfc e6060000.pin-controller: invalid function audio_clk in map table
> [ 1.778983] rcar_sound: probe of ec500000.sound failed with error -22
I should have mentioned that the above was on a salvator-x board.
> > This is for renesas-drivers
> > arm64: renesas: r8a7796: add IPMMU support for AUDIO DMAC
> >
> > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 233 +++++++++++++++++-
> > drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 403 ++++++++++++++++++++++++++++++-
> > 2 files changed, 627 insertions(+), 9 deletions(-)
> >
> > --
> > 1.9.1
> >
>
^ permalink raw reply [flat|nested] 26+ messages in thread