All of lore.kernel.org
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: kvm@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/7] arm64: tlbflush.h: add __tlbi() macro
Date: Mon, 03 Oct 2016 12:04:39 +0100	[thread overview]
Message-ID: <87twctzoag.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <20160928124806.GI24658@arm.com> (Will Deacon's message of "Wed, 28 Sep 2016 13:48:07 +0100")

Will Deacon <will.deacon@arm.com> writes:

> On Fri, Sep 23, 2016 at 05:07:10PM +0100, Will Deacon wrote:
>> On Tue, Sep 13, 2016 at 11:16:06AM +0100, Punit Agrawal wrote:
>> > From: Mark Rutland <mark.rutland@arm.com>
>> > 
>> > As with dsb() and isb(), add a __tlbi() helper so that we can avoid
>> > distracting asm boilerplate every time we want a TLBI. As some TLBI
>> > operations take an argument while others do not, some pre-processor is
>> > used to handle these two cases with different assembly blocks.
>> > 
>> > The existing tlbflush.h code is moved over to use the helper.
>> > 
>> > Signed-off-by: Mark Rutland <mark.rutland@arm.com>
>> > Cc: Catalin Marinas <catalin.marinas@arm.com>
>> > Cc: Marc Zyngier <marc.zyngier@arm.com>
>> > [ rename helper to __tlbi, update comment and commit log ]
>> > Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> > Reviewed-by: Will Deacon <will.deacon@arm.com>
>> > ---
>> >  arch/arm64/include/asm/tlbflush.h | 34 ++++++++++++++++++++++++++--------
>> >  1 file changed, 26 insertions(+), 8 deletions(-)
>> 
>> Given that this series seems to have stalled, I'm inclined to pick this
>> patch (and only this patch) up in the arm64 tree. It's a standalone tidy
>> up and means one fewer dependency next time round.

Agreed!

>
> Ok, I've picked this one up. Please re-post the rest of the series after
> the merge window.

Thanks for merging the patch. I'll re-post the series after the merge
window.

>
> Will
> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: punit.agrawal@arm.com (Punit Agrawal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] arm64: tlbflush.h: add __tlbi() macro
Date: Mon, 03 Oct 2016 12:04:39 +0100	[thread overview]
Message-ID: <87twctzoag.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <20160928124806.GI24658@arm.com> (Will Deacon's message of "Wed, 28 Sep 2016 13:48:07 +0100")

Will Deacon <will.deacon@arm.com> writes:

> On Fri, Sep 23, 2016 at 05:07:10PM +0100, Will Deacon wrote:
>> On Tue, Sep 13, 2016 at 11:16:06AM +0100, Punit Agrawal wrote:
>> > From: Mark Rutland <mark.rutland@arm.com>
>> > 
>> > As with dsb() and isb(), add a __tlbi() helper so that we can avoid
>> > distracting asm boilerplate every time we want a TLBI. As some TLBI
>> > operations take an argument while others do not, some pre-processor is
>> > used to handle these two cases with different assembly blocks.
>> > 
>> > The existing tlbflush.h code is moved over to use the helper.
>> > 
>> > Signed-off-by: Mark Rutland <mark.rutland@arm.com>
>> > Cc: Catalin Marinas <catalin.marinas@arm.com>
>> > Cc: Marc Zyngier <marc.zyngier@arm.com>
>> > [ rename helper to __tlbi, update comment and commit log ]
>> > Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> > Reviewed-by: Will Deacon <will.deacon@arm.com>
>> > ---
>> >  arch/arm64/include/asm/tlbflush.h | 34 ++++++++++++++++++++++++++--------
>> >  1 file changed, 26 insertions(+), 8 deletions(-)
>> 
>> Given that this series seems to have stalled, I'm inclined to pick this
>> patch (and only this patch) up in the arm64 tree. It's a standalone tidy
>> up and means one fewer dependency next time round.

Agreed!

>
> Ok, I've picked this one up. Please re-post the rest of the series after
> the merge window.

Thanks for merging the patch. I'll re-post the series after the merge
window.

>
> Will
> _______________________________________________
> kvmarm mailing list
> kvmarm at lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

  reply	other threads:[~2016-10-03 11:05 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 10:16 [PATCH 0/7] Add support for monitoring guest TLB operations Punit Agrawal
2016-09-13 10:16 ` Punit Agrawal
2016-09-13 10:16 ` Punit Agrawal
2016-09-13 10:16 ` [PATCH 1/7] perf/trace: Add notification for perf trace events Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16 ` [PATCH 2/7] KVM: Track the pid of the VM process Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16 ` [PATCH 3/7] KVM: arm/arm64: Register perf trace event notifier Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16 ` [PATCH 4/7] arm64: tlbflush.h: add __tlbi() macro Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-23 16:07   ` Will Deacon
2016-09-23 16:07     ` Will Deacon
2016-09-23 16:07     ` Will Deacon
2016-09-28 12:48     ` Will Deacon
2016-09-28 12:48       ` Will Deacon
2016-09-28 12:48       ` Will Deacon
2016-10-03 11:04       ` Punit Agrawal [this message]
2016-10-03 11:04         ` Punit Agrawal
2016-09-13 10:16 ` [PATCH 5/7] arm64/kvm: hyp: tlb: use __tlbi() helper Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-10-05 16:41   ` Matthias Brugger
2016-10-05 16:41     ` Matthias Brugger
2016-10-06  9:43     ` Punit Agrawal
2016-10-06  9:43       ` Punit Agrawal
2016-10-06  9:43       ` Punit Agrawal
2016-09-13 10:16 ` [PATCH 6/7] arm64: KVM: Handle trappable TLB instructions Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16 ` [PATCH 7/7] arm64: KVM: Enable selective trapping of " Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal
2016-09-13 10:16   ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twctzoag.fsf@e105922-lin.cambridge.arm.com \
    --to=punit.agrawal@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.