All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Armada 7k/8k SPI0 clock references fix
@ 2016-09-06 17:41 ` Marcin Wojtas
  0 siblings, 0 replies; 10+ messages in thread
From: Marcin Wojtas @ 2016-09-06 17:41 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel
  Cc: sebastian.hesselbarth, andrew, jason, thomas.petazzoni,
	gregory.clement, will.deacon, robh+dt, mark.rutland, nadavh,
	alior, mw, jaz, tn

Hi,

This tiny patchset comprises fixes for SPI0 interfaces in both
Armada 7k/8k CP110 HW blocks. It's split into two, because
the fix in armada-cp110-master.dtsi is applicable also on
v4.7 stable branch (cc'ed).

Any feedback would be welcome.

Best regards,
Marcin

Marcin Wojtas (2):
  arm64: dts: marvell: fix clocksource for CP110 master SPI0
  arm64: dts: marvell: fix clocksource for CP110 slave SPI0

 arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
 arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 0/2] Armada 7k/8k SPI0 clock references fix
@ 2016-09-06 17:41 ` Marcin Wojtas
  0 siblings, 0 replies; 10+ messages in thread
From: Marcin Wojtas @ 2016-09-06 17:41 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

This tiny patchset comprises fixes for SPI0 interfaces in both
Armada 7k/8k CP110 HW blocks. It's split into two, because
the fix in armada-cp110-master.dtsi is applicable also on
v4.7 stable branch (cc'ed).

Any feedback would be welcome.

Best regards,
Marcin

Marcin Wojtas (2):
  arm64: dts: marvell: fix clocksource for CP110 master SPI0
  arm64: dts: marvell: fix clocksource for CP110 slave SPI0

 arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
 arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] arm64: dts: marvell: fix clocksource for CP110 master SPI0
  2016-09-06 17:41 ` Marcin Wojtas
@ 2016-09-06 17:41   ` Marcin Wojtas
  -1 siblings, 0 replies; 10+ messages in thread
From: Marcin Wojtas @ 2016-09-06 17:41 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel
  Cc: sebastian.hesselbarth, andrew, jason, thomas.petazzoni,
	gregory.clement, will.deacon, robh+dt, mark.rutland, nadavh,
	alior, mw, jaz, tn, stable

I2C and SPI interfaces share common clock trees within the CP110 HW block.
It occurred that SPI0 interface has wrong clock assignment in the device
tree, which is fixed in this commit to a proper value.

Fixes: 728dacc7f4dd ("arm64: dts: marvell: initial DT description of ...")
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
CC: <stable@vger.kernel.org> v4.7+
---
 arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
index db1be4c..903b0f6 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
@@ -133,7 +133,7 @@
 				#address-cells = <0x1>;
 				#size-cells = <0x0>;
 				cell-index = <1>;
-				clocks = <&cpm_syscon0 0 3>;
+				clocks = <&cpm_syscon0 1 21>;
 				status = "disabled";
 			};
 
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 1/2] arm64: dts: marvell: fix clocksource for CP110 master SPI0
@ 2016-09-06 17:41   ` Marcin Wojtas
  0 siblings, 0 replies; 10+ messages in thread
From: Marcin Wojtas @ 2016-09-06 17:41 UTC (permalink / raw)
  To: linux-arm-kernel

I2C and SPI interfaces share common clock trees within the CP110 HW block.
It occurred that SPI0 interface has wrong clock assignment in the device
tree, which is fixed in this commit to a proper value.

Fixes: 728dacc7f4dd ("arm64: dts: marvell: initial DT description of ...")
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
CC: <stable@vger.kernel.org> v4.7+
---
 arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
index db1be4c..903b0f6 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
@@ -133,7 +133,7 @@
 				#address-cells = <0x1>;
 				#size-cells = <0x0>;
 				cell-index = <1>;
-				clocks = <&cpm_syscon0 0 3>;
+				clocks = <&cpm_syscon0 1 21>;
 				status = "disabled";
 			};
 
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] arm64: dts: marvell: fix clocksource for CP110 slave SPI0
  2016-09-06 17:41 ` Marcin Wojtas
@ 2016-09-06 17:41   ` Marcin Wojtas
  -1 siblings, 0 replies; 10+ messages in thread
From: Marcin Wojtas @ 2016-09-06 17:41 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel
  Cc: sebastian.hesselbarth, andrew, jason, thomas.petazzoni,
	gregory.clement, will.deacon, robh+dt, mark.rutland, nadavh,
	alior, mw, jaz, tn

I2C and SPI interfaces share common clock trees within the CP110 HW block.
It occurred that SPI0 interface has wrong clock assignment in the device
tree, which is fixed in this commit to a proper value.

Fixes: c749b8d9de32 ("arm64: dts: marvell: add description for the ...")
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
index 37bff70..150675c 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
@@ -133,7 +133,7 @@
 				#address-cells = <0x1>;
 				#size-cells = <0x0>;
 				cell-index = <1>;
-				clocks = <&cps_syscon0 0 3>;
+				clocks = <&cps_syscon0 1 21>;
 				status = "disabled";
 			};
 
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] arm64: dts: marvell: fix clocksource for CP110 slave SPI0
@ 2016-09-06 17:41   ` Marcin Wojtas
  0 siblings, 0 replies; 10+ messages in thread
From: Marcin Wojtas @ 2016-09-06 17:41 UTC (permalink / raw)
  To: linux-arm-kernel

I2C and SPI interfaces share common clock trees within the CP110 HW block.
It occurred that SPI0 interface has wrong clock assignment in the device
tree, which is fixed in this commit to a proper value.

Fixes: c749b8d9de32 ("arm64: dts: marvell: add description for the ...")
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
index 37bff70..150675c 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
@@ -133,7 +133,7 @@
 				#address-cells = <0x1>;
 				#size-cells = <0x0>;
 				cell-index = <1>;
-				clocks = <&cps_syscon0 0 3>;
+				clocks = <&cps_syscon0 1 21>;
 				status = "disabled";
 			};
 
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arm64: dts: marvell: fix clocksource for CP110 master SPI0
  2016-09-06 17:41   ` Marcin Wojtas
@ 2016-09-20 14:56     ` Gregory CLEMENT
  -1 siblings, 0 replies; 10+ messages in thread
From: Gregory CLEMENT @ 2016-09-20 14:56 UTC (permalink / raw)
  To: Marcin Wojtas
  Cc: linux-kernel, linux-arm-kernel, sebastian.hesselbarth, andrew,
	jason, thomas.petazzoni, will.deacon, robh+dt, mark.rutland,
	nadavh, alior, jaz, tn, stable

Hi Marcin,
 
 On mar., sept. 06 2016, Marcin Wojtas <mw@semihalf.com> wrote:

> I2C and SPI interfaces share common clock trees within the CP110 HW block.
> It occurred that SPI0 interface has wrong clock assignment in the device
> tree, which is fixed in this commit to a proper value.
>
> Fixes: 728dacc7f4dd ("arm64: dts: marvell: initial DT description of ...")
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> CC: <stable@vger.kernel.org> v4.7+

Applied on mvebu/fixes

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> index db1be4c..903b0f6 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> @@ -133,7 +133,7 @@
>  				#address-cells = <0x1>;
>  				#size-cells = <0x0>;
>  				cell-index = <1>;
> -				clocks = <&cpm_syscon0 0 3>;
> +				clocks = <&cpm_syscon0 1 21>;
>  				status = "disabled";
>  			};
>  
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] arm64: dts: marvell: fix clocksource for CP110 master SPI0
@ 2016-09-20 14:56     ` Gregory CLEMENT
  0 siblings, 0 replies; 10+ messages in thread
From: Gregory CLEMENT @ 2016-09-20 14:56 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Marcin,
 
 On mar., sept. 06 2016, Marcin Wojtas <mw@semihalf.com> wrote:

> I2C and SPI interfaces share common clock trees within the CP110 HW block.
> It occurred that SPI0 interface has wrong clock assignment in the device
> tree, which is fixed in this commit to a proper value.
>
> Fixes: 728dacc7f4dd ("arm64: dts: marvell: initial DT description of ...")
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> CC: <stable@vger.kernel.org> v4.7+

Applied on mvebu/fixes

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> index db1be4c..903b0f6 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> @@ -133,7 +133,7 @@
>  				#address-cells = <0x1>;
>  				#size-cells = <0x0>;
>  				cell-index = <1>;
> -				clocks = <&cpm_syscon0 0 3>;
> +				clocks = <&cpm_syscon0 1 21>;
>  				status = "disabled";
>  			};
>  
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] arm64: dts: marvell: fix clocksource for CP110 slave SPI0
  2016-09-06 17:41   ` Marcin Wojtas
@ 2016-09-20 15:07     ` Gregory CLEMENT
  -1 siblings, 0 replies; 10+ messages in thread
From: Gregory CLEMENT @ 2016-09-20 15:07 UTC (permalink / raw)
  To: Arnd Bergmann, Olof Johansson, Marcin Wojtas
  Cc: linux-kernel, linux-arm-kernel, sebastian.hesselbarth, andrew,
	jason, thomas.petazzoni, will.deacon, robh+dt, mark.rutland,
	nadavh, alior, jaz, tn

Hi Olof and Arnd,
 
 On mar., sept. 06 2016, Marcin Wojtas <mw@semihalf.com> wrote:

> I2C and SPI interfaces share common clock trees within the CP110 HW block.
> It occurred that SPI0 interface has wrong clock assignment in the device
> tree, which is fixed in this commit to a proper value.
>
> Fixes: c749b8d9de32 ("arm64: dts: marvell: add description for the ...")
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Could you take this patch for 4.9? I didn't realized at first view it
was for 4.9, I though I could put it the PR for fixes for 4.8.

I can do a new PR for dt64 with this single patch if you prefer.

The last option will be to have it as a fix for v4.9-rc2.

Thanks,

Gregory



> ---
>  arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> index 37bff70..150675c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> @@ -133,7 +133,7 @@
>  				#address-cells = <0x1>;
>  				#size-cells = <0x0>;
>  				cell-index = <1>;
> -				clocks = <&cps_syscon0 0 3>;
> +				clocks = <&cps_syscon0 1 21>;
>  				status = "disabled";
>  			};
>  
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 2/2] arm64: dts: marvell: fix clocksource for CP110 slave SPI0
@ 2016-09-20 15:07     ` Gregory CLEMENT
  0 siblings, 0 replies; 10+ messages in thread
From: Gregory CLEMENT @ 2016-09-20 15:07 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Olof and Arnd,
 
 On mar., sept. 06 2016, Marcin Wojtas <mw@semihalf.com> wrote:

> I2C and SPI interfaces share common clock trees within the CP110 HW block.
> It occurred that SPI0 interface has wrong clock assignment in the device
> tree, which is fixed in this commit to a proper value.
>
> Fixes: c749b8d9de32 ("arm64: dts: marvell: add description for the ...")
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Could you take this patch for 4.9? I didn't realized at first view it
was for 4.9, I though I could put it the PR for fixes for 4.8.

I can do a new PR for dt64 with this single patch if you prefer.

The last option will be to have it as a fix for v4.9-rc2.

Thanks,

Gregory



> ---
>  arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> index 37bff70..150675c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> @@ -133,7 +133,7 @@
>  				#address-cells = <0x1>;
>  				#size-cells = <0x0>;
>  				cell-index = <1>;
> -				clocks = <&cps_syscon0 0 3>;
> +				clocks = <&cps_syscon0 1 21>;
>  				status = "disabled";
>  			};
>  
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-09-20 15:07 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 17:41 [PATCH 0/2] Armada 7k/8k SPI0 clock references fix Marcin Wojtas
2016-09-06 17:41 ` Marcin Wojtas
2016-09-06 17:41 ` [PATCH 1/2] arm64: dts: marvell: fix clocksource for CP110 master SPI0 Marcin Wojtas
2016-09-06 17:41   ` Marcin Wojtas
2016-09-20 14:56   ` Gregory CLEMENT
2016-09-20 14:56     ` Gregory CLEMENT
2016-09-06 17:41 ` [PATCH 2/2] arm64: dts: marvell: fix clocksource for CP110 slave SPI0 Marcin Wojtas
2016-09-06 17:41   ` Marcin Wojtas
2016-09-20 15:07   ` Gregory CLEMENT
2016-09-20 15:07     ` Gregory CLEMENT

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.