* [PATCH, RESEND] ssb: host_soc depends on sprom
@ 2016-02-25 20:57 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-02-25 20:57 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-arm-kernel, Michael Buesch, linux-wireless,
Rafał Miłecki, Arnd Bergmann, linux-kernel
Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
a build failure unless at least one of the other drivers that selects
it is enabled:
drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
This adds the same select statement that is used elsewhere.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
---
drivers/ssb/Kconfig | 1 +
1 file changed, 1 insertion(+)
I just noticed this hasn't shown up in linux-next yet, so I'm resending
it to ensure it's still on someone's radar. Please ignore the resend
if it's already in a tree that is not part of linux-next but will
be merged eventually.
See https://patchwork.linux-mips.org/patch/12091/ for the original
submission.
diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 0c675861623f..d8e4219c2324 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -83,6 +83,7 @@ config SSB_SDIOHOST
config SSB_HOST_SOC
bool "Support for SSB bus on SoC"
depends on SSB && BCM47XX_NVRAM
+ select SSB_SPROM
help
Host interface for a SSB directly mapped into memory. This is
for some Broadcom SoCs from the BCM47xx and BCM53xx lines.
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH, RESEND] ssb: host_soc depends on sprom
@ 2016-02-25 20:57 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-02-25 20:57 UTC (permalink / raw)
To: linux-arm-kernel
Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
a build failure unless at least one of the other drivers that selects
it is enabled:
drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
This adds the same select statement that is used elsewhere.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
---
drivers/ssb/Kconfig | 1 +
1 file changed, 1 insertion(+)
I just noticed this hasn't shown up in linux-next yet, so I'm resending
it to ensure it's still on someone's radar. Please ignore the resend
if it's already in a tree that is not part of linux-next but will
be merged eventually.
See https://patchwork.linux-mips.org/patch/12091/ for the original
submission.
diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 0c675861623f..d8e4219c2324 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -83,6 +83,7 @@ config SSB_SDIOHOST
config SSB_HOST_SOC
bool "Support for SSB bus on SoC"
depends on SSB && BCM47XX_NVRAM
+ select SSB_SPROM
help
Host interface for a SSB directly mapped into memory. This is
for some Broadcom SoCs from the BCM47xx and BCM53xx lines.
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH, RESEND] ssb: host_soc depends on sprom
2016-02-25 20:57 ` Arnd Bergmann
@ 2016-02-26 7:11 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-02-26 7:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Michael Buesch, linux-wireless,
Rafał Miłecki, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
> ---
> drivers/ssb/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> I just noticed this hasn't shown up in linux-next yet, so I'm resending
> it to ensure it's still on someone's radar. Please ignore the resend
> if it's already in a tree that is not part of linux-next but will
> be merged eventually.
>
> See https://patchwork.linux-mips.org/patch/12091/ for the original
> submission.
Sorry, I didn't notice that linux-wireless was not CCed and I missed the
patch because it was not in my patchwork queue. But the patch is now
there and I should get to it in few days:
https://patchwork.kernel.org/patch/8426571/
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH, RESEND] ssb: host_soc depends on sprom
@ 2016-02-26 7:11 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-02-26 7:11 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
> ---
> drivers/ssb/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> I just noticed this hasn't shown up in linux-next yet, so I'm resending
> it to ensure it's still on someone's radar. Please ignore the resend
> if it's already in a tree that is not part of linux-next but will
> be merged eventually.
>
> See https://patchwork.linux-mips.org/patch/12091/ for the original
> submission.
Sorry, I didn't notice that linux-wireless was not CCed and I missed the
patch because it was not in my patchwork queue. But the patch is now
there and I should get to it in few days:
https://patchwork.kernel.org/patch/8426571/
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH, RESEND] ssb: host_soc depends on sprom
2016-02-25 20:57 ` Arnd Bergmann
@ 2016-02-26 7:18 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-02-26 7:18 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Michael Buesch, linux-wireless,
Rafał Miłecki, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
I'm planning to queue this to 4.5.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH, RESEND] ssb: host_soc depends on sprom
@ 2016-02-26 7:18 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-02-26 7:18 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
I'm planning to queue this to 4.5.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND] ssb: host_soc depends on sprom
2016-02-25 20:57 ` Arnd Bergmann
` (3 preceding siblings ...)
(?)
@ 2016-02-26 10:48 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-02-26 10:48 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Kalle Valo, linux-arm-kernel, Michael Buesch, linux-wireless,
Rafał Miłecki, Arnd Bergmann, linux-kernel
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
Thanks, applied to wireless-drivers.git.
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND] ssb: host_soc depends on sprom
2016-02-25 20:57 ` Arnd Bergmann
` (2 preceding siblings ...)
(?)
@ 2016-02-26 10:48 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2016-02-26 10:48 UTC (permalink / raw)
To: linux-arm-kernel
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
Thanks, applied to wireless-drivers.git.
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-26 10:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-25 20:57 [PATCH, RESEND] ssb: host_soc depends on sprom Arnd Bergmann
2016-02-25 20:57 ` Arnd Bergmann
2016-02-26 7:11 ` Kalle Valo
2016-02-26 7:11 ` Kalle Valo
2016-02-26 7:18 ` Kalle Valo
2016-02-26 7:18 ` Kalle Valo
2016-02-26 10:48 ` [RESEND] " Kalle Valo
2016-02-26 10:48 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.