From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Stewart Smith <stewart@linux.vnet.ibm.com>
Subject: Re: linux-next: build failure after merge of the modules tree
Date: Thu, 07 Aug 2014 21:07:20 +0930 [thread overview]
Message-ID: <87tx5ocyz3.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20140807132017.2ec9e2ad@canb.auug.org.au>
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Rusty,
>
> After merging the modules tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> arch/powerpc/platforms/powernv/opal-elog.c:85:28: error: macro "__ATTR_RO" passed 2 arguments, but takes just 1
> __ATTR_RO(id, elog_id_show);
Ah, crap. I really hate that macro magic :(
I amended to the minimal fix, so we can pretend that never happened.
Cheers,
Rusty.
commit 6656c21ca10e54a84673d0ec2f0cf5f676e66a40
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed Aug 6 10:15:36 2014 +0930
arch/powerpc/platforms/powernv/opal-elog.c: fix world-writable sysfs files
If you don't have a store function, you're not writable anyway!
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Stewart Smith <stewart@linux.vnet.ibm.com>
diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
index 10268c41d830..925bad993e30 100644
--- a/arch/powerpc/platforms/powernv/opal-elog.c
+++ b/arch/powerpc/platforms/powernv/opal-elog.c
@@ -82,9 +82,9 @@ static ssize_t elog_ack_store(struct elog_obj *elog_obj,
}
static struct elog_attribute id_attribute =
- __ATTR(id, 0666, elog_id_show, NULL);
+ __ATTR(id, S_IRUGO, elog_id_show, NULL);
static struct elog_attribute type_attribute =
- __ATTR(type, 0666, elog_type_show, NULL);
+ __ATTR(type, S_IRUGO, elog_type_show, NULL);
static struct elog_attribute ack_attribute =
__ATTR(acknowledge, 0660, elog_ack_show, elog_ack_store);
next prev parent reply other threads:[~2014-08-07 11:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 3:20 linux-next: build failure after merge of the modules tree Stephen Rothwell
2014-08-07 11:37 ` Rusty Russell [this message]
2014-08-07 13:03 ` Stephen Rothwell
2014-08-07 13:07 ` Rusty Russell
2014-08-08 1:33 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-02-02 1:03 Stephen Rothwell
2022-11-14 0:13 Stephen Rothwell
2022-11-14 8:01 ` Jiri Olsa
2022-11-14 9:08 ` Leizhen (ThunderTown)
2022-02-21 16:07 broonie
2022-02-23 0:32 ` Luis Chamberlain
2022-02-28 5:13 ` Stephen Rothwell
2022-02-28 18:16 ` Luis Chamberlain
2021-02-09 10:08 Stephen Rothwell
2021-02-09 15:16 ` Jessica Yu
2021-02-09 16:06 ` Christoph Hellwig
2021-02-09 21:50 ` Stephen Rothwell
2021-02-10 8:06 ` Jessica Yu
2021-02-10 8:37 ` Masahiro Yamada
2021-02-11 6:19 ` Masahiro Yamada
2021-02-10 12:21 ` Stephen Rothwell
2021-02-10 16:16 ` Jessica Yu
2019-06-25 4:27 Stephen Rothwell
2015-12-01 20:23 Mark Brown
2015-12-02 3:23 ` Rusty Russell
2015-11-27 1:26 Stephen Rothwell
2015-11-27 2:57 ` Rusty Russell
2015-06-25 6:54 Stephen Rothwell
2015-06-25 9:51 ` Dan Streetman
2015-06-24 1:37 Stephen Rothwell
2015-06-24 18:18 ` Dan Streetman
2015-06-24 22:57 ` Stephen Rothwell
2015-06-25 1:50 ` Stephen Rothwell
2014-12-18 2:05 Stephen Rothwell
2014-07-28 3:58 Stephen Rothwell
2014-07-28 11:38 ` Rusty Russell
2014-03-25 3:02 Stephen Rothwell
2014-03-31 3:45 ` Rusty Russell
2012-11-26 4:10 Stephen Rothwell
2012-11-28 11:02 ` Stanislaw Gruszka
2012-12-03 0:29 ` Rusty Russell
2012-11-02 1:57 Stephen Rothwell
2012-11-02 3:16 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx5ocyz3.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.