Re: [PATCH v2 4/4] Add the NVMM acceleration enlightenments

From: Markus Armbruster <armbru@redhat.com>
To: Kamil Rytarowski <n54@gmx.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Sergio Lopez" <slp@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	max@m00nbsd.net, "Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v2 4/4] Add the NVMM acceleration enlightenments
Date: Thu, 06 Feb 2020 15:13:14 +0100	[thread overview]
Message-ID: <87v9ojst1h.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <e87ac5e1-749e-84a2-2c9e-89ac1c69fcdc@gmx.com> (Kamil Rytarowski's message of "Thu, 6 Feb 2020 14:31:08 +0100")

Kamil Rytarowski <n54@gmx.com> writes:

> On 06.02.2020 14:09, Philippe Mathieu-Daudé wrote:
>> On Thu, Feb 6, 2020 at 2:06 PM Markus Armbruster <armbru@redhat.com> wrote:
>>> Kamil Rytarowski <n54@gmx.com> writes:
>>>
>>>> On 03.02.2020 12:54, Philippe Mathieu-Daudé wrote:
>>>>>> @@ -2029,6 +2072,19 @@ static void qemu_whpx_start_vcpu(CPUState *cpu)
>>>>>>   #endif
>>>>>>   }
>>>>>>
>>>>>> +static void qemu_nvmm_start_vcpu(CPUState *cpu)
>>>>>> +{
>>>>>> +    char thread_name[VCPU_THREAD_NAME_SIZE];
>>>>>> +
>>>>>> +    cpu->thread = g_malloc0(sizeof(QemuThread));
>>>>>> +    cpu->halt_cond = g_malloc0(sizeof(QemuCond));
>>>>>
>>>>> Nitpick, we prefer g_new0().
>>>>
>>>> In this file other qemu_*_start_vcpu() use  g_malloc0().
>>>>
>>>> I will leave this part unchanged and defer tor future style fixups if
>>>> someone is interested.
>>>
>>> Time to re-run Coccinelle with the semantic patch from commit
>>> b45c03f585e.
>>
>> I thought about it, but then noticed it would be clever to modify
>> checkpatch to refuse 'g_malloc0?(.*sizeof.*);'
>>
>>
>
> As the patchset was reviewed, could we please merge it in the current
> (v3) form (*) please?

No objection.  If I wanted you to clean this up before we accept your
work, I would've told you :)

[...]