* [Buildroot] [PATCH] Makefile: help: BR2_DEFCONFIG for defconfig must be on command line
@ 2018-07-22 21:34 Arnout Vandecappelle
2018-07-28 21:22 ` Thomas Petazzoni
2018-08-23 20:03 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2018-07-22 21:34 UTC (permalink / raw)
To: buildroot
The help text says that BR2_DEFCONFIG will be used as input, but a
BR2_DEFCONFIG specified in the existing .config file will *not* be
used. So say explicitly that it must be specified on the command line.
Note that both "BR2_DEFCONFIG=... make defconfig" and
"make defconfig BR2_DEFCONFIG=..." will work.
While we're at it, add a semicolon to separate the two statements.
Note that this overflows the help text beyond 80 characters, but that
is already the case in many other lines.
Reported-by: "aissen" on IRC
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 8d25c8a239..37c7072c7c 100644
--- a/Makefile
+++ b/Makefile
@@ -1020,8 +1020,8 @@ help:
@echo ' silentoldconfig - Same as oldconfig, but quietly, additionally update deps'
@echo ' olddefconfig - Same as silentoldconfig but sets new symbols to their default value'
@echo ' randconfig - New config with random answer to all options'
- @echo ' defconfig - New config with default answer to all options'
- @echo ' BR2_DEFCONFIG, if set, is used as input'
+ @echo ' defconfig - New config with default answer to all options;'
+ @echo ' BR2_DEFCONFIG, if set on the command line, is used as input'
@echo ' savedefconfig - Save current config to BR2_DEFCONFIG (minimal config)'
@echo ' allyesconfig - New config where all options are accepted with yes'
@echo ' allnoconfig - New config where all options are answered with no'
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] Makefile: help: BR2_DEFCONFIG for defconfig must be on command line
2018-07-22 21:34 [Buildroot] [PATCH] Makefile: help: BR2_DEFCONFIG for defconfig must be on command line Arnout Vandecappelle
@ 2018-07-28 21:22 ` Thomas Petazzoni
2018-08-23 20:03 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-07-28 21:22 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 22 Jul 2018 23:34:45 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> The help text says that BR2_DEFCONFIG will be used as input, but a
> BR2_DEFCONFIG specified in the existing .config file will *not* be
> used. So say explicitly that it must be specified on the command line.
> Note that both "BR2_DEFCONFIG=... make defconfig" and
> "make defconfig BR2_DEFCONFIG=..." will work.
>
> While we're at it, add a semicolon to separate the two statements.
>
> Note that this overflows the help text beyond 80 characters, but that
> is already the case in many other lines.
>
> Reported-by: "aissen" on IRC
aissen is Anisse Astier, so I've fixed that up when applying.
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] Makefile: help: BR2_DEFCONFIG for defconfig must be on command line
2018-07-22 21:34 [Buildroot] [PATCH] Makefile: help: BR2_DEFCONFIG for defconfig must be on command line Arnout Vandecappelle
2018-07-28 21:22 ` Thomas Petazzoni
@ 2018-08-23 20:03 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-08-23 20:03 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> The help text says that BR2_DEFCONFIG will be used as input, but a
> BR2_DEFCONFIG specified in the existing .config file will *not* be
> used. So say explicitly that it must be specified on the command line.
> Note that both "BR2_DEFCONFIG=... make defconfig" and
> "make defconfig BR2_DEFCONFIG=..." will work.
> While we're at it, add a semicolon to separate the two statements.
> Note that this overflows the help text beyond 80 characters, but that
> is already the case in many other lines.
> Reported-by: "aissen" on IRC
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed to 2018.02.x and 2018.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-23 20:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-22 21:34 [Buildroot] [PATCH] Makefile: help: BR2_DEFCONFIG for defconfig must be on command line Arnout Vandecappelle
2018-07-28 21:22 ` Thomas Petazzoni
2018-08-23 20:03 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.