[PATCH 0/7] drm/i915: move towards kernel types

[PATCH 0/7] drm/i915: move towards kernel types

[Jani Nikula]

Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
conflict much with in-flight patches.

The trouble with mixed use is that it's inconsistent, and any remaining C99
types will encourage their use. We could at least do the low hanging fruit?

$ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n

BR,
Jani.


Jani Nikula (7):
  drm/i915/vbt: switch to kernel unsigned int types
  drm/i915/hdmi: switch to kernel unsigned int types
  drm/i915/uncore: switch to kernel unsigned int types
  drm/i915/dvo: switch to kernel unsigned int types
  drm/i915/backlight: switch to kernel unsigned int types
  drm/i915/audio: switch to kernel unsigned int types
  drm/i915/lspcon: switch to kernel unsigned int types

 drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
 drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
 drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
 drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
 drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
 drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
 drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
 drivers/gpu/drm/i915/intel_bios.c             |  4 +--
 drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
 drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
 drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
 drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
 drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
 drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
 drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
 15 files changed, 120 insertions(+), 120 deletions(-)

-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 1/7] drm/i915/vbt: switch to kernel unsigned int types

[Jani Nikula]

We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
to stick to kernel types at least where it's more prevalent.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c     | 4 ++--
 drivers/gpu/drm/i915/intel_vbt_defs.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 18b9e0444116..62a53eb89b6b 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -652,7 +652,7 @@ parse_edp(struct drm_i915_private *dev_priv, const struct bdb_header *bdb)
 	}
 
 	if (bdb->version >= 173) {
-		uint8_t vswing;
+		u8 vswing;
 
 		/* Don't read from VBT if module parameter has valid value*/
 		if (i915_modparams.edp_vswing) {
@@ -964,7 +964,7 @@ static int goto_next_sequence_v3(const u8 *data, int index, int total)
 	 * includes MIPI_SEQ_ELEM_END byte, excludes the final MIPI_SEQ_END
 	 * byte.
 	 */
-	size_of_sequence = *((const uint32_t *)(data + index));
+	size_of_sequence = *((const u32 *)(data + index));
 	index += 4;
 
 	seq_end = index + size_of_sequence;
diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h
index c132d0c3a500..5f2a9052a190 100644
--- a/drivers/gpu/drm/i915/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
@@ -454,7 +454,7 @@ struct bdb_general_definitions {
 	 * number = (block_size - sizeof(bdb_general_definitions))/
 	 *	     defs->child_dev_size;
 	 */
-	uint8_t devices[0];
+	u8 devices[0];
 } __packed;
 
 /* Mask for DRRS / Panel Channel / SSC / BLT control bits extraction */
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/7] drm/i915/hdmi: switch to kernel unsigned int types

[Jani Nikula]

We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
to stick to kernel types at least where it's more prevalent.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 0ca4cc877520..6e3c4e27c65a 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -51,7 +51,7 @@ assert_hdmi_port_disabled(struct intel_hdmi *intel_hdmi)
 {
 	struct drm_device *dev = intel_hdmi_to_dev(intel_hdmi);
 	struct drm_i915_private *dev_priv = to_i915(dev);
-	uint32_t enabled_bits;
+	u32 enabled_bits;
 
 	enabled_bits = HAS_DDI(dev_priv) ? DDI_BUF_CTL_ENABLE : SDVO_ENABLE;
 
@@ -144,7 +144,7 @@ static void g4x_write_infoframe(struct drm_encoder *encoder,
 				unsigned int type,
 				const void *frame, ssize_t len)
 {
-	const uint32_t *data = frame;
+	const u32 *data = frame;
 	struct drm_device *dev = encoder->dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	u32 val = I915_READ(VIDEO_DIP_CTL);
@@ -199,7 +199,7 @@ static void ibx_write_infoframe(struct drm_encoder *encoder,
 				unsigned int type,
 				const void *frame, ssize_t len)
 {
-	const uint32_t *data = frame;
+	const u32 *data = frame;
 	struct drm_device *dev = encoder->dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state->base.crtc);
@@ -259,7 +259,7 @@ static void cpt_write_infoframe(struct drm_encoder *encoder,
 				unsigned int type,
 				const void *frame, ssize_t len)
 {
-	const uint32_t *data = frame;
+	const u32 *data = frame;
 	struct drm_device *dev = encoder->dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state->base.crtc);
@@ -317,7 +317,7 @@ static void vlv_write_infoframe(struct drm_encoder *encoder,
 				unsigned int type,
 				const void *frame, ssize_t len)
 {
-	const uint32_t *data = frame;
+	const u32 *data = frame;
 	struct drm_device *dev = encoder->dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state->base.crtc);
@@ -376,7 +376,7 @@ static void hsw_write_infoframe(struct drm_encoder *encoder,
 				unsigned int type,
 				const void *frame, ssize_t len)
 {
-	const uint32_t *data = frame;
+	const u32 *data = frame;
 	struct drm_device *dev = encoder->dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
@@ -442,7 +442,7 @@ static void intel_write_infoframe(struct drm_encoder *encoder,
 				  union hdmi_infoframe *frame)
 {
 	struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder);
-	uint8_t buffer[VIDEO_DIP_DATA_SIZE];
+	u8 buffer[VIDEO_DIP_DATA_SIZE];
 	ssize_t len;
 
 	/* see comment above for the reason for this offset */
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 3/7] drm/i915/uncore: switch to kernel unsigned int types

[Jani Nikula]

We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
to stick to kernel types at least where it's more prevalent.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_uncore.h | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_uncore.h b/drivers/gpu/drm/i915/intel_uncore.h
index 47478d609630..2fbe93178fb2 100644
--- a/drivers/gpu/drm/i915/intel_uncore.h
+++ b/drivers/gpu/drm/i915/intel_uncore.h
@@ -67,21 +67,21 @@ struct intel_uncore_funcs {
 	void (*force_wake_put)(struct drm_i915_private *dev_priv,
 			       enum forcewake_domains domains);
 
-	uint8_t  (*mmio_readb)(struct drm_i915_private *dev_priv,
-			       i915_reg_t r, bool trace);
-	uint16_t (*mmio_readw)(struct drm_i915_private *dev_priv,
-			       i915_reg_t r, bool trace);
-	uint32_t (*mmio_readl)(struct drm_i915_private *dev_priv,
-			       i915_reg_t r, bool trace);
-	uint64_t (*mmio_readq)(struct drm_i915_private *dev_priv,
-			       i915_reg_t r, bool trace);
+	u8 (*mmio_readb)(struct drm_i915_private *dev_priv,
+			 i915_reg_t r, bool trace);
+	u16 (*mmio_readw)(struct drm_i915_private *dev_priv,
+			  i915_reg_t r, bool trace);
+	u32 (*mmio_readl)(struct drm_i915_private *dev_priv,
+			  i915_reg_t r, bool trace);
+	u64 (*mmio_readq)(struct drm_i915_private *dev_priv,
+			  i915_reg_t r, bool trace);
 
 	void (*mmio_writeb)(struct drm_i915_private *dev_priv,
-			    i915_reg_t r, uint8_t val, bool trace);
+			    i915_reg_t r, u8 val, bool trace);
 	void (*mmio_writew)(struct drm_i915_private *dev_priv,
-			    i915_reg_t r, uint16_t val, bool trace);
+			    i915_reg_t r, u16 val, bool trace);
 	void (*mmio_writel)(struct drm_i915_private *dev_priv,
-			    i915_reg_t r, uint32_t val, bool trace);
+			    i915_reg_t r, u32 val, bool trace);
 };
 
 struct intel_forcewake_range {
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 4/7] drm/i915/dvo: switch to kernel unsigned int types

[Jani Nikula]

We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
to stick to kernel types at least where it's more prevalent.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/dvo_ch7017.c | 20 +++++++++---------
 drivers/gpu/drm/i915/dvo_ch7xxx.c | 22 ++++++++++----------
 drivers/gpu/drm/i915/dvo_ivch.c   | 26 +++++++++++------------
 drivers/gpu/drm/i915/dvo_ns2501.c | 44 +++++++++++++++++++--------------------
 drivers/gpu/drm/i915/dvo_sil164.c | 10 ++++-----
 drivers/gpu/drm/i915/dvo_tfp410.c | 16 +++++++-------
 drivers/gpu/drm/i915/intel_dvo.c  |  2 +-
 7 files changed, 70 insertions(+), 70 deletions(-)

diff --git a/drivers/gpu/drm/i915/dvo_ch7017.c b/drivers/gpu/drm/i915/dvo_ch7017.c
index 80b3e16cf48c..caac9942e1e3 100644
--- a/drivers/gpu/drm/i915/dvo_ch7017.c
+++ b/drivers/gpu/drm/i915/dvo_ch7017.c
@@ -159,7 +159,7 @@
 #define CH7017_BANG_LIMIT_CONTROL	0x7f
 
 struct ch7017_priv {
-	uint8_t dummy;
+	u8 dummy;
 };
 
 static void ch7017_dump_regs(struct intel_dvo_device *dvo);
@@ -186,7 +186,7 @@ static bool ch7017_read(struct intel_dvo_device *dvo, u8 addr, u8 *val)
 
 static bool ch7017_write(struct intel_dvo_device *dvo, u8 addr, u8 val)
 {
-	uint8_t buf[2] = { addr, val };
+	u8 buf[2] = { addr, val };
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
 		.flags = 0,
@@ -258,11 +258,11 @@ static void ch7017_mode_set(struct intel_dvo_device *dvo,
 			    const struct drm_display_mode *mode,
 			    const struct drm_display_mode *adjusted_mode)
 {
-	uint8_t lvds_pll_feedback_div, lvds_pll_vco_control;
-	uint8_t outputs_enable, lvds_control_2, lvds_power_down;
-	uint8_t horizontal_active_pixel_input;
-	uint8_t horizontal_active_pixel_output, vertical_active_line_output;
-	uint8_t active_input_line_output;
+	u8 lvds_pll_feedback_div, lvds_pll_vco_control;
+	u8 outputs_enable, lvds_control_2, lvds_power_down;
+	u8 horizontal_active_pixel_input;
+	u8 horizontal_active_pixel_output, vertical_active_line_output;
+	u8 active_input_line_output;
 
 	DRM_DEBUG_KMS("Registers before mode setting\n");
 	ch7017_dump_regs(dvo);
@@ -333,7 +333,7 @@ static void ch7017_mode_set(struct intel_dvo_device *dvo,
 /* set the CH7017 power state */
 static void ch7017_dpms(struct intel_dvo_device *dvo, bool enable)
 {
-	uint8_t val;
+	u8 val;
 
 	ch7017_read(dvo, CH7017_LVDS_POWER_DOWN, &val);
 
@@ -361,7 +361,7 @@ static void ch7017_dpms(struct intel_dvo_device *dvo, bool enable)
 
 static bool ch7017_get_hw_state(struct intel_dvo_device *dvo)
 {
-	uint8_t val;
+	u8 val;
 
 	ch7017_read(dvo, CH7017_LVDS_POWER_DOWN, &val);
 
@@ -373,7 +373,7 @@ static bool ch7017_get_hw_state(struct intel_dvo_device *dvo)
 
 static void ch7017_dump_regs(struct intel_dvo_device *dvo)
 {
-	uint8_t val;
+	u8 val;
 
 #define DUMP(reg)					\
 do {							\
diff --git a/drivers/gpu/drm/i915/dvo_ch7xxx.c b/drivers/gpu/drm/i915/dvo_ch7xxx.c
index 7aeeffd2428b..397ac5233726 100644
--- a/drivers/gpu/drm/i915/dvo_ch7xxx.c
+++ b/drivers/gpu/drm/i915/dvo_ch7xxx.c
@@ -85,7 +85,7 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
 static struct ch7xxx_id_struct {
-	uint8_t vid;
+	u8 vid;
 	char *name;
 } ch7xxx_ids[] = {
 	{ CH7011_VID, "CH7011" },
@@ -96,7 +96,7 @@ static struct ch7xxx_id_struct {
 };
 
 static struct ch7xxx_did_struct {
-	uint8_t did;
+	u8 did;
 	char *name;
 } ch7xxx_dids[] = {
 	{ CH7xxx_DID, "CH7XXX" },
@@ -107,7 +107,7 @@ struct ch7xxx_priv {
 	bool quiet;
 };
 
-static char *ch7xxx_get_id(uint8_t vid)
+static char *ch7xxx_get_id(u8 vid)
 {
 	int i;
 
@@ -119,7 +119,7 @@ static char *ch7xxx_get_id(uint8_t vid)
 	return NULL;
 }
 
-static char *ch7xxx_get_did(uint8_t did)
+static char *ch7xxx_get_did(u8 did)
 {
 	int i;
 
@@ -132,7 +132,7 @@ static char *ch7xxx_get_did(uint8_t did)
 }
 
 /** Reads an 8 bit register */
-static bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
+static bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
 {
 	struct ch7xxx_priv *ch7xxx = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -170,11 +170,11 @@ static bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
 }
 
 /** Writes an 8 bit register */
-static bool ch7xxx_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
+static bool ch7xxx_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
 {
 	struct ch7xxx_priv *ch7xxx = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
-	uint8_t out_buf[2];
+	u8 out_buf[2];
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
 		.flags = 0,
@@ -201,7 +201,7 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
 {
 	/* this will detect the CH7xxx chip on the specified i2c bus */
 	struct ch7xxx_priv *ch7xxx;
-	uint8_t vendor, device;
+	u8 vendor, device;
 	char *name, *devid;
 
 	ch7xxx = kzalloc(sizeof(struct ch7xxx_priv), GFP_KERNEL);
@@ -244,7 +244,7 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
 
 static enum drm_connector_status ch7xxx_detect(struct intel_dvo_device *dvo)
 {
-	uint8_t cdet, orig_pm, pm;
+	u8 cdet, orig_pm, pm;
 
 	ch7xxx_readb(dvo, CH7xxx_PM, &orig_pm);
 
@@ -276,7 +276,7 @@ static void ch7xxx_mode_set(struct intel_dvo_device *dvo,
 			    const struct drm_display_mode *mode,
 			    const struct drm_display_mode *adjusted_mode)
 {
-	uint8_t tvco, tpcp, tpd, tlpf, idf;
+	u8 tvco, tpcp, tpd, tlpf, idf;
 
 	if (mode->clock <= 65000) {
 		tvco = 0x23;
@@ -336,7 +336,7 @@ static void ch7xxx_dump_regs(struct intel_dvo_device *dvo)
 	int i;
 
 	for (i = 0; i < CH7xxx_NUM_REGS; i++) {
-		uint8_t val;
+		u8 val;
 		if ((i % 8) == 0)
 			DRM_DEBUG_KMS("\n %02X: ", i);
 		ch7xxx_readb(dvo, i, &val);
diff --git a/drivers/gpu/drm/i915/dvo_ivch.c b/drivers/gpu/drm/i915/dvo_ivch.c
index c73aff163908..24278cc49090 100644
--- a/drivers/gpu/drm/i915/dvo_ivch.c
+++ b/drivers/gpu/drm/i915/dvo_ivch.c
@@ -161,7 +161,7 @@
  * instead. The following list contains all registers that
  * require saving.
  */
-static const uint16_t backup_addresses[] = {
+static const u16 backup_addresses[] = {
 	0x11, 0x12,
 	0x18, 0x19, 0x1a, 0x1f,
 	0x20, 0x21, 0x22, 0x23, 0x24, 0x25, 0x26, 0x27,
@@ -174,11 +174,11 @@ static const uint16_t backup_addresses[] = {
 struct ivch_priv {
 	bool quiet;
 
-	uint16_t width, height;
+	u16 width, height;
 
 	/* Register backup */
 
-	uint16_t reg_backup[ARRAY_SIZE(backup_addresses)];
+	u16 reg_backup[ARRAY_SIZE(backup_addresses)];
 };
 
 
@@ -188,7 +188,7 @@ static void ivch_dump_regs(struct intel_dvo_device *dvo);
  *
  * Each of the 256 registers are 16 bits long.
  */
-static bool ivch_read(struct intel_dvo_device *dvo, int addr, uint16_t *data)
+static bool ivch_read(struct intel_dvo_device *dvo, int addr, u16 *data)
 {
 	struct ivch_priv *priv = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -231,7 +231,7 @@ static bool ivch_read(struct intel_dvo_device *dvo, int addr, uint16_t *data)
 }
 
 /* Writes a 16-bit register on the ivch */
-static bool ivch_write(struct intel_dvo_device *dvo, int addr, uint16_t data)
+static bool ivch_write(struct intel_dvo_device *dvo, int addr, u16 data)
 {
 	struct ivch_priv *priv = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -263,7 +263,7 @@ static bool ivch_init(struct intel_dvo_device *dvo,
 		      struct i2c_adapter *adapter)
 {
 	struct ivch_priv *priv;
-	uint16_t temp;
+	u16 temp;
 	int i;
 
 	priv = kzalloc(sizeof(struct ivch_priv), GFP_KERNEL);
@@ -342,7 +342,7 @@ static void ivch_reset(struct intel_dvo_device *dvo)
 static void ivch_dpms(struct intel_dvo_device *dvo, bool enable)
 {
 	int i;
-	uint16_t vr01, vr30, backlight;
+	u16 vr01, vr30, backlight;
 
 	ivch_reset(dvo);
 
@@ -379,7 +379,7 @@ static void ivch_dpms(struct intel_dvo_device *dvo, bool enable)
 
 static bool ivch_get_hw_state(struct intel_dvo_device *dvo)
 {
-	uint16_t vr01;
+	u16 vr01;
 
 	ivch_reset(dvo);
 
@@ -398,9 +398,9 @@ static void ivch_mode_set(struct intel_dvo_device *dvo,
 			  const struct drm_display_mode *adjusted_mode)
 {
 	struct ivch_priv *priv = dvo->dev_priv;
-	uint16_t vr40 = 0;
-	uint16_t vr01 = 0;
-	uint16_t vr10;
+	u16 vr40 = 0;
+	u16 vr01 = 0;
+	u16 vr10;
 
 	ivch_reset(dvo);
 
@@ -416,7 +416,7 @@ static void ivch_mode_set(struct intel_dvo_device *dvo,
 
 	if (mode->hdisplay != adjusted_mode->crtc_hdisplay ||
 	    mode->vdisplay != adjusted_mode->crtc_vdisplay) {
-		uint16_t x_ratio, y_ratio;
+		u16 x_ratio, y_ratio;
 
 		vr01 |= VR01_PANEL_FIT_ENABLE;
 		vr40 |= VR40_CLOCK_GATING_ENABLE;
@@ -438,7 +438,7 @@ static void ivch_mode_set(struct intel_dvo_device *dvo,
 
 static void ivch_dump_regs(struct intel_dvo_device *dvo)
 {
-	uint16_t val;
+	u16 val;
 
 	ivch_read(dvo, VR00, &val);
 	DRM_DEBUG_KMS("VR00: 0x%04x\n", val);
diff --git a/drivers/gpu/drm/i915/dvo_ns2501.c b/drivers/gpu/drm/i915/dvo_ns2501.c
index 2379c33cfe51..e0f6c69d6c61 100644
--- a/drivers/gpu/drm/i915/dvo_ns2501.c
+++ b/drivers/gpu/drm/i915/dvo_ns2501.c
@@ -191,8 +191,8 @@ enum {
 };
 
 struct ns2501_reg {
-	 uint8_t offset;
-	 uint8_t value;
+	 u8 offset;
+	 u8 value;
 };
 
 /*
@@ -202,23 +202,23 @@ struct ns2501_reg {
  * read all this with a grain of salt.
  */
 struct ns2501_configuration {
-	uint8_t sync;		/* configuration of the C0 register */
-	uint8_t conf;		/* configuration register 8 */
-	uint8_t syncb;		/* configuration register 41 */
-	uint8_t	dither;		/* configuration of the dithering */
-	uint8_t pll_a;		/* PLL configuration, register A, 1B */
-	uint16_t pll_b;		/* PLL configuration, register B, 1C/1D */
-	uint16_t hstart;	/* horizontal start, registers C1/C2 */
-	uint16_t hstop;		/* horizontal total, registers C3/C4 */
-	uint16_t vstart;	/* vertical start, registers C5/C6 */
-	uint16_t vstop;		/* vertical total, registers C7/C8 */
-	uint16_t vsync;         /* manual vertical sync start, 80/81 */
-	uint16_t vtotal;        /* number of lines generated, 82/83 */
-	uint16_t hpos;		/* horizontal position + 256, 98/99  */
-	uint16_t vpos;		/* vertical position, 8e/8f */
-	uint16_t voffs;		/* vertical output offset, 9c/9d */
-	uint16_t hscale;	/* horizontal scaling factor, b8/b9 */
-	uint16_t vscale;	/* vertical scaling factor, 10/11 */
+	u8 sync;		/* configuration of the C0 register */
+	u8 conf;		/* configuration register 8 */
+	u8 syncb;		/* configuration register 41 */
+	u8 dither;		/* configuration of the dithering */
+	u8 pll_a;		/* PLL configuration, register A, 1B */
+	u16 pll_b;		/* PLL configuration, register B, 1C/1D */
+	u16 hstart;		/* horizontal start, registers C1/C2 */
+	u16 hstop;		/* horizontal total, registers C3/C4 */
+	u16 vstart;		/* vertical start, registers C5/C6 */
+	u16 vstop;		/* vertical total, registers C7/C8 */
+	u16 vsync;		/* manual vertical sync start, 80/81 */
+	u16 vtotal;		/* number of lines generated, 82/83 */
+	u16 hpos;		/* horizontal position + 256, 98/99  */
+	u16 vpos;		/* vertical position, 8e/8f */
+	u16 voffs;		/* vertical output offset, 9c/9d */
+	u16 hscale;		/* horizontal scaling factor, b8/b9 */
+	u16 vscale;		/* vertical scaling factor, 10/11 */
 };
 
 /*
@@ -389,7 +389,7 @@ struct ns2501_priv {
 ** If it returns false, it might be wise to enable the
 ** DVO with the above function.
 */
-static bool ns2501_readb(struct intel_dvo_device *dvo, int addr, uint8_t * ch)
+static bool ns2501_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
 {
 	struct ns2501_priv *ns = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -434,11 +434,11 @@ static bool ns2501_readb(struct intel_dvo_device *dvo, int addr, uint8_t * ch)
 ** If it returns false, it might be wise to enable the
 ** DVO with the above function.
 */
-static bool ns2501_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
+static bool ns2501_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
 {
 	struct ns2501_priv *ns = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
-	uint8_t out_buf[2];
+	u8 out_buf[2];
 
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
diff --git a/drivers/gpu/drm/i915/dvo_sil164.c b/drivers/gpu/drm/i915/dvo_sil164.c
index 1c1a0674dbab..4ae5d8fd9ff0 100644
--- a/drivers/gpu/drm/i915/dvo_sil164.c
+++ b/drivers/gpu/drm/i915/dvo_sil164.c
@@ -65,7 +65,7 @@ struct sil164_priv {
 
 #define SILPTR(d) ((SIL164Ptr)(d->DriverPrivate.ptr))
 
-static bool sil164_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
+static bool sil164_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
 {
 	struct sil164_priv *sil = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -102,11 +102,11 @@ static bool sil164_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
 	return false;
 }
 
-static bool sil164_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
+static bool sil164_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
 {
 	struct sil164_priv *sil = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
-	uint8_t out_buf[2];
+	u8 out_buf[2];
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
 		.flags = 0,
@@ -173,7 +173,7 @@ static bool sil164_init(struct intel_dvo_device *dvo,
 
 static enum drm_connector_status sil164_detect(struct intel_dvo_device *dvo)
 {
-	uint8_t reg9;
+	u8 reg9;
 
 	sil164_readb(dvo, SIL164_REG9, &reg9);
 
@@ -243,7 +243,7 @@ static bool sil164_get_hw_state(struct intel_dvo_device *dvo)
 
 static void sil164_dump_regs(struct intel_dvo_device *dvo)
 {
-	uint8_t val;
+	u8 val;
 
 	sil164_readb(dvo, SIL164_FREQ_LO, &val);
 	DRM_DEBUG_KMS("SIL164_FREQ_LO: 0x%02x\n", val);
diff --git a/drivers/gpu/drm/i915/dvo_tfp410.c b/drivers/gpu/drm/i915/dvo_tfp410.c
index 31e181da93db..d603bc2f2506 100644
--- a/drivers/gpu/drm/i915/dvo_tfp410.c
+++ b/drivers/gpu/drm/i915/dvo_tfp410.c
@@ -90,7 +90,7 @@ struct tfp410_priv {
 	bool quiet;
 };
 
-static bool tfp410_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
+static bool tfp410_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
 {
 	struct tfp410_priv *tfp = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -127,11 +127,11 @@ static bool tfp410_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
 	return false;
 }
 
-static bool tfp410_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
+static bool tfp410_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
 {
 	struct tfp410_priv *tfp = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
-	uint8_t out_buf[2];
+	u8 out_buf[2];
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
 		.flags = 0,
@@ -155,7 +155,7 @@ static bool tfp410_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
 
 static int tfp410_getid(struct intel_dvo_device *dvo, int addr)
 {
-	uint8_t ch1, ch2;
+	u8 ch1, ch2;
 
 	if (tfp410_readb(dvo, addr+0, &ch1) &&
 	    tfp410_readb(dvo, addr+1, &ch2))
@@ -203,7 +203,7 @@ static bool tfp410_init(struct intel_dvo_device *dvo,
 static enum drm_connector_status tfp410_detect(struct intel_dvo_device *dvo)
 {
 	enum drm_connector_status ret = connector_status_disconnected;
-	uint8_t ctl2;
+	u8 ctl2;
 
 	if (tfp410_readb(dvo, TFP410_CTL_2, &ctl2)) {
 		if (ctl2 & TFP410_CTL_2_RSEN)
@@ -236,7 +236,7 @@ static void tfp410_mode_set(struct intel_dvo_device *dvo,
 /* set the tfp410 power state */
 static void tfp410_dpms(struct intel_dvo_device *dvo, bool enable)
 {
-	uint8_t ctl1;
+	u8 ctl1;
 
 	if (!tfp410_readb(dvo, TFP410_CTL_1, &ctl1))
 		return;
@@ -251,7 +251,7 @@ static void tfp410_dpms(struct intel_dvo_device *dvo, bool enable)
 
 static bool tfp410_get_hw_state(struct intel_dvo_device *dvo)
 {
-	uint8_t ctl1;
+	u8 ctl1;
 
 	if (!tfp410_readb(dvo, TFP410_CTL_1, &ctl1))
 		return false;
@@ -264,7 +264,7 @@ static bool tfp410_get_hw_state(struct intel_dvo_device *dvo)
 
 static void tfp410_dump_regs(struct intel_dvo_device *dvo)
 {
-	uint8_t val, val2;
+	u8 val, val2;
 
 	tfp410_readb(dvo, TFP410_REV, &val);
 	DRM_DEBUG_KMS("TFP410_REV: 0x%02X\n", val);
diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
index 7b942b6c1700..ff22d5d3a892 100644
--- a/drivers/gpu/drm/i915/intel_dvo.c
+++ b/drivers/gpu/drm/i915/intel_dvo.c
@@ -432,7 +432,7 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
 		int gpio;
 		bool dvoinit;
 		enum pipe pipe;
-		uint32_t dpll[I915_MAX_PIPES];
+		u32 dpll[I915_MAX_PIPES];
 		enum port port;
 
 		/*
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 5/7] drm/i915/backlight: switch to kernel unsigned int types

[Jani Nikula]

We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
to stick to kernel types at least where it's more prevalent.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++++------
 drivers/gpu/drm/i915/intel_panel.c            |  8 ++++----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
index 2bb2ceb9d463..357136f17f85 100644
--- a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
@@ -26,7 +26,7 @@
 
 static void set_aux_backlight_enable(struct intel_dp *intel_dp, bool enable)
 {
-	uint8_t reg_val = 0;
+	u8 reg_val = 0;
 
 	/* Early return when display use other mechanism to enable backlight. */
 	if (!(intel_dp->edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP))
@@ -54,11 +54,11 @@ static void set_aux_backlight_enable(struct intel_dp *intel_dp, bool enable)
  * Read the current backlight value from DPCD register(s) based
  * on if 8-bit(MSB) or 16-bit(MSB and LSB) values are supported
  */
-static uint32_t intel_dp_aux_get_backlight(struct intel_connector *connector)
+static u32 intel_dp_aux_get_backlight(struct intel_connector *connector)
 {
 	struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base);
-	uint8_t read_val[2] = { 0x0 };
-	uint16_t level = 0;
+	u8 read_val[2] = { 0x0 };
+	u16 level = 0;
 
 	if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB,
 			     &read_val, sizeof(read_val)) < 0) {
@@ -82,7 +82,7 @@ intel_dp_aux_set_backlight(const struct drm_connector_state *conn_state, u32 lev
 {
 	struct intel_connector *connector = to_intel_connector(conn_state->connector);
 	struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base);
-	uint8_t vals[2] = { 0x0 };
+	u8 vals[2] = { 0x0 };
 
 	vals[0] = level;
 
@@ -178,7 +178,7 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st
 {
 	struct intel_connector *connector = to_intel_connector(conn_state->connector);
 	struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base);
-	uint8_t dpcd_buf, new_dpcd_buf, edp_backlight_mode;
+	u8 dpcd_buf, new_dpcd_buf, edp_backlight_mode;
 
 	if (drm_dp_dpcd_readb(&intel_dp->aux,
 			DP_EDP_BACKLIGHT_MODE_SET_REGISTER, &dpcd_buf) != 1) {
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index b443278e569c..14b827ec5427 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -406,11 +406,11 @@ intel_panel_detect(struct drm_i915_private *dev_priv)
  * Return @source_val in range [@source_min..@source_max] scaled to range
  * [@target_min..@target_max].
  */
-static uint32_t scale(uint32_t source_val,
-		      uint32_t source_min, uint32_t source_max,
-		      uint32_t target_min, uint32_t target_max)
+static u32 scale(u32 source_val,
+		 u32 source_min, u32 source_max,
+		 u32 target_min, u32 target_max)
 {
-	uint64_t target_val;
+	u64 target_val;
 
 	WARN_ON(source_min > source_max);
 	WARN_ON(target_min > target_max);
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 6/7] drm/i915/audio: switch to kernel unsigned int types

[Jani Nikula]

We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
to stick to kernel types at least where it's more prevalent.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 3ea566f99450..4e4c0ec44f35 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -198,13 +198,13 @@ static int audio_config_hdmi_get_n(const struct intel_crtc_state *crtc_state,
 }
 
 static bool intel_eld_uptodate(struct drm_connector *connector,
-			       i915_reg_t reg_eldv, uint32_t bits_eldv,
-			       i915_reg_t reg_elda, uint32_t bits_elda,
+			       i915_reg_t reg_eldv, u32 bits_eldv,
+			       i915_reg_t reg_elda, u32 bits_elda,
 			       i915_reg_t reg_edid)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->dev);
-	uint8_t *eld = connector->eld;
-	uint32_t tmp;
+	u8 *eld = connector->eld;
+	u32 tmp;
 	int i;
 
 	tmp = I915_READ(reg_eldv);
@@ -218,7 +218,7 @@ static bool intel_eld_uptodate(struct drm_connector *connector,
 	I915_WRITE(reg_elda, tmp);
 
 	for (i = 0; i < drm_eld_size(eld) / 4; i++)
-		if (I915_READ(reg_edid) != *((uint32_t *)eld + i))
+		if (I915_READ(reg_edid) != *((u32 *)eld + i))
 			return false;
 
 	return true;
@@ -229,7 +229,7 @@ static void g4x_audio_codec_disable(struct intel_encoder *encoder,
 				    const struct drm_connector_state *old_conn_state)
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
-	uint32_t eldv, tmp;
+	u32 eldv, tmp;
 
 	DRM_DEBUG_KMS("Disable audio codec\n");
 
@@ -251,9 +251,9 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 	struct drm_connector *connector = conn_state->connector;
-	uint8_t *eld = connector->eld;
-	uint32_t eldv;
-	uint32_t tmp;
+	u8 *eld = connector->eld;
+	u32 eldv;
+	u32 tmp;
 	int len, i;
 
 	DRM_DEBUG_KMS("Enable audio codec, %u bytes ELD\n", eld[2]);
@@ -278,7 +278,7 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,
 	len = min(drm_eld_size(eld) / 4, len);
 	DRM_DEBUG_DRIVER("ELD size %d\n", len);
 	for (i = 0; i < len; i++)
-		I915_WRITE(G4X_HDMIW_HDMIEDID, *((uint32_t *)eld + i));
+		I915_WRITE(G4X_HDMIW_HDMIEDID, *((u32 *)eld + i));
 
 	tmp = I915_READ(G4X_AUD_CNTL_ST);
 	tmp |= eldv;
@@ -393,7 +393,7 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder,
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
 	enum pipe pipe = crtc->pipe;
-	uint32_t tmp;
+	u32 tmp;
 
 	DRM_DEBUG_KMS("Disable audio codec on pipe %c\n", pipe_name(pipe));
 
@@ -426,8 +426,8 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
 	struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
 	struct drm_connector *connector = conn_state->connector;
 	enum pipe pipe = crtc->pipe;
-	const uint8_t *eld = connector->eld;
-	uint32_t tmp;
+	const u8 *eld = connector->eld;
+	u32 tmp;
 	int len, i;
 
 	DRM_DEBUG_KMS("Enable audio codec on pipe %c, %u bytes ELD\n",
@@ -456,7 +456,7 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
 	/* Up to 84 bytes of hw ELD buffer */
 	len = min(drm_eld_size(eld), 84);
 	for (i = 0; i < len / 4; i++)
-		I915_WRITE(HSW_AUD_EDID_DATA(pipe), *((uint32_t *)eld + i));
+		I915_WRITE(HSW_AUD_EDID_DATA(pipe), *((u32 *)eld + i));
 
 	/* ELD valid */
 	tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
@@ -477,7 +477,7 @@ static void ilk_audio_codec_disable(struct intel_encoder *encoder,
 	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
 	enum pipe pipe = crtc->pipe;
 	enum port port = encoder->port;
-	uint32_t tmp, eldv;
+	u32 tmp, eldv;
 	i915_reg_t aud_config, aud_cntrl_st2;
 
 	DRM_DEBUG_KMS("Disable audio codec on port %c, pipe %c\n",
@@ -524,8 +524,8 @@ static void ilk_audio_codec_enable(struct intel_encoder *encoder,
 	struct drm_connector *connector = conn_state->connector;
 	enum pipe pipe = crtc->pipe;
 	enum port port = encoder->port;
-	uint8_t *eld = connector->eld;
-	uint32_t tmp, eldv;
+	u8 *eld = connector->eld;
+	u32 tmp, eldv;
 	int len, i;
 	i915_reg_t hdmiw_hdmiedid, aud_config, aud_cntl_st, aud_cntrl_st2;
 
@@ -575,7 +575,7 @@ static void ilk_audio_codec_enable(struct intel_encoder *encoder,
 	/* Up to 84 bytes of hw ELD buffer */
 	len = min(drm_eld_size(eld), 84);
 	for (i = 0; i < len / 4; i++)
-		I915_WRITE(hdmiw_hdmiedid, *((uint32_t *)eld + i));
+		I915_WRITE(hdmiw_hdmiedid, *((u32 *)eld + i));
 
 	/* ELD valid */
 	tmp = I915_READ(aud_cntrl_st2);
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 7/7] drm/i915/lspcon: switch to kernel unsigned int types

[Jani Nikula]

We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
to stick to kernel types at least where it's more prevalent.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_lspcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
index 8ae8f42f430a..5dae16ccd9f1 100644
--- a/drivers/gpu/drm/i915/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/intel_lspcon.c
@@ -116,7 +116,7 @@ static int lspcon_change_mode(struct intel_lspcon *lspcon,
 
 static bool lspcon_wake_native_aux_ch(struct intel_lspcon *lspcon)
 {
-	uint8_t rev;
+	u8 rev;
 
 	if (drm_dp_dpcd_readb(&lspcon_to_intel_dp(lspcon)->aux, DP_DPCD_REV,
 			      &rev) != 1) {
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.CHECKPATCH: warning for drm/i915: move towards kernel types

[Patchwork]

== Series Details ==

Series: drm/i915: move towards kernel types
URL   : https://patchwork.freedesktop.org/series/44610/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5e5d04a1d33d drm/i915/vbt: switch to kernel unsigned int types
ba755792a04b drm/i915/hdmi: switch to kernel unsigned int types
b67a03bc35e4 drm/i915/uncore: switch to kernel unsigned int types
592d209523eb drm/i915/dvo: switch to kernel unsigned int types
-:289: WARNING:TABSTOP: Statements should start on a tabstop
#289: FILE: drivers/gpu/drm/i915/dvo_ns2501.c:194:
+	 u8 offset;

-:290: WARNING:TABSTOP: Statements should start on a tabstop
#290: FILE: drivers/gpu/drm/i915/dvo_ns2501.c:195:
+	 u8 value;

total: 0 errors, 2 warnings, 0 checks, 407 lines checked
295e98774483 drm/i915/backlight: switch to kernel unsigned int types
cb02e7d6517d drm/i915/audio: switch to kernel unsigned int types
62b5ce446f23 drm/i915/lspcon: switch to kernel unsigned int types

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.SPARSE: warning for drm/i915: move towards kernel types

[Patchwork]

== Series Details ==

Series: drm/i915: move towards kernel types
URL   : https://patchwork.freedesktop.org/series/44610/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Commit: drm/i915/vbt: switch to kernel unsigned int types
Okay!

Commit: drm/i915/hdmi: switch to kernel unsigned int types
Okay!

Commit: drm/i915/uncore: switch to kernel unsigned int types
Okay!

Commit: drm/i915/dvo: switch to kernel unsigned int types
Okay!

Commit: drm/i915/backlight: switch to kernel unsigned int types
Okay!

Commit: drm/i915/audio: switch to kernel unsigned int types
-O:drivers/gpu/drm/i915/intel_audio.c:278:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_audio.c:278:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_audio.c:457:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_audio.c:576:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:278:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:278:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:457:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:576:15: warning: expression using sizeof(void)

Commit: drm/i915/lspcon: switch to kernel unsigned int types
Okay!

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: move towards kernel types

[Patchwork]

== Series Details ==

Series: drm/i915: move towards kernel types
URL   : https://patchwork.freedesktop.org/series/44610/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4305 -> Patchwork_9270 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/44610/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_9270 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000)

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-glk-j4005:       PASS -> FAIL (fdo#106724)

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-glk-j4005:       PASS -> FAIL (fdo#103481)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-cnl-psr:         PASS -> DMESG-WARN (fdo#104951)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-WARN (fdo#106607) -> PASS

    
  fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106607 https://bugs.freedesktop.org/show_bug.cgi?id=106607
  fdo#106724 https://bugs.freedesktop.org/show_bug.cgi?id=106724


== Participating hosts (42 -> 37) ==

  Missing    (5): fi-ctg-p8600 fi-bsw-cyan fi-ilk-m540 fi-skl-gvtdvm fi-skl-6700hq 


== Build changes ==

    * Linux: CI_DRM_4305 -> Patchwork_9270

  CI_DRM_4305: d5ec1c93d19ce1fa4e23176828f4fb9a592f2609 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4515: a0f2d23b7d3d4226a0a7637a9240bfa86f08c1d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9270: 62b5ce446f23712cf857ecec728470f8cab2cc78 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

62b5ce446f23 drm/i915/lspcon: switch to kernel unsigned int types
cb02e7d6517d drm/i915/audio: switch to kernel unsigned int types
295e98774483 drm/i915/backlight: switch to kernel unsigned int types
592d209523eb drm/i915/dvo: switch to kernel unsigned int types
b67a03bc35e4 drm/i915/uncore: switch to kernel unsigned int types
ba755792a04b drm/i915/hdmi: switch to kernel unsigned int types
5e5d04a1d33d drm/i915/vbt: switch to kernel unsigned int types

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9270/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v2 4/7] drm/i915/dvo: switch to kernel unsigned int types

[Jani Nikula]

We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
to stick to kernel types at least where it's more prevalent.

v2: fix checkpatch warning on indentation

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/dvo_ch7017.c | 20 +++++++++---------
 drivers/gpu/drm/i915/dvo_ch7xxx.c | 22 ++++++++++----------
 drivers/gpu/drm/i915/dvo_ivch.c   | 26 +++++++++++------------
 drivers/gpu/drm/i915/dvo_ns2501.c | 44 +++++++++++++++++++--------------------
 drivers/gpu/drm/i915/dvo_sil164.c | 10 ++++-----
 drivers/gpu/drm/i915/dvo_tfp410.c | 16 +++++++-------
 drivers/gpu/drm/i915/intel_dvo.c  |  2 +-
 7 files changed, 70 insertions(+), 70 deletions(-)

diff --git a/drivers/gpu/drm/i915/dvo_ch7017.c b/drivers/gpu/drm/i915/dvo_ch7017.c
index 80b3e16cf48c..caac9942e1e3 100644
--- a/drivers/gpu/drm/i915/dvo_ch7017.c
+++ b/drivers/gpu/drm/i915/dvo_ch7017.c
@@ -159,7 +159,7 @@
 #define CH7017_BANG_LIMIT_CONTROL	0x7f
 
 struct ch7017_priv {
-	uint8_t dummy;
+	u8 dummy;
 };
 
 static void ch7017_dump_regs(struct intel_dvo_device *dvo);
@@ -186,7 +186,7 @@ static bool ch7017_read(struct intel_dvo_device *dvo, u8 addr, u8 *val)
 
 static bool ch7017_write(struct intel_dvo_device *dvo, u8 addr, u8 val)
 {
-	uint8_t buf[2] = { addr, val };
+	u8 buf[2] = { addr, val };
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
 		.flags = 0,
@@ -258,11 +258,11 @@ static void ch7017_mode_set(struct intel_dvo_device *dvo,
 			    const struct drm_display_mode *mode,
 			    const struct drm_display_mode *adjusted_mode)
 {
-	uint8_t lvds_pll_feedback_div, lvds_pll_vco_control;
-	uint8_t outputs_enable, lvds_control_2, lvds_power_down;
-	uint8_t horizontal_active_pixel_input;
-	uint8_t horizontal_active_pixel_output, vertical_active_line_output;
-	uint8_t active_input_line_output;
+	u8 lvds_pll_feedback_div, lvds_pll_vco_control;
+	u8 outputs_enable, lvds_control_2, lvds_power_down;
+	u8 horizontal_active_pixel_input;
+	u8 horizontal_active_pixel_output, vertical_active_line_output;
+	u8 active_input_line_output;
 
 	DRM_DEBUG_KMS("Registers before mode setting\n");
 	ch7017_dump_regs(dvo);
@@ -333,7 +333,7 @@ static void ch7017_mode_set(struct intel_dvo_device *dvo,
 /* set the CH7017 power state */
 static void ch7017_dpms(struct intel_dvo_device *dvo, bool enable)
 {
-	uint8_t val;
+	u8 val;
 
 	ch7017_read(dvo, CH7017_LVDS_POWER_DOWN, &val);
 
@@ -361,7 +361,7 @@ static void ch7017_dpms(struct intel_dvo_device *dvo, bool enable)
 
 static bool ch7017_get_hw_state(struct intel_dvo_device *dvo)
 {
-	uint8_t val;
+	u8 val;
 
 	ch7017_read(dvo, CH7017_LVDS_POWER_DOWN, &val);
 
@@ -373,7 +373,7 @@ static bool ch7017_get_hw_state(struct intel_dvo_device *dvo)
 
 static void ch7017_dump_regs(struct intel_dvo_device *dvo)
 {
-	uint8_t val;
+	u8 val;
 
 #define DUMP(reg)					\
 do {							\
diff --git a/drivers/gpu/drm/i915/dvo_ch7xxx.c b/drivers/gpu/drm/i915/dvo_ch7xxx.c
index 7aeeffd2428b..397ac5233726 100644
--- a/drivers/gpu/drm/i915/dvo_ch7xxx.c
+++ b/drivers/gpu/drm/i915/dvo_ch7xxx.c
@@ -85,7 +85,7 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
 static struct ch7xxx_id_struct {
-	uint8_t vid;
+	u8 vid;
 	char *name;
 } ch7xxx_ids[] = {
 	{ CH7011_VID, "CH7011" },
@@ -96,7 +96,7 @@ static struct ch7xxx_id_struct {
 };
 
 static struct ch7xxx_did_struct {
-	uint8_t did;
+	u8 did;
 	char *name;
 } ch7xxx_dids[] = {
 	{ CH7xxx_DID, "CH7XXX" },
@@ -107,7 +107,7 @@ struct ch7xxx_priv {
 	bool quiet;
 };
 
-static char *ch7xxx_get_id(uint8_t vid)
+static char *ch7xxx_get_id(u8 vid)
 {
 	int i;
 
@@ -119,7 +119,7 @@ static char *ch7xxx_get_id(uint8_t vid)
 	return NULL;
 }
 
-static char *ch7xxx_get_did(uint8_t did)
+static char *ch7xxx_get_did(u8 did)
 {
 	int i;
 
@@ -132,7 +132,7 @@ static char *ch7xxx_get_did(uint8_t did)
 }
 
 /** Reads an 8 bit register */
-static bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
+static bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
 {
 	struct ch7xxx_priv *ch7xxx = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -170,11 +170,11 @@ static bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
 }
 
 /** Writes an 8 bit register */
-static bool ch7xxx_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
+static bool ch7xxx_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
 {
 	struct ch7xxx_priv *ch7xxx = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
-	uint8_t out_buf[2];
+	u8 out_buf[2];
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
 		.flags = 0,
@@ -201,7 +201,7 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
 {
 	/* this will detect the CH7xxx chip on the specified i2c bus */
 	struct ch7xxx_priv *ch7xxx;
-	uint8_t vendor, device;
+	u8 vendor, device;
 	char *name, *devid;
 
 	ch7xxx = kzalloc(sizeof(struct ch7xxx_priv), GFP_KERNEL);
@@ -244,7 +244,7 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
 
 static enum drm_connector_status ch7xxx_detect(struct intel_dvo_device *dvo)
 {
-	uint8_t cdet, orig_pm, pm;
+	u8 cdet, orig_pm, pm;
 
 	ch7xxx_readb(dvo, CH7xxx_PM, &orig_pm);
 
@@ -276,7 +276,7 @@ static void ch7xxx_mode_set(struct intel_dvo_device *dvo,
 			    const struct drm_display_mode *mode,
 			    const struct drm_display_mode *adjusted_mode)
 {
-	uint8_t tvco, tpcp, tpd, tlpf, idf;
+	u8 tvco, tpcp, tpd, tlpf, idf;
 
 	if (mode->clock <= 65000) {
 		tvco = 0x23;
@@ -336,7 +336,7 @@ static void ch7xxx_dump_regs(struct intel_dvo_device *dvo)
 	int i;
 
 	for (i = 0; i < CH7xxx_NUM_REGS; i++) {
-		uint8_t val;
+		u8 val;
 		if ((i % 8) == 0)
 			DRM_DEBUG_KMS("\n %02X: ", i);
 		ch7xxx_readb(dvo, i, &val);
diff --git a/drivers/gpu/drm/i915/dvo_ivch.c b/drivers/gpu/drm/i915/dvo_ivch.c
index c73aff163908..24278cc49090 100644
--- a/drivers/gpu/drm/i915/dvo_ivch.c
+++ b/drivers/gpu/drm/i915/dvo_ivch.c
@@ -161,7 +161,7 @@
  * instead. The following list contains all registers that
  * require saving.
  */
-static const uint16_t backup_addresses[] = {
+static const u16 backup_addresses[] = {
 	0x11, 0x12,
 	0x18, 0x19, 0x1a, 0x1f,
 	0x20, 0x21, 0x22, 0x23, 0x24, 0x25, 0x26, 0x27,
@@ -174,11 +174,11 @@ static const uint16_t backup_addresses[] = {
 struct ivch_priv {
 	bool quiet;
 
-	uint16_t width, height;
+	u16 width, height;
 
 	/* Register backup */
 
-	uint16_t reg_backup[ARRAY_SIZE(backup_addresses)];
+	u16 reg_backup[ARRAY_SIZE(backup_addresses)];
 };
 
 
@@ -188,7 +188,7 @@ static void ivch_dump_regs(struct intel_dvo_device *dvo);
  *
  * Each of the 256 registers are 16 bits long.
  */
-static bool ivch_read(struct intel_dvo_device *dvo, int addr, uint16_t *data)
+static bool ivch_read(struct intel_dvo_device *dvo, int addr, u16 *data)
 {
 	struct ivch_priv *priv = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -231,7 +231,7 @@ static bool ivch_read(struct intel_dvo_device *dvo, int addr, uint16_t *data)
 }
 
 /* Writes a 16-bit register on the ivch */
-static bool ivch_write(struct intel_dvo_device *dvo, int addr, uint16_t data)
+static bool ivch_write(struct intel_dvo_device *dvo, int addr, u16 data)
 {
 	struct ivch_priv *priv = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -263,7 +263,7 @@ static bool ivch_init(struct intel_dvo_device *dvo,
 		      struct i2c_adapter *adapter)
 {
 	struct ivch_priv *priv;
-	uint16_t temp;
+	u16 temp;
 	int i;
 
 	priv = kzalloc(sizeof(struct ivch_priv), GFP_KERNEL);
@@ -342,7 +342,7 @@ static void ivch_reset(struct intel_dvo_device *dvo)
 static void ivch_dpms(struct intel_dvo_device *dvo, bool enable)
 {
 	int i;
-	uint16_t vr01, vr30, backlight;
+	u16 vr01, vr30, backlight;
 
 	ivch_reset(dvo);
 
@@ -379,7 +379,7 @@ static void ivch_dpms(struct intel_dvo_device *dvo, bool enable)
 
 static bool ivch_get_hw_state(struct intel_dvo_device *dvo)
 {
-	uint16_t vr01;
+	u16 vr01;
 
 	ivch_reset(dvo);
 
@@ -398,9 +398,9 @@ static void ivch_mode_set(struct intel_dvo_device *dvo,
 			  const struct drm_display_mode *adjusted_mode)
 {
 	struct ivch_priv *priv = dvo->dev_priv;
-	uint16_t vr40 = 0;
-	uint16_t vr01 = 0;
-	uint16_t vr10;
+	u16 vr40 = 0;
+	u16 vr01 = 0;
+	u16 vr10;
 
 	ivch_reset(dvo);
 
@@ -416,7 +416,7 @@ static void ivch_mode_set(struct intel_dvo_device *dvo,
 
 	if (mode->hdisplay != adjusted_mode->crtc_hdisplay ||
 	    mode->vdisplay != adjusted_mode->crtc_vdisplay) {
-		uint16_t x_ratio, y_ratio;
+		u16 x_ratio, y_ratio;
 
 		vr01 |= VR01_PANEL_FIT_ENABLE;
 		vr40 |= VR40_CLOCK_GATING_ENABLE;
@@ -438,7 +438,7 @@ static void ivch_mode_set(struct intel_dvo_device *dvo,
 
 static void ivch_dump_regs(struct intel_dvo_device *dvo)
 {
-	uint16_t val;
+	u16 val;
 
 	ivch_read(dvo, VR00, &val);
 	DRM_DEBUG_KMS("VR00: 0x%04x\n", val);
diff --git a/drivers/gpu/drm/i915/dvo_ns2501.c b/drivers/gpu/drm/i915/dvo_ns2501.c
index 2379c33cfe51..c584e01dc8dc 100644
--- a/drivers/gpu/drm/i915/dvo_ns2501.c
+++ b/drivers/gpu/drm/i915/dvo_ns2501.c
@@ -191,8 +191,8 @@ enum {
 };
 
 struct ns2501_reg {
-	 uint8_t offset;
-	 uint8_t value;
+	u8 offset;
+	u8 value;
 };
 
 /*
@@ -202,23 +202,23 @@ struct ns2501_reg {
  * read all this with a grain of salt.
  */
 struct ns2501_configuration {
-	uint8_t sync;		/* configuration of the C0 register */
-	uint8_t conf;		/* configuration register 8 */
-	uint8_t syncb;		/* configuration register 41 */
-	uint8_t	dither;		/* configuration of the dithering */
-	uint8_t pll_a;		/* PLL configuration, register A, 1B */
-	uint16_t pll_b;		/* PLL configuration, register B, 1C/1D */
-	uint16_t hstart;	/* horizontal start, registers C1/C2 */
-	uint16_t hstop;		/* horizontal total, registers C3/C4 */
-	uint16_t vstart;	/* vertical start, registers C5/C6 */
-	uint16_t vstop;		/* vertical total, registers C7/C8 */
-	uint16_t vsync;         /* manual vertical sync start, 80/81 */
-	uint16_t vtotal;        /* number of lines generated, 82/83 */
-	uint16_t hpos;		/* horizontal position + 256, 98/99  */
-	uint16_t vpos;		/* vertical position, 8e/8f */
-	uint16_t voffs;		/* vertical output offset, 9c/9d */
-	uint16_t hscale;	/* horizontal scaling factor, b8/b9 */
-	uint16_t vscale;	/* vertical scaling factor, 10/11 */
+	u8 sync;		/* configuration of the C0 register */
+	u8 conf;		/* configuration register 8 */
+	u8 syncb;		/* configuration register 41 */
+	u8 dither;		/* configuration of the dithering */
+	u8 pll_a;		/* PLL configuration, register A, 1B */
+	u16 pll_b;		/* PLL configuration, register B, 1C/1D */
+	u16 hstart;		/* horizontal start, registers C1/C2 */
+	u16 hstop;		/* horizontal total, registers C3/C4 */
+	u16 vstart;		/* vertical start, registers C5/C6 */
+	u16 vstop;		/* vertical total, registers C7/C8 */
+	u16 vsync;		/* manual vertical sync start, 80/81 */
+	u16 vtotal;		/* number of lines generated, 82/83 */
+	u16 hpos;		/* horizontal position + 256, 98/99  */
+	u16 vpos;		/* vertical position, 8e/8f */
+	u16 voffs;		/* vertical output offset, 9c/9d */
+	u16 hscale;		/* horizontal scaling factor, b8/b9 */
+	u16 vscale;		/* vertical scaling factor, 10/11 */
 };
 
 /*
@@ -389,7 +389,7 @@ struct ns2501_priv {
 ** If it returns false, it might be wise to enable the
 ** DVO with the above function.
 */
-static bool ns2501_readb(struct intel_dvo_device *dvo, int addr, uint8_t * ch)
+static bool ns2501_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
 {
 	struct ns2501_priv *ns = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -434,11 +434,11 @@ static bool ns2501_readb(struct intel_dvo_device *dvo, int addr, uint8_t * ch)
 ** If it returns false, it might be wise to enable the
 ** DVO with the above function.
 */
-static bool ns2501_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
+static bool ns2501_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
 {
 	struct ns2501_priv *ns = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
-	uint8_t out_buf[2];
+	u8 out_buf[2];
 
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
diff --git a/drivers/gpu/drm/i915/dvo_sil164.c b/drivers/gpu/drm/i915/dvo_sil164.c
index 1c1a0674dbab..4ae5d8fd9ff0 100644
--- a/drivers/gpu/drm/i915/dvo_sil164.c
+++ b/drivers/gpu/drm/i915/dvo_sil164.c
@@ -65,7 +65,7 @@ struct sil164_priv {
 
 #define SILPTR(d) ((SIL164Ptr)(d->DriverPrivate.ptr))
 
-static bool sil164_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
+static bool sil164_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
 {
 	struct sil164_priv *sil = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -102,11 +102,11 @@ static bool sil164_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
 	return false;
 }
 
-static bool sil164_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
+static bool sil164_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
 {
 	struct sil164_priv *sil = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
-	uint8_t out_buf[2];
+	u8 out_buf[2];
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
 		.flags = 0,
@@ -173,7 +173,7 @@ static bool sil164_init(struct intel_dvo_device *dvo,
 
 static enum drm_connector_status sil164_detect(struct intel_dvo_device *dvo)
 {
-	uint8_t reg9;
+	u8 reg9;
 
 	sil164_readb(dvo, SIL164_REG9, &reg9);
 
@@ -243,7 +243,7 @@ static bool sil164_get_hw_state(struct intel_dvo_device *dvo)
 
 static void sil164_dump_regs(struct intel_dvo_device *dvo)
 {
-	uint8_t val;
+	u8 val;
 
 	sil164_readb(dvo, SIL164_FREQ_LO, &val);
 	DRM_DEBUG_KMS("SIL164_FREQ_LO: 0x%02x\n", val);
diff --git a/drivers/gpu/drm/i915/dvo_tfp410.c b/drivers/gpu/drm/i915/dvo_tfp410.c
index 31e181da93db..d603bc2f2506 100644
--- a/drivers/gpu/drm/i915/dvo_tfp410.c
+++ b/drivers/gpu/drm/i915/dvo_tfp410.c
@@ -90,7 +90,7 @@ struct tfp410_priv {
 	bool quiet;
 };
 
-static bool tfp410_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
+static bool tfp410_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
 {
 	struct tfp410_priv *tfp = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
@@ -127,11 +127,11 @@ static bool tfp410_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
 	return false;
 }
 
-static bool tfp410_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
+static bool tfp410_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
 {
 	struct tfp410_priv *tfp = dvo->dev_priv;
 	struct i2c_adapter *adapter = dvo->i2c_bus;
-	uint8_t out_buf[2];
+	u8 out_buf[2];
 	struct i2c_msg msg = {
 		.addr = dvo->slave_addr,
 		.flags = 0,
@@ -155,7 +155,7 @@ static bool tfp410_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
 
 static int tfp410_getid(struct intel_dvo_device *dvo, int addr)
 {
-	uint8_t ch1, ch2;
+	u8 ch1, ch2;
 
 	if (tfp410_readb(dvo, addr+0, &ch1) &&
 	    tfp410_readb(dvo, addr+1, &ch2))
@@ -203,7 +203,7 @@ static bool tfp410_init(struct intel_dvo_device *dvo,
 static enum drm_connector_status tfp410_detect(struct intel_dvo_device *dvo)
 {
 	enum drm_connector_status ret = connector_status_disconnected;
-	uint8_t ctl2;
+	u8 ctl2;
 
 	if (tfp410_readb(dvo, TFP410_CTL_2, &ctl2)) {
 		if (ctl2 & TFP410_CTL_2_RSEN)
@@ -236,7 +236,7 @@ static void tfp410_mode_set(struct intel_dvo_device *dvo,
 /* set the tfp410 power state */
 static void tfp410_dpms(struct intel_dvo_device *dvo, bool enable)
 {
-	uint8_t ctl1;
+	u8 ctl1;
 
 	if (!tfp410_readb(dvo, TFP410_CTL_1, &ctl1))
 		return;
@@ -251,7 +251,7 @@ static void tfp410_dpms(struct intel_dvo_device *dvo, bool enable)
 
 static bool tfp410_get_hw_state(struct intel_dvo_device *dvo)
 {
-	uint8_t ctl1;
+	u8 ctl1;
 
 	if (!tfp410_readb(dvo, TFP410_CTL_1, &ctl1))
 		return false;
@@ -264,7 +264,7 @@ static bool tfp410_get_hw_state(struct intel_dvo_device *dvo)
 
 static void tfp410_dump_regs(struct intel_dvo_device *dvo)
 {
-	uint8_t val, val2;
+	u8 val, val2;
 
 	tfp410_readb(dvo, TFP410_REV, &val);
 	DRM_DEBUG_KMS("TFP410_REV: 0x%02X\n", val);
diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
index 7b942b6c1700..ff22d5d3a892 100644
--- a/drivers/gpu/drm/i915/intel_dvo.c
+++ b/drivers/gpu/drm/i915/intel_dvo.c
@@ -432,7 +432,7 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
 		int gpio;
 		bool dvoinit;
 		enum pipe pipe;
-		uint32_t dpll[I915_MAX_PIPES];
+		u32 dpll[I915_MAX_PIPES];
 		enum port port;
 
 		/*
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Tvrtko Ursulin]

On 12/06/2018 10:19, Jani Nikula wrote:
> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
> conflict much with in-flight patches.
> 
> The trouble with mixed use is that it's inconsistent, and any remaining C99
> types will encourage their use. We could at least do the low hanging fruit?

Ack from me. Doesn't seem so big to cause much pain.

When you say low-hanging fruit, that implies you only dealt with a 
particular class of occurrences?

Also going forward we have to make sure we will be able to stop them 
creeping back in. Is checkpatch perhaps covering this? Or we could put 
something in dim?

Regards,

Tvrtko

> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
> 
> BR,
> Jani.
> 
> 
> Jani Nikula (7):
>    drm/i915/vbt: switch to kernel unsigned int types
>    drm/i915/hdmi: switch to kernel unsigned int types
>    drm/i915/uncore: switch to kernel unsigned int types
>    drm/i915/dvo: switch to kernel unsigned int types
>    drm/i915/backlight: switch to kernel unsigned int types
>    drm/i915/audio: switch to kernel unsigned int types
>    drm/i915/lspcon: switch to kernel unsigned int types
> 
>   drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
>   drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
>   drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
>   drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
>   drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
>   drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
>   drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
>   drivers/gpu/drm/i915/intel_bios.c             |  4 +--
>   drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
>   drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
>   drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
>   drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
>   drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
>   drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
>   drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
>   15 files changed, 120 insertions(+), 120 deletions(-)
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Jani Nikula]

On Tue, 12 Jun 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 12/06/2018 10:19, Jani Nikula wrote:
>> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
>> conflict much with in-flight patches.
>> 
>> The trouble with mixed use is that it's inconsistent, and any remaining C99
>> types will encourage their use. We could at least do the low hanging fruit?
>
> Ack from me. Doesn't seem so big to cause much pain.
>
> When you say low-hanging fruit, that implies you only dealt with a 
> particular class of occurrences?

I meant the files which don't have massive amounts of C99 types and
aren't under active development right now. I just wanted to avoid
trouble for starters. ;)

> Also going forward we have to make sure we will be able to stop them 
> creeping back in. Is checkpatch perhaps covering this? Or we could put 
> something in dim?

We can stop ignoring PREFER_KERNEL_TYPES in checkpatch (the ignores are
in dim). We don't even have to change everything for that, we just need
to change enough to make the S/N better. People tend to use the types
near the places they change.

BR,
Jani.


>
> Regards,
>
> Tvrtko
>
>> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
>> 
>> BR,
>> Jani.
>> 
>> 
>> Jani Nikula (7):
>>    drm/i915/vbt: switch to kernel unsigned int types
>>    drm/i915/hdmi: switch to kernel unsigned int types
>>    drm/i915/uncore: switch to kernel unsigned int types
>>    drm/i915/dvo: switch to kernel unsigned int types
>>    drm/i915/backlight: switch to kernel unsigned int types
>>    drm/i915/audio: switch to kernel unsigned int types
>>    drm/i915/lspcon: switch to kernel unsigned int types
>> 
>>   drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
>>   drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
>>   drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
>>   drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
>>   drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
>>   drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
>>   drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
>>   drivers/gpu/drm/i915/intel_bios.c             |  4 +--
>>   drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
>>   drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
>>   drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
>>   drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
>>   drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
>>   drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
>>   drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
>>   15 files changed, 120 insertions(+), 120 deletions(-)
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.SPARSE: warning for drm/i915: move towards kernel types (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: move towards kernel types (rev2)
URL   : https://patchwork.freedesktop.org/series/44610/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Commit: drm/i915/vbt: switch to kernel unsigned int types
Okay!

Commit: drm/i915/hdmi: switch to kernel unsigned int types
Okay!

Commit: drm/i915/uncore: switch to kernel unsigned int types
Okay!

Commit: drm/i915/dvo: switch to kernel unsigned int types
Okay!

Commit: drm/i915/backlight: switch to kernel unsigned int types
Okay!

Commit: drm/i915/audio: switch to kernel unsigned int types
-O:drivers/gpu/drm/i915/intel_audio.c:278:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_audio.c:278:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_audio.c:457:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_audio.c:576:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:278:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:278:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:457:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:576:15: warning: expression using sizeof(void)

Commit: drm/i915/lspcon: switch to kernel unsigned int types
Okay!

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: move towards kernel types (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: move towards kernel types (rev2)
URL   : https://patchwork.freedesktop.org/series/44610/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4305 -> Patchwork_9272 =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9272 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9272, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/44610/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9272:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        PASS -> SKIP

    
== Known issues ==

  Here are the changes found in Patchwork_9272 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_gttfill@basic:
      fi-byt-n2820:       PASS -> FAIL (fdo#106744)

    igt@gem_exec_nop@basic-parallel:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#105719)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000)

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-glk-j4005:       PASS -> FAIL (fdo#100368)
      fi-cfl-s3:          PASS -> FAIL (fdo#103928, fdo#100368)
      fi-cnl-psr:         PASS -> FAIL (fdo#103928, fdo#100368)

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         PASS -> FAIL (fdo#104008)

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-WARN (fdo#106607) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106607 https://bugs.freedesktop.org/show_bug.cgi?id=106607
  fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744


== Participating hosts (42 -> 36) ==

  Missing    (6): fi-ilk-m540 fi-skl-gvtdvm fi-bdw-gvtdvm fi-bsw-cyan fi-ctg-p8600 fi-skl-6700hq 


== Build changes ==

    * Linux: CI_DRM_4305 -> Patchwork_9272

  CI_DRM_4305: d5ec1c93d19ce1fa4e23176828f4fb9a592f2609 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4515: a0f2d23b7d3d4226a0a7637a9240bfa86f08c1d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9272: 63e510d8cf5be48d1cd705797004da2b8cbf6ad9 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

63e510d8cf5b drm/i915/lspcon: switch to kernel unsigned int types
f8db0d41ba91 drm/i915/audio: switch to kernel unsigned int types
63849ccfe923 drm/i915/backlight: switch to kernel unsigned int types
ec9c81f7b3c8 drm/i915/dvo: switch to kernel unsigned int types
d68815c38f9a drm/i915/uncore: switch to kernel unsigned int types
f22e9c3948d6 drm/i915/hdmi: switch to kernel unsigned int types
4a7207fae0c9 drm/i915/vbt: switch to kernel unsigned int types

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9272/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915: move towards kernel types (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: move towards kernel types (rev2)
URL   : https://patchwork.freedesktop.org/series/44610/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4305_full -> Patchwork_9272_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9272_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9272_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9272_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          SKIP -> PASS +2

    igt@gem_mocs_settings@mocs-rc6-vebox:
      shard-kbl:          PASS -> SKIP +3

    igt@gem_tiled_blits@normal:
      shard-glk:          SKIP -> PASS

    igt@kms_cursor_legacy@cursora-vs-flipa-legacy:
      shard-snb:          SKIP -> PASS +3

    
== Known issues ==

  Here are the changes found in Patchwork_9272_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_gtt:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)
      shard-glk:          PASS -> FAIL (fdo#105347)

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#105763)

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          PASS -> FAIL (fdo#104724, fdo#103822)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-hsw:          INCOMPLETE (fdo#103540) -> PASS

    igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
      shard-hsw:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-hsw:          FAIL (fdo#102887) -> PASS

    igt@kms_flip@2x-flip-vs-fences:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> PASS +1

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS
      shard-hsw:          FAIL (fdo#100368) -> PASS

    igt@kms_flip_tiling@flip-x-tiled:
      shard-glk:          FAIL (fdo#104724, fdo#103822) -> PASS +1

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4305 -> Patchwork_9272

  CI_DRM_4305: d5ec1c93d19ce1fa4e23176828f4fb9a592f2609 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4515: a0f2d23b7d3d4226a0a7637a9240bfa86f08c1d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9272: 63e510d8cf5be48d1cd705797004da2b8cbf6ad9 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9272/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 6/7] drm/i915/audio: switch to kernel unsigned int types

[Ville Syrjälä]

On Tue, Jun 12, 2018 at 12:19:34PM +0300, Jani Nikula wrote:
> We have fairly mixed uintN_t vs. uN usage throughout the driver, but try
> to stick to kernel types at least where it's more prevalent.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_audio.c | 36 ++++++++++++++++++------------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 3ea566f99450..4e4c0ec44f35 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -198,13 +198,13 @@ static int audio_config_hdmi_get_n(const struct intel_crtc_state *crtc_state,
>  }
>  
>  static bool intel_eld_uptodate(struct drm_connector *connector,
> -			       i915_reg_t reg_eldv, uint32_t bits_eldv,
> -			       i915_reg_t reg_elda, uint32_t bits_elda,
> +			       i915_reg_t reg_eldv, u32 bits_eldv,
> +			       i915_reg_t reg_elda, u32 bits_elda,
>  			       i915_reg_t reg_edid)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(connector->dev);
> -	uint8_t *eld = connector->eld;
> -	uint32_t tmp;
> +	u8 *eld = connector->eld;

Drive by observation: could make all of these eld pointers const u32 *

> +	u32 tmp;
>  	int i;
>  
>  	tmp = I915_READ(reg_eldv);
> @@ -218,7 +218,7 @@ static bool intel_eld_uptodate(struct drm_connector *connector,
>  	I915_WRITE(reg_elda, tmp);
>  
>  	for (i = 0; i < drm_eld_size(eld) / 4; i++)
> -		if (I915_READ(reg_edid) != *((uint32_t *)eld + i))
> +		if (I915_READ(reg_edid) != *((u32 *)eld + i))
>  			return false;
>  
>  	return true;
-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Ville Syrjälä]

On Tue, Jun 12, 2018 at 12:19:28PM +0300, Jani Nikula wrote:
> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
> conflict much with in-flight patches.
> 
> The trouble with mixed use is that it's inconsistent, and any remaining C99
> types will encourage their use. We could at least do the low hanging fruit?
> 
> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
> 
> BR,
> Jani.
> 
> 
> Jani Nikula (7):
>   drm/i915/vbt: switch to kernel unsigned int types
>   drm/i915/hdmi: switch to kernel unsigned int types
>   drm/i915/uncore: switch to kernel unsigned int types
>   drm/i915/dvo: switch to kernel unsigned int types
>   drm/i915/backlight: switch to kernel unsigned int types
>   drm/i915/audio: switch to kernel unsigned int types
>   drm/i915/lspcon: switch to kernel unsigned int types

Did a quick once over and didn't spot anything wrong, so
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
>  drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
>  drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
>  drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
>  drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
>  drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
>  drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
>  drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
>  drivers/gpu/drm/i915/intel_bios.c             |  4 +--
>  drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
>  drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
>  drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
>  drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
>  drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
>  drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
>  drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
>  15 files changed, 120 insertions(+), 120 deletions(-)
> 
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Lucas De Marchi]

On Tue, Jun 12, 2018 at 3:15 AM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Tue, 12 Jun 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> > On 12/06/2018 10:19, Jani Nikula wrote:
> >> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
> >> conflict much with in-flight patches.
> >>
> >> The trouble with mixed use is that it's inconsistent, and any remaining C99
> >> types will encourage their use. We could at least do the low hanging fruit?
> >
> > Ack from me. Doesn't seem so big to cause much pain.
> >
> > When you say low-hanging fruit, that implies you only dealt with a
> > particular class of occurrences?
>
> I meant the files which don't have massive amounts of C99 types and
> aren't under active development right now. I just wanted to avoid
> trouble for starters. ;)

If using kernel types is where we want to go (which I agree with),
maybe it would be better to have a single conversion rather than
several small ones as we are doing with dev_priv -> i915? This allows
in-flight-but-not-yet-sent patches to easily keep up with the changes
rather than conflicting every other rebase.

Lucas De Marchi

>
> > Also going forward we have to make sure we will be able to stop them
> > creeping back in. Is checkpatch perhaps covering this? Or we could put
> > something in dim?
>
> We can stop ignoring PREFER_KERNEL_TYPES in checkpatch (the ignores are
> in dim). We don't even have to change everything for that, we just need
> to change enough to make the S/N better. People tend to use the types
> near the places they change.
>
> BR,
> Jani.
>
>
> >
> > Regards,
> >
> > Tvrtko
> >
> >> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
> >>
> >> BR,
> >> Jani.
> >>
> >>
> >> Jani Nikula (7):
> >>    drm/i915/vbt: switch to kernel unsigned int types
> >>    drm/i915/hdmi: switch to kernel unsigned int types
> >>    drm/i915/uncore: switch to kernel unsigned int types
> >>    drm/i915/dvo: switch to kernel unsigned int types
> >>    drm/i915/backlight: switch to kernel unsigned int types
> >>    drm/i915/audio: switch to kernel unsigned int types
> >>    drm/i915/lspcon: switch to kernel unsigned int types
> >>
> >>   drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
> >>   drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
> >>   drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
> >>   drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
> >>   drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
> >>   drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
> >>   drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
> >>   drivers/gpu/drm/i915/intel_bios.c             |  4 +--
> >>   drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
> >>   drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
> >>   drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
> >>   drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
> >>   drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
> >>   drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
> >>   drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
> >>   15 files changed, 120 insertions(+), 120 deletions(-)
> >>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Jani Nikula]

On Tue, 12 Jun 2018, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> On Tue, Jun 12, 2018 at 3:15 AM Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> On Tue, 12 Jun 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>> > On 12/06/2018 10:19, Jani Nikula wrote:
>> >> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
>> >> conflict much with in-flight patches.
>> >>
>> >> The trouble with mixed use is that it's inconsistent, and any remaining C99
>> >> types will encourage their use. We could at least do the low hanging fruit?
>> >
>> > Ack from me. Doesn't seem so big to cause much pain.
>> >
>> > When you say low-hanging fruit, that implies you only dealt with a
>> > particular class of occurrences?
>>
>> I meant the files which don't have massive amounts of C99 types and
>> aren't under active development right now. I just wanted to avoid
>> trouble for starters. ;)
>
> If using kernel types is where we want to go (which I agree with),
> maybe it would be better to have a single conversion rather than
> several small ones as we are doing with dev_priv -> i915? This allows
> in-flight-but-not-yet-sent patches to easily keep up with the changes
> rather than conflicting every other rebase.

I'm thinking we can do a lot of changes without conflicting anything or
very little. At least for starters before the sudden ripping off the
band-aid.

BR,
Jani.

>
> Lucas De Marchi
>
>>
>> > Also going forward we have to make sure we will be able to stop them
>> > creeping back in. Is checkpatch perhaps covering this? Or we could put
>> > something in dim?
>>
>> We can stop ignoring PREFER_KERNEL_TYPES in checkpatch (the ignores are
>> in dim). We don't even have to change everything for that, we just need
>> to change enough to make the S/N better. People tend to use the types
>> near the places they change.
>>
>> BR,
>> Jani.
>>
>>
>> >
>> > Regards,
>> >
>> > Tvrtko
>> >
>> >> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
>> >>
>> >> BR,
>> >> Jani.
>> >>
>> >>
>> >> Jani Nikula (7):
>> >>    drm/i915/vbt: switch to kernel unsigned int types
>> >>    drm/i915/hdmi: switch to kernel unsigned int types
>> >>    drm/i915/uncore: switch to kernel unsigned int types
>> >>    drm/i915/dvo: switch to kernel unsigned int types
>> >>    drm/i915/backlight: switch to kernel unsigned int types
>> >>    drm/i915/audio: switch to kernel unsigned int types
>> >>    drm/i915/lspcon: switch to kernel unsigned int types
>> >>
>> >>   drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
>> >>   drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
>> >>   drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
>> >>   drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
>> >>   drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
>> >>   drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
>> >>   drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
>> >>   drivers/gpu/drm/i915/intel_bios.c             |  4 +--
>> >>   drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
>> >>   drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
>> >>   drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
>> >>   drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
>> >>   drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
>> >>   drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
>> >>   drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
>> >>   15 files changed, 120 insertions(+), 120 deletions(-)
>> >>
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Rodrigo Vivi]

On Wed, Jun 13, 2018 at 09:55:38AM +0300, Jani Nikula wrote:
> On Tue, 12 Jun 2018, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> > On Tue, Jun 12, 2018 at 3:15 AM Jani Nikula <jani.nikula@intel.com> wrote:
> >>
> >> On Tue, 12 Jun 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> >> > On 12/06/2018 10:19, Jani Nikula wrote:
> >> >> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
> >> >> conflict much with in-flight patches.
> >> >>
> >> >> The trouble with mixed use is that it's inconsistent, and any remaining C99
> >> >> types will encourage their use. We could at least do the low hanging fruit?
> >> >
> >> > Ack from me. Doesn't seem so big to cause much pain.
> >> >
> >> > When you say low-hanging fruit, that implies you only dealt with a
> >> > particular class of occurrences?
> >>
> >> I meant the files which don't have massive amounts of C99 types and
> >> aren't under active development right now. I just wanted to avoid
> >> trouble for starters. ;)
> >
> > If using kernel types is where we want to go (which I agree with),
> > maybe it would be better to have a single conversion rather than
> > several small ones as we are doing with dev_priv -> i915? This allows
> > in-flight-but-not-yet-sent patches to easily keep up with the changes
> > rather than conflicting every other rebase.
> 
> I'm thinking we can do a lot of changes without conflicting anything or
> very little. At least for starters before the sudden ripping off the
> band-aid.

I'm with Lucas. I'd prefer one single massive move than many small ones.
Easier for the internal maintenance. We fix it only once and not one per
day for months and months like dev_priv/i915 case.

> 
> BR,
> Jani.
> 
> >
> > Lucas De Marchi
> >
> >>
> >> > Also going forward we have to make sure we will be able to stop them
> >> > creeping back in. Is checkpatch perhaps covering this? Or we could put
> >> > something in dim?
> >>
> >> We can stop ignoring PREFER_KERNEL_TYPES in checkpatch (the ignores are
> >> in dim). We don't even have to change everything for that, we just need
> >> to change enough to make the S/N better. People tend to use the types
> >> near the places they change.
> >>
> >> BR,
> >> Jani.
> >>
> >>
> >> >
> >> > Regards,
> >> >
> >> > Tvrtko
> >> >
> >> >> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
> >> >>
> >> >> BR,
> >> >> Jani.
> >> >>
> >> >>
> >> >> Jani Nikula (7):
> >> >>    drm/i915/vbt: switch to kernel unsigned int types
> >> >>    drm/i915/hdmi: switch to kernel unsigned int types
> >> >>    drm/i915/uncore: switch to kernel unsigned int types
> >> >>    drm/i915/dvo: switch to kernel unsigned int types
> >> >>    drm/i915/backlight: switch to kernel unsigned int types
> >> >>    drm/i915/audio: switch to kernel unsigned int types
> >> >>    drm/i915/lspcon: switch to kernel unsigned int types
> >> >>
> >> >>   drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
> >> >>   drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
> >> >>   drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
> >> >>   drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
> >> >>   drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
> >> >>   drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
> >> >>   drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
> >> >>   drivers/gpu/drm/i915/intel_bios.c             |  4 +--
> >> >>   drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
> >> >>   drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
> >> >>   drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
> >> >>   drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
> >> >>   drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
> >> >>   drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
> >> >>   drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
> >> >>   15 files changed, 120 insertions(+), 120 deletions(-)
> >> >>
> >>
> >> --
> >> Jani Nikula, Intel Open Source Graphics Center
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Jani Nikula]

On Thu, 14 Jun 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Jun 13, 2018 at 09:55:38AM +0300, Jani Nikula wrote:
>> On Tue, 12 Jun 2018, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
>> > On Tue, Jun 12, 2018 at 3:15 AM Jani Nikula <jani.nikula@intel.com> wrote:
>> >>
>> >> On Tue, 12 Jun 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>> >> > On 12/06/2018 10:19, Jani Nikula wrote:
>> >> >> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
>> >> >> conflict much with in-flight patches.
>> >> >>
>> >> >> The trouble with mixed use is that it's inconsistent, and any remaining C99
>> >> >> types will encourage their use. We could at least do the low hanging fruit?
>> >> >
>> >> > Ack from me. Doesn't seem so big to cause much pain.
>> >> >
>> >> > When you say low-hanging fruit, that implies you only dealt with a
>> >> > particular class of occurrences?
>> >>
>> >> I meant the files which don't have massive amounts of C99 types and
>> >> aren't under active development right now. I just wanted to avoid
>> >> trouble for starters. ;)
>> >
>> > If using kernel types is where we want to go (which I agree with),
>> > maybe it would be better to have a single conversion rather than
>> > several small ones as we are doing with dev_priv -> i915? This allows
>> > in-flight-but-not-yet-sent patches to easily keep up with the changes
>> > rather than conflicting every other rebase.
>> 
>> I'm thinking we can do a lot of changes without conflicting anything or
>> very little. At least for starters before the sudden ripping off the
>> band-aid.
>
> I'm with Lucas. I'd prefer one single massive move than many small ones.
> Easier for the internal maintenance. We fix it only once and not one per
> day for months and months like dev_priv/i915 case.

For everything else, I believe smaller patches are easier. For example,
who is going to review the massive change? Halt everything until it's
reviewed and merged? For merge conflicts I think git can do a better job
of managing the rerere with piecemeal changes. Internal is not the only
consideration.

BR,
Jani.

>
>> 
>> BR,
>> Jani.
>> 
>> >
>> > Lucas De Marchi
>> >
>> >>
>> >> > Also going forward we have to make sure we will be able to stop them
>> >> > creeping back in. Is checkpatch perhaps covering this? Or we could put
>> >> > something in dim?
>> >>
>> >> We can stop ignoring PREFER_KERNEL_TYPES in checkpatch (the ignores are
>> >> in dim). We don't even have to change everything for that, we just need
>> >> to change enough to make the S/N better. People tend to use the types
>> >> near the places they change.
>> >>
>> >> BR,
>> >> Jani.
>> >>
>> >>
>> >> >
>> >> > Regards,
>> >> >
>> >> > Tvrtko
>> >> >
>> >> >> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
>> >> >>
>> >> >> BR,
>> >> >> Jani.
>> >> >>
>> >> >>
>> >> >> Jani Nikula (7):
>> >> >>    drm/i915/vbt: switch to kernel unsigned int types
>> >> >>    drm/i915/hdmi: switch to kernel unsigned int types
>> >> >>    drm/i915/uncore: switch to kernel unsigned int types
>> >> >>    drm/i915/dvo: switch to kernel unsigned int types
>> >> >>    drm/i915/backlight: switch to kernel unsigned int types
>> >> >>    drm/i915/audio: switch to kernel unsigned int types
>> >> >>    drm/i915/lspcon: switch to kernel unsigned int types
>> >> >>
>> >> >>   drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
>> >> >>   drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
>> >> >>   drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
>> >> >>   drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
>> >> >>   drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
>> >> >>   drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
>> >> >>   drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
>> >> >>   drivers/gpu/drm/i915/intel_bios.c             |  4 +--
>> >> >>   drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
>> >> >>   drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
>> >> >>   drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
>> >> >>   drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
>> >> >>   drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
>> >> >>   drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
>> >> >>   drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
>> >> >>   15 files changed, 120 insertions(+), 120 deletions(-)
>> >> >>
>> >>
>> >> --
>> >> Jani Nikula, Intel Open Source Graphics Center
>> >> _______________________________________________
>> >> Intel-gfx mailing list
>> >> Intel-gfx@lists.freedesktop.org
>> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> 
>> -- 
>> Jani Nikula, Intel Open Source Graphics Center
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Joonas Lahtinen]

Quoting Jani Nikula (2018-06-15 12:08:23)
> On Thu, 14 Jun 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > On Wed, Jun 13, 2018 at 09:55:38AM +0300, Jani Nikula wrote:
> >> On Tue, 12 Jun 2018, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> >> > On Tue, Jun 12, 2018 at 3:15 AM Jani Nikula <jani.nikula@intel.com> wrote:
> >> >>
> >> >> On Tue, 12 Jun 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> >> >> > On 12/06/2018 10:19, Jani Nikula wrote:
> >> >> >> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
> >> >> >> conflict much with in-flight patches.
> >> >> >>
> >> >> >> The trouble with mixed use is that it's inconsistent, and any remaining C99
> >> >> >> types will encourage their use. We could at least do the low hanging fruit?
> >> >> >
> >> >> > Ack from me. Doesn't seem so big to cause much pain.
> >> >> >
> >> >> > When you say low-hanging fruit, that implies you only dealt with a
> >> >> > particular class of occurrences?
> >> >>
> >> >> I meant the files which don't have massive amounts of C99 types and
> >> >> aren't under active development right now. I just wanted to avoid
> >> >> trouble for starters. ;)
> >> >
> >> > If using kernel types is where we want to go (which I agree with),
> >> > maybe it would be better to have a single conversion rather than
> >> > several small ones as we are doing with dev_priv -> i915? This allows
> >> > in-flight-but-not-yet-sent patches to easily keep up with the changes
> >> > rather than conflicting every other rebase.
> >> 
> >> I'm thinking we can do a lot of changes without conflicting anything or
> >> very little. At least for starters before the sudden ripping off the
> >> band-aid.
> >
> > I'm with Lucas. I'd prefer one single massive move than many small ones.
> > Easier for the internal maintenance. We fix it only once and not one per
> > day for months and months like dev_priv/i915 case.
> 
> For everything else, I believe smaller patches are easier. For example,
> who is going to review the massive change? Halt everything until it's
> reviewed and merged? For merge conflicts I think git can do a better job
> of managing the rerere with piecemeal changes. Internal is not the only
> consideration.

I'm somewhere in the middle, but I have to agree changing everything with
one patch would be bit too overwhelming for review.

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Jani Nikula]

On Mon, 18 Jun 2018, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> Quoting Jani Nikula (2018-06-15 12:08:23)
>> On Thu, 14 Jun 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>> > On Wed, Jun 13, 2018 at 09:55:38AM +0300, Jani Nikula wrote:
>> >> On Tue, 12 Jun 2018, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
>> >> > On Tue, Jun 12, 2018 at 3:15 AM Jani Nikula <jani.nikula@intel.com> wrote:
>> >> >>
>> >> >> On Tue, 12 Jun 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>> >> >> > On 12/06/2018 10:19, Jani Nikula wrote:
>> >> >> >> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
>> >> >> >> conflict much with in-flight patches.
>> >> >> >>
>> >> >> >> The trouble with mixed use is that it's inconsistent, and any remaining C99
>> >> >> >> types will encourage their use. We could at least do the low hanging fruit?
>> >> >> >
>> >> >> > Ack from me. Doesn't seem so big to cause much pain.
>> >> >> >
>> >> >> > When you say low-hanging fruit, that implies you only dealt with a
>> >> >> > particular class of occurrences?
>> >> >>
>> >> >> I meant the files which don't have massive amounts of C99 types and
>> >> >> aren't under active development right now. I just wanted to avoid
>> >> >> trouble for starters. ;)
>> >> >
>> >> > If using kernel types is where we want to go (which I agree with),
>> >> > maybe it would be better to have a single conversion rather than
>> >> > several small ones as we are doing with dev_priv -> i915? This allows
>> >> > in-flight-but-not-yet-sent patches to easily keep up with the changes
>> >> > rather than conflicting every other rebase.
>> >> 
>> >> I'm thinking we can do a lot of changes without conflicting anything or
>> >> very little. At least for starters before the sudden ripping off the
>> >> band-aid.
>> >
>> > I'm with Lucas. I'd prefer one single massive move than many small ones.
>> > Easier for the internal maintenance. We fix it only once and not one per
>> > day for months and months like dev_priv/i915 case.
>> 
>> For everything else, I believe smaller patches are easier. For example,
>> who is going to review the massive change? Halt everything until it's
>> reviewed and merged? For merge conflicts I think git can do a better job
>> of managing the rerere with piecemeal changes. Internal is not the only
>> consideration.
>
> I'm somewhere in the middle, but I have to agree changing everything with
> one patch would be bit too overwhelming for review.

Okay, we can continue to debate, but I've pushed this series in the mean
time because it has review and by my judgement should not conflict much.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] drm/i915: move towards kernel types

[Lucas De Marchi]

On Fri, Jun 15, 2018 at 2:08 AM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Thu, 14 Jun 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > On Wed, Jun 13, 2018 at 09:55:38AM +0300, Jani Nikula wrote:
> >> On Tue, 12 Jun 2018, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> >> > On Tue, Jun 12, 2018 at 3:15 AM Jani Nikula <jani.nikula@intel.com> wrote:
> >> >>
> >> >> On Tue, 12 Jun 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> >> >> > On 12/06/2018 10:19, Jani Nikula wrote:
> >> >> >> Semi-RFC. Do we want to do this? Here's a batch of conversions that shouldn't
> >> >> >> conflict much with in-flight patches.
> >> >> >>
> >> >> >> The trouble with mixed use is that it's inconsistent, and any remaining C99
> >> >> >> types will encourage their use. We could at least do the low hanging fruit?
> >> >> >
> >> >> > Ack from me. Doesn't seem so big to cause much pain.
> >> >> >
> >> >> > When you say low-hanging fruit, that implies you only dealt with a
> >> >> > particular class of occurrences?
> >> >>
> >> >> I meant the files which don't have massive amounts of C99 types and
> >> >> aren't under active development right now. I just wanted to avoid
> >> >> trouble for starters. ;)
> >> >
> >> > If using kernel types is where we want to go (which I agree with),
> >> > maybe it would be better to have a single conversion rather than
> >> > several small ones as we are doing with dev_priv -> i915? This allows
> >> > in-flight-but-not-yet-sent patches to easily keep up with the changes
> >> > rather than conflicting every other rebase.
> >>
> >> I'm thinking we can do a lot of changes without conflicting anything or
> >> very little. At least for starters before the sudden ripping off the
> >> band-aid.
> >
> > I'm with Lucas. I'd prefer one single massive move than many small ones.
> > Easier for the internal maintenance. We fix it only once and not one per
> > day for months and months like dev_priv/i915 case.
>
> For everything else, I believe smaller patches are easier. For example,
> who is going to review the massive change? Halt everything until it's
> reviewed and merged? For merge conflicts I think git can do a better job
> of managing the rerere with piecemeal changes. Internal is not the only
> consideration.

A change like this would be a matter of having a sed/cocci/whatever
script that can be reproduced later.
The end result can be split in logical chunks for review/merge, I
never said it ought to be in one patch.

Lucas De Marchi

>
> BR,
> Jani.
>
> >
> >>
> >> BR,
> >> Jani.
> >>
> >> >
> >> > Lucas De Marchi
> >> >
> >> >>
> >> >> > Also going forward we have to make sure we will be able to stop them
> >> >> > creeping back in. Is checkpatch perhaps covering this? Or we could put
> >> >> > something in dim?
> >> >>
> >> >> We can stop ignoring PREFER_KERNEL_TYPES in checkpatch (the ignores are
> >> >> in dim). We don't even have to change everything for that, we just need
> >> >> to change enough to make the S/N better. People tend to use the types
> >> >> near the places they change.
> >> >>
> >> >> BR,
> >> >> Jani.
> >> >>
> >> >>
> >> >> >
> >> >> > Regards,
> >> >> >
> >> >> > Tvrtko
> >> >> >
> >> >> >> $ git grep "uint\(8\|16\|32\|64\)_t" -- drivers/gpu/drm/i915/ | sed 's/:.*//' | sort | uniq -c | sort -n
> >> >> >>
> >> >> >> BR,
> >> >> >> Jani.
> >> >> >>
> >> >> >>
> >> >> >> Jani Nikula (7):
> >> >> >>    drm/i915/vbt: switch to kernel unsigned int types
> >> >> >>    drm/i915/hdmi: switch to kernel unsigned int types
> >> >> >>    drm/i915/uncore: switch to kernel unsigned int types
> >> >> >>    drm/i915/dvo: switch to kernel unsigned int types
> >> >> >>    drm/i915/backlight: switch to kernel unsigned int types
> >> >> >>    drm/i915/audio: switch to kernel unsigned int types
> >> >> >>    drm/i915/lspcon: switch to kernel unsigned int types
> >> >> >>
> >> >> >>   drivers/gpu/drm/i915/dvo_ch7017.c             | 20 ++++++------
> >> >> >>   drivers/gpu/drm/i915/dvo_ch7xxx.c             | 22 +++++++-------
> >> >> >>   drivers/gpu/drm/i915/dvo_ivch.c               | 26 ++++++++--------
> >> >> >>   drivers/gpu/drm/i915/dvo_ns2501.c             | 44 +++++++++++++--------------
> >> >> >>   drivers/gpu/drm/i915/dvo_sil164.c             | 10 +++---
> >> >> >>   drivers/gpu/drm/i915/dvo_tfp410.c             | 16 +++++-----
> >> >> >>   drivers/gpu/drm/i915/intel_audio.c            | 36 +++++++++++-----------
> >> >> >>   drivers/gpu/drm/i915/intel_bios.c             |  4 +--
> >> >> >>   drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 12 ++++----
> >> >> >>   drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
> >> >> >>   drivers/gpu/drm/i915/intel_hdmi.c             | 14 ++++-----
> >> >> >>   drivers/gpu/drm/i915/intel_lspcon.c           |  2 +-
> >> >> >>   drivers/gpu/drm/i915/intel_panel.c            |  8 ++---
> >> >> >>   drivers/gpu/drm/i915/intel_uncore.h           | 22 +++++++-------
> >> >> >>   drivers/gpu/drm/i915/intel_vbt_defs.h         |  2 +-
> >> >> >>   15 files changed, 120 insertions(+), 120 deletions(-)
> >> >> >>
> >> >>
> >> >> --
> >> >> Jani Nikula, Intel Open Source Graphics Center
> >> >> _______________________________________________
> >> >> Intel-gfx mailing list
> >> >> Intel-gfx@lists.freedesktop.org
> >> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >>
> >> --
> >> Jani Nikula, Intel Open Source Graphics Center
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Graphics Center



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx