[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Felipe Balbi]

Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:

> From: Vardan Mikayelyan <mvardan@synopsys.com>
>
> These are wrapper functions which are calling device or host
> enter/exit hibernation functions.
>
> Signed-off-by: Vardan Mikayelyan <mvardan@synopsys.com>
> Signed-off-by: John Youn <johnyoun@synopsys.com>
> Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>

didn't apply to testing/next. Care to rebase on testing/next?

best

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Felipe Balbi]

Hi,

Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
> On 3/12/2018 5:34 PM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
>>> One more thing.
>>>
>>> In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn)
>>> Signed-off is missing.
>>>
>>> Could you please manually add his Signed-off ("Signed-off-by: John Youn
>>> <johnyoun@synopsys.com>") or it's against rules?
>> 
>> I need John to give me his S-o-B line, without it, I'll have to drop the
>> patch and, consequently, the rest of the series.
>> 
>
> I have a call with him today. I will told him to give you his S-o-B line 
> as soon as possible.

Thanks

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Grigor Tovmasyan]

On 3/12/2018 5:34 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
>> One more thing.
>>
>> In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn)
>> Signed-off is missing.
>>
>> Could you please manually add his Signed-off ("Signed-off-by: John Youn
>> <johnyoun@synopsys.com>") or it's against rules?
> 
> I need John to give me his S-o-B line, without it, I'll have to drop the
> patch and, consequently, the rest of the series.
> 

I have a call with him today. I will told him to give you his S-o-B line 
as soon as possible.

Thanks again.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Felipe Balbi]

Hi,

Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
> One more thing.
>
> In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn) 
> Signed-off is missing.
>
> Could you please manually add his Signed-off ("Signed-off-by: John Youn 
> <johnyoun@synopsys.com>") or it's against rules?

I need John to give me his S-o-B line, without it, I'll have to drop the
patch and, consequently, the rest of the series.

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Grigor Tovmasyan]

One more thing.

In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn) 
Signed-off is missing.

Could you please manually add his Signed-off ("Signed-off-by: John Youn 
<johnyoun@synopsys.com>") or it's against rules?


On 3/12/2018 5:07 PM, Felipe Balbi wrote:
> 
> (no top-posting!!)
> 
> Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
>> Hi,
>>
>> Yes. I'm verifying, it's okay.
>>
>> Sorry for inconvenience.
> 
> thank you. I'll move the changes to 'next'.
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Felipe Balbi]

(no top-posting!!)

Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
> Hi,
>
> Yes. I'm verifying, it's okay.
>
> Sorry for inconvenience.

thank you. I'll move the changes to 'next'.

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Grigor Tovmasyan]

Hi,

Yes. I'm verifying, it's okay.

Sorry for inconvenience.

Thanks,
Grigor.

On 3/12/2018 4:47 PM, Felipe Balbi wrote:
> 
> (please avoid top-posting)
> 
> Hi,
> 
> Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
>> Hi Balbi,
>>
>> Please also cherry-pick following commit from your 'testing/next' to
>> 'tmp' right before 01/14. It will solve the problem.
>>
>> 969d58abe57d usb: dwc2: Enable LPM
> 
> testing/next has been updated. Can you verify it's okay?
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Felipe Balbi]

(please avoid top-posting)

Hi,

Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
> Hi Balbi,
>
> Please also cherry-pick following commit from your 'testing/next' to 
> 'tmp' right before 01/14. It will solve the problem.
>
> 969d58abe57d usb: dwc2: Enable LPM

testing/next has been updated. Can you verify it's okay?

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Grigor Tovmasyan]

Hi Balbi,

Please also cherry-pick following commit from your 'testing/next' to 
'tmp' right before 01/14. It will solve the problem.

969d58abe57d usb: dwc2: Enable LPM

On 3/12/2018 4:03 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
>> Hi Balbi,
>>
>> Did you tried to apply your patch of the top of your testing/next branch?
>>
>> If yes, could you please apply 01/14 ("[PATCH v1 01/14] usb: dwc2:
>> Rename hibernation to partial_power_down")
>> and 02/14 ([PATCH v1 02/14] usb: dwc2: Add hibernation field into
>> dwc2_hw_params) patches right before 03/14 ([PATCH v1 03/14] usb: dwc2:
>> gadget: Moved dtxfsiz backup array place).
>>
>> You can use "git rebase --interactive HEAD~10" command just adding
>> following lines starting with "x" in the top of opened file.
>>
>> x git apply <01/14 patch>
>> x git apply <02/14 patch>
>> pick 3d6c862d9361 usb: dwc2: gadget: Moved dtxfsiz backup array place
> 
> if I do that, patch 6/14 won't apply anymore. I've pushed a 'tmp' branch
> to kernel.org with patches 1/14 - 5/14 on top of my 'next' branch. Now
> 6/14 doesn't apply to that.
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Felipe Balbi]

Hi,

Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
> Hi Balbi,
>
> Did you tried to apply your patch of the top of your testing/next branch?
>
> If yes, could you please apply 01/14 ("[PATCH v1 01/14] usb: dwc2: 
> Rename hibernation to partial_power_down")
> and 02/14 ([PATCH v1 02/14] usb: dwc2: Add hibernation field into 
> dwc2_hw_params) patches right before 03/14 ([PATCH v1 03/14] usb: dwc2: 
> gadget: Moved dtxfsiz backup array place).
>
> You can use "git rebase --interactive HEAD~10" command just adding 
> following lines starting with "x" in the top of opened file.
>
> x git apply <01/14 patch>
> x git apply <02/14 patch>
> pick 3d6c862d9361 usb: dwc2: gadget: Moved dtxfsiz backup array place

if I do that, patch 6/14 won't apply anymore. I've pushed a 'tmp' branch
to kernel.org with patches 1/14 - 5/14 on top of my 'next' branch. Now
6/14 doesn't apply to that.

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Grigor Tovmasyan]

Hi Balbi,

Did you tried to apply your patch of the top of your testing/next branch?

If yes, could you please apply 01/14 ("[PATCH v1 01/14] usb: dwc2: 
Rename hibernation to partial_power_down")
and 02/14 ([PATCH v1 02/14] usb: dwc2: Add hibernation field into 
dwc2_hw_params) patches right before 03/14 ([PATCH v1 03/14] usb: dwc2: 
gadget: Moved dtxfsiz backup array place).

You can use "git rebase --interactive HEAD~10" command just adding 
following lines starting with "x" in the top of opened file.

x git apply <01/14 patch>
x git apply <02/14 patch>
pick 3d6c862d9361 usb: dwc2: gadget: Moved dtxfsiz backup array place

On 3/12/2018 2:22 PM, Felipe Balbi wrote:
> Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
> 
>> Hi Balbi,
>>
>> This patch didn't apply, because you missing 01/14 and 02/14 commits
>> from this patch seria.
>> Please apply following patches and try again.
>> [PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down
>> [PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params
> 
> right, and patch 1 doesn't apply:
> 
> error: patch failed: drivers/usb/dwc2/core.h:1117
> error: drivers/usb/dwc2/core.h: patch does not apply
> error: patch failed: drivers/usb/dwc2/hcd.c:4378
> error: drivers/usb/dwc2/hcd.c: patch does not apply
> Applying: usb: dwc2: Rename hibernation to partial_power_down
> Patch failed at 0001 usb: dwc2: Rename hibernation to partial_power_down
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Felipe Balbi]

Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:

> Hi Balbi,
>
> This patch didn't apply, because you missing 01/14 and 02/14 commits
> from this patch seria.
> Please apply following patches and try again.
> [PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down
> [PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params

right, and patch 1 doesn't apply:

error: patch failed: drivers/usb/dwc2/core.h:1117
error: drivers/usb/dwc2/core.h: patch does not apply
error: patch failed: drivers/usb/dwc2/hcd.c:4378
error: drivers/usb/dwc2/hcd.c: patch does not apply
Applying: usb: dwc2: Rename hibernation to partial_power_down
Patch failed at 0001 usb: dwc2: Rename hibernation to partial_power_down
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Grigor Tovmasyan]

Hi Balbi,

This patch didn't apply, because you missing 01/14 and 02/14 commits
from this patch seria.
Please apply following patches and try again.
[PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down
[PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params

On 3/9/2018 5:10 PM, Grigor Tovmasyan wrote:
> Hi  Balbi,
>
> Seems like your testing/next was changed.
> I will rebese and send them again.
>
> On 3/9/2018 1:07 PM, Felipe Balbi wrote:
>> Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
>>
>>> From: Vardan Mikayelyan <mvardan@synopsys.com>
>>>
>>> These are wrapper functions which are calling device or host
>>> enter/exit hibernation functions.
>>>
>>> Signed-off-by: Vardan Mikayelyan <mvardan@synopsys.com>
>>> Signed-off-by: John Youn <johnyoun@synopsys.com>
>>> Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
>> didn't apply to testing/next. Care to rebase on testing/next?
>>
>> best
>>
> BR,
> Grigor.
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Grigor Tovmasyan]

Hi  Balbi,

Seems like your testing/next was changed.
I will rebese and send them again.

On 3/9/2018 1:07 PM, Felipe Balbi wrote:
> Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com> writes:
>
>> From: Vardan Mikayelyan <mvardan@synopsys.com>
>>
>> These are wrapper functions which are calling device or host
>> enter/exit hibernation functions.
>>
>> Signed-off-by: Vardan Mikayelyan <mvardan@synopsys.com>
>> Signed-off-by: John Youn <johnyoun@synopsys.com>
>> Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
> didn't apply to testing/next. Care to rebase on testing/next?
>
> best
>

BR,
Grigor.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v1,10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

[Grigor Tovmasyan]

From: Vardan Mikayelyan <mvardan@synopsys.com>

These are wrapper functions which are calling device or host
enter/exit hibernation functions.

Signed-off-by: Vardan Mikayelyan <mvardan@synopsys.com>
Signed-off-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
---
 drivers/usb/dwc2/core.c | 38 ++++++++++++++++++++++++++++++++++++++
 drivers/usb/dwc2/core.h |  3 +++
 2 files changed, 41 insertions(+)

diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
index 73b05a8ccba1..280ecddf82cb 100644
--- a/drivers/usb/dwc2/core.c
+++ b/drivers/usb/dwc2/core.c
@@ -448,6 +448,44 @@ static bool dwc2_iddig_filter_enabled(struct dwc2_hsotg *hsotg)
 	return true;
 }
 
+/*
+ * dwc2_enter_hibernation() - Common function to enter hibernation.
+ *
+ * @hsotg: Programming view of the DWC_otg controller
+ * @is_host: True if core is in host mode.
+ *
+ * Return: 0 if successful, negative error code otherwise
+ */
+int dwc2_enter_hibernation(struct dwc2_hsotg *hsotg, int is_host)
+{
+	if (hsotg->params.power_down != DWC2_POWER_DOWN_PARAM_HIBERNATION)
+		return -ENOTSUPP;
+
+	if (is_host)
+		return dwc2_host_enter_hibernation(hsotg);
+	else
+		return dwc2_gadget_enter_hibernation(hsotg);
+}
+
+/*
+ * dwc2_exit_hibernation() - Common function to exit from hibernation.
+ *
+ * @hsotg: Programming view of the DWC_otg controller
+ * @rem_wakeup: Remote-wakeup, enabled in case of remote-wakeup.
+ * @reset: Enabled in case of restore with reset.
+ * @is_host: True if core is in host mode.
+ *
+ * Return: 0 if successful, negative error code otherwise
+ */
+int dwc2_exit_hibernation(struct dwc2_hsotg *hsotg, int rem_wakeup,
+			  int reset, int is_host)
+{
+	if (is_host)
+		return dwc2_host_exit_hibernation(hsotg, rem_wakeup, reset);
+	else
+		return dwc2_gadget_exit_hibernation(hsotg, rem_wakeup, reset);
+}
+
 /*
  * Do core a soft reset of the core.  Be careful with this because it
  * resets all the internal state machines of the core.
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index b04c794c6f13..cc7856496a4f 100644
--- a/drivers/usb/dwc2/core.h
+++ b/drivers/usb/dwc2/core.h
@@ -1134,6 +1134,9 @@ int dwc2_core_reset(struct dwc2_hsotg *hsotg, bool skip_wait);
 int dwc2_core_reset_and_force_dr_mode(struct dwc2_hsotg *hsotg);
 int dwc2_enter_partial_power_down(struct dwc2_hsotg *hsotg);
 int dwc2_exit_partial_power_down(struct dwc2_hsotg *hsotg, bool restore);
+int dwc2_enter_hibernation(struct dwc2_hsotg *hsotg, int is_host);
+int dwc2_exit_hibernation(struct dwc2_hsotg *hsotg, int rem_wakeup,
+			  int reset, int is_host);
 
 bool dwc2_force_mode_if_needed(struct dwc2_hsotg *hsotg, bool host);
 void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg);