[Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types

* [Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types
@ 2017-05-17 21:25 Eduardo Habkost
  2017-05-17 21:28 ` no-reply
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Eduardo Habkost @ 2017-05-17 21:25 UTC (permalink / raw)
  To: qemu-devel; +Cc: Markus Armbruster, Eric Blake, Marcel Apfelbaum

Currently there's no way for QMP clients to get a list of device types
that are really usable with -device.  This information would be useful
for management software and test scripts (like the device-crash-test
script I have submitted recently).  Interestingly, the "info qdm" HMP
command provides this information, but no QMP command does.

Add two new fields to the return value of qom-list-types:
"user-creatable-device" and "hotpluggable-device".  Also, add extra
arguments for filtering the list of types based on the new fields.

I'm not sure about the naming of the new command arguments.  Maybe the
names are too long, but I believe that "user-creatable-devices-only=false"
would have more obvious semantics than "user-creatable-devices=false"
(the latter looks ambiguous: it could mean "return only
non-user-creatable devices" or "return all devices").

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 qapi-schema.json | 25 +++++++++++++++++++++++--
 qmp.c            | 39 ++++++++++++++++++++++++++++++++++-----
 2 files changed, 57 insertions(+), 7 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index 80603cfc51..c0a56fc3a2 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3034,12 +3034,24 @@
 #
 # @name: the type name found in the search
 #
+# @user-creatable-device: If true, the type is a user-creatable device that
+#                         can be used with the "-device" command-line option.
+#                         Note that this does not guarantee that the device
+#                         is going to be accepted by all machine-types.
+#                         (since 2.10)
+#
+# @hotpluggable-device: If true, the type is a hotpluggable device that can
+#                       be plugged using the "device_add" monitor command.
+#                       Note that this does not guarantee that the device can
+#                       be hotplugged on any machine-type. (since 2.10)
+#
 # Since: 1.1
 #
 # Notes: This command is experimental and may change syntax in future releases.
 ##
 { 'struct': 'ObjectTypeInfo',
-  'data': { 'name': 'str' } }
+  'data': { 'name': 'str', 'user-creatable-device': 'bool',
+            'hotpluggable-device': 'bool' } }
 
 ##
 # @qom-list-types:
@@ -3050,12 +3062,21 @@
 #
 # @abstract: if true, include abstract types in the results
 #
+# @user-creatable-devices-only: If true, return only user-creatable device types
+#                               (See @ObjectTypeInfo.user-creatable-device)
+#                               (since 2.10)
+#
+# @hotpluggable-devices-only: If true, return only hotpluggable device types
+#                             (See @ObjectTypeInfo.hotpluggable-device)
+#                             (since 2.10)
+#
 # Returns: a list of @ObjectTypeInfo or an empty list if no results are found
 #
 # Since: 1.1
 ##
 { 'command': 'qom-list-types',
-  'data': { '*implements': 'str', '*abstract': 'bool' },
+  'data': { '*implements': 'str', '*abstract': 'bool',
+            '*user-creatable-devices-only': 'bool', '*hotpluggable-devices-only': 'bool' },
   'returns': [ 'ObjectTypeInfo' ] }
 
 ##
diff --git a/qmp.c b/qmp.c
index f656940769..4f350e4ea2 100644
--- a/qmp.c
+++ b/qmp.c
@@ -436,29 +436,58 @@ void qmp_change(const char *device, const char *target,
     }
 }
 
+typedef struct QOMListTypesArgs {
+    bool user_creatable_devices_only;
+    bool hotpluggable_devices_only;
+    ObjectTypeInfoList **pret;
+} QOMListTypesArgs;
+
 static void qom_list_types_tramp(ObjectClass *klass, void *data)
 {
-    ObjectTypeInfoList *e, **pret = data;
+    QOMListTypesArgs *args = data;
+    ObjectTypeInfoList *e;
     ObjectTypeInfo *info;
+    DeviceClass *dc = DEVICE_CLASS(object_class_dynamic_cast(klass,
+                                                             TYPE_DEVICE));
+    bool uc = dc ? dc->user_creatable : false;
+    bool hp = dc ? uc && dc->hotpluggable : false;
+
+    if ((args->user_creatable_devices_only && !uc) ||
+        (args->hotpluggable_devices_only && !hp)) {
+        return;
+    }
 
     info = g_malloc0(sizeof(*info));
     info->name = g_strdup(object_class_get_name(klass));
+    info->user_creatable_device = uc;
+    info->hotpluggable_device = hp;
 
     e = g_malloc0(sizeof(*e));
     e->value = info;
-    e->next = *pret;
-    *pret = e;
+    e->next = *args->pret;
+    *args->pret = e;
 }
 
 ObjectTypeInfoList *qmp_qom_list_types(bool has_implements,
                                        const char *implements,
                                        bool has_abstract,
                                        bool abstract,
+                                       bool has_user_creatable_devices_only,
+                                       bool user_creatable_devices_only,
+                                       bool has_hotpluggable_devices_only,
+                                       bool hotpluggable_devices_only,
                                        Error **errp)
 {
     ObjectTypeInfoList *ret = NULL;
-
-    object_class_foreach(qom_list_types_tramp, implements, abstract, &ret);
+    QOMListTypesArgs args = {
+        .pret = &ret,
+        .user_creatable_devices_only = has_user_creatable_devices_only &&
+                                      user_creatable_devices_only,
+        .hotpluggable_devices_only = has_hotpluggable_devices_only &&
+                                    hotpluggable_devices_only,
+    };
+
+    object_class_foreach(qom_list_types_tramp, implements, abstract, &args);
 
     return ret;
 }
-- 
2.11.0.259.g40922b1

^ permalink raw reply related	[flat|nested] 10+ messages in thread