[PATCH 23/25 v7][RFC] Local: Hack: remove pm_sysrq_init

[PATCH 23/25 v7][RFC] Local: Hack: remove pm_sysrq_init

[Kuninori Morimoto]

From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>

In initial H3 environment, psci/pm/suspend is not supported.
When primary cpu was booted, pm_sysrq_init() is not initialized.
So remove this function as temporary fix.

Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
---
v5 -> v7

 - no change

 kernel/power/poweroff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c
index 7ef6866..3f7ba43 100644
--- a/kernel/power/poweroff.c
+++ b/kernel/power/poweroff.c
@@ -39,7 +39,7 @@ static struct sysrq_key_op	sysrq_poweroff_op = {
 
 static int __init pm_sysrq_init(void)
 {
-	register_sysrq_key('o', &sysrq_poweroff_op);
+//	register_sysrq_key('o', &sysrq_poweroff_op);
 	return 0;
 }
 
-- 
1.9.1

Re: [PATCH 23/25 v7][RFC] Local: Hack: remove pm_sysrq_init

[Magnus Damm]

Hi Morimoto-san,

On Mon, Aug 24, 2015 at 11:32 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>
> In initial H3 environment, psci/pm/suspend is not supported.
> When primary cpu was booted, pm_sysrq_init() is not initialized.
> So remove this function as temporary fix.
>
> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> ---
> v5 -> v7
>
>  - no change

Thanks for your patch. Is this really needed? I doubt that, but
usually code is included for a reason. =)

If the patch is still needed, may I propose that you temporarily
modify the defconfig to disable CONFIG_MAGIC_SYSRQ instead of
modifying core code?

Thanks,

/ magnus