[PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Magnus Damm]

From: Magnus Damm <damm@opensource.se>

Hook up the single channel thermal sensor via DT
on r8a7790. The information used by the platform
device has been verified against the data sheet.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 Written against renesas-devel-20130925

 arch/arm/boot/dts/r8a7790.dtsi         |    7 +++++++
 arch/arm/mach-shmobile/clock-r8a7790.c |    1 +
 2 files changed, 8 insertions(+)

--- 0001/arch/arm/boot/dts/r8a7790.dtsi
+++ work/arch/arm/boot/dts/r8a7790.dtsi	2013-09-26 07:23:04.000000000 +0900
@@ -87,6 +87,13 @@
 		interrupts = <1 9 0xf04>;
 	};
 
+	thermal@e61f0000 {
+		compatible = "renesas,rcar-thermal";
+		reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 69 4>;
+	};
+
 	gpio0: gpio@ffc40000 {
 		compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar";
 		reg = <0 0xffc40000 0 0x2c>;
--- 0001/arch/arm/mach-shmobile/clock-r8a7790.c
+++ work/arch/arm/mach-shmobile/clock-r8a7790.c	2013-09-26 07:24:37.000000000 +0900
@@ -272,6 +272,7 @@ static struct clk_lookup lookups[] = {
 	CLKDEV_DEV_ID("sh-sci.8", &mstp_clks[MSTP717]),
 	CLKDEV_DEV_ID("sh-sci.9", &mstp_clks[MSTP716]),
 	CLKDEV_DEV_ID("r8a7790-ether", &mstp_clks[MSTP813]),
+	CLKDEV_DEV_ID("e61f0000.thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("rcar_thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("ee200000.mmcif", &mstp_clks[MSTP315]),
 	CLKDEV_DEV_ID("sh_mmcif.0", &mstp_clks[MSTP315]),

[PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Magnus Damm]

From: Magnus Damm <damm@opensource.se>

Hook up the single channel thermal sensor via DT
on r8a7790. The information used by the platform
device has been verified against the data sheet.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 Written against renesas-devel-20130925

 arch/arm/boot/dts/r8a7790.dtsi         |    7 +++++++
 arch/arm/mach-shmobile/clock-r8a7790.c |    1 +
 2 files changed, 8 insertions(+)

--- 0001/arch/arm/boot/dts/r8a7790.dtsi
+++ work/arch/arm/boot/dts/r8a7790.dtsi	2013-09-26 07:23:04.000000000 +0900
@@ -87,6 +87,13 @@
 		interrupts = <1 9 0xf04>;
 	};
 
+	thermal at e61f0000 {
+		compatible = "renesas,rcar-thermal";
+		reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 69 4>;
+	};
+
 	gpio0: gpio at ffc40000 {
 		compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar";
 		reg = <0 0xffc40000 0 0x2c>;
--- 0001/arch/arm/mach-shmobile/clock-r8a7790.c
+++ work/arch/arm/mach-shmobile/clock-r8a7790.c	2013-09-26 07:24:37.000000000 +0900
@@ -272,6 +272,7 @@ static struct clk_lookup lookups[] = {
 	CLKDEV_DEV_ID("sh-sci.8", &mstp_clks[MSTP717]),
 	CLKDEV_DEV_ID("sh-sci.9", &mstp_clks[MSTP716]),
 	CLKDEV_DEV_ID("r8a7790-ether", &mstp_clks[MSTP813]),
+	CLKDEV_DEV_ID("e61f0000.thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("rcar_thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("ee200000.mmcif", &mstp_clks[MSTP315]),
 	CLKDEV_DEV_ID("sh_mmcif.0", &mstp_clks[MSTP315]),

Re: [PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Simon Horman]

On Thu, Sep 26, 2013 at 08:11:19AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Hook up the single channel thermal sensor via DT
> on r8a7790. The information used by the platform
> device has been verified against the data sheet.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>

Hi Magnus,

I would prefer if this was split into two patches.
An SoC patch that updates clock-r8a7790.c.
And a DT patch which updates r8a7790.dtsi.

Thanks

> ---
> 
>  Written against renesas-devel-20130925
> 
>  arch/arm/boot/dts/r8a7790.dtsi         |    7 +++++++
>  arch/arm/mach-shmobile/clock-r8a7790.c |    1 +
>  2 files changed, 8 insertions(+)
> 
> --- 0001/arch/arm/boot/dts/r8a7790.dtsi
> +++ work/arch/arm/boot/dts/r8a7790.dtsi	2013-09-26 07:23:04.000000000 +0900
> @@ -87,6 +87,13 @@
>  		interrupts = <1 9 0xf04>;
>  	};
>  
> +	thermal@e61f0000 {
> +		compatible = "renesas,rcar-thermal";
> +		reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
> +		interrupt-parent = <&gic>;
> +		interrupts = <0 69 4>;
> +	};
> +
>  	gpio0: gpio@ffc40000 {
>  		compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar";
>  		reg = <0 0xffc40000 0 0x2c>;
> --- 0001/arch/arm/mach-shmobile/clock-r8a7790.c
> +++ work/arch/arm/mach-shmobile/clock-r8a7790.c	2013-09-26 07:24:37.000000000 +0900
> @@ -272,6 +272,7 @@ static struct clk_lookup lookups[] = {
>  	CLKDEV_DEV_ID("sh-sci.8", &mstp_clks[MSTP717]),
>  	CLKDEV_DEV_ID("sh-sci.9", &mstp_clks[MSTP716]),
>  	CLKDEV_DEV_ID("r8a7790-ether", &mstp_clks[MSTP813]),
> +	CLKDEV_DEV_ID("e61f0000.thermal", &mstp_clks[MSTP522]),
>  	CLKDEV_DEV_ID("rcar_thermal", &mstp_clks[MSTP522]),
>  	CLKDEV_DEV_ID("ee200000.mmcif", &mstp_clks[MSTP315]),
>  	CLKDEV_DEV_ID("sh_mmcif.0", &mstp_clks[MSTP315]),
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Simon Horman]

On Thu, Sep 26, 2013 at 08:11:19AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Hook up the single channel thermal sensor via DT
> on r8a7790. The information used by the platform
> device has been verified against the data sheet.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>

Hi Magnus,

I would prefer if this was split into two patches.
An SoC patch that updates clock-r8a7790.c.
And a DT patch which updates r8a7790.dtsi.

Thanks

> ---
> 
>  Written against renesas-devel-20130925
> 
>  arch/arm/boot/dts/r8a7790.dtsi         |    7 +++++++
>  arch/arm/mach-shmobile/clock-r8a7790.c |    1 +
>  2 files changed, 8 insertions(+)
> 
> --- 0001/arch/arm/boot/dts/r8a7790.dtsi
> +++ work/arch/arm/boot/dts/r8a7790.dtsi	2013-09-26 07:23:04.000000000 +0900
> @@ -87,6 +87,13 @@
>  		interrupts = <1 9 0xf04>;
>  	};
>  
> +	thermal at e61f0000 {
> +		compatible = "renesas,rcar-thermal";
> +		reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
> +		interrupt-parent = <&gic>;
> +		interrupts = <0 69 4>;
> +	};
> +
>  	gpio0: gpio at ffc40000 {
>  		compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar";
>  		reg = <0 0xffc40000 0 0x2c>;
> --- 0001/arch/arm/mach-shmobile/clock-r8a7790.c
> +++ work/arch/arm/mach-shmobile/clock-r8a7790.c	2013-09-26 07:24:37.000000000 +0900
> @@ -272,6 +272,7 @@ static struct clk_lookup lookups[] = {
>  	CLKDEV_DEV_ID("sh-sci.8", &mstp_clks[MSTP717]),
>  	CLKDEV_DEV_ID("sh-sci.9", &mstp_clks[MSTP716]),
>  	CLKDEV_DEV_ID("r8a7790-ether", &mstp_clks[MSTP813]),
> +	CLKDEV_DEV_ID("e61f0000.thermal", &mstp_clks[MSTP522]),
>  	CLKDEV_DEV_ID("rcar_thermal", &mstp_clks[MSTP522]),
>  	CLKDEV_DEV_ID("ee200000.mmcif", &mstp_clks[MSTP315]),
>  	CLKDEV_DEV_ID("sh_mmcif.0", &mstp_clks[MSTP315]),
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Magnus Damm]

On Thu, Sep 26, 2013 at 8:35 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Sep 26, 2013 at 08:11:19AM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Hook up the single channel thermal sensor via DT
>> on r8a7790. The information used by the platform
>> device has been verified against the data sheet.
>>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>
> Hi Magnus,
>
> I would prefer if this was split into two patches.
> An SoC patch that updates clock-r8a7790.c.
> And a DT patch which updates r8a7790.dtsi.

Sure, that's fine with me. I will do that from now on.

I believe that common clock framework will allow us to handle all
within a single dtsi patch.

Cheers,

/ magnus

[PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Magnus Damm]

On Thu, Sep 26, 2013 at 8:35 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Sep 26, 2013 at 08:11:19AM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Hook up the single channel thermal sensor via DT
>> on r8a7790. The information used by the platform
>> device has been verified against the data sheet.
>>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>
> Hi Magnus,
>
> I would prefer if this was split into two patches.
> An SoC patch that updates clock-r8a7790.c.
> And a DT patch which updates r8a7790.dtsi.

Sure, that's fine with me. I will do that from now on.

I believe that common clock framework will allow us to handle all
within a single dtsi patch.

Cheers,

/ magnus

Re: [PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Simon Horman]

On Thu, Sep 26, 2013 at 08:43:46AM +0900, Magnus Damm wrote:
> On Thu, Sep 26, 2013 at 8:35 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Sep 26, 2013 at 08:11:19AM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Hook up the single channel thermal sensor via DT
> >> on r8a7790. The information used by the platform
> >> device has been verified against the data sheet.
> >>
> >> Signed-off-by: Magnus Damm <damm@opensource.se>
> >
> > Hi Magnus,
> >
> > I would prefer if this was split into two patches.
> > An SoC patch that updates clock-r8a7790.c.
> > And a DT patch which updates r8a7790.dtsi.
> 
> Sure, that's fine with me. I will do that from now on.

Thanks. I'm trying to reduce dependencies/conflicts between
branches. I'm not sure how well it will pan out. But that is my aim
at the moment.

> I believe that common clock framework will allow us to handle all
> within a single dtsi patch.

Excellent.

[PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Simon Horman]

On Thu, Sep 26, 2013 at 08:43:46AM +0900, Magnus Damm wrote:
> On Thu, Sep 26, 2013 at 8:35 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Sep 26, 2013 at 08:11:19AM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Hook up the single channel thermal sensor via DT
> >> on r8a7790. The information used by the platform
> >> device has been verified against the data sheet.
> >>
> >> Signed-off-by: Magnus Damm <damm@opensource.se>
> >
> > Hi Magnus,
> >
> > I would prefer if this was split into two patches.
> > An SoC patch that updates clock-r8a7790.c.
> > And a DT patch which updates r8a7790.dtsi.
> 
> Sure, that's fine with me. I will do that from now on.

Thanks. I'm trying to reduce dependencies/conflicts between
branches. I'm not sure how well it will pan out. But that is my aim
at the moment.

> I believe that common clock framework will allow us to handle all
> within a single dtsi patch.

Excellent.

Re: [PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Kuninori Morimoto]

Hi Simon, Magnus

> > >> Hook up the single channel thermal sensor via DT
> > >> on r8a7790. The information used by the platform
> > >> device has been verified against the data sheet.
> > >>
> > >> Signed-off-by: Magnus Damm <damm@opensource.se>
> > >
> > > Hi Magnus,
> > >
> > > I would prefer if this was split into two patches.
> > > An SoC patch that updates clock-r8a7790.c.
> > > And a DT patch which updates r8a7790.dtsi.
> > 
> > Sure, that's fine with me. I will do that from now on.
> 
> Thanks. I'm trying to reduce dependencies/conflicts between
> branches. I'm not sure how well it will pan out. But that is my aim
> at the moment.
> 
> > I believe that common clock framework will allow us to handle all
> > within a single dtsi patch.

About thermal on H2/M2 (= Gen2),
I am concerned about whether Gen1/Gen2 thermal chip have a compatible,
since H2 datasheet v0.05 <-> v0.6 seems have different register mapping,
and M2 is very different from Gen1.
Now, I'm confirming about it

Best regards
---
Kuninori Morimoto

[PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Kuninori Morimoto]

Hi Simon, Magnus

> > >> Hook up the single channel thermal sensor via DT
> > >> on r8a7790. The information used by the platform
> > >> device has been verified against the data sheet.
> > >>
> > >> Signed-off-by: Magnus Damm <damm@opensource.se>
> > >
> > > Hi Magnus,
> > >
> > > I would prefer if this was split into two patches.
> > > An SoC patch that updates clock-r8a7790.c.
> > > And a DT patch which updates r8a7790.dtsi.
> > 
> > Sure, that's fine with me. I will do that from now on.
> 
> Thanks. I'm trying to reduce dependencies/conflicts between
> branches. I'm not sure how well it will pan out. But that is my aim
> at the moment.
> 
> > I believe that common clock framework will allow us to handle all
> > within a single dtsi patch.

About thermal on H2/M2 (= Gen2),
I am concerned about whether Gen1/Gen2 thermal chip have a compatible,
since H2 datasheet v0.05 <-> v0.6 seems have different register mapping,
and M2 is very different from Gen1.
Now, I'm confirming about it

Best regards
---
Kuninori Morimoto

Re: [PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Kuninori Morimoto]

Hi Simon, Magnus

> > > >> Hook up the single channel thermal sensor via DT
> > > >> on r8a7790. The information used by the platform
> > > >> device has been verified against the data sheet.
> > > >>
> > > >> Signed-off-by: Magnus Damm <damm@opensource.se>
> > > >
> > > > Hi Magnus,
> > > >
> > > > I would prefer if this was split into two patches.
> > > > An SoC patch that updates clock-r8a7790.c.
> > > > And a DT patch which updates r8a7790.dtsi.
> > > 
> > > Sure, that's fine with me. I will do that from now on.
> > 
> > Thanks. I'm trying to reduce dependencies/conflicts between
> > branches. I'm not sure how well it will pan out. But that is my aim
> > at the moment.
> > 
> > > I believe that common clock framework will allow us to handle all
> > > within a single dtsi patch.
> 
> About thermal on H2/M2 (= Gen2),
> I am concerned about whether Gen1/Gen2 thermal chip have a compatible,
> since H2 datasheet v0.05 <-> v0.6 seems have different register mapping,
> and M2 is very different from Gen1.
> Now, I'm confirming about it

Sorry, It seems my mistake.
H2 thermal seems no problem.

Best regards
---
Kuninori Morimoto

[PATCH] ARM: shmobile: Add r8a7790 thermal sensor DT device

[Kuninori Morimoto]

Hi Simon, Magnus

> > > >> Hook up the single channel thermal sensor via DT
> > > >> on r8a7790. The information used by the platform
> > > >> device has been verified against the data sheet.
> > > >>
> > > >> Signed-off-by: Magnus Damm <damm@opensource.se>
> > > >
> > > > Hi Magnus,
> > > >
> > > > I would prefer if this was split into two patches.
> > > > An SoC patch that updates clock-r8a7790.c.
> > > > And a DT patch which updates r8a7790.dtsi.
> > > 
> > > Sure, that's fine with me. I will do that from now on.
> > 
> > Thanks. I'm trying to reduce dependencies/conflicts between
> > branches. I'm not sure how well it will pan out. But that is my aim
> > at the moment.
> > 
> > > I believe that common clock framework will allow us to handle all
> > > within a single dtsi patch.
> 
> About thermal on H2/M2 (= Gen2),
> I am concerned about whether Gen1/Gen2 thermal chip have a compatible,
> since H2 datasheet v0.05 <-> v0.6 seems have different register mapping,
> and M2 is very different from Gen1.
> Now, I'm confirming about it

Sorry, It seems my mistake.
H2 thermal seems no problem.

Best regards
---
Kuninori Morimoto