[PATCH] arch/tile: avoid build warnings from duplicate ELF_R_xxx #defines

[PATCH] arch/tile: avoid build warnings from duplicate ELF_R_xxx #defines

[Chris Metcalf]

These are now provided in <asm-generic/module.h>, so clean up warning
by not re-defining them in module.c.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
 arch/tile/kernel/module.c |   10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/tile/kernel/module.c b/arch/tile/kernel/module.c
index 001cbfa..243ffeb 100644
--- a/arch/tile/kernel/module.c
+++ b/arch/tile/kernel/module.c
@@ -24,16 +24,6 @@
 #include <asm/homecache.h>
 #include <arch/opcode.h>
 
-#ifdef __tilegx__
-# define Elf_Rela Elf64_Rela
-# define ELF_R_SYM ELF64_R_SYM
-# define ELF_R_TYPE ELF64_R_TYPE
-#else
-# define Elf_Rela Elf32_Rela
-# define ELF_R_SYM ELF32_R_SYM
-# define ELF_R_TYPE ELF32_R_TYPE
-#endif
-
 #ifdef MODULE_DEBUG
 #define DEBUGP printk
 #else
-- 
1.7.10.3

Re: [PATCH] arch/tile: avoid build warnings from duplicate ELF_R_xxx #defines

[Rusty Russell]

Chris Metcalf <cmetcalf@tilera.com> writes:

> These are now provided in <asm-generic/module.h>, so clean up warning
> by not re-defining them in module.c.
>
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>

This change was in linux-next for quite a while, BTW, so there would
have been over a month of warnings...

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.

Re: [PATCH] arch/tile: avoid build warnings from duplicate ELF_R_xxx #defines

[Chris Metcalf]

On 10/21/2012 11:16 PM, Rusty Russell wrote:
> Chris Metcalf <cmetcalf@tilera.com> writes:
>
>> These are now provided in <asm-generic/module.h>, so clean up warning
>> by not re-defining them in module.c.
>>
>> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
> This change was in linux-next for quite a while, BTW, so there would
> have been over a month of warnings...
>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks.  Yes, I don't always drill into the results of the builds at
http://kisskb.ellerman.id.au/kisskb/matrix/, but just go by the "Build OK"
green light.  I'll remember to keep looking at the details more frequently :-)

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com