* [PATCH][next] mt76: Remove redundant assignment to variable tidno
@ 2024-02-07 13:11 ` Colin Ian King
0 siblings, 0 replies; 10+ messages in thread
From: Colin Ian King @ 2024-02-07 13:11 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Kalle Valo, Matthias Brugger,
AngeloGioacchino Del Regno, linux-wireless, linux-mediatek
Cc: kernel-janitors, linux-kernel, linux-arm-kernel
The variable tidno is being assigned a value that is not being read
and is being re-assigned a new value a few statements later.
The assignment is redundant and can be removed.
Cleans up clang scan warning:
drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
to 'tidno' during its initialization is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/mediatek/mt76/agg-rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c
index 10cbd9e560e7..07c386c7b4d0 100644
--- a/drivers/net/wireless/mediatek/mt76/agg-rx.c
+++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c
@@ -122,7 +122,7 @@ mt76_rx_aggr_check_ctl(struct sk_buff *skb, struct sk_buff_head *frames)
struct ieee80211_bar *bar = mt76_skb_get_hdr(skb);
struct mt76_wcid *wcid = status->wcid;
struct mt76_rx_tid *tid;
- u8 tidno = status->qos_ctl & IEEE80211_QOS_CTL_TID_MASK;
+ u8 tidno;
u16 seqno;
if (!ieee80211_is_ctl(bar->frame_control))
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH][next] mt76: Remove redundant assignment to variable tidno
@ 2024-02-07 13:11 ` Colin Ian King
0 siblings, 0 replies; 10+ messages in thread
From: Colin Ian King @ 2024-02-07 13:11 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Kalle Valo, Matthias Brugger,
AngeloGioacchino Del Regno, linux-wireless, linux-mediatek
Cc: kernel-janitors, linux-kernel, linux-arm-kernel
The variable tidno is being assigned a value that is not being read
and is being re-assigned a new value a few statements later.
The assignment is redundant and can be removed.
Cleans up clang scan warning:
drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
to 'tidno' during its initialization is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/mediatek/mt76/agg-rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c
index 10cbd9e560e7..07c386c7b4d0 100644
--- a/drivers/net/wireless/mediatek/mt76/agg-rx.c
+++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c
@@ -122,7 +122,7 @@ mt76_rx_aggr_check_ctl(struct sk_buff *skb, struct sk_buff_head *frames)
struct ieee80211_bar *bar = mt76_skb_get_hdr(skb);
struct mt76_wcid *wcid = status->wcid;
struct mt76_rx_tid *tid;
- u8 tidno = status->qos_ctl & IEEE80211_QOS_CTL_TID_MASK;
+ u8 tidno;
u16 seqno;
if (!ieee80211_is_ctl(bar->frame_control))
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno
2024-02-07 13:11 ` Colin Ian King
@ 2024-02-07 13:31 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2024-02-07 13:31 UTC (permalink / raw)
To: Colin Ian King
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
linux-wireless, linux-mediatek, kernel-janitors, linux-kernel,
linux-arm-kernel
Colin Ian King <colin.i.king@gmail.com> writes:
> The variable tidno is being assigned a value that is not being read
> and is being re-assigned a new value a few statements later.
> The assignment is redundant and can be removed.
>
> Cleans up clang scan warning:
> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
"wifi:" missing from title.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno
@ 2024-02-07 13:31 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2024-02-07 13:31 UTC (permalink / raw)
To: Colin Ian King
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
linux-wireless, linux-mediatek, kernel-janitors, linux-kernel,
linux-arm-kernel
Colin Ian King <colin.i.king@gmail.com> writes:
> The variable tidno is being assigned a value that is not being read
> and is being re-assigned a new value a few statements later.
> The assignment is redundant and can be removed.
>
> Cleans up clang scan warning:
> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
"wifi:" missing from title.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno
2024-02-07 13:31 ` Kalle Valo
@ 2024-02-07 14:53 ` Colin King (gmail)
-1 siblings, 0 replies; 10+ messages in thread
From: Colin King (gmail) @ 2024-02-07 14:53 UTC (permalink / raw)
To: Kalle Valo
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
linux-wireless, linux-mediatek, kernel-janitors, linux-kernel,
linux-arm-kernel
On 07/02/2024 13:31, Kalle Valo wrote:
> Colin Ian King <colin.i.king@gmail.com> writes:
>
>> The variable tidno is being assigned a value that is not being read
>> and is being re-assigned a new value a few statements later.
>> The assignment is redundant and can be removed.
>>
>> Cleans up clang scan warning:
>> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
>> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> "wifi:" missing from title.
>
does this require a V2?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno
@ 2024-02-07 14:53 ` Colin King (gmail)
0 siblings, 0 replies; 10+ messages in thread
From: Colin King (gmail) @ 2024-02-07 14:53 UTC (permalink / raw)
To: Kalle Valo
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
linux-wireless, linux-mediatek, kernel-janitors, linux-kernel,
linux-arm-kernel
On 07/02/2024 13:31, Kalle Valo wrote:
> Colin Ian King <colin.i.king@gmail.com> writes:
>
>> The variable tidno is being assigned a value that is not being read
>> and is being re-assigned a new value a few statements later.
>> The assignment is redundant and can be removed.
>>
>> Cleans up clang scan warning:
>> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
>> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> "wifi:" missing from title.
>
does this require a V2?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno
2024-02-07 14:53 ` Colin King (gmail)
@ 2024-02-07 14:56 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2024-02-07 14:56 UTC (permalink / raw)
To: Colin King (gmail)
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
linux-wireless, linux-mediatek, kernel-janitors, linux-kernel,
linux-arm-kernel
"Colin King (gmail)" <colin.i.king@gmail.com> writes:
> On 07/02/2024 13:31, Kalle Valo wrote:
>> Colin Ian King <colin.i.king@gmail.com> writes:
>>
>>> The variable tidno is being assigned a value that is not being read
>>> and is being re-assigned a new value a few statements later.
>>> The assignment is redundant and can be removed.
>>>
>>> Cleans up clang scan warning:
>>> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
>>> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> "wifi:" missing from title.
>>
> does this require a V2?
Up to Felix, my guess is that he can add it during commit.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno
@ 2024-02-07 14:56 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2024-02-07 14:56 UTC (permalink / raw)
To: Colin King (gmail)
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
linux-wireless, linux-mediatek, kernel-janitors, linux-kernel,
linux-arm-kernel
"Colin King (gmail)" <colin.i.king@gmail.com> writes:
> On 07/02/2024 13:31, Kalle Valo wrote:
>> Colin Ian King <colin.i.king@gmail.com> writes:
>>
>>> The variable tidno is being assigned a value that is not being read
>>> and is being re-assigned a new value a few statements later.
>>> The assignment is redundant and can be removed.
>>>
>>> Cleans up clang scan warning:
>>> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
>>> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> "wifi:" missing from title.
>>
> does this require a V2?
Up to Felix, my guess is that he can add it during commit.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno
2024-02-07 13:11 ` Colin Ian King
@ 2024-02-07 15:00 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 10+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-02-07 15:00 UTC (permalink / raw)
To: Colin Ian King, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Kalle Valo, Matthias Brugger,
linux-wireless, linux-mediatek
Cc: kernel-janitors, linux-kernel, linux-arm-kernel
Il 07/02/24 14:11, Colin Ian King ha scritto:
> The variable tidno is being assigned a value that is not being read
> and is being re-assigned a new value a few statements later.
> The assignment is redundant and can be removed.
>
> Cleans up clang scan warning:
> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/net/wireless/mediatek/mt76/agg-rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c
> index 10cbd9e560e7..07c386c7b4d0 100644
> --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c
> +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c
> @@ -122,7 +122,7 @@ mt76_rx_aggr_check_ctl(struct sk_buff *skb, struct sk_buff_head *frames)
> struct ieee80211_bar *bar = mt76_skb_get_hdr(skb);
> struct mt76_wcid *wcid = status->wcid;
> struct mt76_rx_tid *tid;
> - u8 tidno = status->qos_ctl & IEEE80211_QOS_CTL_TID_MASK;
> + u8 tidno;
> u16 seqno;
>
> if (!ieee80211_is_ctl(bar->frame_control))
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno
@ 2024-02-07 15:00 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 10+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-02-07 15:00 UTC (permalink / raw)
To: Colin Ian King, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Kalle Valo, Matthias Brugger,
linux-wireless, linux-mediatek
Cc: kernel-janitors, linux-kernel, linux-arm-kernel
Il 07/02/24 14:11, Colin Ian King ha scritto:
> The variable tidno is being assigned a value that is not being read
> and is being re-assigned a new value a few statements later.
> The assignment is redundant and can be removed.
>
> Cleans up clang scan warning:
> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/net/wireless/mediatek/mt76/agg-rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c
> index 10cbd9e560e7..07c386c7b4d0 100644
> --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c
> +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c
> @@ -122,7 +122,7 @@ mt76_rx_aggr_check_ctl(struct sk_buff *skb, struct sk_buff_head *frames)
> struct ieee80211_bar *bar = mt76_skb_get_hdr(skb);
> struct mt76_wcid *wcid = status->wcid;
> struct mt76_rx_tid *tid;
> - u8 tidno = status->qos_ctl & IEEE80211_QOS_CTL_TID_MASK;
> + u8 tidno;
> u16 seqno;
>
> if (!ieee80211_is_ctl(bar->frame_control))
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-02-07 15:01 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-07 13:11 [PATCH][next] mt76: Remove redundant assignment to variable tidno Colin Ian King
2024-02-07 13:11 ` Colin Ian King
2024-02-07 13:31 ` Kalle Valo
2024-02-07 13:31 ` Kalle Valo
2024-02-07 14:53 ` Colin King (gmail)
2024-02-07 14:53 ` Colin King (gmail)
2024-02-07 14:56 ` Kalle Valo
2024-02-07 14:56 ` Kalle Valo
2024-02-07 15:00 ` AngeloGioacchino Del Regno
2024-02-07 15:00 ` AngeloGioacchino Del Regno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.